Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…
CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…
CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…
Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …
Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…
Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…
Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…
This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…
Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…
Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …
This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…
Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…
Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…
Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…
Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…
Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…
This commit fixes cases where Electrum's wallet cache could hold onto outdated information about coins and transactions after blockchain reorganizations or mempool changes. For example, if a transaction was previously thought to be mined b…
stale cached state after reorg/mempool evictionincorrect confirmation metadata displayed to userscache invalidation added at multiple state transitions
This commit is a simple code cleanup: it replaces two repeated lines that set a transaction input's block height and position with a single helper method called set_mined_info. There is no change in behavior, no bug fix, and no security re…
This is a small internal code cleanup in the Electrum Bitcoin wallet. It moves the logic that builds a compact transaction identifier (like '123x4') into one shared helper method, and removes a duplicate helper class. There is no user-faci…
This commit changes how the Electrum AppImage build container first obtains trusted web certificates. Because the build's pinned Debian package sources use HTTPS, the container needs certificates before it can talk to them. The old method …
build pipeline changetemporary downgrade from HTTPS to HTTP for package bootstrappackage integrity still protected by apt GPG signatures
Merge pull request #10881 from ekzyis/bip32-reject-depth0-nonzero-metadata
bip32: reject master key with non-zero child/fingerprint
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 44/100
This change tightens validation of BIP32 master keys (the root keys used to derive all wallet addresses). Previously, Electrum would accept an extended public or private key that claimed to be a master key (depth 0) but had a non-zero child number or parent fingerprint. Such keys violate the BIP32 specification and could cause confusion or interoperability problems, but the patch is a defensive validation fix rather than a clear remote-exploitable vulnerability.
Merge pull request #10880 from ekzyis/bip32-reject-xpriv-non-zero-key-prefix
bip32: reject extended private key with non-zero key prefix
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 44/100
This update makes Electrum stricter when reading a BIP32 extended private key (the long encoded string that can generate all your wallet's addresses). BIP32 requires that the 33-byte private-key field start with a zero byte before the actual 32-byte secret. Electrum now rejects keys that violate this rule, which closes a gap where a malformed key could be accepted and later produce unexpected public keys or wallet behavior.
bip32: reject master key with non-zero child/fingerprint
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Low 47/100
This commit tightens validation of Bitcoin wallet master keys. Under the BIP32 standard, a master key must have zero values for its 'child number' and 'parent fingerprint' fields. The change makes Electrum reject extended keys that violate this rule, preventing malformed or intentionally crafted master keys from being accepted. This is a defensive correctness fix rather than an active exploit patch.
bip32: reject extended private key with non-zero key prefix
55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Moderate 59/100
Electrum added a check to reject malformed BIP32 extended private keys ('xprv...') where the private key data does not start with a required zero byte. Previously, such invalid keys may have been accepted. This is a defensive validation fix that prevents non-standard or corrupted keys from being processed, reducing the risk of key-handling bugs or unexpected behavior.
Merge pull request #10872 from f321x/trezor_always_on_device_passphrase
plugin: trezor: fix usage with passphrase
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 29/100
This commit fixes how Electrum's Trezor hardware wallet plugin handles passphrases. Previously, the code could prompt the user to enter their passphrase on the computer even when the Trezor device was configured to ask for the passphrase on the device itself. This could make users type their passphrase twice or, worse, enter a sensitive passphrase into the computer when they expected to enter it only on the device. The patch also makes the settings screen more robust when the device is locked. It is a usability and security-hardening fix rather than a remote-exploitable vulnerability.
plugin: trezor: handle empty passphrase feature in settings dialog
The settings dialog would raise after disabling the passphrase because the feature is None after disconnecting:
``` 24.43 | I | plugins.trezor.clientbase.TrezorClientBase | locking: <trezorlib.protocol_v1.TrezorClientV1 object at 0x7fec5f7d45e0> 24.82 | I | plugins.trezor.clientbase.TrezorClientBase | closing: SessionV1(id=fec9fa77e94f52faa50e3aa5573d6e760a028e2e6cd2366bc998dcc9870f2382) 24.97 | E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter Traceback (most recent call last): File "/var/home/user/code/code_vm/electrum-3/electrum/gui/common_qt/util.py", line 175, in on_done cb_result(result) ~~~~~~~~~^^^^^^^^ File "/var/home/user/code/code_vm/electrum-3/electrum/plugins/trezor/qt.py", line 534, in update passphrases_label.setText(disen[features.passphrase_protection]) ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: list indices must be integers or slices, not NoneType ```
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
access control
AI analysis · Informational 17/100
This commit fixes a crash in Electrum's settings window for Trezor hardware wallets. After a user disabled the passphrase feature and disconnected the device, the settings dialog tried to read a value that had become 'None', causing a TypeError and crashing the dialog. The patch stores the device features before disconnecting and gracefully handles the 'None' case by showing 'Unknown' instead of crashing.
Trezor devices have a config option `passphrase_always_on_device` that might be set (e.g. through the CLI `trezorctl set passphrase on --force-on-device`). This makes the device enforce passphrase input on the device (in comparison to input through the Electrum GUI).
There were two issues when this config is enabled: 1. On V1 devices the passphrase would be prompted twice. Once after entering the PIN (automatically by the device), then Electrum would initiate a second, redundant passphrase prompt. 2. On THP devices (Safe 7), the setup would error as `client.get_session()` must receive `PassphraseSettings.ON_DEVICE` which it didn't.
Tested on Safe 3 and Safe 7. Fixes https://github.com/spesmilo/electrum/issues/10868
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access control
AI analysis · Informational 22/100
This commit fixes a bug in how Electrum talks to Trezor hardware wallets when a device setting forces passphrase entry on the Trezor itself instead of in Electrum. Previously, older Trezor devices could ask for the passphrase twice, and newer Safe 7 devices would fail to set up. The fix checks the device's setting and tells the Trezor library to handle the passphrase on the device when appropriate. It is a usability/compatibility fix, not a vulnerability patch.
AI review queuedMerge pull request #10863 from SomberNight/202608_config_consistencyby Felix · cfa0c533 · Aug 18, 2026 · 3 filesMessage 73 · AdequateInformational 21Details
Commit message · Felix
Merge pull request #10863 from SomberNight/202608_config_consistency
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This commit adds internal consistency checks to make sure a wallet, its lightning component, and the network layer all share the same configuration object. It is a defensive hardening change: it does not fix an active bug by itself, but makes future misconfigurations fail loudly during development/testing rather than silently causing odd behavior.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit adds internal consistency checks (assertions) to make sure that a wallet, its lightning worker, and the network connection all share the same configuration object. It is a hardening/test-quality change only; it does not fix any user-facing bug or vulnerability and does not change runtime behavior except to fail loudly during tests or development if the invariant is violated.
AI review queuedMerge pull request #10830 from accumulator/qml_trustedcoin_wallet_scopeby ghost43 · a357e86f · Aug 14, 2026 · 3 filesMessage 73 · AdequateLow 42Details
Commit message · ghost43
Merge pull request #10830 from accumulator/qml_trustedcoin_wallet_scope
qml: wallet, tx and callbacks were incorrectly scoped to class level for trustedcoin plugin.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100
This change fixes a programming mistake in Electrum's mobile/QML user interface where the trustedcoin two-factor authentication (2FA) plugin stored wallet, transaction, and callback information as shared class-level data instead of per-use data. In practice, this could mean that if multiple wallets or transactions requested an OTP at the same time, the wrong wallet or transaction could be signed, or a stale callback could run. The patch scopes those values to each individual OTP request so they cannot collide or leak across requests.
AI review queuedMerge pull request #10853 from f321x/swapserver_negative_nonceby ghost43 · 0d6df530 · Aug 14, 2026 · 2 filesMessage 73 · AdequateLow 49Details
Commit message · ghost43
Merge pull request #10853 from f321x/swapserver_negative_nonce
swaps: handle negative PoW nonce gracefully
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This patch fixes a small bug in how Electrum checks proof-of-work (PoW) nonces from Nostr swap server announcements. Previously, a missing or negative nonce was treated as having zero PoW, which is correct for missing nonces but the code also allowed negative nonces to be passed into the hash calculation. The patch now explicitly rejects negative nonces and moves the PoW check inside the try block so any parsing error skips the announcement. In practical terms, a malicious or buggy swap server could have advertised a negative nonce; depending on the exact behavior of the hash function with negative numbers, this could have caused a crash, incorrect PoW evaluation, or unexpected filtering of swap servers.
Handle negative nonces in swap announcement events gracefully.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Low 37/100
This commit fixes a small bug in Electrum's submarine swap feature. When a swap server advertises itself using a Nostr event, the client checks a 'proof-of-work nonce' to verify the server did enough computational work. Before the patch, a negative nonce could slip through and be treated as valid, potentially letting a low-effort or malicious swap server bypass the anti-spam check. The fix treats negative nonces the same as a missing nonce (zero proof-of-work bits).
AI review queuedMerge pull request #10851 from f321x/fix_7513_non_deterministic_walletby ghost43 · 78469e38 · Aug 14, 2026 · 1 fileMessage 73 · AdequateModerate 56Details
Commit message · ghost43
Merge pull request #10851 from f321x/fix_7513_non_deterministic_wallet
wallet: don't remove ln xprv from wallet backup
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 56/100
This change fixes a bug in Electrum wallet backups. Previously, when creating a backup of a wallet that had Lightning (Bitcoin's layer-2 network) enabled, the backup code was incorrectly wiping out the Lightning private key from the backup copy. A backup without this key cannot fully restore the wallet's Lightning funds and state. The fix simply stops removing that key, so backups remain complete and recoverable.
AI review queuedwallet: don't remove ln xprv from wallet backupby f321x · a1039232 · Aug 14, 2026 · 1 fileMessage 76 · AdequateModerate 64Details
Commit message · f321x
wallet: don't remove ln xprv from wallet backup
Fixes the same issue described in https://github.com/spesmilo/electrum/issues/7513 for non-deterministic lightning wallets.
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 64/100
This commit fixes a bug in Electrum's wallet backup feature. Previously, when creating a backup, the software incorrectly wiped a private Lightning key ('lightning_privkey2') from non-deterministic Lightning wallets. That meant backups could be incomplete and users might not be able to recover their Lightning funds from the backup. The fix simply stops removing that key during backup.
This commit only updates a macOS build documentation file (README.md). It adds troubleshooting instructions for developers who are code-signing Electrum app bundles, including how to fix private-key access control and certificate trust settings. There is no code change, no wallet behavior change, and no security vulnerability being fixed.
Merge pull request #10845 from f321x/hide_passphrase_entry
qml: wizard: hide passphrase input if disabled
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 20/100
This change tweaks a mobile-style setup wizard so that the optional passphrase text box is hidden when its checkbox is not selected, instead of merely grayed out. The commit message says this was done because users were confusing the passphrase field with the seed re-entry field. It is a usability fix, not a security bug fix.
Security candidaterelease notes: add pre-notification of security fixes for 4.8.1by SomberNight · c4cc40fd · Aug 12, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · SomberNight
release notes: add pre-notification of security fixes for 4.8.1
55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
explicit security language
AI analysis · Informational 15/100
This commit only edits the project's release notes to add a vague pre-notification that version 4.8.1 will contain undisclosed security fixes. It does not include any actual code changes, patches, or details about what the security issues are.
AI review queuedprepare release 4.8.1by SomberNight · 59d1b201 · Aug 10, 2026 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · SomberNight
prepare release 4.8.1
38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit is a routine version bump and release-notes update for Electrum 4.8.1. It does not change any executable code, only the version string and the changelog. The changelog itself lists many fixes from prior commits, but this specific commit only packages those notes for release.
AI review queuedqml: styling OTP dialogby Sander van Grieken · b7f124fc · Aug 10, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Sander van Grieken
qml: styling OTP dialog
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit is purely a user-interface styling tweak for the one-time password (OTP) dialog in Electrum's QML (mobile-style) GUI. It sets the character used to calculate the input field width to '8', adds left/right padding to that width calculation, and changes how an error label is horizontally centered. There is no security-relevant change.
Merge pull request #10829 from nrobi144/coldcard-firmware-range-fix
docs: correct Coldcard firmware range in seed-entropy notice
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessdocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only updates a documentation file (a README) to correct the range of Coldcard hardware wallet firmware versions affected by a previously disclosed security issue. It does not change any executable code, cryptographic logic, or wallet behavior in Electrum itself. The underlying security problem exists in Coldcard firmware, not in Electrum.
AI review queuedMerge pull request #10833 from SomberNight/202608_swaps_dm_repliesby ThomasV · cb4fe3a3 · Aug 10, 2026 · 1 fileMessage 73 · AdequateLow 46Details
Commit message · ThomasV
Merge pull request #10833 from SomberNight/202608_swaps_dm_replies
swaps: nostr: check_dms: duplicate replies from server could crash transport
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This patch fixes a crash in Electrum's submarine swap feature when using Nostr direct messages. If a Nostr server sent the same reply twice, the code tried to complete an already-completed 'future' object, which raises an exception in Python's asyncio. The fix ignores duplicate or unknown replies instead of crashing. A malicious or misbehaving swap server could potentially trigger this to disrupt a user's swap transport/connection.
AI review queuedcontrib: drop protobuf requirementby f321x · 5f6e9102 · Aug 10, 2026 · 4 filesMessage 66 · AdequateInformational 15Details
Commit message · f321x
contrib: drop protobuf requirement
The protobuf dependency was introduced with bip 70 payment requests in commits 4120678df / c44427d33e but not removed with the bip 70 removal in https://github.com/spesmilo/electrum/pull/10535
Currently it fails the installation of the deterministic requirements as newer setuptools doesn't seem to have the `pkg_resources` module anymore: ``` Collecting protobuf==3.20.3 (from -r /tmp/requirements.txt (line 39)) Downloading protobuf-3.20.3.tar.gz (216 kB) Installing build dependencies: started Installing build dependencies: finished with status 'done' Getting requirements to build wheel: started Getting requirements to build wheel: finished with status 'error' error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully. │ exit code: 1 ╰─> [23 lines of output] Traceback (most recent call last): File "/usr/local/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module> main() ~~~~^^ File "/usr/local/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main json_out["return_val"] = hook(**hook_input["kwargs"]) ~~~~^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel return hook(config_settings) File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 333, in get_requires_for_build_wheel return self._get_build_requires(config_settings, requirements=[]) ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires self.run_setup() ~~~~~~~~~~~~~~^^ File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 520, in run_setup super().run_setup(setup_script=setup_script) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 317, in run_setup exec(code, locals()) ~~~~^^^^^^^^^^^^^^^^ File "<string>", line 11, in <module> ModuleNotFoundError: No module named 'pkg_resources' [end of output] ```
66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit removes an unused software dependency called protobuf. The dependency was originally added years ago to support a Bitcoin payment protocol feature (BIP 70) that has since been removed from Electrum. Keeping protobuf in the requirements list was causing installation failures on newer systems because an old version of protobuf cannot build with current Python packaging tools. There is no security vulnerability here—this is a cleanup fix for a broken build/install process.
AI review queuedMerge pull request #10808 from SomberNight/202608_wallet_checksighash_handle_unknownby ThomasV · cdf24305 · Aug 9, 2026 · 1 fileMessage 73 · AdequateLow 39Details
Commit message · ThomasV
Merge pull request #10808 from SomberNight/202608_wallet_checksighash_handle_unknown
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 39/100
This change makes Electrum's wallet handle unusual or unrecognized Bitcoin signature hash types without crashing. Previously, if a transaction input used a sighash value not in the hardcoded list, the code would throw a KeyError exception. The patch now maps unknown sighash values to a warning labeled 'INSANE_SIGHASH'. This is a defensive hardening fix: it prevents an unexpected transaction from causing an unhandled error and instead reports it as a dangerous condition.
Merge pull request #10816 from accumulator/qml_auth_log_improvement
qml: improve auth logging
63/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly! No meaningful explanatory body
This commit is a minor logging cleanup in the mobile/QML authentication helper. It changes the wording and placement of debug/error log messages so they reveal the function name only after safely retrieving it, and avoids logging a raw tuple that could contain sensitive arguments. There is no security fix, behavior change, or vulnerability patch here.
AI review queuedMerge pull request #10798 from SomberNight/202608_base43by Felix · 0e9f1a0d · Aug 7, 2026 · 2 filesMessage 73 · AdequateModerate 51Details
Commit message · Felix
Merge pull request #10798 from SomberNight/202608_base43
transaction: cap max tx size we allow for base43
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 51/100
This commit fixes a performance weakness in Electrum's handling of large Bitcoin transactions encoded in 'base43'. The base43 encoding and decoding functions run in quadratic time, meaning the work grows much faster than the input size. An attacker could send or feed Electrum a very large base43 transaction string and cause the program to freeze or become unresponsive for a noticeable period (a denial-of-service effect). The patch limits how large a base43 string Electrum will try to decode and also makes the encoder slightly faster. It does not fix the underlying quadratic algorithm.