Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedwallet: don't leave a stale 'use_encryption' flag on enable/disableby Sander van Grieken · 8e33ed3b · Oct 16, 2026 · 3 filesMessage 73 · AdequateModerate 69Details
Commit message · Sander van Grieken
wallet: don't leave a stale 'use_encryption' flag on enable/disable
When disabling the only keystore that could be encrypted (e.g. the keystore of a standard wallet), 'use_encryption' was left set. Without storage encryption, the wallet then had no password anymore (has_password() False), so when re-enabling the keystore, its seed was stored in plaintext, while has_keystore_encryption() returned True.
Make consistent, and add a note to the confirmation dialog when disabling a keystore removes the wallet password.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 69/100
This commit fixes a bug in the Electrum Bitcoin wallet where disabling and re-enabling an encrypted keystore could leave the wallet's seed (the secret that controls the coins) stored on disk without a password, while the wallet still falsely claimed the keystore was password-protected. The patch makes the wallet correctly clear the encryption flag when no encryptable keystore remains, and warns the user that disabling will remove the wallet password. A new test also handles wallets that were already affected by the old bug.
AI review queuedwallet: disable_keystore: block only while lightning needs the keystoreby Sander van Grieken · 2d94b72c · Oct 16, 2026 · 3 filesMessage 73 · AdequateLow 44Details
Commit message · Sander van Grieken
wallet: disable_keystore: block only while lightning needs the keystore
lnworker itself does not need the keystore, it uses lightning_xprv or lightning_privkey2. However, without keystore it can't sweep the outputs of force-closed or bump anchor channel closes, or claim or refund submarine swaps.
Block disabling the keystore while there are channels that are not fully closed, or pending submarine swaps.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit tightens a safety check in the Electrum Bitcoin wallet. Previously, Electrum blocked users from making a keystore 'watching-only' if they had any Lightning channels at all. The new logic only blocks this when Lightning actually still needs the keystore to recover funds, such as when a channel is not fully closed or a submarine swap is pending. Making the keystore watching-only at the wrong time could prevent the wallet from signing transactions needed to sweep funds after a force-close or to complete/refund swaps, potentially causing loss of funds. The change is defensive and reduces the window of risk.
An old seed decodes to an odd number of hex digits when one of its word triples is worth 2**32 or more. Since 4.6.1 such seeds fail on import, and wallets restored from them earlier can no longer sign. Accept them again. get_seed now raises a clear error for them, as mn_encode cannot encode them.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 42/100
This commit fixes a bug in Electrum where very old wallet seeds containing a rare word combination could no longer be imported or used to sign transactions since version 4.6.1. The fix restores support for these odd-length hex seeds while preventing the wallet from trying to display them as a normal word seed. It is a bug fix for a denial-of-service/access-loss issue, not an exploitable vulnerability that lets an attacker steal funds.
AI review queuedMerge pull request #11041 from accumulator/qml_senddialog_enter_recipientby Felix · 38ea2485 · Oct 14, 2026 · 2 filesMessage 58 · ThinInformational 19Details
Commit message · Felix
Merge pull request #11041 from accumulator/qml_senddialog_enter_recipient
qml: allow manual entry in SendDialog
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit adds a new 'Enter manually' button to Electrum's mobile-style QML send screen, letting users type a recipient address instead of scanning a QR code. It also makes sure the manual-entry popup is cleaned up when the send dialog closes and that the camera scanner restarts if the user cancels manual entry. There is no obvious security bug in the change itself; it is a user-interface feature.
AI review queuedMerge pull request #11035 from f321x/fix_txeditor_crashby accumulator · 9bcd2cbc · Oct 13, 2026 · 1 fileMessage 73 · AdequateInformational 21Details
Commit message · accumulator
Merge pull request #11035 from f321x/fix_txeditor_crash
qt: TxEditor: keep onchain tab enabled, fix crash
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This is a small user-interface bug fix in Electrum's Qt desktop wallet. It changes how tabs are added and removed in the transaction editor dialog so that the 'Onchain Transaction' tab is not accidentally removed and re-added in a way that could crash the application. There is no indication this is a security vulnerability; it appears to be a stability/usability fix for a GUI crash.
AI review queuedMerge pull request #11001 from spesmilo/jit_forward_checksby Felix · 45a38f12 · Oct 13, 2026 · 2 filesMessage 58 · ThinModerate 58Details
Commit message · Felix
Merge pull request #11001 from spesmilo/jit_forward_checks
Jit forward checks
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 58/100
This commit hardens Electrum's Lightning 'just-in-time' (JIT) channel feature by adding safety checks before opening a new channel on the fly. Previously, some incoming payment checks were skipped when a JIT channel was opened, which could let a malicious or buggy payment push the node into opening a channel under bad terms (for example, with insufficient fees, an unrealistic expiry, or an invalid onion payload). The patch moves those checks to happen before the channel is created and makes sure failures are reported back as standard Lightning errors rather than internal exceptions. It also adds tests demonstrating the new protections.
AI review queuedandroid: fix notification icon.by Sander van Grieken · 32a47234 · Oct 12, 2026 · 3 filesMessage 58 · ThinInformational 20Details
Commit message · Sander van Grieken
android: fix notification icon.
This removes the 'plyer' dependency, replaced with a pyjnius implementation, since plyer was too inflexible to choose a specific icon file.
This commit fixes a cosmetic Android notification icon problem. It swaps out a third-party library ('plyer') for a direct Android system call so Electrum's notifications show the correct icon instead of a blank circle. There is no direct security bug being patched, but the change touches notification code and removes one external dependency, which slightly reduces attack surface.
AI review queuedMerge pull request #10955 from f321x/qml-qtmultimedia-scannerby ThomasV · f0690ead · Oct 10, 2026 · 44 filesMessage 73 · AdequateLow 35Details
Commit message · ThomasV
Merge pull request #10955 from f321x/qml-qtmultimedia-scanner
qr scanning: rm zbar, rm barcodescannerview, use zxing-cpp
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This commit replaces the QR-code scanning backend of the Electrum wallet. It removes the old zbar library and the custom Android BarcodeScannerView/CameraView components, and switches everything to Qt Multimedia for camera access and zxing-cpp for decoding QR codes. The change touches build scripts, packaging, QML/Qt GUI code, and the low-level decoder wrapper. It is a large refactoring with security-relevant side effects: it drops a dependency that had known CVEs, changes how camera frames are handled, and adds new input-validation and memory-management code around the decoder. There is no direct evidence in the commit that this fixes an exploitable vulnerability in Electrum itself, but the change is clearly security-motivated and hardens the QR pipeline.
AI review queuedMerge pull request #11029 from devdavidejesus/fix-8302-feeslider-wallet-noneby accumulator · 28921042 · Oct 9, 2026 · 1 fileMessage 73 · AdequateInformational 17Details
Commit message · accumulator
Merge pull request #11029 from devdavidejesus/fix-8302-feeslider-wallet-none
qml: fix crash in the fee slider when the current wallet goes away
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This is a small bug-fix patch for Electrum's QML (mobile-style) user interface. It prevents the app from crashing when a wallet is closed while a fee-slider screen is still active. The code now checks whether a wallet still exists before trying to read its settings or compare transactions. There is no indication this can be used to steal funds or attack users remotely.
AI review queuedMerge pull request #10994 from spesmilo/ln_config_symmetryby ThomasV · 304e22ec · Oct 9, 2026 · 9 filesMessage 58 · ThinLow 27Details
Commit message · ThomasV
Merge pull request #10994 from spesmilo/ln_config_symmetry
Ln config symmetry
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100
This is a large internal refactoring of how Electrum stores Lightning channel secrets. It removes private keys from the channel configuration objects saved in the wallet file, keeping only public data there, and puts the actual secrets (channel seed and multisig private key) directly in the channel storage. It also makes the local and remote channel configurations symmetric. The change includes a wallet database upgrade that converts old wallets to the new format and verifies that derived public keys match the stored ones. There is no direct evidence in the commit of an exploitable vulnerability; it looks like a hardening/cleanup change, but it touches sensitive key-handling code and the upgrade routine could in theory lock users out if key derivation does not match stored data.
AI review queuedMerge pull request #10991 from f321x/qml_history_calendar_sectionsby accumulator · beaa8291 · Oct 9, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · accumulator
Merge pull request #10991 from f321x/qml_history_calendar_sections
qml: use calendar based history sections
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a user-interface improvement for the Electrum mobile/QML wallet's transaction history screen. It changes how transactions are grouped by date, adding sections like 'Earlier this week' and 'Earlier this month' and making the week start follow the user's locale. There is no security issue here.
AI review queuedandroid: fix avoiding loading QtMultimedia on android. (#11018)by accumulator · 89dda292 · Oct 8, 2026 · 3 filesMessage 81 · StrongInformational 24Details
Commit message · accumulator
android: fix avoiding loading QtMultimedia on android. (#11018)
* android: fix avoiding loading QtMultimedia on android.
followup on fd5b867689f6f2b29d4681e0edd51238be7ac415, which did not properly avoid SendDialog compilation after wallet load.
This moves the SendDialog component signal handlers declared in WalletMainView to the SendDialog component itself, and dynamically loads the component at runtime, only if running on desktop.
fixes #10784
* qml: quit the app in case of send/scan component load error
main.qml: dedup app quit logic into quitApp() function
Co-authored-by: Felix <51097237+f321x@users.noreply.github.com>
---------
Co-authored-by: Felix <51097237+f321x@users.noreply.github.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 24/100
This commit fixes a bug in Electrum's Android app where a desktop-only camera component (QtMultimedia) was accidentally being loaded on Android, which could cause crashes. The fix moves the send/scan dialog code so it is only loaded on desktop, and adds a clean app-exit path if loading fails. There is no direct evidence this is a security vulnerability; it appears to be a stability/crash fix.
AI review queuedMerge pull request #11017 from f321x/fix_10998by accumulator · 6b78158d · Oct 7, 2026 · 6 filesMessage 68 · AdequateModerate 59Details
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This commit fixes a bug where Electrum would save private keys for unsupported Bitcoin address types (such as multi-signature 'p2wsh' keys) to the wallet file when a user tried to import them. The fix makes the wallet reject and not store these unsupported keys. Before the fix, an imported unsupported key could silently persist in the wallet even though Electrum could not actually use it, which could mislead users and potentially cause loss of funds or confusion.
AI review queuedMerge pull request #10993 from spesmilo/remove_attrby ghost43 · 4cb03ef4 · Oct 1, 2026 · 8 filesMessage 58 · ThinInformational 12Details
Commit message · ghost43
Merge pull request #10993 from spesmilo/remove_attr
replace attrs with dataclasses
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 12/100
This commit replaces the third-party 'attrs' library with Python's built-in 'dataclasses' across several Electrum source files. It is a routine refactoring change: the same data classes are defined in a different syntax, and equivalent validation/conversion logic is preserved using Python's standard mechanisms. There is no indication this fixes or introduces a security vulnerability.
Merge pull request #10874 from spesmilo/plugin_zipfile
plugins: load zip plugins from the bytes whose signature was verified
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Moderate 60/100
This commit hardens how Electrum loads third-party plugins. Previously, the app could authorize a plugin zip file, then later re-read that same file from disk to run it. An attacker who could replace the file in the brief gap (a 'time-of-check/time-of-use' or TOCTOU race) might get malicious code executed despite the signature check. The fix keeps the verified plugin bytes in memory and loads all code and icons from those bytes, so the file on disk can no longer be swapped in after approval. It also adds a plugin upgrade flow and new safety checks.
Merge pull request #11003 from SomberNight/202609_tx_any_segwit
transaction: rename `is_segwit`->`is_any_segwit`, and add `is_all_segwit`
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit renames Electrum's transaction 'is_segwit' check to 'is_any_segwit' and adds a new 'is_all_segwit' check. It then uses the stricter 'all inputs are segwit' rule when validating Lightning channel funding transactions and timelock-recovery transactions. The change is defensive: a transaction that mixes segwit and non-segwit inputs still has a malleable transaction ID, which can cause problems for protocols that rely on a stable txid. The commit does not claim to fix an active exploit, and one new code comment explicitly flags that a related zeroconf check is still incomplete and unsafe.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit adds a helper method to check whether every input of a Bitcoin transaction uses SegWit, and starts using it in place of a weaker 'any input is SegWit' check when validating Lightning funding transactions. SegWit fixes 'transaction malleability,' where the transaction ID (txid) can be changed by someone else after signing. For Lightning, the funding txid must be stable because both parties rely on it to set up the channel. The old check only required at least one SegWit input, which could still allow non-SegWit inputs to be re-signed or malleated, changing the txid. The commit also adds a TODO noting that a zero-confirmation code path still doesn't perform this check at all, which the authors already flag as unsafe.
transaction: rename tx.is_segwit() to tx.is_any_segwit()
Some callers might want the "any" usage, some might want "all".
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit is a code cleanup that renames a method from is_segwit() to is_any_segwit() and adds a clarifying comment. It does not change the actual behavior of the code. The rename makes it clearer that the method returns true if any input is SegWit, not necessarily all inputs. A developer left a note in the Lightning channel funding code saying the current check should eventually use an 'all inputs are SegWit' check instead. On its own, this commit is not a security fix, but it highlights a place where the code's understanding of SegWit malleability could be imprecise.
Merge pull request #10984 from f321x/fix_onchain_backup_discovery
lnwallet: fix discovery of onchain backups
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This commit fixes how Electrum's Lightning wallet discovers and watches 'on-chain channel backups'—recovery records embedded in funding transactions. Previously, backups could be missed if the wallet learned about a transaction in stages, or if two channels reused the same on-chain funding address. The fix makes the wallet re-check transactions when more of their inputs are identified as belonging to the wallet, and switches watcher callbacks from being keyed by address to being keyed by the unique funding outpoint. A malicious or buggy remote peer could reuse a funding public key, causing two channels to share the same address; the old code might then overwrite the watcher callback for one channel with the other, leaving a backup unwatched and funds unrecoverable if the channel closed.
Merge pull request #11000 from f321x/bip32_index_with_whitespace
bip32: followup #10999: require child index to be ascii digits
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 39/100
This commit tightens how Electrum parses BIP32 wallet derivation paths. Previously, the code used Python's built-in int() conversion, which accepts a wide variety of number-like strings, including whitespace, plus signs, underscores, and non-ASCII digits. The change now requires each path index to be plain ASCII digits only, optionally preceded by a minus sign for hardened derivation. This prevents subtle parsing surprises where a user or attacker could supply a path that looks valid but is interpreted differently than expected.
Merge pull request #10999 from MrKalipo/fix/bip32-strpath-index-range
bip32: reject str path child index >= 2**31
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 49/100
This commit fixes a bug in how Electrum converts text-based Bitcoin wallet key paths (like "m/44'/0'/0'") into numeric form. Previously, typing an index of 2^31 or higher could silently be treated as a hardened key or could make the hardening marker (the apostrophe) meaningless. The fix now rejects such out-of-range indexes with a clear error. This is a correctness and safety improvement for a function that handles sensitive wallet derivation paths, but the commit itself does not describe a specific exploit or security incident.
convert_bip32_strpath_to_intpath only checked the *combined* value (index | hardened flag) against UINT32_MAX. As the hardened flag is the top bit, a literal index in [2**31, 2**32) passed the check and was silently interpreted as hardened: "m/2147483648" parsed to the same path as "m/0'", and for "m/2147483649'" the hardened marker was a no-op.
Reject any literal index >= 2**31 instead, and tell the user to use the hardened suffix. This matches other implementations (rust-bitcoin, bitcoinjs, BIP380 descriptor key paths) and makes the str->int->str round trip unambiguous.
Co-authored-by: f321x <f@f321x.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialdefensive validationcryptography-sensitive path
AI analysis · Low 49/100
This commit fixes a bug in how Electrum parsed Bitcoin wallet derivation paths typed by users. A path like "m/2147483648" was silently treated the same as "m/0'" (a hardened key), and "m/2147483649'" lost its hardening marker. The patch now rejects any index of 2^31 or larger and tells the user to use the standard hardened suffix instead. This prevents confusion and makes path conversion unambiguous, but it is a correctness/hardening fix rather than a demonstrated remote exploit.
Merge pull request #10972 from SomberNight/202609_qt_label_plaintext_by_default
qt/qml: labels to require opt-in to rich text
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathsigning or wallet pathboot or update pathmerge-commit duplicate discount
AI analysis · Moderate 63/100
This commit changes Electrum's user interface so that text labels default to plain text instead of rich text. Rich text (HTML-like formatting) can be abused if untrusted data is displayed, because it may allow attackers to inject clickable links, fake UI elements, or trigger bugs in the text-rendering engine. The patch makes rich text an opt-in choice for developers and explicitly marks trusted labels that need formatting. It also adds a runtime sanity check on Android and patches the Qt framework used in Android builds to make plain text the default at a lower level. This is a defensive hardening change rather than a fix for a specific known exploit.
Merge pull request #10992 from f321x/dedup_is_seed_wizard
qt: wizard: dedup seed validation rules
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes duplicated logic rather than fixing a security bug. There is no direct evidence in the commit or supplied references that this change addresses a vulnerability.
Merge pull request #10982 from spesmilo/wizard_2fa_seed_redirect
wizard: redirect flow if a 2fa seed is entered for a standard wallet.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlsigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 29/100
This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redirects them into the correct 2FA wallet setup flow instead of rejecting the seed or creating a mismatched wallet. Previously, the wizard would treat 2FA seeds as invalid for standard wallets. The change also ensures the Qt GUI seed validator matches this new behavior. It is a usability fix that prevents user confusion and potential loss of access to funds, not a remote-exploitable vulnerability.