Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedadd_tx_fee_from_server: check fee_sat typeby ThomasV · 671c08b6 · Jun 23, 2026 · 1 fileMessage 35 · OpaqueLow 32Details
Commit message · ThomasV
add_tx_fee_from_server: check fee_sat type
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 32/100
This commit adds a type check to ensure a transaction fee value coming from an external server is either a valid whole number or absent. Without the check, an unexpected type (such as a string or special object) could later cause errors or unusual behavior inside the wallet when it stores or compares fee data. The change is defensive and narrows the range of bad inputs the wallet will accept.
Lower-prioritykeystore: remove old python2 invocation and emacs python modeby ThomasV · 920840a8 · Jun 23, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ThomasV
keystore: remove old python2 invocation and emacs python mode
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply removes two obsolete comment lines from the top of a source file: a Python 2 shebang and an Emacs editor mode hint. It does not change any executable code, behavior, or security properties of the Electrum wallet.
Lower-priorityswaps: cache SwapData in self._swaps instead of accessing storageby ThomasV · d8ff8305 · Jun 22, 2026 · 1 fileMessage 85 · StrongLow 35Details
Commit message · ThomasV
swaps: cache SwapData in self._swaps instead of accessing storage
SwapsData contains several fields that are not stored on disk. We should not expect these fields to be persisted across database access. This commit caches swap data in self._swaps instead of accessing the storage, so that temporary fields are reusable.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 35/100
This change is a bug-fix-style refactor for Electrum's submarine swap feature. It separates in-memory cached swap data from data saved to disk, so temporary fields used while a swap is running don't get lost or behave inconsistently when the code reads from storage. The commit itself does not describe a security vulnerability, but the underlying bug it fixes—relying on disk storage for fields that were never persisted—could in theory cause swap state confusion, such as duplicate processing or stale indexing.
Lower-prioritylnworker: export_channel_backup: document design in more detailby SomberNight · 6f31136e · Jun 18, 2026 · 1 fileMessage 65 · AdequateInformational 11Details
Commit message · SomberNight
lnworker: export_channel_backup: document design in more detail
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 11/100
This commit only adds explanatory comments to existing code. It does not change any behavior. The new comments describe how encrypted lightning channel backups work in Electrum and note that the wallet's public key (xpub) is somewhat sensitive because someone with both the xpub and an encrypted backup could force-close a channel. This is documentation, not a fix.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit is a minor code cleanup following a previous change. It renames a parameter, adds type hints, switches some function calls to use keyword arguments, and adds a couple of safety assertions. There is no indication it fixes a security bug or introduces a vulnerability.
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only adds a detailed code comment explaining how a constant named SWAP_TX_SIZE is used to estimate Bitcoin mining fees for submarine swaps. No program logic, numbers, or behavior were changed. It is purely documentation.
Lower-prioritycreate_channel_storage: return dict instead of StoredDictby ThomasV · 76fbf9df · Jun 15, 2026 · 5 filesMessage 65 · AdequateLow 34Details
Commit message · ThomasV
create_channel_storage: return dict instead of StoredDict
We should avoid dangling StoredDict; this does not make sense if the DB is not in memory.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 34/100
This commit changes how Electrum stores newly-created Lightning channel data during the brief setup phase. Previously, a 'StoredDict' object was created before the channel was fully committed to the wallet database, which could leave a 'dangling' reference and cause problems when the database is not fully loaded in memory. The fix makes the setup use a plain Python dictionary first, then converts it to a proper StoredDict only when the channel is officially added to the wallet. The commit message itself frames this as a robustness improvement, not a security fix, and no exploit is demonstrated.
AI review queuedqml: QEWallet lifecycle fix, remove QEWallet from QEWallet.__instances on destruction.by Sander van Grieken · 34f83a07 · Jun 11, 2026 · 1 fileMessage 65 · AdequateInformational 21Details
Commit message · Sander van Grieken
qml: QEWallet lifecycle fix, remove QEWallet from QEWallet.__instances on destruction.
This never surfaced, as the mobile GUI currently has no option to unload/close a wallet.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This commit fixes a bookkeeping bug in Electrum's mobile/QML wallet interface. When a wallet object is destroyed, it was not being removed from an internal list that tracks all active wallet objects. The commit adds that cleanup step. The commit message says this bug never caused visible problems because the mobile app currently has no way to unload or close a wallet, so the fix is preventive.
Lower-prioritycommands: add delete_channel(_backup) cli commands, analog to functionality already present in the GUIsby Sander van Grieken · 8644b07f · Jun 10, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Sander van Grieken
commands: add delete_channel(_backup) cli commands, analog to functionality already present in the GUIs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit adds two new command-line commands to Electrum, 'delete_channel' and 'delete_channel_backup', which already existed in the graphical user interface. It simply exposes existing wallet functionality through the command line, with the same safety checks. There is no indication this is a security fix or introduces a security issue.
AI review queuedconstants: add basic sanity check for servers.jsonby Sander van Grieken · ab6308d6 · Jun 10, 2026 · 1 fileMessage 73 · AdequateInformational 23Details
Commit message · Sander van Grieken
constants: add basic sanity check for servers.json
Some users will fiddle with this file and if we don't sanity check the error will pop out elsewhere and end up as a not immediately obvious crash report on github
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 23/100
This commit adds a basic sanity check to Electrum's code that reads the built-in list of default servers (servers.json). Previously, if a user edited that JSON file incorrectly, the bad data would travel deeper into the program and cause a confusing crash later. Now the code checks early that each server entry is a dictionary and that all values inside it are strings, failing fast with a clearer error message. It is a hardening/quality improvement, not a fix for an externally exploitable vulnerability.
Lower-prioritylnwire: add bolt12 types to onion_wireby Sander van Grieken · 52e681c8 · Jun 9, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Sander van Grieken
lnwire: add bolt12 types to onion_wire
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit adds data definitions for BOLT12 (a newer Lightning Network protocol for offers and invoices) to Electrum's wire format specification file. It is purely a schema addition with no executable code changes, no bug fixes, and no security behavior changes.
AI review queuedtest_lnmsg: add bolt 12 merkle tree test vectorby f321x · 5426f0a1 · Jun 9, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · f321x
test_lnmsg: add bolt 12 merkle tree test vector
55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new test file and a unit test for BOLT 12 merkle root calculation. It does not change any production code, so it cannot introduce a security vulnerability or fix one. It is purely a test-suite addition.
Lower-prioritylnmsg: fix parsing of nested complex types where the leaf objectsby Sander van Grieken · 2e89915c · Jun 9, 2026 · 1 fileMessage 65 · AdequateModerate 57Details
Commit message · Sander van Grieken
lnmsg: fix parsing of nested complex types where the leaf objects
were consuming too much from the fd.
Co-Authored-By: f321x <f@f321x.com>
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Moderate 57/100
This commit fixes a bug in Electrum's Lightning Network message parser. When reading nested structured data, the parser could keep consuming more bytes than intended because it didn't stop after reaching the expected number of items. The fix makes it stop at the right count and raises an error if too few items are found. This is a correctness fix that likely prevents malformed or crafted Lightning messages from being misinterpreted.
Lower-prioritylnmsg: validate point primitive fieldby f321x · 9b151a60 · Jun 9, 2026 · 2 filesMessage 78 · AdequateLow 47Details
Commit message · f321x
lnmsg: validate point primitive field
Validate points to be valid ECPubkeys in lnmsg._read_primitive_field. There are failing bolt12 test vectors that contain offers with invalid points.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationfuzzing or regression evidence
AI analysis · Low 47/100
This commit adds a safety check in Electrum's Lightning message parser to reject invalid cryptographic 'points' (public-key-like values) instead of silently accepting them. Previously, malformed points could pass through parsing and potentially cause problems later. The change is defensive and aligns with official BOLT12 test vectors that expect invalid points to be rejected.
Security candidatelnmsg: add new primitive type `bip340sig`, add tlv merkle root calculation and schnorr-sign over tlvs, implicit en/decode utf8 fields, schnorr signature verification.by Sander van Grieken · 759ef10d · Jun 9, 2026 · 1 fileMessage 88 · StrongLow 25Details
Commit message · Sander van Grieken
lnmsg: add new primitive type `bip340sig`, add tlv merkle root calculation and schnorr-sign over tlvs, implicit en/decode utf8 fields, schnorr signature verification.
Co-Authored-By: f321x <f@f321x.com>
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validation
AI analysis · Low 25/100
This commit adds new Lightning Network message handling code to Electrum. It introduces a new BIP-340 Schnorr signature field type, computes Merkle roots over TLV (type-length-value) records, signs and verifies those roots, and adds implicit UTF-8 encoding/decoding for text fields. The changes are a feature addition to support BOLT12-style offers/invoices rather than a fix for a known vulnerability. There is no direct evidence in the commit or supplied references that this patch itself creates or fixes a security bug, but any new cryptographic signing code carries implementation risk.
Lower-prioritycommon_qt: move submarine swap support code from qt gui to common_qt as SubmarineSwapMixinby Sander van Grieken · 7c728344 · Jun 8, 2026 · 3 filesMessage 73 · AdequateInformational 12Details
Commit message · Sander van Grieken
common_qt: move submarine swap support code from qt gui to common_qt as SubmarineSwapMixin
This covers the functionality for swap use during payments (so, change-to-ln and submarine-payments) present in gui/qt/confirm_tx_dialog, not the 'standalone' swap.
This is in preparation for adding the same functionality to qml.
- move swap support code from TxEditor to SubmarineSwapMixin - don't require wallet instance at construction, allow late setting of wallet
swaps: add initialize/destroy methods to SwapServerTransport, to simplify consumer side, adds a done callback so the transport can be used once ready or failure can be handled.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 12/100
This commit is a straightforward internal code refactor. It moves the user-interface code that handles 'submarine swaps' (a way to exchange on-chain Bitcoin for Lightning funds, or vice versa) out of the Qt desktop dialog and into a shared module so it can later be reused by the QML mobile-style interface. It also adds explicit initialize/destroy lifecycle methods to the swap server connection class. There is no indication this change fixes a security bug or introduces a new vulnerability.
Lower-priorityqt: refactor message for change-to-lightning swap to backend submarine_swaps.pyby Sander van Grieken · ffec9df1 · Jun 8, 2026 · 2 filesMessage 50 · ThinInformational 13Details
Commit message · Sander van Grieken
qt: refactor message for change-to-lightning swap to backend submarine_swaps.py
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 13/100
This commit is a straightforward code cleanup: it moves the logic that decides what message to show users about 'sending change to Lightning' from the Qt GUI dialog into a shared backend module. The visible behavior is essentially unchanged, and there is no indication of a security fix or vulnerability.
Lower-priorityswaps: encapsulate swap transport ongoing_connection_attempt future into transportby Sander van Grieken · 1fae2da5 · Jun 8, 2026 · 2 filesMessage 50 · ThinInformational 13Details
Commit message · Sander van Grieken
swaps: encapsulate swap transport ongoing_connection_attempt future into transport
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 13/100
This commit is a small internal code cleanup in Electrum's submarine swap feature. It moves a 'future' object (a handle for an in-progress network connection attempt) from the transaction dialog class into the swap transport class itself. There is no user-facing behavior change and no indication of a security fix.
Lower-priorityqt: move wait_for_swap_transport to SwapManagerby Sander van Grieken · 1a1516ac · Jun 8, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Sander van Grieken
qt: move wait_for_swap_transport to SwapManager
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply moves an existing helper function from the Qt user-interface layer into the core swap-management module. The code's behavior is unchanged; it is a routine internal refactoring with no visible security implications.
AI review queuedwallet: cache paid-invoice keys to avoid prevout rescanby Sasha Zykov · d2d4251c · Jun 6, 2026 · 2 filesMessage 85 · StrongInformational 19Details
Commit message · Sasha Zykov
wallet: cache paid-invoice keys to avoid prevout rescan
On wallets with many outgoing invoices that share output scriptpubkeys, broadcasting a new transaction froze the GUI for several seconds — up to a minute on bigger wallets. The hot loops in set_broadcasting() and _update_onchain_invoice_paid_detection() iterate every invoice touched by the new tx's outputs, which is large when scriptpubkeys are shared via _invoices_from_scriptpubkey_map. For each touched invoice they call _is_onchain_invoice_paid(), which scans all of the invoice's output scripthashes against _prevouts_by_scripthash and does a get_tx_height per prevout. Both inner dimensions blow up together when invoices share inputs/outputs across many past payments.
Add _paid_invoice_keys: Set[str], an in-memory cache of outgoing invoice ids known to be PR_PAID, maintained incrementally:
- populated at wallet load by _prepare_onchain_invoice_paid_detection - updated in _update_onchain_invoice_paid_detection (discard then recompute, so reorgs still demote PAID->UNPAID) - updated in save_invoice, delete_invoice, clear_invoices - new on_event_invoice_status listener keeps it in sync with LN-driven transitions from LNWallet.set_invoice_status
get_invoice_status() short-circuits to PR_PAID on cache hit, skipping the prevout scan. set_broadcasting() skips already-paid invoices entirely — broadcasting_status has no effect on a paid invoice and the callback churn is what made the GUI freeze.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit is a performance optimization, not a security fix. It adds an in-memory cache of which outgoing invoices are already paid, so Electrum can skip expensive re-scanning of previous transaction outputs when many invoices share the same Bitcoin address. The goal is to stop the user interface from freezing for seconds or minutes when broadcasting a transaction. There is no indication this change fixes a vulnerability or changes security-critical behavior beyond making status lookups faster.
Lower-priorityqt/send_tab: drop redundant invoice_list.update() after broadcastby Sasha Zykov · c8db5c83 · Jun 6, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Sasha Zykov
qt/send_tab: drop redundant invoice_list.update() after broadcast
The full invoice-list rebuild after a successful broadcast is unnecessary: the set_broadcasting(PR_BROADCAST) call immediately after fires the invoice_status callback for any touched invoices, and main_window.on_event_invoice_status updates the affected rows incrementally via refresh_item / delete_item. Tx ingestion also sets need_update, which causes update_tabs() to refresh.
On wallets with many invoices this rebuild iterated all unpaid invoices and called get_invoice_status() per entry on the GUI thread, contributing to the post-broadcast freeze fixed in the previous commit.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100
This commit removes one unnecessary screen refresh in Electrum's Qt send tab after a payment is broadcast. It is a performance cleanup, not a security fix. The removed line caused the entire invoice list to rebuild, which could freeze the user interface on wallets with many invoices. Other existing update paths already refresh the affected rows, so the removed call was redundant.
AI review queued(trivial) move StorageEncryptionVersion and StorageReadWriteError to stored_dict.pyby ThomasV · 1f4c0fc7 · Jun 6, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · ThomasV
(trivial) move StorageEncryptionVersion and StorageReadWriteError to stored_dict.py
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a simple code cleanup: it moves two definitions (a storage encryption version enum and a read/write error exception) from one file to another and updates the import statements in the files that use them. There is no functional change, no bug fix, and no security relevance.
AI review queuedstorage: add get_path methodby ThomasV · 6797e917 · Jun 6, 2026 · 7 filesMessage 35 · OpaqueInformational 15Details
Commit message · ThomasV
storage: add get_path method
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a simple internal code cleanup. It adds a new helper method called get_path() to the wallet storage class and updates various parts of the program to use that method instead of reading the storage path directly. There is no security fix or vulnerability here.
there is a later check in Channel.update_funded_state added in https://github.com/spesmilo/electrum/pull/9624 but it only validates the funding_tx once it's already 3 blocks deep
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validation
AI analysis · Low 41/100
A developer left a FIXME note in Electrum's Lightning code warning that a feature called 'zeroconf' channels marks a payment channel as funded before actually checking that the funding transaction exists or contains the required multisig output. The commit does not fix the issue; it only documents the concern. The note explicitly says this is unsafe and must be reworked before mainnet use, suggesting the current code could let a malicious or buggy peer make Electrum believe money was locked in a channel when it really wasn't.
AI review queuedlnchan: if funding tx is coinbase tx, wait for maturityby SomberNight · 08f39f89 · Jun 5, 2026 · 2 filesMessage 73 · AdequateLow 42Details
Commit message · SomberNight
lnchan: if funding tx is coinbase tx, wait for maturity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 42/100
This commit adds a check so that if a Lightning channel is funded by a coinbase transaction (newly created bitcoins from mining), Electrum waits for the standard 100-block maturity period before treating the funding as settled. Before this change, Electrum might have accepted an immature coinbase funding transaction too early, which could lead to an invalid channel state or forced channel closure if the coinbase output later becomes invalid or reorganized. The fix follows a recent update to the Lightning protocol specification.