ci: code review: extend prompt to verify commit message intent
What the developer wrote
Authored by f321x
ci: code review: extend prompt to verify commit message intent
Extends the code review CI prompt to verify commit messages are
actually doing what they claim to do. E.g. that a commit specifying
it is only moving code actually does not modify any logic.
What changed, and why it matters
This commit only changes the internal instructions used by Electrum's automated code-review system. It tells the AI reviewer to double-check that commits claiming to just move code around don't secretly change behavior. No actual wallet, network, or cryptographic code was modified, so users are not directly affected.
No action required. This is a process-hardening change to the CI review prompt and does not introduce or fix a software vulnerability.
Security signals we found
No functional code changes
CI/infrastructure-only change
Documentation/prompt update
No cryptographic, networking, or wallet logic modified
Evidence from the diff
The diff adds a new section to contrib/ci/security_review_prompt.md, a CI prompt template. The new section instructs the automated reviewer to verify claims in commit messages that a change is purely a move/rename/extraction/split, and to flag any hidden logic changes at the severity of the change itself. No source code, build scripts, tests, or documentation outside this prompt file were touched.
Changed components
contrib/ci/security_review_prompt.mdInspect captured patch +14 / −0
diff --git a/contrib/ci/security_review_prompt.md b/contrib/ci/security_review_prompt.md
index 4741ecf..5a417d4 100644
--- a/contrib/ci/security_review_prompt.md
+++ b/contrib/ci/security_review_prompt.md
@@ -24,6 +24,20 @@ sophisticated real-world attackers -- Electrum is a high-value target where supp
compromise, malicious Electrum servers, and rogue Lightning peers are realistic threat
vectors.
+## Verifying commit message claims
+
+Use commit messages to understand intent -- but verify, do not trust them. If a
+commit message claims, in any phrasing, that it only **moves**, **relocates**,
+**renames**, **extracts**, **splits**, or otherwise rearranges code without
+behavioral change, strictly verify the claim against the diff: removed and added
+lines must match aside from cosmetic adjustments inherent to the move
+(indentation, import paths, file/module names). Any logic change, condition
+change, branch reordering, altered error handling, modified call signature, new
+side effect, or removed validation hiding inside such a commit must be flagged
+at the severity of the hidden change itself -- these are easy for human
+reviewers to miss. Explicitly note in the finding that the change was concealed
+inside a commit claiming to be a pure code move.
+
## Severity Definitions
### CRITICAL
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.