build: fix trezor: new trezorlib 0.20 now requires *.dist-info metadata
What the developer wrote
Authored by SomberNight
build: fix trezor: new trezorlib 0.20 now requires *.dist-info metadata
```
8.16 | W | gui.qt.wizard.wallet.WCChooseHWDevice | error getting device infos for trezor: Library version for 'trezor' is incompatible. // Installed: unknown, Needed: 0.20.0 <= x < 0.21 // Make sure you install it with python3
```
```
>>> trezorlib.__version__
Traceback (most recent call last):
File "<string>", line 1, in <module>
NameError: name 'trezorlib' is not defined
>>> import trezorlib
>>> trezorlib.__version__
Traceback (most recent call last):
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 397, in from_name
return next(cls.discover(name=name))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
StopIteration
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/site-packages/trezorlib/__init__.py", line 27, in __getattr__
return importlib.metadata.version("trezor")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 889, in version
return distribution(distribution_name).version
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 862, in distribution
return Distribution.from_name(distribution_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 399, in from_name
raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for trezor
```
We generally don't bundle the *.dist-info importlib metadata stuff as for many packages, these files are not reproducible.
ref
https://github.com/spesmilo/electrum/commit/aecc22dc081339fb570a7a3b09f3e47bf9ea5021
https://github.com/spesmilo/electrum/commit/c52a29fc221f8fdbe55872084f215478c957010d
(cherry picked from commit f8226f9384369ca30a2c4811cd631eb77719f97e)
What changed, and why it matters
This commit fixes a build/packaging problem in Electrum's bundled desktop releases (AppImage, Windows, macOS). A newer version of the Trezor hardware-wallet library now needs its package metadata files to be present, otherwise it cannot report its version and Electum wrongly treats it as incompatible. The change simply includes those metadata files in the bundled app. It is a reliability fix, not a security vulnerability patch.
No security action required; treat as a normal build fix. Users relying on Trezor hardware wallets in bundled Electrum releases should upgrade to a build containing this commit to restore Trezor functionality.
Security signals we found
No security-relevant code change
Build/packaging compatibility fix only
No attacker-controlled input is processed
No memory safety, cryptography, or authorization changes
Evidence from the diff
The commit updates three PyInstaller/AppImage build scripts so that trezor’s *.dist-info metadata is preserved in packaged binaries. trezorlib 0.20 uses importlib.metadata.version(‘trezor’) in getattr, which raises PackageNotFoundError when the dist-info directory is stripped. The fix preserves slip10 and trezor dist-info through the reproducible-build stripping dance in the AppImage script, and adds copy_metadata(‘trezor’) in the Windows and macOS PyInstaller specs. No runtime code logic is changed.
Changed components
contrib/build-linux/appimage/make_appimage.shcontrib/build-wine/pyinstaller.speccontrib/osx/pyinstaller.specInspect captured patch +4 / −2
diff --git a/contrib/build-linux/appimage/make_appimage.sh b/contrib/build-linux/appimage/make_appimage.sh
index 061a12a..f10ef52 100755
--- a/contrib/build-linux/appimage/make_appimage.sh
+++ b/contrib/build-linux/appimage/make_appimage.sh
@@ -245,10 +245,10 @@ rm -rf "$PYDIR"/site-packages/PyQt6/Qt.so
find "$APPDIR" -path '*/__pycache__*' -delete
# although note that *.dist-info might be needed by certain packages...
# e.g. slip10 uses importlib that needs it
-for f in "$PYDIR"/site-packages/slip10-*.dist-info; do mv "$f" "$(echo "$f" | sed s/\.dist-info/\.dist-info2/)"; done
+for f in "$PYDIR"/site-packages/{slip10,trezor}-*.dist-info; do mv "$f" "$(echo "$f" | sed s/\.dist-info/\.dist-info2/)"; done
rm -rf "$PYDIR"/site-packages/*.dist-info/
rm -rf "$PYDIR"/site-packages/*.egg-info/
-for f in "$PYDIR"/site-packages/slip10-*.dist-info2; do mv "$f" "$(echo "$f" | sed s/\.dist-info2/\.dist-info/)"; done
+for f in "$PYDIR"/site-packages/{slip10,trezor}-*.dist-info2; do mv "$f" "$(echo "$f" | sed s/\.dist-info2/\.dist-info/)"; done
find -exec touch -h -d '2000-11-11T11:11:11+00:00' {} +
diff --git a/contrib/build-wine/pyinstaller.spec b/contrib/build-wine/pyinstaller.spec
index 09f1655..91e34b9 100644
--- a/contrib/build-wine/pyinstaller.spec
+++ b/contrib/build-wine/pyinstaller.spec
@@ -51,6 +51,7 @@ datas += collect_data_files('bitbox02')
# some deps rely on importlib metadata
datas += copy_metadata('slip10') # from trezor->slip10
+datas += copy_metadata('trezor')
# Exclude parts of Qt that we never use. Reduces binary size by tens of MBs. see #4815
excludes = [
diff --git a/contrib/osx/pyinstaller.spec b/contrib/osx/pyinstaller.spec
index 6adb551..682807d 100644
--- a/contrib/osx/pyinstaller.spec
+++ b/contrib/osx/pyinstaller.spec
@@ -54,6 +54,7 @@ datas += collect_data_files('bitbox02')
# some deps rely on importlib metadata
datas += copy_metadata('slip10') # from trezor->slip10
+datas += copy_metadata('trezor')
# Exclude parts of Qt that we never use. Reduces binary size by tens of MBs. see #4815
excludes = [
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.