Electrum

This commit is a straightforward internal code cleanup in Electrum's Lightning payment handling. It converts a simple data container (PaymentInfo) from a NamedTuple to a Python dataclass and adds basic type/length validation when creating these objects. There is no security fix or vulnerability being addressed.

This commit simply tidies up Python import statements in one file. It removes unused imports and merges some import lines. There is no change to program logic, no bug fix, and no security relevance.

This commit is a test-suite cleanup, not a fix for a user-facing security bug. It stops old test objects from leaking between unit tests by clearing a global callback list after each test. That makes tests faster and less error-prone, but it does not change how the real Electrum wallet handles callbacks in production.

This is a routine change to Electrum's automated build configuration. It switches the CI (continuous integration) setup for building the Linux AppImage from running a sub-script inside a custom Docker container to running a top-level build script on a generic Docker-enabled virtual machine. There is no user-facing change, no wallet or cryptography change, and no security fix or vulnerability introduced based on the diff.

This commit changes several Docker build files so the build containers can optionally run as the root user (UID 0) instead of always creating a normal 'user' account. By default it still uses UID 1000, but when the build is invoked with UID=0 it skips creating an unprivileged user and runs everything as root. This is a build-hardening regression: it weakens the principle of least privilege in the build environment, but it does not directly introduce a vulnerability in the Electrum wallet software that end users run.

This commit changes Electrum's build scripts so that when running Docker containers, the '-it' flags (which request an interactive terminal) are only added if a terminal is actually available. Previously, the scripts always used 'docker run -it', which fails in non-interactive environments like CI systems because there is no TTY. This is a build-script reliability fix with no security relevance.

This commit simply moves existing build instructions from one shell script into a new, separate shell script. It does not change what the build does, what software it downloads, or how it behaves. There is no security-relevant change visible in the code.

This commit is a routine tweak to the project's automated testing setup. It changes one line in the CI configuration so that the coveralls code-coverage reporting tool only runs on the Python 3.10 test job instead of on every test job. There is no change to Electrum's wallet code, cryptography, networking, or anything users interact with.

This commit fixes a subtle shell-script bug in Electrum's build scripts. Because of how Bash handles 'set -e' inside subshells followed by '||', errors inside those build steps were silently ignored instead of stopping the build. That could let a broken or incomplete build continue, potentially producing a bad release binary. The fix removes the '|| fail' wrappers so the scripts now correctly abort on failure.

This commit only updates comments and type annotations in Electrum's code. It changes documentation strings to note that certain transaction height values are now SPV-verified (Simple Payment Verification), and adds Python type hints. No actual code behavior changes, so there is no security vulnerability introduced or fixed by this patch itself.

This commit changes how Electrum decides whether a Bitcoin transaction is truly confirmed. Previously, parts of the code could treat a transaction as confirmed just because an Electrum server claimed it was mined at a certain block height, even before the wallet had independently verified that block header through SPV (Simple Payment Verification). Now, the wallet's central `TxMinedInfo.height()` method returns a real block height only if the transaction has also passed SPV verification; otherwise it reports the transaction as unconfirmed. This closes a class of bugs where a malicious or buggy Electrum server could trick the wallet into thinking a transaction was confirmed when it was not, which could affect spending decisions, Lightning channel state, swap refunds, and user-visible confirmation counts.

This commit fixes a crash in Electrum's transaction builder when a user has Lightning anchor channels enabled but has disabled change addresses. Previously, the code assumed a change address would always be available and tried to access the first item of an empty list, causing an error. The fix falls back to reusing an input address for the required reserve output when no change address exists.

This is a minor user-interface layout fix in Electrum's QML (mobile/desktop GUI) code. It moves a visibility check so that an entire row showing a Lightning color key is hidden when the wallet does not support Lightning, instead of hiding only the color box and label individually. There is no security relevance.

This commit changes how Electrum saves its list of recently used Bitcoin servers to a small file on disk. Previously it used a custom helper class called MyEncoder; now it uses Python's simpler default=str option. The change is described by the developer as a cleanup to limit MyEncoder to wallet database code. There is no direct evidence in the commit that this fixes a security vulnerability, but switching serializers can in principle change how unusual data is written or read back.

This is a simple bug fix for a crash in the Electrum Bitcoin wallet. When a user without Lightning support clicked on a receive request, the wallet tried to check Lightning receive capacity on a missing component and crashed with an AttributeError. The patch adds a safety check so the code skips the Lightning check when no Lightning worker exists. There is no security vulnerability here—just a UI crash being fixed.

This commit changes how Electrum opens files inside external plugin ZIP archives. Previously it used the operating system's file-path joiner, which on Windows uses backslashes. ZIP archive entries always use forward-slash separators, so on Windows the old code could fail to find the requested file or behave unexpectedly. The fix forces forward slashes, making plugin file lookup reliable across all platforms. The linked issue suggests this caused a real bug, possibly a crash or broken plugin loading, but the commit message does not explicitly call it a security vulnerability.

This commit simply rewrites one error message to use a modern Python string-formatting style (f-string) instead of the older .format() style. It does not change what the program does, what data it handles, or how secure it is.

This change is a small diagnostic improvement, not a security fix. When a user opens the built-in developer console in Electrum, future crash reports will have '-consoletaint' added to the app version string. This helps Electrum's support team spot bug reports from users who may have manually changed internal settings at runtime, so they don't chase false bugs. It does not prevent any attack or close a vulnerability.

This is a small code cleanup in Electrum's wallet history display. It removes a redundant 'include_fiat' setting and instead decides whether to show fiat currency values based on whether a working exchange-rate object is provided. The change also fixes a minor consistency issue where a placeholder 'parent' grouping entry could previously contain a fiat currency code even when fiat values were not supposed to be included. There is no direct security vulnerability here.

This commit adds a safety check (an assertion) in the Electrum wallet's coin-selection feature. It ensures that any coins being added to manual coin control actually belong to the wallet's known list of coins. The change is defensive and likely follows a reported bug (issue 10206), but the commit itself does not explain whether the bug had security consequences.

This is a small code cleanup in Electrum's Qt wallet interface. It replaces a Python loop that built a dictionary one item at a time with a single expression that builds the dictionary all at once. The commit message says this is safe because Python dictionaries are thread-safe for single operations. The change is in the code that displays your unspent coins (UTXOs), not in transaction signing or cryptography. There is no direct evidence in the commit or supplied references that this fixes an exploitable security bug.

This commit only adds and updates automated tests for restoring an old Electrum wallet from either its word seed or its equivalent hex seed. It also adds a small clarifying comment to a helper function. There is no change to production wallet logic, no bug fix, and no security-relevant behavior change.

This change fixes a logic bug in Electrum's submarine swap handling. Previously, a forward swap could be marked as 'redeemed' and stop being watched before the secret payment proof (preimage) was actually extracted. Without the preimage, the wallet cannot claim the funds it is owed. The patch adds a check so the swap is only marked redeemed if the preimage is already known. This prevents premature cleanup that could strand funds or break swap accounting.

This commit only adds Python type hints and removes two unused methods/variables. It does not change any runtime behavior, fix a bug, or alter security logic. There is no security relevance.

This commit adds error handling around a list of notification callbacks in Electrum's Lightning network watcher. Previously, if one callback crashed with an error, all remaining callbacks were skipped. Now each callback is wrapped in a try/except so the loop continues and the crash is logged. This is a robustness improvement rather than a fix for an obvious attack path.