CommitWatch RSS
EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Source repository ↗
Repository coverage

1149 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

90security candidates259second-pass queue1003AI analyses
132commits · 30 days
258commits · 60 days
541commits · 180 days
1001commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
220Strong · 80–100
546Adequate · 60–79
339Thin · 40–59
44Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV137891162
SomberNight39330362063
f321x40124385070
Sander van Grieken10910101057
ghost4341516070
Felix2439072
user323062
ekzyis222053
accumulator613071
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 15 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10988 from f321x/update_security_review_ci_model

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…

CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
638fbba8by Felix+75−111 file
No security note in commit
Open full analysis →Source commit ↗
Informational 12 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: warn if the model got downgraded

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…

CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
ace2ca7aby f321x+74−101 file
No security note in commit
Open full analysis →Source commit ↗
Low 44 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10987 from spesmilo/fix_10986

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…

Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
bef80421by ghost43+11−02 files
No security note in commit
Open full analysis →Source commit ↗
Low 35 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

transaction: treat native segwit input with non-empty witness as complete

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …

Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
e9bb42e6by ThomasV+11−02 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 68 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…

Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
9da4c342by ThomasV+10−21 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…

Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
46408a78by ThomasV+13−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…

Exception swallowing bug fixedNetwork/transaction input enrichment logic changedSilent failure mode removed
bb9d3280by ghost43+1−11 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 60 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…

Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
4b92c0f2by ghost43+82−939 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 61 AI analysisMessage 80 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

add_info_from_network: do not swallow exceptions

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…

Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
3f67b21bby ThomasV+1−11 file
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: remove tag arg from get_routing_info

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …

e78fba28by f321x+12−127 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 62 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10940 from accumulator/fix_10937

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…

Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
a57ef6e7by Felix+707−9610 files
No security note in commit
Open full analysis →Source commit ↗
Low 40 AI analysisMessage 36 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: followup #10940

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…

Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
3026fbdbby f321x+14−232 files
No security note in commit
Open full analysis →Source commit ↗
Low 32 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…

Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
5b77ca46by Felix+9−22 files
No security note in commit
Open full analysis →Source commit ↗
Informational 23 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10958 from SomberNight/202609_deps

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…

Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
8bd8c3fbby ghost43+57−5612 files
No security note in commit
Open full analysis →Source commit ↗
Informational 21 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10965 from SomberNight/202609_header_checkpoints

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…

Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
9e0b7e64by ghost43+276−04 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

update block header checkpoints

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…

e11c579bby SomberNight+276−04 files
No security note in commit
Open full analysis →Source commit ↗
Low 46 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10945 from accumulator/stale_utxo_data_fixes

This commit fixes cases where Electrum's wallet cache could hold onto outdated information about coins and transactions after blockchain reorganizations or mempool changes. For example, if a transaction was previously thought to be mined b…

stale cached state after reorg/mempool evictionincorrect confirmation metadata displayed to userscache invalidation added at multiple state transitions
e20b24c0by Felix+132−239 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

transaction: add set_mined_info setter to TxInput

This commit is a simple code cleanup: it replaces two repeated lines that set a transaction input's block height and position with a single helper method called set_mined_info. There is no change in behavior, no bug fix, and no security re…

61f71acbby f321x+7−73 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt/util: consolidate short_id check pattern

This is a small internal code cleanup in the Electrum Bitcoin wallet. It moves the logic that builds a compact transaction identifier (like '123x4') into one shared helper method, and removes a duplicate helper class. There is no user-faci…

2af9e26aby f321x+7−133 files
No security note in commit
Open full analysis →Source commit ↗
Informational 19 AI analysisMessage 85 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

contrib: build appimage: fetch ca-certificates from pinned sources

This commit changes how the Electrum AppImage build container first obtains trusted web certificates. Because the build's pinned Debian package sources use HTTPS, the container needs certificates before it can talk to them. The old method …

build pipeline changetemporary downgrade from HTTPS to HTTP for package bootstrappackage integrity still protected by apt GPG signatures
fd687940by f321x+11−41 file
No security note in commit
Open full analysis →Source commit ↗
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedcontrib: build appimage: fetch ca-certificates from pinned sourcesby f321x · fd687940 · Sep 9, 2026 · 1 fileMessage 85 · StrongInformational 19Details
Commit message · f321x

contrib: build appimage: fetch ca-certificates from pinned sources

Fetch ca-certificates from the pinned sources similar to the other
packages.
This needs to be done because the default sources of debian 11
stopped working.
Because the pinned sources are https they need to be patched to
http before using them to get ca-certificate, as https requires
ca-certificates. This is safe as packages are signed by debian
(the previous way of installing ca-certificates also used http).

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100

This commit changes how the Electrum AppImage build container first obtains trusted web certificates. Because the build's pinned Debian package sources use HTTPS, the container needs certificates before it can talk to them. The old method stopped working on Debian 11, so the patch temporarily switches the package source to plain HTTP just long enough to install the certificate bundle, then switches back. The packages are still verified by Debian's own signatures, so this is a build-fix rather than a security vulnerability, though it does introduce a brief HTTP download step inside the isolated build environment.

Lower-prioritypi: assert script_to_string result always parses to its input bytesby Sander van Grieken · fe38a34d · Sep 9, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Sander van Grieken

pi: assert script_to_string result always parses to its input bytes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI review queuedMerge pull request #10871 from accumulator/hww_deprecation_bb01_archosby ghost43 · 96613bd4 · Sep 9, 2026 · 5 filesMessage 73 · AdequateInformational 19Details
Commit message · ghost43

Merge pull request #10871 from accumulator/hww_deprecation_bb01_archos

hww: add a deprecation message popup at get_xpub time for bitbox01 and safe-t

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds user-facing warning popups that appear when Electrum interacts with two older hardware wallets: the Digital Bitbox (BitBox01) and the Archos Safe-T mini. The message tells users these devices are being deprecated, are no longer supported by their manufacturers, and that users should move their coins to a modern device. It is a notification-only change, not a security fix or vulnerability.

Lower-priorityMerge pull request #10947 from fametrano/btclib-666-error-messagesby ThomasV · 87121026 · Sep 9, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · ThomasV

Merge pull request #10947 from fametrano/btclib-666-error-messages

descriptor: fix two incorrect error messages

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #10953 from accumulator/fix_6791by Felix · 73ffb292 · Sep 9, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Felix

Merge pull request #10953 from accumulator/fix_6791

qt: fix regression for #6791 introduced in 48916f56b

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedqt: fix onchain invoice dialog exc for script outputsby f321x · 539ab9e9 · Sep 9, 2026 · 1 fileMessage 73 · AdequateInformational 21Details
Commit message · f321x

qt: fix onchain invoice dialog exc for script outputs

Fixes exception when double clicking on saved invoice (`show_onchain_invoice()`)
for an invoice containing a script output (invoice.address is None).

```
17.57 | E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/my_treeview.py", line 341, in mouseDoubleClickEvent
self.on_double_click(idx)
~~~~~~~~~~~~~~~~~~~~^^^^^
File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/invoice_list.py", line 88, in on_double_click
self.show_invoice(key)
~~~~~~~~~~~~~~~~~^^^^^
File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/invoice_list.py", line 150, in show_invoice
self.main_window.show_onchain_invoice(invoice)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/main_window.py", line 1672, in show_onchain_invoice
outputs_str = '\n'.join(map(lambda x: x.address + ' : ' + self.format_amount(x.value)+ self.base_unit(), invoice.outputs))
File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/main_window.py", line 1672, in <lambda>
outputs_str = '\n'.join(map(lambda x: x.address + ' : ' + self.format_amount(x.value)+ self.base_unit(), invoice.outputs))
~~~~~~~~~~^~~~~~~
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
```

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 21/100

This commit fixes a simple user-interface crash in Electrum's desktop (Qt) wallet. When a user double-clicked a saved invoice that pays to a raw Bitcoin script (rather than a normal address), the invoice details dialog threw an error and failed to open. It is a UI-only bug, not a way to steal funds or bypass security.

Lower-priorityMerge pull request #10847 from SomberNight/202608_contrib_release_sh_mget_resumeby ThomasV · 32c258d2 · Sep 9, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · ThomasV

Merge pull request #10847 from SomberNight/202608_contrib_release_sh_mget_resume

contrib/release.sh: do not re-download full dist/ after gpg errors

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityqt: fix regression for #6791 introduced in 48916f56bby Sander van Grieken · e7792e3b · Sep 9, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Sander van Grieken

qt: fix regression for #6791 introduced in 48916f56b

68/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
AI review queuedadb: add missing cache invalidation sites for transitions to/from unverifiedby Sander van Grieken · b5a54166 · Sep 8, 2026 · 2 filesMessage 50 · ThinModerate 57Details
Commit message · Sander van Grieken

adb: add missing cache invalidation sites for transitions to/from unverified

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This commit fixes missing cache invalidation in Electrum's wallet history code. When a transaction's status changed—such as when a confirmed transaction returned to the mempool after a blockchain reorganization—the wallet's internal caches were not always cleared. This could leave the wallet showing stale or inconsistent information, such as an outdated balance, an outdated transaction height, or a now-invalid 'short ID' used to identify coins. The fix adds explicit cache clearing at several state-transition points and includes tests demonstrating the problem.

AI review queuedwallet: keep height and txpos in sync in wallet.add_input_info()by Sander van Grieken · 4d66088b · Sep 8, 2026 · 5 filesMessage 85 · StrongLow 35Details
Commit message · Sander van Grieken

wallet: keep height and txpos in sync in wallet.add_input_info()

a change in funding tx status (e.g. from verified to back in mempool due to reorg)
can change both height and txpos, but txpos was not kept in sync here. match
what adb.get_transaction() does.

also guard TxInput.short_id on both height and txpos

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit fixes a bookkeeping bug in the Electrum Bitcoin wallet. When a transaction's status changes due to a blockchain reorganization (for example, a confirmed transaction temporarily returns to the unconfirmed mempool), the wallet was updating a coin's 'block height' but forgetting to update its 'position within the block' (txpos). The two values were getting out of sync, which could make the wallet display or identify coins incorrectly. The fix keeps both values together and adds a safety check so the short display ID is only used when both height and position are valid.

Lower-priorityMerge pull request #10944 from accumulator/qt_send_tab_pi_usable_consistencyby Felix · 722f7023 · Sep 8, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Felix

Merge pull request #10944 from accumulator/qt_send_tab_pi_usable_consistency

qt: keep send button enabled/disabled using same 'pi is usable' check.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #10943 from accumulator/qt_new_channel_cap_check_fixby Felix · 8fa2c8f4 · Sep 8, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Felix

Merge pull request #10943 from accumulator/qt_new_channel_cap_check_fix

qt: fix new channel option for old wallets that have lightning enabled,

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityqt: keep send button enabled/disabled using same 'pi is usable' check.by Sander van Grieken · 44d04dc2 · Sep 8, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Sander van Grieken

qt: keep send button enabled/disabled using same 'pi is usable' check.

before, a non-lightning wallet could inadvertently enable the Send button for
lightning invoice via missing pi-is-usable check in on_amount_changed.
(practical for LNURLp with amount-range, and amountless bolt11)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityMerge pull request #10931 from SomberNight/202609_lnutil_chantype_commentsby Felix · 05808484 · Sep 8, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Felix

Merge pull request #10931 from SomberNight/202609_lnutil_chantype_comments

lnutil: LocalConfig.from_seed: add more asserts

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-prioritytest_lnpeer: invoice status, add separate test for unresolved then failed mppby ThomasV · b094e171 · Sep 8, 2026 · 1 fileMessage 75 · AdequateTriage 0Details
Commit message · ThomasV

test_lnpeer: invoice status, add separate test for unresolved then failed mpp

Co-authored-by: SomberNight <somber.night@protonmail.com>

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI review queuedMerge pull request #10929 from spesmilo/fix_trampoline_forwardingby ThomasV · 5f5439a4 · Sep 8, 2026 · 4 filesMessage 58 · ThinModerate 69Details
Commit message · ThomasV

Merge pull request #10929 from spesmilo/fix_trampoline_forwarding

Fix trampoline forwarding

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 69/100

This commit fixes how Electrum handles Lightning trampoline forwarding and zero-conf channels. Previously, a forwarding node could be tricked into forwarding a partial/incomplete payment set, or could open risky zero-conf channels while also acting as a payment forwarder. The patch makes forwarding wait until the full expected amount arrives, blocks zero-conf channels for forwarding wallets, and tightens feature signaling so wallets don't advertise zero-conf support to untrusted peers when they shouldn't.

AI review queuedminor fix (f321x)by ThomasV · fac84c34 · Sep 8, 2026 · 1 fileMessage 28 · OpaqueLow 36Details
Commit message · ThomasV

minor fix (f321x)

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 36/100

This is a one-line bug fix in Electrum's Lightning Network payment handling. The code was comparing a whole status object to a resolution value, which would always be false. The fix compares just the resolution status correctly. This likely changes when a specific payment timeout error is returned versus a generic payment-details error. It appears to be a correctness fix for Lightning multi-part payment handling, with possible security implications around error handling but no clear exploit shown.

Lower-priorityMerge pull request #10932 from f321x/qt_qrreader_frame_coalescingby ThomasV · 52d08db1 · Sep 8, 2026 · 2 filesMessage 58 · ThinTriage 0Details
Commit message · ThomasV

Merge pull request #10932 from f321x/qt_qrreader_frame_coalescing

qt: qr code reader: speed up camera

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #10939 from spesmilo/fix_trampoline_forwarding_5by ghost43 · 8a9bc905 · Sep 7, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · ghost43

Merge pull request #10939 from spesmilo/fix_trampoline_forwarding_5

trampoline forwarding: make sure cltv budget is not negative

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-prioritytrampoline forwarding: make sure cltv budget is not negativeby ThomasV · ef93592b · Sep 7, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · ThomasV

trampoline forwarding: make sure cltv budget is not negative

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidateMerge pull request #10933 from SomberNight/202609_crandom_prepby ThomasV · e7ee1e6c · Sep 7, 2026 · 18 filesMessage 73 · AdequateInformational 20Details
Commit message · ThomasV

Merge pull request #10933 from SomberNight/202609_crandom_prep

prep crandom.py: trivial refactor to centralise our RNG code

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
entropy or randomnesscryptography-sensitive pathseed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 20/100

This commit is a cleanup change: it creates a single helper module for random-number generation and replaces scattered calls to os.urandom, secrets.token_bytes, and an old randrange helper with the new helpers. The new helpers still use the same Python standard-library secure random sources (os.urandom and secrets.randbelow), so the change does not introduce a security weakness. It is preparation work for a future improvement, not a fix for an active vulnerability.

Lower-priorityMerge pull request #10938 from spesmilo/fail_non_final_onion_with_trampoline_onionby ThomasV · 68f0c712 · Sep 7, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · ThomasV

Merge pull request #10938 from spesmilo/fail_non_final_onion_with_trampoline_onion

Fail non-final onion containing a trampoline onion

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityFail non-final onion containing a trampoline onionby ThomasV · 7febb414 · Sep 7, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · ThomasV

Fail non-final onion containing a trampoline onion

This guards an assert in _check_unfulfilled_htlc_set

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-prioritytests: lnchan: clarify "force_state_transition" function (#10913)by ghost43 · d532e2a4 · Sep 7, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · ghost43

tests: lnchan: clarify "force_state_transition" function (#10913)

* tests: lnchan: clarify "force_state_transition" function

* tests: lnchan: test_single_payment: fix copy-paste mistake

* tests: lnchan: test_single_payment: factor out "one_mbtc_in_msat"

I cannot count this many zeroes visually :P

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritylnworker: set invoice status after htlc resolved outside of pay sessionby ThomasV · 7fd33094 · Sep 5, 2026 · 2 filesMessage 65 · AdequateTriage 0Details
Commit message · ThomasV

lnworker: set invoice status after htlc resolved outside of pay session

- if fulfilled after session, set to PR_PAID
- if failed after session, set to UNPAID

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body