EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2009 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

184security candidates280second-pass queue1894AI analyses
56commits · 30 days
192commits · 60 days
678commits · 180 days
1671commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

70/100 average clarity
489Strong · 80–100
1231Adequate · 60–79
259Thin · 40–59
30Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker14910384
Níckolas Goline63844277
Rusty Russell96475958172
daywalker90118895165
Lagrang386578170
Vincenzo Palazzo13411182
dovgopoly15015164
Sangbida Chaudhuri14931146066
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1024101071
Christian Decker36436072
Analysis record

Published AI watches

Last scanned 9 minutes ago

Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

contrib: add jaonoctus's signing key

This commit simply adds a new person's PGP public-key fingerprint to the list of trusted release signers in two documentation files. It does not change any code, fix any bug, or alter any security behavior of the software itself.

41278b4eby jaonoctus+2−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: fixed timestamps for invented bookkeeper deposits

This is a tiny internal fix to make a bookkeeping migration produce stable event ordering. It changes the timestamp used when creating historical 'deposit' records during a one-time database migration, so the records sort consistently with…

498e5086by daywalker90+2−01 file
No security note in commit
Informational 21 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: document missing and fix erroneous JSON-RPC error codes

This commit is a documentation-only cleanup of the JSON-RPC command help files. It corrects which numeric error codes are listed for each command so the published schemas match what the software actually returns. No program logic, validati…

Documentation-only change with no executable code modificationsCorrects RPC schema error-code metadata to match actual handler behaviorNo change to input parsing, authorization, cryptography, or network behavior
d1b6963bby daywalker90+204−1224 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: initialize tx_sigs_allowed on startup

This commit fixes a bug where a setting that controls whether unexpected transaction signatures are allowed was not initialized when the channel daemon starts. If a peer sent such signatures before the channel was fully ready, the program …

use of uninitialized variableundefined behavior (invalid bool load)network-triggered code path
c09c4520by Erick Cestari+1−01 file
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

ci: fix the coverage nightly's profile handling

This commit fixes the project's internal nightly code-coverage CI workflow. It changes how test coverage files are collected, ensures the same LLVM compiler version is used to generate and merge coverage data, and uploads a Codecov-compati…

5685c9a3by cdecker+12−211 file
No security note in commit
Low 37 AI analysisMessage 78 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

schemas: make required fields match the code

This commit is a large cleanup of Core Lightning's API schemas, generated RPC bindings, and related plugin code. The stated goal is to make the documented 'required' fields match what the C code actually always produces or expects. In prac…

Large schema-only change with no accompanying security advisory or CVEOne semantic change to plugin hook response: invoice_payment hook can now reject with only failure_message and no resultMany fields change from optional to required in public RPC/protobuf interfaces
ddbd2963by daywalker90+1786−173950 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: document error 313 on every command which can return it

This commit only updates documentation. It adds error code 313 to the documented error lists for several Core Lightning commands (fundpsbt, utxopsbt, txprepare, multiwithdraw, and upgradewallet). The error code already existed in the code …

a34b9758by Peter Neuroth+30−86 files
No security note in commit
Low 25 AI analysisMessage 88 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tools/build-release.sh: name the checksum file when verifying the signature

This commit fixes a release-script check that verifies the cryptographic signature on a file of checksums. Previously, the script only told GPG to verify the signature file itself. If someone replaced that signature file with an inline-sig…

Incorrect cryptographic verification logic in release toolingPotential false-positive signature verification with inline-signed .asc substitutionRelease-integrity hardening
8e495707by Peter Neuroth+5−21 file
No security note in commit
Low 42 AI analysisMessage 95 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: pass the manifest explicitly to gpg --verify

This commit updates Core Lightning's release documentation to tell users and release managers to run gpg --verify with both the signature file and the manifest file named explicitly. The old one-argument form can silently succeed even if t…

Verification bypass risk in release artifact validationgpg --verify single-argument form can exit 0 without reading the intended manifestDocumentation-only hardening of release process
2dee8699by Peter Neuroth+9−62 files
Vendor flagged security relevance
Low 25 AI analysisMessage 58 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

Cargo.lock: update dependencies

This commit is a routine update to the Rust dependency lock file (Cargo.lock), bumping many third-party libraries to newer patch or minor versions. The commit message gives no security reason for the update, and no verified references link…

Routine dependency refresh with no stated security rationaleUpdates to security-sensitive transitive crates (rustls, hyper, h2, tokio, webpki-roots) but no evidence these versions fix known vulnerabilitiesNo source-code changes or patch-specific fixes visible in the diff
c1551c55by daywalker90+298−2761 file
No security note in commit
High 80 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

common: bound JSON nesting depth when parsing

This commit fixes a stack-overflow risk in Core Lightning's JSON parser. Before the fix, an attacker could send a valid JSON-RPC message containing thousands of nested brackets or braces. The parser's own helper functions used recursion fo…

Stack-overflow via deeply nested JSONRecursive JSON traversal without depth boundDenial-of-service vector in JSON-RPC input parsing
83f92e4bby Níckolas Goline+90−22 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 28 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

common: minor typo fixes

This commit only fixes typos and comment style. It changes two C-style comments from // to /* */ and corrects a grammar error in a documentation comment ('element' to 'elements'). There are no code behavior changes, no bug fixes, and no se…

273d7f02by w3lld1+3−32 files
No security note in commit
Informational 20 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-testing: truncate long testnames

This change fixes a test-infrastructure bug in Core Lightning's Python testing helpers. When running tests against a PostgreSQL database, very long test names could be silently shortened by PostgreSQL, causing different test runs or nodes …

No security-relevant signal: change is in test framework code onlyFixes a test reliability issue, not a runtime vulnerabilityNo input sanitization, authentication, cryptography, or network changes
c4fe4cbaby Peter Neuroth+59−12 files
No security note in commit
Moderate 60 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: exclude immature coinbase outputs from fee rescue selection

This fix prevents Core Lightning from trying to use freshly created bitcoins (immature coinbase rewards) as emergency funds for fee-bump transactions. Such a transaction would be invalid under Bitcoin's rules and would be rejected by the n…

Consensus-invalid transaction generation preventedFee rescue / CPFP failure mode mitigatedCoinbase maturity check added to coin selection
34883ff7by cdecker+5−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 91 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

askrene: fix crash loading node bias with description

This commit fixes a bug in Core Lightning's askrene plugin that could prevent a node from restarting. When a saved routing layer contained a node bias with a description, the plugin accidentally freed the description's memory while using i…

Use-after-free / double-take of a tal-allocated string during plugin startupDenial-of-service-like symptom: lightningd aborts before replying to init, node cannot restartFixes publicly reported issue #9433 by endothermicdev
4681177dby Vincenzo Palazzo+2−32 files
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: restart the node which owns the layer in node bias test

This commit only fixes a test case so it actually exercises the intended code path. It does not change any production code, so it cannot introduce or fix a real-world security vulnerability by itself. The test change is a reproducer for a …

0f3f67a0by Vincenzo Palazzo+3−21 file
No security note in commit
High 78 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopend: bound the feerates a peer opens at

This commit fixes a bug in Core Lightning's experimental dual-funded channel feature. When another node tried to open a channel, Core Lightning was not checking whether the proposed transaction fees were reasonable. A peer could request a …

Missing input validation on wire-parsed feerate fieldsPeer could induce signing and storage of feerate == 0RBF remote path allowed unbounded upward feerate walks
ba08356fby cdecker+140−04 files
Vendor flagged security relevance
High 72 AI analysisMessage 100 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: regression coverage for out-of-range feerates

This commit adds regression tests for three related bugs where wildly wrong Bitcoin transaction feerates could enter Core Lightning. In the worst case, a malicious or broken fee source could make the node think a feerate was zero (due to a…

Integer overflow in feerate conversion (u32 wrap from 0xFFFFFFFF perkb to 0 perkw)Absurd feerate from external fee source bypassing sanity ceilingDatabase-stored out-of-range feerate causing startup abort/crash loop
65bdbc47by cdecker+137−02 files
No security note in commit
Moderate 64 AI analysisMessage 86 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: don't assert on funding feerates read from the db

This update fixes a crash bug in Core Lightning. When the software tried to list details of a channel opening in progress, it could crash if a stored fee rate was extremely large or zero. The crash happened because the code used an interna…

Integer overflow in RBF escalation (u32 * 25 / 24) leading to assertion failureAssertion failure in read-only introspection RPC (listpeerchannels) causing crash-loop at startupDatabase value treated as invariant despite originating from external fee estimator
d67c4936by cdecker+72−227 files
Vendor flagged security relevance
Moderate 53 AI analysisMessage 86 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: clamp absurd inflight funding feerates on upgrade

This commit fixes a bug where Core Lightning nodes could get stuck in a crash loop. If a node had previously stored an extremely high or zero fee rate for an in-progress channel funding operation (a 'splice' or dual-funded channel RBF), a …

Integer overflow in fee-rate calculation (u32 overflow when multiplying by 25/24)Assertion failure leading to daemon crash loop at startupDatabase migration clamps out-of-range stored funding feerates
f057c692by cdecker+34−01 file
Vendor flagged security relevance
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritylsp_plugin: add hook helper to the clientby Peter Neuroth · 0559ff1a · Nov 13, 2025 · 1 fileMessage 68 · AdequateLow 29Details
Commit message · Peter Neuroth

lsp_plugin: add hook helper to the client

We nearly always want to return `{"result":"continue"}` in case that
something went wrong. This commits adds two helper macros that help us
to cleanly return from a hook while logging necessary information.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 29/100

This commit refactors error handling in a Core Lightning plugin so that when something unexpected happens during payment processing, the plugin returns 'continue' instead of stopping or crashing. The change is defensive: it makes the plugin more resilient by avoiding hard failures that could disrupt normal routing. However, it also means some errors are now silently swallowed and logged only at debug level, which could hide problems. There is no direct evidence this fixes a known security vulnerability; it appears to be a robustness improvement.

Lower-prioritylsp_plugin: add cleanup on "on_invoice_payment"by Peter Neuroth · fcf1868d · Nov 13, 2025 · 3 filesMessage 68 · AdequateInformational 18Details
Commit message · Peter Neuroth

lsp_plugin: add cleanup on "on_invoice_payment"

The `on_invoice_payment` hook is called when core-lightning successfully
collected all parts to an invoice. We'll use this to clean up the the
datastore when an invoice completes.

Caveat: This will be called on every succesfull invoice payment, we may
improve this in the future.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit adds a cleanup step to the experimental LSPS (Lightning Service Provider Specification) plugin. When a JIT-channel invoice is fully paid, the plugin now deletes its stored record from Core Lightning's datastore. The change is defensive housekeeping rather than a fix for an active vulnerability, and the commit message does not describe any security issue.

Lower-prioritylsp_plugin: format test fileby Peter Neuroth · 3b05a813 · Nov 13, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Peter Neuroth

lsp_plugin: format test file

autoformat on save complained about the formatting.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only reformats a test file by changing two single-quoted strings to double quotes and adding trailing commas. It does not change any real code behavior or fix any security issue.

Lower-prioritylsp_plugin: refactor lsps0listprotocols handlerby Peter Neuroth · ef539dd5 · Nov 13, 2025 · 3 filesMessage 58 · ThinInformational 13Details
Commit message · Peter Neuroth

lsp_plugin: refactor lsps0listprotocols handler

Move the handler to a separate file, and add lsps2_enabled flag to the
handler.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 13/100

This commit is a routine code cleanup (refactor) in the Core Lightning 'lsps-plugin'. It moves the handler for the 'lsps0.listProtocols' JSON-RPC method into its own file and adds a flag so the handler can later include protocol number 2 in its response when enabled. Currently, the flag is hard-coded to false, so the behavior is unchanged from before: the handler still returns an empty list of protocols. There is no security fix or vulnerability visible in this change.

Lower-prioritylsp_plugin: rename cmds and opts to fit conventionby Peter Neuroth · 9e301f0f · Nov 13, 2025 · 5 filesMessage 73 · AdequateInformational 15Details
Commit message · Peter Neuroth

lsp_plugin: rename cmds and opts to fit convention

We use `experimental-*` for documented commands instead of `dev-` which
are undocumented commands.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit simply renames configuration options and internal command names in the LSPS (Lightning Service Provider Specification) plugin to follow the project's naming convention. 'dev-' prefixed names are changed to 'experimental-' prefixes, and some internal RPC command names are updated. There is no security fix or vulnerability here—it's a cleanup and consistency change.

Lower-prioritylsp_plugin: remove redundant config optionby Peter Neuroth · ce0be9dc · Nov 13, 2025 · 1 fileMessage 68 · AdequateInformational 18Details
Commit message · Peter Neuroth

lsp_plugin: remove redundant config option

We don't need to separately enable lsp and lsps2 services. If lsps2 is
not enabled what can we do with just the messaging layer?

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit removes a redundant developer-only configuration flag from an experimental Lightning Service Provider (LSP) plugin. Previously, users had to enable both a general 'LSPS service' flag and a separate 'LSPS2 service' flag. The change makes the LSPS2 flag alone control whether the plugin runs. It also adds a clear error if LSPS2 is enabled but its required secret is missing. There is no direct security vulnerability here; it is a code cleanup that slightly reduces configuration confusion.

Lower-prioritychore(fmt): Fix formatting of new python files.by Christian Decker · 1126bc31 · Nov 13, 2025 · 2 filesMessage 57 · ThinInformational 15Details
Commit message · Christian Decker

chore(fmt): Fix formatting of new python files.

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only reformats Python test files and a test plugin. It adjusts whitespace, quote style, line breaks, and removes a couple of unused local variables. There is no change to production code, no security fix, and no behavior change in the software users run.

Lower-prioritylsp_plugin: add fn to wrap payload with peer idby Peter Neuroth · c52da76a · Nov 13, 2025 · 3 filesMessage 68 · AdequateInformational 19Details
Commit message · Peter Neuroth

lsp_plugin: add fn to wrap payload with peer id

We need to somehow access the peer id in the jrpc server to know where
the response should go. This seems to be the most convenient way for
now. We may unclutter this in the future if this results in performance
issues.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit adds a helper function in the LSPS (Lightning Service Provider Specification) plugin that attaches the sender's peer ID to incoming JSON-RPC messages before passing them to the internal handler. It is a plumbing/infrastructure change to make routing responses easier. There is no direct security fix or vulnerability being patched; it is a feature addition with some minor robustness checks.

Lower-prioritylsp_plugin: add primitives for messagesby Peter Neuroth · e36fdeff · Nov 13, 2025 · 4 filesMessage 60 · AdequateInformational 16Details
Commit message · Peter Neuroth

lsp_plugin: add primitives for messages

Adds some primitives defined in lsps0 for other protocol messages.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 16/100

This commit adds basic building-block types for a new Lightning Service Provider (LSP) plugin in Core Lightning. It introduces Rust code to represent money amounts (millisatoshis), fee rates (parts-per-million), channel IDs, and timestamps, plus tests. There is no security fix or vulnerability here; it is ordinary feature development.

Lower-prioritylsp_plugin: change listprotocols requestby Peter Neuroth · 6c5c302c · Nov 13, 2025 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Peter Neuroth

lsp_plugin: change listprotocols request

Using lsp_id instead of peer as identifier

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit simply renames a parameter in the LSPS (Lightning Service Provider Specification) plugin from 'peer' to 'lsp_id'. It is a straightforward API naming change with no apparent security implications.

Lower-prioritylsp_plugin: check that featurebit is set and thatby Peter Neuroth · bbcb51d9 · Nov 13, 2025 · 4 filesMessage 60 · AdequateLow 46Details
Commit message · Peter Neuroth

lsp_plugin: check that featurebit is set and that

the client is connected to the lsp before sending a request

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 46/100

This commit hardens a Core Lightning plugin for the Lightning Service Provider (LSP) protocol. Before sending a request, the plugin now verifies that the target peer is currently connected and advertises the required LSP feature bit. It also makes the plugin advertise that feature bit itself. The change is defensive: without it, a user could accidentally send an LSP request to a peer that does not support LSPs, likely causing the request to fail or behave unexpectedly.

Lower-prioritylsp_plugin: add lsps2 modelsby Peter Neuroth · 17a9a928 · Nov 13, 2025 · 7 filesMessage 50 · ThinInformational 12Details
Commit message · Peter Neuroth

lsp_plugin: add lsps2 models

Add models and options to enable lsps2 on the lsp

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
AI analysis · Informational 12/100

This commit adds new data models and configuration options for an experimental LSPS2 (Lightning Service Provider Specification 2) feature in Core Lightning's LSP plugin. It is a feature-implementation patch, not a security fix. There is no indication in the commit or supplied references that it addresses a vulnerability, incident, or security disclosure.

Lower-prioritylsp_plugin: add lsps2_buy request and handlerby Peter Neuroth · ecb1f4c7 · Nov 13, 2025 · 5 filesMessage 68 · AdequateInformational 23Details
Commit message · Peter Neuroth

lsp_plugin: add lsps2_buy request and handler

Adds the lsps2.buy request to the client and the lsps2.buy handler to
the LSP service.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 23/100

This commit adds a new feature to the experimental LSPS (Lightning Service Provider Specification) plugin, allowing a client to request a 'just-in-time' channel purchase from a service provider and the service to handle that request. It is a feature addition to a development plugin, not a fix for a known security bug. The code includes validation of fee parameters and basic bounds checks, but because it is new and touches payment-related logic, it introduces some risk of implementation flaws.

Lower-prioritylsp_plugin: add htlc_accepted handler for no-mppby Peter Neuroth · 7f3789b6 · Nov 13, 2025 · 6 filesMessage 68 · AdequateLow 35Details
Commit message · Peter Neuroth

lsp_plugin: add htlc_accepted handler for no-mpp

Adds the service side (LSP) for a simple no-mpp trusted jit channel
opening. This is only an intermediate step, we are going to add support
for multiple htlcs.
This is experimental and can drain on-chain fees from the LSP if used in
public.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 35/100

This commit adds an experimental service-side feature for Core Lightning's LSPS2 plugin that automatically opens a new Lightning channel when a payment arrives for an unknown peer. The code is marked as experimental and incomplete by its own author, with several 'Fixme' notes indicating future hardening is needed. The main operational risk is that a public LSP could have its on-chain funds drained by attackers who trigger many automatic channel opens. The commit itself does not claim to fix a security bug; it is a new feature implementation.

Lower-prioritylsp_plugin: add warning if extra_fee is wrongby Peter Neuroth · ec54d348 · Nov 13, 2025 · 1 fileMessage 68 · AdequateLow 26Details
Commit message · Peter Neuroth

lsp_plugin: add warning if extra_fee is wrong

The extra_fee tlv appended to the update_add_htlc message is set by the
LSP and should specify what was deducted from a single htlc. If it does
not match the expected amount, we log a warning message.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 26/100

This change adds a warning log in the LSPS (Lightning Service Provider Specification) plugin when the extra fee reported by an LSP does not match the expected amount. It does not actually reject the problematic payment; it only logs a warning and includes a developer note saying a strict implementation should reject it. The change also removes some older placeholder comments and simplifies how the invoice total amount is determined.

Lower-prioritylsp_plugin: add client side check for zero_confby Peter Neuroth · e789b969 · Nov 13, 2025 · 3 filesMessage 68 · AdequateModerate 60Details
Commit message · Peter Neuroth

lsp_plugin: add client side check for zero_conf

We only allow zero_conf channels if we approved the a jit-channel from
the LSP in advance.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 60/100

This commit adds a security check in Core Lightning's LSPS (Lightning Service Provider Specification) plugin so that the client only accepts 'zero confirmation' channels from LSPs it has previously approved for a JIT (just-in-time) channel. Before this change, the plugin blindly allowed any zero-conf channel opening, which could let a malicious or mistaken LSP open a channel the user never requested. The patch stores an approval record when the user approves a JIT channel, then checks that record when an open-channel request arrives, deleting it after use. A new test confirms that unapproved zero-conf channels are rejected.

Lower-prioritylsp_plugin: pass-through invoice paramsby Peter Neuroth · 366ada78 · Nov 13, 2025 · 2 filesMessage 68 · AdequateInformational 18Details
Commit message · Peter Neuroth

lsp_plugin: pass-through invoice params

Calling lsps_jitchannel we want to pass through the label and
description parameters used to call `invoice` to keep the api close to
Core-Lightning

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit changes a Core Lightning plugin so that when a user requests a just-in-time Lightning channel, the label and description they provide are passed through to the generated invoice instead of being replaced with placeholder or auto-generated values. It also removes an unused label generator and simplifies how payment sizes are handled. There is no direct security bug being fixed here; it is mostly an API usability and correctness improvement.

Lower-prioritylsp_plugin: add lsps2_getinfo handler and callby Peter Neuroth · 581eb307 · Nov 13, 2025 · 6 filesMessage 78 · AdequateInformational 20Details
Commit message · Peter Neuroth

lsp_plugin: add lsps2_getinfo handler and call

This commit adds the lsps2_get_info call defined by BLIP052. It also
adds a test policy plugin that the LSP service plugin uses to fetch the
actual fee menu from to separate the concerns of providing a spec
compliant implementation of an LSP and making business decisions about
fee prices.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 20/100

This commit adds a new feature to Core Lightning's experimental LSPS (Lightning Service Provider Specification) plugin. It lets a client ask a service provider for its current fee menu, and the service plugin fetches that menu from a separate policy plugin. The change is mostly feature work, but it introduces a few places where malformed input or a misbehaving policy plugin could cause errors or unexpected behavior. There is no indication this fixes a known security bug or is being treated as a security patch by the project.

Lower-prioritylsp_plugin: change id type in jsonrpcby Peter Neuroth · 60174f73 · Nov 13, 2025 · 1 fileMessage 60 · AdequateInformational 11Details
Commit message · Peter Neuroth

lsp_plugin: change id type in jsonrpc

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 11/100

This is a small Rust code cleanup in a Lightning Service Provider (LSP) plugin. It changes a function parameter from accepting any value that can be converted into an optional string, to only accepting an already-optional string. There is no indication this fixes a security bug; it appears to be a routine type-simplification change.

Lower-prioritylsp_plugin: add dev-eneabled flag for clientby Peter Neuroth · 3606106c · Nov 13, 2025 · 3 filesMessage 68 · AdequateInformational 18Details
Commit message · Peter Neuroth

lsp_plugin: add dev-eneabled flag for client

While this is still experimental, we only want to enable the client when
explicitly defined!

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit adds an opt-in 'dev-lsps-client-enabled' flag so the experimental LSPS client plugin only runs when explicitly enabled. It also renames the existing service flag for consistency and moves the service setup to happen only after the flag is checked. There is no direct security fix here; it is a hardening/guardrail change to prevent an unfinished experimental feature from being active by default.

Lower-prioritykeysend: enforce BOLT11 description length limitby Wes Payne · 89270024 · Nov 13, 2025 · 2 filesMessage 78 · AdequateLow 35Details
Commit message · Wes Payne

keysend: enforce BOLT11 description length limit

The keysend plugin previously used `> 1023` as the cutoff for
description length when inserting an invoice. This was
inconsistent with invoice.c, which enforces the BOLT11 description
field limit defined in `common/bolt11.h`.

This patch switches to using `BOLT11_FIELD_BYTE_LIMIT` directly.
As a result, keysend no longer fails on descriptions between
641–1023 bytes, which previously caused unexpected failures.

A new regression test (`test_keysend_description_size_limit`)
exercises boundary cases just below, at, and above the limit.

Changelog-Fixed: Protocol: `keysend` with descriptions of length 640-1023 bytes fixed.
Signed-off-by: Wes Payne <noblepayne@noblepayne.com>

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Low 35/100

This commit fixes a bug in Core Lightning's 'keysend' payment feature where invoice descriptions between 641 and 1023 bytes long were incorrectly rejected. The keysend plugin used a hard-coded 1023-byte cutoff, while the rest of the software enforced a stricter 640-byte BOLT11 protocol limit. The patch makes keysend use the same shared limit, so medium-length descriptions now work correctly. This is a reliability/standards-compliance fix rather than a critical security vulnerability.

Lower-prioritylightningd: don't allow invoices with 640 byte descriptions.by Rusty Russell · b05dbeff · Nov 13, 2025 · 4 filesMessage 93 · StrongLow 37Details
Commit message · Rusty Russell

lightningd: don't allow invoices with 640 byte descriptions.

They are invalid! This is because our BOLT11_FIELD_BYTE_LIMIT is not the limit,
it's one greater than the limit.

Reported-by: https://github.com/noblepayne
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON-RPC: `invoice` no longer accepts 640-byte descriptions (it would produce malformed invoices).

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
AI analysis · Low 37/100

This fix stops Core Lightning from creating invalid BOLT11 invoices when a user supplies a 640-byte payment description. Previously the software treated 640 bytes as acceptable, but the Lightning protocol only allows 639 bytes, so a 640-byte description produced a malformed invoice that other wallets might reject or fail to parse correctly. The change tightens the length check and updates an internal constant so the limit is now correctly 639 bytes.

Lower-prioritysplice: Clean up some spammy debug messagesby Dusty Daemon · 4525243b · Nov 13, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Dusty Daemon

splice: Clean up some spammy debug messages

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply removes extra debug log messages from a sorting function used during splicing. No code behavior changes; it only reduces log noise.

Lower-prioritysplice: Add Bolt references and conform to themby Dusty Daemon · 4d155814 · Nov 13, 2025 · 3 filesMessage 68 · AdequateLow 45Details
Commit message · Dusty Daemon

splice: Add Bolt references and conform to them

Adding Bolt references around `commitment_signed` logic and conforming to them.

This allows us to remove the `await_commitment_succcess` logic which was never elegant anyway, nice!

While we’re there we remove a parameter from `handle_peer_commit_sig_batch` that shouldn’t have been there anyway.

Changelog-Changed: Adding stricter conformance to Bolt spec for splice commitments.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 45/100

This commit tightens how Core Lightning handles commitment messages during splicing (a way to resize a Lightning channel). It removes an internal 'await commitment success' flag and instead follows stricter BOLT specification rules: requiring a batch of commitment_signed messages when splices are pending, requiring a funding_txid in those messages, and failing the channel with an error if those rules are violated. The change is framed as spec conformance, but it also removes a lenient 'ignore stale commit_sig' path that previously could have let mismatched messages pass during a splice race.

Lower-prioritycontrib: Let log visualizer open all nodes in tabsby Dusty Daemon · c018f749 · Nov 13, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Dusty Daemon

contrib: Let log visualizer open all nodes in tabs

New feature when visualizing logs with multiple nodes to view them all in multiple tables

Changelog-None

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit updates a local HTML helper tool used to view test logs. It adds a convenience feature to open logs from multiple test nodes in separate browser tabs. There is no indication this change affects real Lightning node operations, wallets, network protocol handling, or any production code.