ci: fix the coverage nightly's profile handling
What the developer wrote
Authored by cdecker
ci: fix the coverage nightly's profile handling
Three things stand between the restored scripts and a nightly that
finishes:
pyln-testing sets CLN_TEST_NAME for every test, so the profiles land in
$CLN_COVERAGE_DIR/<test-name>/ and never directly in $CLN_COVERAGE_DIR.
The coverage-raw/*.profraw upload glob therefore matches nothing, under
if-no-files-found: error. A local three-test run produced 515 profiles,
all of them in subdirectories. Both jobs now hand the directory to
collect-coverage.sh, which walks it and drops what crashed tests left
half-written; that also retires the flattening cp, which could collide
on <pid>-<signature>.profraw between matrix cells.
The build uses the runner's default clang while the report job installed
LLVM 18 and symlinked llvm-profdata to it. There are no compatibility
guarantees for the raw profile format across LLVM releases, so the two
have to come from the same one.
Codecov cannot read a .profdata; it gets the lcov export instead.
Changelog-None
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HGKo3ccLpkH2xFeEXUzEBK
What changed, and why it matters
This commit fixes the project's internal nightly code-coverage CI workflow. It changes how test coverage files are collected, ensures the same LLVM compiler version is used to generate and merge coverage data, and uploads a Codecov-compatible lcov report instead of an unreadable .profdata file. There is no security issue here—just build-script maintenance.
No security action needed. Treat as routine CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates .github/workflows/coverage-nightly.yaml: (1) uploads the whole coverage-raw/ directory because pyln-testing stores .profraw files in per-test subdirectories; (2) installs the distribution’s default llvm package rather than LLVM 18, so llvm-profdata matches the clang that produced the raw profiles; (3) passes the downloaded artifact tree directly to collect-coverage.sh, which now handles walking subdirectories and discarding half-written profiles from crashed tests; (4) uploads coverage/coverage.lcov to Codecov instead of coverage/merged.profdata, which Codecov cannot parse.
Changed components
.github/workflows/coverage-nightly.yamlInspect captured patch +12 / −21
### .github/workflows/coverage-nightly.yaml
@@ -101,7 +101,8 @@ jobs:
if: always()
with:
name: coverage-raw-${{ matrix.name }}
- path: coverage-raw/*.profraw
+ # pyln-testing puts the profiles in per-test subdirectories
+ path: coverage-raw/
if-no-files-found: error
report:
@@ -114,13 +115,13 @@ jobs:
- name: Checkout
uses: actions/checkout@v6
+ # The raw profile format has no compatibility guarantees across LLVM
+ # releases, so llvm-profdata has to come from the same release as the
+ # clang that produced the profiles: the distro default in both cases.
- name: Install LLVM tools
run: |
- wget https://apt.llvm.org/llvm.sh
- chmod +x llvm.sh
- sudo ./llvm.sh 18
- sudo ln -sf /usr/bin/llvm-profdata-18 /usr/bin/llvm-profdata
- sudo ln -sf /usr/bin/llvm-cov-18 /usr/bin/llvm-cov
+ sudo apt-get update
+ sudo apt-get install -y llvm
- name: Download build artifact
uses: actions/download-artifact@v8
@@ -136,28 +137,18 @@ jobs:
pattern: coverage-raw-*
path: coverage-artifacts
+ # collect-coverage.sh walks the tree itself and rejects the profiles
+ # that crashed tests left half-written, so it gets the whole download.
- name: Merge coverage data
- run: |
- mkdir -p coverage-raw coverage
- find coverage-artifacts -name "*.profraw" -exec cp {} coverage-raw/ \;
- PROFRAW_COUNT=$(ls -1 coverage-raw/*.profraw 2>/dev/null | wc -l)
- echo "Found $PROFRAW_COUNT profile files"
- if [ "$PROFRAW_COUNT" -eq 0 ]; then
- echo "ERROR: No coverage data found"
- exit 1
- fi
- chmod +x contrib/coverage/collect-coverage.sh
- CLN_COVERAGE_DIR=coverage-raw ./contrib/coverage/collect-coverage.sh
+ run: ./contrib/coverage/collect-coverage.sh coverage-artifacts
- name: Generate HTML report
- run: |
- chmod +x contrib/coverage/generate-coverage-report.sh
- ./contrib/coverage/generate-coverage-report.sh
+ run: ./contrib/coverage/generate-coverage-report.sh
- name: Upload to Codecov
uses: codecov/codecov-action@v6
with:
- files: coverage/merged.profdata
+ files: coverage/coverage.lcov
flags: integration-tests
name: cln-nightly-coverage
token: ${{ secrets.CODECOV_TOKEN }}Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.