AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 20 Bitcoin

lsp_plugin: add lsps2_getinfo handler and call

Public commit record

What the developer wrote

Authored by Peter Neuroth

78/100 · Adequate
lsp_plugin: add lsps2_getinfo handler and call

This commit adds the lsps2_get_info call defined by BLIP052. It also
adds a test policy plugin that the LSP service plugin uses to fetch the
actual fee menu from to separate the concerns of providing a spec
compliant implementation of an LSP and making business decisions about
fee prices.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit adds a new feature to Core Lightning's experimental LSPS (Lightning Service Provider Specification) plugin. It lets a client ask a service provider for its current fee menu, and the service plugin fetches that menu from a separate policy plugin. The change is mostly feature work, but it introduces a few places where malformed input or a misbehaving policy plugin could cause errors or unexpected behavior. There is no indication this fixes a known security bug or is being treated as a security patch by the project.

Recommended action

Treat as a normal feature commit. Reviewers should verify that the policy-plugin RPC is only exposed to the local node (it is prefixed `dev-`), that error responses do not leak sensitive internal paths to remote peers, and that the promise HMAC covers all fields intended to be tamper-evident per BLIP-052. No urgent security action is indicated from this diff alone.

Security signals we found

01

New network-exposed RPC method `lsps-lsps2-getinfo` added to client plugin

02

New JSON-RPC handler `lsps2.get_info` added to service plugin

03

Service plugin delegates fee policy to external plugin via `dev-lsps2-getpolicy` RPC

04

Error message from policy plugin is forwarded to remote peer with code 200, potentially leaking internal error details

05

Promise HMAC is computed over policy-provided fee parameters using a configured 32-byte secret

Risk score

Why this scored 20/100

Our methodology →
Potential impact 2/30
Exploitability 3/25
Stealth signal 2/15
Affected reach 3/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.