lsp_plugin: change listprotocols request
What the developer wrote
Authored by Peter Neuroth
lsp_plugin: change listprotocols request
Using lsp_id instead of peer as identifier
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
What changed, and why it matters
This commit simply renames a parameter in the LSPS (Lightning Service Provider Specification) plugin from 'peer' to 'lsp_id'. It is a straightforward API naming change with no apparent security implications.
No security action required. This is a normal refactoring/API consistency change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies the lsps-plugin’s listprotocols request handler to use ‘lsp_id’ instead of ‘peer’ as the identifier field. The change is purely cosmetic/naming consistency: the same string value (the peer node ID) is still passed to Bolt8Transport. The test is updated accordingly. No security vulnerability is introduced or fixed by this change.
Changed components
plugins/lsps-plugin/src/client.rstests/test_cln_lsps.pyInspect captured patch +3 / −3
diff --git a/plugins/lsps-plugin/src/client.rs b/plugins/lsps-plugin/src/client.rs
index ce39d655..b100e5f4 100644
--- a/plugins/lsps-plugin/src/client.rs
+++ b/plugins/lsps-plugin/src/client.rs
@@ -62,7 +62,7 @@ async fn on_lsps_listprotocols(
) -> Result<serde_json::Value, anyhow::Error> {
#[derive(Deserialize)]
struct Request {
- peer: String,
+ lsp_id: String,
}
let dir = p.configuration().lightning_dir;
let rpc_path = Path::new(&dir).join(&p.configuration().rpc_file);
@@ -71,7 +71,7 @@ async fn on_lsps_listprotocols(
// Create the transport first and handle potential errors
let transport = Bolt8Transport::new(
- &req.peer,
+ &req.lsp_id,
rpc_path,
p.state().hook_manager.clone(),
None, // Use default timeout
diff --git a/tests/test_cln_lsps.py b/tests/test_cln_lsps.py
index 5803d934..512d432d 100644
--- a/tests/test_cln_lsps.py
+++ b/tests/test_cln_lsps.py
@@ -27,5 +27,5 @@ def test_lsps0_listprotocols(node_factory):
# We don't need a channel to query for lsps services
node_factory.join_nodes([l1, l2], fundchannel=False)
- res = l1.rpc.lsps_listprotocols(peer=l2.info['id'])
+ res = l1.rpc.lsps_listprotocols(lsp_id=l2.info['id'])
assert res
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.