Modular C implementation of the Lightning Network protocol and node stack.
Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Aug 5 → Feb 61049 seen37 candidatesCompleteFeb 6 → Jun 6579 seen10 candidatesCompleteJun 6 → Jul 678 seen1 candidatesCompleteJul 6 → Aug 5147 seen16 candidatesCompleteMessage quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
Public Git author strings; identities are not independently verified.
Last scanned 19 minutes ago
This commit simply adds a new person's PGP public-key fingerprint to the list of trusted release signers in two documentation files. It does not change any code, fix any bug, or alter any security behavior of the software itself.
41278b4eby jaonoctus+2−02 filesThis is a tiny internal fix to make a bookkeeping migration produce stable event ordering. It changes the timestamp used when creating historical 'deposit' records during a one-time database migration, so the records sort consistently with…
498e5086by daywalker90+2−01 fileThis commit is a documentation-only cleanup of the JSON-RPC command help files. It corrects which numeric error codes are listed for each command so the published schemas match what the software actually returns. No program logic, validati…
d1b6963bby daywalker90+204−1224 filesThis commit fixes a bug where a setting that controls whether unexpected transaction signatures are allowed was not initialized when the channel daemon starts. If a peer sent such signatures before the channel was fully ready, the program …
c09c4520by Erick Cestari+1−01 fileThis commit fixes the project's internal nightly code-coverage CI workflow. It changes how test coverage files are collected, ensures the same LLVM compiler version is used to generate and merge coverage data, and uploads a Codecov-compati…
5685c9a3by cdecker+12−211 fileThis commit is a large cleanup of Core Lightning's API schemas, generated RPC bindings, and related plugin code. The stated goal is to make the documented 'required' fields match what the C code actually always produces or expects. In prac…
ddbd2963by daywalker90+1786−173950 filesThis commit only updates documentation. It adds error code 313 to the documented error lists for several Core Lightning commands (fundpsbt, utxopsbt, txprepare, multiwithdraw, and upgradewallet). The error code already existed in the code …
a34b9758by Peter Neuroth+30−86 filesThis commit fixes a release-script check that verifies the cryptographic signature on a file of checksums. Previously, the script only told GPG to verify the signature file itself. If someone replaced that signature file with an inline-sig…
8e495707by Peter Neuroth+5−21 fileThis commit updates Core Lightning's release documentation to tell users and release managers to run gpg --verify with both the signature file and the manifest file named explicitly. The old one-argument form can silently succeed even if t…
2dee8699by Peter Neuroth+9−62 filesThis commit is a routine update to the Rust dependency lock file (Cargo.lock), bumping many third-party libraries to newer patch or minor versions. The commit message gives no security reason for the update, and no verified references link…
c1551c55by daywalker90+298−2761 fileThis commit fixes a stack-overflow risk in Core Lightning's JSON parser. Before the fix, an attacker could send a valid JSON-RPC message containing thousands of nested brackets or braces. The parser's own helper functions used recursion fo…
83f92e4bby Níckolas Goline+90−22 filesThis commit only fixes typos and comment style. It changes two C-style comments from // to /* */ and corrects a grammar error in a documentation comment ('element' to 'elements'). There are no code behavior changes, no bug fixes, and no se…
273d7f02by w3lld1+3−32 filesThis change fixes a test-infrastructure bug in Core Lightning's Python testing helpers. When running tests against a PostgreSQL database, very long test names could be silently shortened by PostgreSQL, causing different test runs or nodes …
c4fe4cbaby Peter Neuroth+59−12 filesThis fix prevents Core Lightning from trying to use freshly created bitcoins (immature coinbase rewards) as emergency funds for fee-bump transactions. Such a transaction would be invalid under Bitcoin's rules and would be rejected by the n…
34883ff7by cdecker+5−12 filesThis commit fixes a bug in Core Lightning's askrene plugin that could prevent a node from restarting. When a saved routing layer contained a node bias with a description, the plugin accidentally freed the description's memory while using i…
4681177dby Vincenzo Palazzo+2−32 filesThis commit only fixes a test case so it actually exercises the intended code path. It does not change any production code, so it cannot introduce or fix a real-world security vulnerability by itself. The test change is a reproducer for a …
0f3f67a0by Vincenzo Palazzo+3−21 fileThis commit fixes a bug in Core Lightning's experimental dual-funded channel feature. When another node tried to open a channel, Core Lightning was not checking whether the proposed transaction fees were reasonable. A peer could request a …
ba08356fby cdecker+140−04 filesThis commit adds regression tests for three related bugs where wildly wrong Bitcoin transaction feerates could enter Core Lightning. In the worst case, a malicious or broken fee source could make the node think a feerate was zero (due to a…
65bdbc47by cdecker+137−02 filesThis update fixes a crash bug in Core Lightning. When the software tried to list details of a channel opening in progress, it could crash if a stored fee rate was extremely large or zero. The crash happened because the code used an interna…
d67c4936by cdecker+72−227 filesThis commit fixes a bug where Core Lightning nodes could get stuck in a crash loop. If a node had previously stored an extremely high or zero fee rate for an in-progress channel funding operation (a 'splice' or dual-funded channel RBF), a …
f057c692by cdecker+34−01 fileExpand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
d065d369 · Dec 18, 2025 · 1 fileInformational 15tests: add payer_note case for xpay
This commit only changes a test file. It updates an existing test case to pass a new optional parameter, payer_note, when calling the xpay command for a BOLT 12 invoice. There is no change to production code, no bug fix, and no security relevance.
07165697 · Dec 18, 2025 · 1 fileInformational 15readme: change links for 'Useful commands' from local to a web doc
Changelog-None
This commit only updates the README file to point documentation links for common commands to an external website instead of local files. It does not change any program code, configuration, or security behavior.
611e2620 · Dec 17, 2025 · 1 fileInformational 15script: Update sync RPC documentation script to check if the page was renderable for Readme
- ReadMe API v2 now requires category.uri instead of category.id.
- ReadMe v2 page responses include a renderable field indicating whether the document is MDX-compatible and can be rendered successfully. The script now checks this field and prints detailed compilation errors if rendering fails.
This commit updates an internal GitHub automation script that publishes Core Lightning's JSON-RPC command documentation to the ReadMe documentation platform. It adapts the script to ReadMe's newer API version (using a category web address instead of a numeric ID, wrapping page content differently, and checking whether ReadMe can successfully render each uploaded page). There is no change to the Core Lightning node software, wallet logic, network protocol, or any user-facing runtime behavior. It is purely a documentation-publishing tooling fix.
3e841b35 · Dec 17, 2025 · 151 filesInformational 15docs: Updated schema for mdx compatibility
Changelog-Fixed: Ensure documentation renders correctly when adding/updating new RPCs by detecting non-MDX-compatible pages.
This commit is a documentation-only change. It updates the project's documentation files and JSON schemas so that author email addresses, web links, and tables are written in a format compatible with MDX (a modern documentation rendering format). There are no changes to the actual Core Lightning software code, so it cannot affect node security, funds, or network behavior.
d1857fff · Dec 17, 2025 · 1 fileLow 28pytest: add test to demonstrate gossip_store misordering node announcements.
We usually lose the node announcement on restart, because the
node_announcement message is ignored by gossmap, as it doesn't (yet!) know of the node, since the
channel_announcement does not precede the node_announcement.
This is supposed to be detected and fixed by gossipd, but this simple test shows that it is not!
```
FAILED tests/test_gossip.py::test_gossmap_lost_node - AssertionError: assert {'nodes': [{'nodeid': '022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59', 'alias': 'SILENTARTIST-v25.12-2-g703851b', 'color': '022d22', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}, {'nodeid': '0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518', 'alias': 'JUNIORBEAM-v25.12-2-g703851b', 'color': '0266e4', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}, {'nodeid': '035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d'}, {'nodeid': '0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199', 'alias': 'JUNIORFELONY-v25.12-2-g703851b', 'color': '0382ce', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}]} == {'nodes': [{'nodeid': '022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59', 'alias': 'SILENTARTIST-v25.12-2-g703851b', 'color': '022d22', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}, {'nodeid': '0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518', 'alias': 'JUNIORBEAM-v25.12-2-g703851b', 'color': '0266e4', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}, {'nodeid': '035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d', 'alias': 'HOPPINGFIRE-v25.12-2-g703851b', 'color': '035d2b', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}, {'nodeid': '0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199', 'alias': 'JUNIORFELONY-v25.12-2-g703851b', 'color': '0382ce', 'last_timestamp': 1765172273, 'features': '8898880a8a59a1', 'addresses': []}]}
Differing items:
{'nodes': [{'addresses': [], 'alias': 'SILENTARTIST-v25.12-2-g703851b', 'color': '022d22', 'features': '8898880a8a59a1...}, {'addresses': [], 'alias': 'JUNIORFELONY-v25.12-2-g703851b', 'color': '0382ce', 'features': '8898880a8a59a1', ...}]} != {'nodes': [{'addresses': [], 'alias': 'SILENTARTIST-v25.12-2-g703851b', 'color': '022d22', 'features': '8898880a8a59a1...}, {'addresses': [], 'alias': 'JUNIORFELONY-v25.12-2-g703851b', 'color': '0382ce', 'features': '8898880a8a59a1', ...}]}
Full diff:
{
'nodes': [
{
'addresses': [],
'alias': 'SILENTARTIST-v25.12-2-g703851b',
'color': '022d22',
'features': '8898880a8a59a1',
'last_timestamp': 1765172273,
'nodeid': '022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59',
},
{
'addresses': [],
'alias': 'JUNIORBEAM-v25.12-2-g703851b',
'color': '0266e4',
'features': '8898880a8a59a1',
'last_timestamp': 1765172273,
'nodeid': '0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518',
},
{
- 'addresses': [],
- 'alias': 'HOPPINGFIRE-v25.12-2-g703851b',
- 'color': '035d2b',
- 'features': '8898880a8a59a1',
- 'last_timestamp': 1765172273,
'nodeid': '035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d',
},
{
'addresses': [],
'alias': 'JUNIORFELONY-v25.12-2-g703851b',
'color': '0382ce',
'features': '8898880a8a59a1',
'last_timestamp': 1765172273,
'nodeid': '0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199',
},
],
}
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit only adds a new test that demonstrates a bug: after restarting a Core Lightning node, one node's announcement information can disappear from the local network view. The test is marked as expected to fail, so it documents the problem rather than fixing it. There is no immediate security exploit here, but it shows a reliability issue in how the node stores and reloads network gossip data.
f0e95476 · Dec 17, 2025 · 2 filesLow 32gossipd: make sure we correctly move node announcement when *no* channel preceeds it in the gossip store.
We had the test backwards, so we moved it *all the time*. This bloats our gossip store, as well as
not moving it in the case where we need to.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: gossipd: we would occasionally not show a node announcement in listnodes().
This commit fixes a logic bug in Core Lightning's gossip daemon. The condition for moving a 'node announcement' record in the gossip store was accidentally inverted, so it was moved all the time instead of only when needed. This caused unnecessary growth of the gossip store and could hide node announcements from the listnodes() RPC result. It is a reliability/availability bug, not a direct funds-loss vulnerability, and there is no evidence it was disclosed as a security issue or credited to an external researcher.
38b3d14e · Dec 16, 2025 · 2 filesInformational 12plugins: lsps: add own trait for lsps offer provider
The cln api trait is really cluttered, we try to clean it up a little
bit.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a routine internal code cleanup in Core Lightning's experimental LSPS (Lightning Service Provider Specification) plugin. It splits two policy-related RPC methods out of a large generic 'ClnApi' trait into a new, smaller 'Lsps2OfferProvider' trait and refactors the handler code to use it. It also adds a new 'client_rejected' flag to the policy response so the plugin can reject clients early. There is no direct evidence in the commit or supplied references that this fixes a security vulnerability.
e50f5ee8 · Dec 16, 2025 · 7 filesInformational 12plugins: lsps: refactor service hook
We have some shared behavior and can use the MessageSender for the
service hook as well
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a routine internal code cleanup (refactor) in the LSPS (Lightning Service Provider Specification) plugin for Core Lightning. It merges two similar message-handling paths into one shared implementation and switches the service-side response path to use the same message-sender component already used elsewhere. There is no indication from the commit itself that this fixes a security bug or introduces a vulnerability.
ba93a7ca · Dec 16, 2025 · 6 filesInformational 15plugins: lsps: move primitives into lsps0
Those primitives are actually defined in lsps0
This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This is a straightforward code reorganization: the developer moved shared data types (like monetary amounts and channel identifiers) from a file called 'primitives.rs' into a file called 'lsps0.rs' because the LSPS0 specification actually defines those types. Other files were updated to import from the new location. No behavior changes, bug fixes, or security fixes are visible in the diff.
0f624ed6 · Dec 16, 2025 · 3 filesInformational 14plugins: lsps: add peer_id to transport
Frankly, transport without a target doesn't make sense, so this commit
adds a PublicKey (from secp256k1) as the target to the Transport trait.
It can easily be replaced by a common PeerId without changing the api
for external implementations if needed in the future
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a routine code refactor in an experimental plugin. It adds a peer identifier (a public key) to the internal transport layer so every message knows which Lightning peer it is intended for. There is no indication this fixes a security bug; it is a design improvement.
74015850 · Dec 16, 2025 · 5 filesInformational 15plugins: lsps: move client transport to cln_adapters
cln_adapters is the layer that holds concrete implementations that are
related to core-lightning.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a pure code reorganization: it moves the client transport module from one directory (lsps0) to another (cln_adapters) without changing any behavior. The same code is deleted from one file and added to another, with only import paths updated. There is no security fix or vulnerability introduced.
3cf99c35 · Dec 16, 2025 · 1 fileInformational 12plugins: lsps: add slim multiplexing transport
We can separate concerns here by adding a lightweight multiplexing
transport client. This helps us to clean up any direct dependencies on
CLN
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit adds a new internal helper for the LSPS (Lightning Service Provider Specification) plugin that multiplexes JSON-RPC request/response messages over a generic sender. It is purely a refactor/addition of new code with no obvious security bug, no disclosed vulnerability, and no change to existing behavior that callers rely on.
b88dc597 · Dec 16, 2025 · 6 filesInformational 15plugins: lsps: move lsps2 model to proto module
This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a pure code refactor: it moves the LSPS2 data model (request/response types, fee calculation, validation, and tests) from one internal module path to another within the same plugin crate. No functionality, logic, or security behavior changes. It is not a security fix.
5847cd44 · Dec 16, 2025 · 11 filesInformational 15plugins: lsps: move jsonrpc into proto module
This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a straightforward code reorganization: it moves the JSON-RPC protocol definitions from one Rust module to another inside the LSPS plugin. No security-sensitive logic is added, removed, or changed. It is purely a refactoring step to make the code more modular for third-party plugin developers.
b7be5ef3 · Dec 16, 2025 · 8 filesInformational 14plugins: lsps: refactor lsps2 and lsps0 error enums
Split them up how they are actually defined.
This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This is a routine code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It reorganizes how error codes are defined and generated, moving from hand-written helper functions to a macro-generated trait pattern. There is no security fix or behavior change visible in the diff.
d5bcde09 · Dec 16, 2025 · 2 filesInformational 12plugins: lsps: implement ClnSender for bolt8 transport
Implement the MessageSender trait for Bolt8 transport via core-lightning
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit adds a new Rust module that lets the LSPS plugin send custom Lightning messages through Core Lightning's RPC interface. It is a straightforward feature implementation with no obvious security bug. There is no indication in the commit that it fixes a vulnerability or addresses a security issue.
38c84be2 · Dec 16, 2025 · 1 fileInformational 14plugins: lsps: add own trait for blockheight provider
The ClnApi trait is way overloaded. We break things down to make it more
modular on the service side.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This is a routine internal code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It splits an overloaded interface into smaller, more focused pieces. There is no user-facing behavior change, no bug fix, and no security relevance visible in the commit.
a94885ba · Dec 16, 2025 · 2 filesInformational 15plugins: lsps: move errors into proto module
This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a routine code reorganization in Core Lightning's experimental LSPS plugin. It moves standard JSON-RPC error code constants from one internal Rust module to another and adds a new client-rejected error type. There is no security-relevant behavior change, no bug fix, and no vulnerability patch.
f678a706 · Dec 16, 2025 · 10 filesInformational 15plugins: lsps: remove lsps2 module
Separate concerns of the lsps2 modules into their respective layers:
core for tlv, as it is lightning related, not specifically
core-lightning. cln_adapters for core-lightning related types.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a straightforward internal code reorganization (refactoring) in the Core Lightning LSPS plugin. It removes a dedicated 'lsps2' module and splits its contents between a new 'core/tlv' module for generic Lightning TLV parsing and a new 'cln_adapters/types' module for Core Lightning-specific data structures. No security fixes or functional behavior changes are visible in the diff.
2546642c · Dec 16, 2025 · 4 filesInformational 12plugins: lsps: move id generation into jsonrpcrequest
There is no need to generate the id in some client when we can actually
generate it on a lower layer as we know by LSPS0 how we have to generate
it.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a routine code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It moves the generation of random request IDs from the transport/client layer down into the JSON-RPC request construction layer. There is no security-relevant change: the same secure random number generator is still used, and request IDs are still generated for normal requests while notifications remain without IDs. The change simply removes duplicated ID-generation logic and aligns the code with the LSPS0 specification.
bad42c71 · Dec 16, 2025 · 6 filesInformational 13plugin: lsps: simplify json-rpc response object
We can use an enum as a more idiomatic rust style to create and retreive
json-rpc responses. The actual response data is kept in the body enum
while the surrounding only holds the identifier.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a routine internal code cleanup in Core Lightning's experimental LSPS plugin. It replaces one Rust programming pattern for building JSON-RPC response messages with another, more idiomatic pattern. There is no indication it fixes a security bug, changes wire behavior, or introduces a vulnerability. It is purely a refactor.
ffc05ddc · Dec 16, 2025 · 3 filesInformational 12plugins: lsps: add slim generic json-rpc router
This router is very lightweight and can handle routing for the lsps
service. It avoids allocations by just borrowing from the request. This
is much cleaner than what we have now and reduces the amount of
serializations by a lot.
Also it supports typed handlers which will remove serialization overhead
from the handlers in future commits
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit adds a new internal JSON-RPC routing helper for the experimental LSPS plugin. It is a code-refactoring change: it introduces a lightweight router that borrows from incoming requests instead of copying data, and enables typed handlers to reduce serialization work. There is no indication in the commit that this fixes a security bug or introduces a vulnerability.
1159adb0 · Dec 16, 2025 · 7 filesInformational 15plugin: lsps: move json-rpc server to core module
This removes the jsonrpc module
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is a simple internal code reorganization: it moves the JSON-RPC server implementation from a 'jsonrpc' module into the 'core' module and updates import paths in other files. No security-relevant behavior changes are visible in the diff.
461065af · Dec 16, 2025 · 4 filesInformational 10plugins: lsps: add router compatible lsps2 service handler
This commit copys and adapts the lsps2 service handlers to match the
slim router handlers
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit adds a new experimental plugin feature for the LSPS2 protocol, which lets a Core Lightning node act as a service provider that opens just-in-time channels for payments. The change is purely additive (about 1,500 lines of new Rust code plus tests) and does not patch any reported vulnerability. There is no vendor statement or external report linking it to a security incident.
a05c2c9c · Dec 16, 2025 · 1 fileInformational 15plugins: lsps: add own trait for datastore provider
This now only makes it easier to test, but also more modular. It allows
us to use any kind of storage, not only the datastore.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This is a routine internal refactoring of a Core Lightning plugin. It introduces a new Rust trait so the LSPS2 plugin can store purchase records through any storage backend, not just the CLN datastore. The change is purely architectural: it moves datastore calls behind an interface, updates tests to use the new interface, and adds a new RPC call for policy lookups. There is no indication of a security fix or vulnerability.