pytest: another flake in test_important_plugin.
What the developer wrote
Authored by Rusty Russell
pytest: another flake in test_important_plugin.
There's one more complaint we can see when plugins get upset:
```
lightningd-1 2026-01-12T06:10:49.317Z **BROKEN** plugin-cln-xpay: askrene-create-layer failed with {"code":-4, "message":"Plugin terminated before replying to RPC call."}
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit is a one-line change to a test file. It adds another expected log message to a test that already tolerates several 'broken' log lines when a node is deliberately started with a missing important plugin. There is no change to production code, no security fix, and no vulnerability.
No security action needed. This is a test-only reliability improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates the broken_log regex in tests/test_plugin.py::test_important_plugin to also accept ‘Plugin terminated before replying to RPC call’. This is purely a test-flake suppression: when lightningd is started with a non-existent important plugin and then shuts down abruptly, other plugins can log broken messages. The change prevents CI from failing on an additional harmless race message.
Changed components
tests/test_plugin.pyInspect captured patch +1 / −1
diff --git a/tests/test_plugin.py b/tests/test_plugin.py
index 713b3fbb..78f6d849 100644
--- a/tests/test_plugin.py
+++ b/tests/test_plugin.py
@@ -2319,7 +2319,7 @@ def test_important_plugin(node_factory):
n = node_factory.get_node(options={"important-plugin": os.path.join(pluginsdir, "nonexistent")},
may_fail=True, expect_fail=True,
# Other plugins can complain as lightningd stops suddenly:
- broken_log='Plugin marked as important, shutting down lightningd|Reading sync lightningd: Connection reset by peer|Lost connection to the RPC socket',
+ broken_log='Plugin marked as important, shutting down lightningd|Reading sync lightningd: Connection reset by peer|Lost connection to the RPC socket|Plugin terminated before replying to RPC call',
start=False)
n.daemon.start(wait_for_initialized=False, stderr_redir=True)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.