CW
← All projectsCake Wallet

Cake Wallet / Monero.com

Noncustodial mobile and desktop wallet code for Cake Wallet and the Monero-only Monero.com wallet.

MoneroPrivacy protocolsSoftware walletsNormal
Repository coverage

916 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

152security candidates388second-pass queue540AI analyses
101commits · 30 days
176commits · 60 days
504commits · 180 days
821commits · 365 days
Backfill bands
Sep 27 → Mar 31329 seen44 candidatesComplete
Mar 31 → Jul 29266 seen28 candidatesComplete
Jul 29 → Aug 2891 seen17 candidatesComplete
Aug 28 → Sep 2765 seen18 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

62/100 average clarity
220Strong · 80–100
291Adequate · 60–79
256Thin · 40–59
149Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cyan781038268
David Adegoke1112774178
Omar Hatem751353171
malik1004x1522170065
Konstantin Ullrich631640076
Seth For Privacy421424085
Blazebrain191012058
tuxsudo23714058
Omar65649035
Serhii49619067
Robert Malikowski73555029
claude[bot]2158078
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 23 AI analysisMessage 35 · Opaque
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

fix litecoin renaming issue

This commit fixes a bug in the Cake Wallet Litecoin wallet where, when renaming a wallet, stored MWEB (a privacy feature for Litecoin) transaction records were being copied to a new storage box by reusing the exact same object references. …

Data migration now clones objects instead of sharing referencesPrevents potential state corruption when renaming Litecoin walletsNo explicit input validation or cryptographic change present
e45d45b1by Omar+12−11 file
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

ci: build iOS on the Mac Studio runners (canary), Xcode 27 (#3872)

This is a routine update to the project's automated iOS build pipeline. It changes which Apple computer (runner) and Xcode version are used to compile and upload the iPhone app, so the app meets Apple's upcoming App Store requirement to us…

1ab697f6by Seth For Privacy+22−21 file
No security note in commit
Informational 17 AI analysisMessage 18 · Opaque
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

miscellaneous

This commit is a routine mix of small fixes and test-tool updates. It makes a UI key more specific to avoid list-item conflicts, adds a safety check before showing a post-transaction popup, updates a test helper to match new app settings, …

Flutter BuildContext used across async gap now guarded by context.mountedNo explicit security keywords, CVE references, or advisory links in commit or titleChanges are split across UI, test tooling, and fixture scripts with no coherent security theme
ee39fd83by Omar+76−184 files
No security note in commit
Low 39 AI analysisMessage 100 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

Fix screen-reader gaps that block accessibility-tree automation (#3693)

This is a large accessibility and test-automation improvement for the Cake Wallet Flutter app. It adds stable identifiers to buttons, text fields, lists, and dialogs so screen readers and automated UI tests can find them. The patch also re…

Removed user-data interpolation from accessibility identifiers (tx ids, wallet names, seed words, addresses)Added stable, index-based or enum-based semantics identifiers across UI componentsAdded custom lints and CI workflow to prevent future user-data interpolation in test keys
be835c03by Seth For Privacy+2128−2260 files
Vendor flagged security relevance
Low 27 AI analysisMessage 100 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

QA: report-only e2e lanes (android / iOS / cache nightly) (#3700)

This commit adds three new automated testing pipelines for the Cake Wallet mobile app: one for Android, one for iOS, and a weekly overnight test. These are explicitly marked as 'reply-only' experiments, meaning a failure will not block rel…

New CI/CD pipeline handling wallet seed phrases and API keysUse of `NO_REPLY` / `continue-on-error: true` to avoid blocking mergesExplicit mitigation: avoids `npx` on macOS to prevent environment-variable leakage via process title
12f17920by Seth For Privacy+801−04 files
No security note in commit
Low 30 AI analysisMessage 100 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

Add TestId helper, identifier plumbing for shared widgets, and test-key lints (#3690)

This is a large cleanup of how the app labels its on-screen buttons and fields for automated testing and accessibility tools. Previously, many test labels were accidentally built from private user data such as wallet names, transaction IDs…

Accessibility identifiers derived from PII/sensitive data (wallet names, transaction IDs, seed words, addresses) are replaced with static or index-based identifiersNew custom lint rule no_string_interpolation_in_test_key blocks string interpolation in test keys except for int indexes and enum .nameNew custom lint rule require_test_key_semantics_identifier ensures framework interactive widgets with _key keys expose a Semantics identifier
e5505f89by Seth For Privacy+2086−630164 files
Vendor flagged security relevance
Low 48 AI analysisMessage 100 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

Refactor swap logic and state management (#3472)

This is a very large code refactor of the cryptocurrency swap/exchange feature in Cake Wallet. It rewrites how exchange rates are fetched, how trades are created and tracked, and how trade history is stored in the local database. The commi…

Large-scale rewrite of trade creation, rate fetching, and status monitoringDatabase schema migration for Trade table with data reconstruction from old columnsNew amount parsing helper (Money.safeParse) and exchange-rate math (ExchangeRate.fromAmounts)
d62183e3by malik1004x+26666−15194257 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

CW-1681-4-Bitcoin-Accounts-code-enhancements-lightning-deposit (#3825)

This commit expands Cake Wallet's Lightning Bitcoin feature so it works across multiple Bitcoin accounts instead of being locked to the primary account only. It also fixes address selection so the app picks an unused Segwit address that be…

Account isolation logic changed: Lightning and Segwit address selection now account-awarePrevious code could return a Segwit address from a different account than the one currently selectedRemoval of hard-coded account index checks suggests prior account-boundary assumptions were too restrictive
30658bb3by Serhii+14−145 files
No security note in commit
Low 32 AI analysisMessage 81 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

Cw 1681 bitcoin accounts code enhancements (#3728)

This commit is a large internal refactor of how Bitcoin-style wallets in Cake Wallet store and derive account keys. It replaces scattered maps of HD keys with a single shared 'ElectrumAccounts' model, initializes those keys earlier during …

Refactor of BIP32 HD key derivation and account key storage across multiple coin modulesWallet keys view model now exposes master xPrv and xPub instead of per-account private keyChange in how legacy change HDs are identified, with a new regression test for Litecoin MWEB change addresses
2388fd70by Serhii+500−37317 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

Remove unused Android MainActivity and Application copies (#3849)

This commit deletes four leftover Android Java files that were no longer used. The app's namespace was already fixed to 'com.cakewallet.cake_wallet', so these old copies of the main activity and application class under different package na…

06f6e5bfby Omar Hatem+0−1874 files
No security note in commit
Informational 22 AI analysisMessage 96 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

i18n: fit the long Tamil strings on the new UI (#3878)

This commit fixes visual layout bugs in the Cake Wallet mobile app where long Tamil translations were being drawn off-screen or clipped. It also fixes a broken unit test by adding a missing mock object. There is no security vulnerability h…

8c3365fdby Seth For Privacy+232−1446 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

i18n: add Bengali, Marathi, Tamil, Telugu and repair Hindi (#3859)

This commit adds new language translations (Bengali, Marathi, Tamil, Telugu), fixes Hindi translations, and introduces automated tools to check translation quality. It also makes a small formatting fix so cryptocurrency amounts display wit…

No changes to cryptographic, authentication, networking, or storage codeNo permission changes or new entitlementsNo changes to dependency versions or external URL endpoints
87a71a84by Seth For Privacy+9719−10618 files
No security note in commit
Informational 20 AI analysisMessage 86 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

Add "More Actions" UI (#3667)

This commit is a routine user-interface redesign for the Cake Wallet app. It adds a new 'More Actions' menu (a floating plus button), moves Contacts and Buy/Sell options into that menu, and introduces first-time explainer pop-ups for gift …

No security-relevant code changes identifiedUI-only refactor with no new network, storage, or crypto logicNew URL launch to cakepay.com in gift card explainer uses standard url_launcher external application mode
3cd46aaeby malik1004x+1765−60831 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

a11y: Wallets tab screen-reader fixes (edit labels, coin names, single rows, current wallet) (#3752)

This commit improves accessibility for screen-reader users. It adds spoken labels to buttons that were previously unlabeled, announces which cryptocurrency each wallet holds, removes a duplicate invisible tap target, and makes the currentl…

0b121b07by Seth For Privacy+53−116 files
No security note in commit
Informational 19 AI analysisMessage 96 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

a11y: name settings switches by their row title and expose selected state on Fiat API choices (#3808)

This commit improves screen-reader accessibility in the Cake Wallet mobile app. It makes settings switches announce their name (e.g., 'Auto generate addresses, switch, off') and makes choice options like 'Enabled / Tor only / Disabled' tel…

b4192b14by Seth For Privacy+198−125 files
No security note in commit
Informational 18 AI analysisMessage 18 · Opaque
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

miscellaneous

This commit makes small GitHub workflow and documentation tweaks. It adds read-only permissions to four pull-request check workflows, deletes an already-commented-out lint workflow, and updates a Windows installer filename and release note…

Workflow least-privilege hardening: four PR workflows now declare read-only repository permissionsRemoval of an inactive lint workflow that contained commented-out build steps and external download commandsDocumentation-only update for Windows installer filename and release history
613ced85by Omar+14−1106 files
No security note in commit
Informational 15 AI analysisMessage 76 · Adequate
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

v6.5.4 Release candidate (#3851)

This commit is a routine version bump and changelog update for the Cake Wallet/Monero.com v6.5.4 release candidate. It updates translated changelog text, version/build numbers across Android, iOS, Linux, and macOS, and makes minor UI fixes…

1c80aca3by Omar Hatem+120−9539 files
No security note in commit
Moderate 51 AI analysisMessage 50 · Thin
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

- Fix signing messages to include change addresses as well

This commit fixes a bug in how Cake Wallet signs Bitcoin-style messages. Previously, the app could not correctly sign messages with 'change addresses' (a special type of address used when sending leftover funds back to yourself). The fix m…

Refactor centralizes address validation and derivation-path construction for hardware signingChange addresses are now included in address lookup, fixing a functional signing bugTaproot and MWEB addresses are explicitly rejected for message signing
40ffab7dby Omar+260−1368 files
No security note in commit
Moderate 60 AI analysisMessage 98 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

fix: refuse Bitcoin message signing for an address the wallet cannot derive (#3826)

This commit fixes a bug in Cake Wallet's Bitcoin message signing. Previously, if a user chose a silent payment address (a newer privacy-focused Bitcoin address type), the app would still sign the message using the wallet's main key. That s…

Cryptographic signature produced for a different identifier than the one presented to the userSilent fallback to main wallet key when selected address cannot be derivedMessage signing bypass for silent payment / unheld addresses
a2e88dadby Omid+72−43 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
CW Cake WalletCake Wallet / Monero.com MoneroPrivacy protocolsSoftware wallets

[ui perf] pause animations in hidden dashboard tabs (#3806)

This commit is a straightforward user-interface performance fix. It wraps each tab of the app's main dashboard in a Flutter widget called TickerMode, which pauses animations in tabs that are not currently visible. Before the change, a load…

95b8b05aby malik1004x+8−33 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateci: build iOS on the Mac Studio runners (canary), Xcode 27 (#3872)by Seth For Privacy · 1ab697f6 · Nov 21, 2026 · 1 fileMessage 93 · StrongInformational 15Details
Commit message · Seth For Privacy

ci: build iOS on the Mac Studio runners (canary), Xcode 27 (#3872)

* ci: build iOS on the Mac Studio runners, sign and upload with Xcode 27

The build job takes its runner from the IOS_BUILD_RUNNER repository variable
(the self-hosted Mac Studio pool) and falls back to GitHub's xcode-27 image.
Both use Xcode 27.1, and the testflight job now runs on xcode-27 with Xcode 27.1
selected, so archives are built and exported with the same iOS 27 SDK that App
Store Connect requires from April 2027 (ITMS-90725).

* ci: re-run the iOS canary on the template with a pre-filled tool cache

* ci: re-run the iOS canary on the current template

* ci: drop the canary's runner and Xcode print step

* ci: pin Xcode 27.1 in build too, so either pool archives with the Xcode testflight exports with

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controldocumentation-only discount
AI analysis · Informational 15/100

This is a routine update to the project's automated iOS build pipeline. It changes which Apple computer (runner) and Xcode version are used to compile and upload the iPhone app, so the app meets Apple's upcoming App Store requirement to use the iOS 27 SDK. There is no user-facing change and no security fix or vulnerability introduced in the code itself.

Security candidateFix screen-reader gaps that block accessibility-tree automation (#3693)by Seth For Privacy · be835c03 · Nov 20, 2026 · 60 filesMessage 100 · StrongLow 39Details
Commit message · Seth For Privacy

Fix screen-reader gaps that block accessibility-tree automation (#3693)

* Add TestId helper for accessibility identifiers

Semantics(identifier:) is what XCUITest (accessibilityIdentifier) and
UIAutomator (resource-id) drivers match on; Flutter keys are invisible to
them. TestId.merge folds a leaf control into one node carrying the id,
TestId.container gives a group its own node; both return the child
unchanged for a null id.

TestId.fromKey only accepts ValueKey<String> values matching
^[a-z0-9_]+_key$. Identifiers ship in release builds and identity keys
(AnimatedSwitcher, contact names, balances) can hold user data, so keys
are never published wholesale. The pattern still accepts an interpolated
lowercase seed word, so the no_string_interpolation_in_test_key lint is
the actual guard.

On iOS a node with no label/value/action is not an accessibility
element, so ids belong on the control node (merge), not on bare
containers.

* Plumb testId into shared widgets

Each shared widget takes an optional testId and otherwise falls back to
TestId.fromKey(key), so the ~125 existing *_key keys on Cake widgets
surface as identifiers without touching call sites. Existing keys stay
where they are for find.byKey robots.

Placement:
- Widgets that already build a Semantics/MergeSemantics node get
identifier: on that node (ModernButton, CoinActionButton,
LoadingPrimaryButton, FloatingIconButton, SeedCheckboxRow,
CurrencyPickerRow, AlertCloseButton, StandardSwitch, LineTabSwitcher,
main nav bar).
- Widgets built on framework buttons are wrapped in TestId.merge only
when an id resolves (NewPrimaryButton, PrimaryButton,
PrimaryImageButton, OptionTile, StandardListRow/SettingsCellWithArrow,
SettingsSwitcherCell, StackedButtons link button), so label, role,
toggled state and id share one node.
- BaseAlertDialog action buttons get a button role and ids from their
keys, defaulting to alert_dialog_left/right_button_key, or
alert_dialog_action_button_key for single-action alerts.
- ModalTopBar: title gets its own container header node
<base>_title_key, chrome buttons <base>_leading_key /
<base>_trailing_key, base defaulting to modal_top_bar. The hashCode
keys stay because the trailing AnimatedSwitcher relies on them.
- ListItem.testId is applied by NewListSections; rows with a trailing or
bottom widget use a container so their own buttons stay separately
focusable, all other rows merge.
- BaseTextFormField uses a container, not MergeSemantics: merging folded
suffix buttons (paste, scan) into the text-field node. Only applied
when the field has a hint/label.
- SettingsChoicesCell and LineTabSwitcher use index-based ids so
localized option text never becomes an identifier.

* Add test-key semantics lints

require_test_key_semantics_identifier warns when a ValueKey/Key "*_key"
literal is the key of a framework interactive widget (GestureDetector,
InkWell, Text/Icon/Elevated/Outlined/FilledButton, TextField,
TextFormField, Switch, Checkbox, Radio, ListTile, CupertinoButton) and no
TestId.merge/TestId.container or Semantics(identifier:) encloses it in
the same method. Such keys work for find.byKey but are invisible to
XCUITest/UIAutomator. Cake widgets are not flagged because they now
derive an identifier from their key. A quick fix wraps the widget in
TestId.merge with the same id and adds the import; it is single-location
(IDE) only, dart fix does not apply it.

no_string_interpolation_in_test_key warns when a String or dynamic value
is interpolated into a "*_key" ValueKey/Key. Test keys become release
build accessibility identifiers, and the plan's inventory found seed
words, recipient addresses, wallet names and tx/order ids interpolated
into keys. ints, enums and enum .name are allowed. integration_test/ is
skipped: robots only look keys up, they never ship them.

Tests drive analyzer_testing's AnalysisRuleTest from plain package:test
cases against the mock flutter package. They avoid test_reflective_loader
because its test_ method names would need a nested analysis_options.yaml,
and a nested options file that includes the root one stops the plugin
from reporting on multi-file runs.

* Apply text-field identifier regardless of hint

* Key list text fields by keyValue so the identifier fallback applies

* Never derive list row identifiers from keyValue

NewListSections builds each row's key from ListItem.keyValue, which is an arbitrary runtime string (routes, provider titles, wallet names, node URIs). A user-chosen wallet name such as savings_key passed the fallback regex and shipped as a release accessibility identifier via WalletRemovalPopup. List rows now publish only an explicit ListItem.testId; the five security page rows that relied on the fallback get explicit ids.

* Add semantics_ids codemod for test keys on framework widgets

dart run tool/semantics_ids/main.dart [--apply] [paths...] lists ValueKey/Key
'*_key' literals passed as key: to framework interactive widgets with no
enclosing TestId or Semantics(identifier:), mirroring the
require_test_key_semantics_identifier lint (same widget list and ancestor
walk). --apply wraps each hit in TestId.merge(<same id>, child: ...) and adds
the test_id.dart import.

It parses without resolution so it runs in seconds, matching both
InstanceCreationExpression and unresolved MethodInvocation call forms. It
imports package:analyzer, already a transitive dependency of the root package
via build_runner/mobx_codegen, so no pubspec change is needed (tool/ already
imports other transitive packages such as args/convert). Verified against the
lint: identical 21 hits across lib/.

* Apply semantics_ids codemod to new-ui, placed by hand

The codemod found two hits in lib/new-ui; both sit under an existing
Semantics node, so per the placement rules the identifier goes on that node
instead of a new TestId.merge wrapper:
- assets_top_bar: identifier on the existing MergeSemantics>Semantics(button).
- history_top_bar: the key is inside ExcludeSemantics, so the identifier goes
on the outer Semantics(button, label).
Also moves home_page_wallet_name_text_key onto WalletInfoBar's outer
Semantics(label) for the same ExcludeSemantics reason (Text is not a lint
target, so the codemod does not report it).

* Index home history row ids instead of interpolating the tx id

home_page_transaction_<tx id>_key would publish transaction ids as release
accessibility identifiers (no_string_interpolation_in_test_key). Use the list
index, and surface it as the identifier on the row's existing merged
Semantics via TestId.fromKey(child.key).

HomePageRobot.firstTransactionIdInAllView now maps the index back to the
transaction through dashboardViewModel.items, so transaction_details_test
keeps comparing tx ids.

* Give new-ui settings rows and top bar stable ids

Each SettingsListItem carries a static testId,
settings_page_<route constant in snake_case, minus a trailing Page>_row_key
(e.g. settings_page_privacy_row_key), passed to ListItemRegularRow.testId so
the PR1 wrapper puts it on the row's merged node. keyValue stays the route so
NewSettingsPageRobot and find.byKey keep working. The top bar gets the
settings_page_top_bar base name.

* Give every new-ui ModalTopBar a per-sheet testId base name

All ModalTopBar instances in lib/new-ui (except receive_amount_modal and
wallet_accounts_page, owned by the a11y gap-fix PR) get
testId: "<file stem>_top_bar", so the title/leading/trailing ids become
<sheet>_top_bar_title_key / _leading_key / _trailing_key instead of the shared
modal_top_bar_* fallback. Files with two top bars use the class name:
send_help_page_top_bar, picker_top_bar, picker_slider_page_top_bar.

* Surface send sheet ids on their accessibility nodes

- NewSendAddressInput: identifier from its *_key key on the field's existing
MergeSemantics>Semantics(label) node (send_page_address_input_key).
- NewSendAmountInput: the TextField is deliberately unlabeled (an authored
label made Android announce the amount twice), so it gets a label-less
TestId.merge with the key-derived id; a widget test confirms it stays its
own isTextField node (send_page_amount_input_key).
- ConfirmSwiper: key-derived id on both the swiper's single Semantics node and
the accessible-navigation NewPrimaryButton fallback
(send_page_confirm_swiper_key).
- Fee and coin-control rows in Advanced settings get
send_page_fee_row_key / send_page_coin_control_row_key.
send_page_send_button_key already resolves through NewFuturePrimaryButton.

* Surface swap sheet ids on their accessibility nodes

SwapAmountBox's amount TextField and currency-picker GestureDetector are keyed
with a ternary ValueKey (receive vs deposit), which neither the lint nor the
codemod sees, so they are wrapped in TestId.merge with the same existing key
names: swap_page_{deposit,receive}_amount_field_key and
swap_amount_box_{deposit,receive}_currency_button_key.
The provider preview row gets swap_page_provider_row_key and the unlabeled
direction toggle gets swap_page_reverse_button_key. The swap button already
resolves via LoadingPrimaryButton's exchange_page_exchange_button_key.

* Give receive sheet controls stable ids

- Bottom buttons: receive_page_{copy,set_amount,label,addresses}_button_key via
ModernButton.testId.
- QR (receive_page_qr_code_key), address-type row
(receive_page_address_type_button_key) and label chip
(receive_page_label_chip_key): identifier on their existing
MergeSemantics>Semantics nodes.
- Address text: TestId.merge with its existing receive_page_address_key so the
segmented address is one labelled node.
- Top-bar trailing button: receive_page_share_button_key in large-QR mode,
receive_page_rotate_button_key otherwise.
- Address-type picker rows: index-based
receive_address_type_{common,other}_<index>_key on the row Semantics via
TestId.fromKey(key).
receive_amount_modal.dart is left to the a11y gap-fix PR.

* Index the new-ui wallet picker rows

SwapAddressSelectionModal is the new UI's wallet switcher (swap from/to wallet
picker). Each wallet row gets swap_wallet_picker_wallet_<index>_key, surfaced
on the row's tap target through TestId.merge(TestId.fromKey(widget.key)).
The index is used rather than the wallet name so no user data reaches the
identifier.

* Test new-ui identifiers on settings, send and receive

newui_identifiers_test pumps SettingsMainPage with a mocked dashboard and
checks five settings_page_*_row_key rows plus the settings_page_top_bar ids,
the send amount field staying its own text-field node with its id, the
confirm swiper id, and the four receive bottom-button ids.

platformNodesWithId now reads the identifier from getSemanticsData(), which
is what the platform receives: a merged parent (e.g. CopyWrapper's
MergeSemantics around the copy ModernButton) carries its descendant's
identifier there while its own config field stays empty.

* Use double-quoted test_id imports per prefer_double_quotes

* Apply semantics_ids codemod to lib/src and cake_pay, placed by hand

Wraps keyed framework controls in TestId.merge so their existing test keys
surface as accessibility identifiers. Where a Semantics node already labels
the control, the identifier goes on that node instead of a new wrapper
(contact_list_page add button, header_row transaction filter). The
new_wallet_page generate-name button swaps its label-only Semantics for
TestId.merge with the same label, so label, button role, tap and id are one
node instead of a label node over an unlabelled button.

new_wallet_type_${item.name} keeps its id: item is a WalletType, so .name is
an enum name and not user data.

* Index picker item ids instead of interpolating item names

Picker is generic and built ids from item.toString() (or Currency.name),
which the interpolation lint cannot prove is free of user data. Ids now use
the item's position in the picker's unfiltered items list, so they stay
stable while the search filter is applied, and the button ids surface via
TestId.merge.

Robots resolve the index from the open Picker's items through a new
BaseRobot.pickerIndexWhere helper.

* Index seed verification option ids instead of the seed word

seed_verification_option_<word>_button_key would publish seed words as
release-build accessibility identifiers. Use the option's index, surfaced
with TestId.merge. The robot finds the correct word's index in the view
model's currentOptions.

* Index wallet list row and edit ids instead of the wallet name

Wallets tab ids no longer carry wallet names:
- wallet_list_single_wallet_<i>_key on a single wallet's tappable title
- wallet_list_group_<i>_key on a group header
- wallet_list_group_<i>_wallet_<j>_key on a wallet row inside a group
- wallet_list_single_wallet_<i>_edit_button_key and
wallet_list_group_<i>_wallet_<j>_edit_button_key on edit buttons

GroupedWalletExpansionTile derives the title and child-row ids from its
tileKey via TestId.fromKey, so tiles without a test key are unchanged.
EditWalletButtonWidget surfaces its key on the edit button with
TestId.merge.

WalletListPageRobot.openEditFor looks the wallet up in the page's
singleWalletsList, and WalletFlows expands groups by the new group key.

* Keep tx, trade, order and address data out of data-model test keys

Transaction, trade, order, payjoin and anonpay list items were keyed with
their ids. These ActionListItem keys are never read (renaming the field
breaks nothing), but they are test keys, so they now use the item's
position in the list being built.

The saved recipient-address row reuses the static
standard_list_item_transaction_details_recipient_address_key; it is only
added when the definition-driven row with that key was not shown.

WalletKeysViewModel's _walletName was the wallet type name, not the wallet
name. Interpolate _wallet.type.name directly so the lint can see it is an
enum name; ids are unchanged.

* Use enum names for internal test key prefixes

ExchangeCard's cardInstanceName and DEuroSavingsPage's tooltip key were
app-internal constants passed as Strings, which the interpolation lint
cannot distinguish from user data. Type them as enums and interpolate
.name. The deuro ids are unchanged. ExchangeCard has had no callers since
the old exchange page was removed, so its ids have no consumers. Its two
address buttons get identifiers on their existing labelled Semantics.

* Pass alert dialog keys to the dialog widget

AlertWithOneAction accepted a key and dropped it, and BaseAlertDialog put
its own (always null) key on the barrier GestureDetector. BaseAlertDialog
now forwards super.key, AlertWithOneAction passes its key through,
AlertWithTwoActions passes alertDialogKey, and the GestureDetector no
longer repeats it, so find.byKey on a dialog key matches exactly one
widget.

* Test legacy wallet list, seed verification and alert identifiers

* Publish transaction detail row identifiers from their model keys

Removing the keyValue fallback in #3690 left TransactionDetailsModal rows without identifiers. The rows now pass the view model's static key through testId; every key in that model is a constant and the interpolation lint keeps it that way.

* Give the Set amount sheet stable semantics identifiers

The amount field gets its identifier on the existing Semantics inside the
MergeSemantics that already keeps it a distinct text-field node, so no new
node is added. The sheet's ModalTopBar gets the explicit receive_amount_modal
base id (title, leading close button) and the continue button gets its own
id, so uiautomator/XCUITest can address the sheet without relying on text.

* Use the colon-free amount string for semantics labels

S.amount is the visible caption "Amount: " and carries its own colon (and
trailing space) in every locale, so using it as the Set amount field's
semantics label produced "Amount: " on the node and "Amount:: 2500" in
tools that join label and value. The field now uses S.receive_amount
("Amount"); the visible caption is unchanged and no .arb file is touched.

The send and swap amount error live regions concatenated the same caption
with the error text. They now join S.receive_amount and the error with a
newline, the separator Flutter itself uses when merging labels, which
screen readers read as a pause in every locale.

* Announce PIN entry progress and identify the PIN pad keys

The PIN dots had no semantics, so screen-reader users got no feedback after
pressing a digit. The dots row is now one container live region labelled
"n of m digits entered" (new pin_digits_entered string) with the
pin_code_progress_key identifier. Only the count is exposed, never the
digits.

Digit buttons keep their existing ValueKey and gain the same string as their
identifier through TestId.merge, so the id lands on the TextButton's own
button node. The delete button's existing Semantics gets
pin_code_delete_button_key.

pin_digits_entered is added in English to every strings_*.arb next to
pin_at_top, for the translation workflow to fill in later.

* Make balance and account cards containers with index-based ids

The home balance card and the wallet accounts card both put a button
Semantics around a BalanceCard without container/explicitChildNodes, so every
balance Text folded into the card's label ("Savings\n0\nBTC\nUSD 0.00")
and there was nothing stable to target.

Both existing Semantics now set container and explicitChildNodes, keeping the
balances as their own child nodes under the card, and carry an index-based
identifier: home_page_balance_card_<realIndex>_key and
wallet_accounts_page_account_<index>_key. The user-editable account label is
never used in the id.

* Expose selection state and ids on segmented controls

Chart range options had no semantics beyond their text: no button role, no
selected state. Each option is now a merged button node with selected and
inMutuallyExclusiveGroup, identified as chart_range_<index>_key. ChartRange
is a class of static constants rather than an enum, so the index into
ChartRange.ranges is used instead of the display text, which may be
localised later.

SettingsChoicesCell options get the same button/selected/
inMutuallyExclusiveGroup semantics inside the existing TestId.merge, so
selection is announced with or without a testId.

The Lightning switch and the receive address type rows already had correct
roles and states; they only gain identifiers on their existing Semantics:
home_page_lightning_switch_key and receive_address_type_<index>_key, where
the index is into ReceiveOptionViewModel.options (stable per wallet type,
independent of the common/other grouping and sort).

* Identify the crypto and fiat balance lines on balance cards

With the card Semantics now using explicitChildNodes, each balance Text was
its own loose node ("0", "BTC", "USD 0.00"). The main balance line and
the secondary line are now each one container node, so the amount and its
asset are read together and can be targeted as
balance_card_crypto_balance_key and balance_card_fiat_balance_key. The ids
follow fiatFirst, which swaps which line shows the fiat amount.

The crypto line's container sits inside the existing
ExcludeSemantics(excluding: !selected), so unselected stacked cards still do
not announce, or expose an id for, a balance that is faded out.

* Label theme choices by title instead of toString()

MaterialThemeBase does not override toString(), so each theme preview was
announced as "Instance of 'LightTheme'". It now uses theme.title.

The option also gets display_settings_theme_<family>_key, where family is
themeFamily ("blacktheme") or else the theme type ("light"/"dark"). title
and raw are not used for the id because both change with the Black theme's
accent colour.

theme.title is still an English literal in each theme class; localising it
is left for a follow-up.

* Cover alert action buttons in the gap-fix tests

PR1 already wraps BaseAlertDialog's action GestureDetectors in
TestId.merge(Semantics(button: true)). This asserts that AlertWithOneAction
and AlertWithTwoActions each expose their actions as button nodes with tap
actions and the default alert_dialog_* ids.

AlertWithOneAction still drops its own key (BaseAlertDialog has no
constructor that accepts one, and its build() reuses key on the inner
GestureDetector), so passing it through is not a one-line change and is left
for a follow-up.

Also replaces the deprecated pipelineOwner tree walk in the PIN test with
find.semantics.byPredicate.

* Keep send and swap amount error labels unchanged

* Publish balance line identifiers only on the selected card

Every BalanceCard put the same global id on its lower balance line, so a home screen with several accounts exposed duplicate balance_card_fiat_balance_key (or crypto when fiatFirst) nodes. Unselected cards keep the label but no identifier.

* Stop announcing the account name twice on balance cards

The home and wallet-account card wrappers already label the card with the account name. With explicitChildNodes the BalanceCard header text became a second stop reading the same name, so it is excluded when it is the account name.

* Namespace transaction row ids by history view

The home preview indexes itemsShort (no date headers) and the All modal indexes items, so the same home_page_transaction_<i>_key meant different transactions in each. Preview rows keep home_page_transaction_<i>_key; modal rows become history_modal_transaction_<i>_key, and the robot reads the modal prefix.

* Keep transaction history keys unique across incremental updates; edit grouped wallets in the robot

History keys came from a local counter reset to 0 on every update, so appended items reused keys held by existing rows. The keys are never read, but they should still be unique: all six sites now share one view-model counter. WalletListPageRobot.openEditFor also resolves wallets inside groups, expanding the group first when its edit button is not built.

* Suffix the Lightning preimage row key with _key

It was the only transaction-detail key without the suffix, so TestId.fromKey rejected it and the row published no identifier.

* Hide the account index with the duplicated account name

With the name excluded, the index beside it became a bare "1." stop. It is now excluded under the same condition.

* Label the wallet edit button and expose the coin control checkbox state

The wallet rename control was an unlabelled icon button and the coin control
checkbox a bare GestureDetector, so neither TalkBack nor the e2e agent could
find or operate them (shadow QA could not rename wallets or deselect UTXOs).

* Stub a card order in the CardsView a11y tests

CardsView now builds its stack from cardOrder and picks designs through
cardAccountIndices, so an empty order rendered no cards.

* Wait for the wrong-PIN bar to clear before entering the right PIN

The failed-auth Flushbar has a 1s timer. If the correct PIN closes the
auth route while it is still up, the timer's pop trips a navigator
assertion. The extra PIN-pad semantics on this branch slow the Android
accessibility bridge enough to hit that window in show_keys_auth_test.

* Use TestId.container in the test-key quick fix for text fields

MergeSemantics would fold a field's suffix controls (paste, scan) into the
field node, so they stop being separately focusable. Text fields get
TestId.container instead, as BaseTextFormField already does.

* Drop the unused key on list text-field rows

It was added so a keyValue identifier fallback would apply; that fallback was
removed and the widget never reads its key.

* Address review: codemod guards, container on amount fields, ids on five top bars

- The codemod wraps TextField/TextFormField in TestId.container, like the lint
quick fix, and no longer picks up interpolated keys: one hit at this head
would have copied a seed word into an identifier.
- The send and swap amount fields use TestId.container.
- Five ModalTopBars that arrived through base merges get their own testId.

* Address review: unique saved-recipient key, delete dead ExchangeCard, CI check for test keys

- The saved-recipient fallback row no longer shares its key with the
recipient-address row.
- ExchangeCard is built by no screen, so it is deleted instead of retyped.
- A workflow fails when a test key under lib/ interpolates anything other
than a list index or an enum name. Until now only an IDE lint kept seed
words, addresses and wallet names out of release identifiers.

* Address review: translate the PIN progress announcement, one stop per checkbox row

- pin_digits_entered is translated in the 30 non-English locales. Each keeps
${entered} before ${total}: the generator takes a locale's parameters in
the order its own string uses them.
- A ListItemCheckbox row without a testId, and a coin control row, were two
screen-reader stops: the label, then an unnamed checked box. Each is now
one node carrying the name and the checked state. Tests cover a row with
and without a testId and the coin control row.

* Announce a labelled SVG once when it falls back to the raw asset

The fallback picture is built inside the first one's semantics node, so it
repeated the label as a second image node.

* Test-key check: allow a list position from indexOf

chart_range_${ChartRange.ranges.indexOf(item)}_key on the next branch in the
stack interpolates an int index and tripped the check.

* Keep the account name on a BalanceCard that nothing labels

The card dropped its account name and index from the tree so the home and
wallet-accounts wrappers would not repeat them. The card customizer shows the
card without such a wrapper, so the exclusion is now opt-in for those two.

* Add semantics identifiers to new-UI release-checklist screens and a semantics_ids codemod (#3694)

* Add semantics_ids codemod for test keys on framework widgets

dart run tool/semantics_ids/main.dart [--apply] [paths...] lists ValueKey/Key
'*_key' literals passed as key: to framework interactive widgets with no
enclosing TestId or Semantics(identifier:), mirroring the
require_test_key_semantics_identifier lint (same widget list and ancestor
walk). --apply wraps each hit in TestId.merge(<same id>, child: ...) and adds
the test_id.dart import.

It parses without resolution so it runs in seconds, matching both
InstanceCreationExpression and unresolved MethodInvocation call forms. It
imports package:analyzer, already a transitive dependency of the root package
via build_runner/mobx_codegen, so no pubspec change is needed (tool/ already
imports other transitive packages such as args/convert). Verified against the
lint: identical 21 hits across lib/.

* Apply semantics_ids codemod to new-ui, placed by hand

The codemod found two hits in lib/new-ui; both sit under an existing
Semantics node, so per the placement rules the identifier goes on that node
instead of a new TestId.merge wrapper:
- assets_top_bar: identifier on the existing MergeSemantics>Semantics(button).
- history_top_bar: the key is inside ExcludeSemantics, so the identifier goes
on the outer Semantics(button, label).
Also moves home_page_wallet_name_text_key onto WalletInfoBar's outer
Semantics(label) for the same ExcludeSemantics reason (Text is not a lint
target, so the codemod does not report it).

* Index home history row ids instead of interpolating the tx id

home_page_transaction_<tx id>_key would publish transaction ids as release
accessibility identifiers (no_string_interpolation_in_test_key). Use the list
index, and surface it as the identifier on the row's existing merged
Semantics via TestId.fromKey(child.key).

HomePageRobot.firstTransactionIdInAllView now maps the index back to the
transaction through dashboardViewModel.items, so transaction_details_test
keeps comparing tx ids.

* Give new-ui settings rows and top bar stable ids

Each SettingsListItem carries a static testId,
settings_page_<route constant in snake_case, minus a trailing Page>_row_key
(e.g. settings_page_privacy_row_key), passed to ListItemRegularRow.testId so
the PR1 wrapper puts it on the row's merged node. keyValue stays the route so
NewSettingsPageRobot and find.byKey keep working. The top bar gets the
settings_page_top_bar base name.

* Give every new-ui ModalTopBar a per-sheet testId base name

All ModalTopBar instances in lib/new-ui (except receive_amount_modal and
wallet_accounts_page, owned by the a11y gap-fix PR) get
testId: "<file stem>_top_bar", so the title/leading/trailing ids become
<sheet>_top_bar_title_key / _leading_key / _trailing_key instead of the shared
modal_top_bar_* fallback. Files with two top bars use the class name:
send_help_page_top_bar, picker_top_bar, picker_slider_page_top_bar.

* Surface send sheet ids on their accessibility nodes

- NewSendAddressInput: identifier from its *_key key on the field's existing
MergeSemantics>Semantics(label) node (send_page_address_input_key).
- NewSendAmountInput: the TextField is deliberately unlabeled (an authored
label made Android announce the amount twice), so it gets a label-less
TestId.merge with the key-derived id; a widget test confirms it stays its
own isTextField node (send_page_amount_input_key).
- ConfirmSwiper: key-derived id on both the swiper's single Semantics node and
the accessible-navigation NewPrimaryButton fallback
(send_page_confirm_swiper_key).
- Fee and coin-control rows in Advanced settings get
send_page_fee_row_key / send_page_coin_control_row_key.
send_page_send_button_key already resolves through NewFuturePrimaryButton.

* Surface swap sheet ids on their accessibility nodes

SwapAmountBox's amount TextField and currency-picker GestureDetector are keyed
with a ternary ValueKey (receive vs deposit), which neither the lint nor the
codemod sees, so they are wrapped in TestId.merge with the same existing key
names: swap_page_{deposit,receive}_amount_field_key and
swap_amount_box_{deposit,receive}_currency_button_key.
The provider preview row gets swap_page_provider_row_key and the unlabeled
direction toggle gets swap_page_reverse_button_key. The swap button already
resolves via LoadingPrimaryButton's exchange_page_exchange_button_key.

* Give receive sheet controls stable ids

- Bottom buttons: receive_page_{copy,set_amount,label,addresses}_button_key via
ModernButton.testId.
- QR (receive_page_qr_code_key), address-type row
(receive_page_address_type_button_key) and label chip
(receive_page_label_chip_key): identifier on their existing
MergeSemantics>Semantics nodes.
- Address text: TestId.merge with its existing receive_page_address_key so the
segmented address is one labelled node.
- Top-bar trailing button: receive_page_share_button_key in large-QR mode,
receive_page_rotate_button_key otherwise.
- Address-type picker rows: index-based
receive_address_type_{common,other}_<index>_key on the row Semantics via
TestId.fromKey(key).
receive_amount_modal.dart is left to the a11y gap-fix PR.

* Index the new-ui wallet picker rows

SwapAddressSelectionModal is the new UI's wallet switcher (swap from/to wallet
picker). Each wallet row gets swap_wallet_picker_wallet_<index>_key, surfaced
on the row's tap target through TestId.merge(TestId.fromKey(widget.key)).
The index is used rather than the wallet name so no user data reaches the
identifier.

* Test new-ui identifiers on settings, send and receive

newui_identifiers_test pumps SettingsMainPage with a mocked dashboard and
checks five settings_page_*_row_key rows plus the settings_page_top_bar ids,
the send amount field staying its own text-field node with its id, the
confirm swiper id, and the four receive bottom-button ids.

platformNodesWithId now reads the identifier from getSemanticsData(), which
is what the platform receives: a merged parent (e.g. CopyWrapper's
MergeSemantics around the copy ModernButton) carries its descendant's
identifier there while its own config field stays empty.

* Use double-quoted test_id imports per prefer_double_quotes

* Namespace transaction row ids by history view

The home preview indexes itemsShort (no date headers) and the All modal indexes items, so the same home_page_transaction_<i>_key meant different transactions in each. Preview rows keep home_page_transaction_<i>_key; modal rows become history_modal_transaction_<i>_key, and the robot reads the modal prefix.

* Address review: codemod guards, container on amount fields, ids on five top bars

- The codemod wraps TextField/TextFormField in TestId.container, like the lint
quick fix, and no longer picks up interpolated keys: one hit at this head
would have copied a seed word into an identifier.
- The send and swap amount fields use TestId.container.
- Five ModalTopBars that arrived through base merges get their own testId.

* Semantics identifier tests: #3469 widget tests, expectTestId, tier0 identifiers suite (#3696)

* Add semantics widget tests for the new a11y primitives

CW-1574. Screen-reader tests for the accessibility primitives introduced
by the six a11y branches, cherry-picked from #3469:

- ModernButton: single button node, semanticLabel over the visible caption,
decorative icon, semantic tap.
- ModalTopBar: leading button defaults to the localized "Close", custom
leading/trailing labels, title as a header, no phantom trailing node.
- ConfirmSwiper: button variant under accessibleNavigation (with swiperText
fallback) is tappable; the swiper variant is one unnamed-action node that
still confirms on a horizontal drag.
- FloatingIconButton, CakeImageWidget, RoundedCheckbox, PrimaryButton /
LoadingPrimaryButton, AddressFormatter.

AddressFormatter is the security-critical one: both the full and truncated
renderings must announce the entire address, never the chunked or
ellipsised visual form.

One test is skipped and documents a real defect rather than asserting it:
RoundedCheckbox(value: false) renders Offstage(), whose zero-rect node
Flutter drops, so an unselected option announces nothing.

* Update semantics tests for the review round, add CopyWrapper coverage

Follows the five review fix commits merged into this branch.

ModalTopBar: the implicit "Close" default is gone, so the test that pinned
it is replaced by tests that the new constructor asserts fire -- a
leadingIcon without a non-empty leadingSemanticLabel, and the trailing
equivalent -- plus the cases that must still be accepted (no icons at all,
a leadingWidget that carries its own semantics). The explicit-label,
header and tap tests carry over with labels now supplied.

ModernButton: new tests for the constructor assert on both constructors --
icon-only with no name is rejected, an empty visible label does not count,
and either a visible label or a semanticLabel satisfies it.

PrimaryButton: its Semantics wrapper is gone, so the tests now pin the
TextButton-provided behaviour that replaced it. The reviewer's claim holds
for the ordinary cases (label and disabled state survive), with one
exception worth flagging: isDisabled + onDisabledPressed now reports
ENABLED, because there is no longer an `enabled:` annotation independent of
the TextButton callback. Asserted as-is rather than worked around.
LoadingPrimaryButton keeps its wrapper and its tests unchanged.

CopyWrapper (new file): builder mode exposes one merged node with the copy
custom action and no duplicate stop; nothing-to-copy returns the child with
no phantom actionable node or hint; copying flips the label and marks the
node a live region, matching the move off SemanticsService.announce;
requireLongPress swaps the hint, drops `button`, and only responds to a
long press; controlBuilder mode stacks no extra gesture or action on the
caller's control and hands it a null onCopy when there is nothing to copy.

* Rebase the #3469 semantics tests onto the current widgets

Drop the ModernButton and ModalTopBar constructor-assert groups: #3483
replaced those asserts with the modern_button_semantics and
modal_top_bar_semantics lints, so the constructors now accept an
unnamed icon and the rule is enforced at analysis time instead.

Move the duplicated simulatedAccessibilityTraversal helper into
semantics_helpers.dart as screenReaderStops, migrate the deprecated
containsSemantics matcher to isSemantics, replace the deprecated
binding.pipelineOwner lookup, and strip the comments.

The skipped RoundedCheckbox test still documents a real defect:
value: false renders Offstage(), a zero-rect subtree Flutter drops from
the semantics tree, so the checked: false state never reaches a screen
reader. Giving the unchecked indicator the checked one's 20x20 footprint
fixes it but shifts layout in the two pickers that use it.

Add a ModalTopBar test that a sheet has exactly one header node, that it
carries <testId>_title_key with the title alone (bottomText stays out),
and that the leading and trailing buttons carry their own ids.

* Add expectTestId and a tier0 semantics identifiers suite

BaseRobot.expectTestId waits for find.bySemanticsIdentifier with
pumpUntilFound, takes the same timeout screenshot, and also screenshots
before failing on a duplicate id. It holds its own ensureSemantics
handle so it works even if a suite turns semanticsEnabled off; on a
physical iOS device that handle is what makes Flutter build the tree.
tapTestId taps by identifier for controls that carry a testId but no
ValueKey, such as the receive sheet buttons, keeping find calls in the
robot layer.

semantics_identifiers_test creates a Solana wallet and asserts the
navbar, home action, settings, receive, set amount and send identifiers
added by the TestId plumbing and the new-ui id pass, each after
waiting for its screen. The set amount sheet has no testId yet, so it is
checked through the ModalTopBar fallback modal_top_bar_title_key; once
#3693 gives it testId "receive_amount_modal" that becomes
receive_amount_modal_title_key and modal_top_bar_leading_key becomes
receive_amount_modal_leading_key. No alert is reachable without a
funded, synced wallet, so alert_dialog_action_button_key stays covered
by the widget tests only.

The runner discovers suites by glob; the suite is added to the tier0
table in docs/INTEGRATION_TESTS.md.

* Count exported semantics nodes in expectTestId

find.bySemanticsIdentifier also matches render objects whose node was merged into a parent, so an identifier that never reaches the accessibility client still passed. The assertion now walks the semantics tree and requires exactly one node that is not merged into its parent.

* Walk the Set amount sheet by identifier in the tier0 suite

* Hold a semantics handle in tapTestId and enterTextByTestId

find.bySemanticsIdentifier only sees nodes while semantics is enabled, and expectTestId releases its handle on return, so the tap and text helpers now hold their own instead of relying on something else keeping semantics on.

* Address review: pin the swiper's scroll actions, cover SVG assets, drop the skipped test

- The ConfirmSwiper test now fails if the bare GestureDetector's scroll
actions come back; it passed with the old broken shape before.
- CakeImageWidget is tested with an .svg asset, the path 123 of 125 callers use.
- The skipped RoundedCheckbox test pinned nothing and is removed.

* Put list text-field test ids on the field, not the merged row

* Surface legacy screen test keys as accessibility identifiers and drop user data from ids (#3695)

* Add semantics_ids codemod for test keys on framework widgets

dart run tool/semantics_ids/main.dart [--apply] [paths...] lists ValueKey/Key
'*_key' literals passed as key: to framework interactive widgets with no
enclosing TestId or Semantics(identifier:), mirroring the
require_test_key_semantics_identifier lint (same widget list and ancestor
walk). --apply wraps each hit in TestId.merge(<same id>, child: ...) and adds
the test_id.dart import.

It parses without resolution so it runs in seconds, matching both
InstanceCreationExpression and unresolved MethodInvocation call forms. It
imports package:analyzer, already a transitive dependency of the root package
via build_runner/mobx_codegen, so no pubspec change is needed (tool/ already
imports other transitive packages such as args/convert). Verified against the
lint: identical 21 hits across lib/.

* Apply semantics_ids codemod to new-ui, placed by hand

The codemod found two hits in lib/new-ui; both sit under an existing
Semantics node, so per the placement rules the identifier goes on that node
instead of a new TestId.merge wrapper:
- assets_top_bar: identifier on the existing MergeSemantics>Semantics(button).
- history_top_bar: the key is inside ExcludeSemantics, so the identifier goes
on the outer Semantics(button, label).
Also moves home_page_wallet_name_text_key onto WalletInfoBar's outer
Semantics(label) for the same ExcludeSemantics reason (Text is not a lint
target, so the codemod does not report it).

* Index home history row ids instead of interpolating the tx id

home_page_transaction_<tx id>_key would publish transaction ids as release
accessibility identifiers (no_string_interpolation_in_test_key). Use the list
index, and surface it as the identifier on the row's existing merged
Semantics via TestId.fromKey(child.key).

HomePageRobot.firstTransactionIdInAllView now maps the index back to the
transaction through dashboardViewModel.items, so transaction_details_test
keeps comparing tx ids.

* Give new-ui settings rows and top bar stable ids

Each SettingsListItem carries a static testId,
settings_page_<route constant in snake_case, minus a trailing Page>_row_key
(e.g. settings_page_privacy_row_key), passed to ListItemRegularRow.testId so
the PR1 wrapper puts it on the row's merged node. keyValue stays the route so
NewSettingsPageRobot and find.byKey keep working. The top bar gets the
settings_page_top_bar base name.

* Give every new-ui ModalTopBar a per-sheet testId base name

All ModalTopBar instances in lib/new-ui (except receive_amount_modal and
wallet_accounts_page, owned by the a11y gap-fix PR) get
testId: "<file stem>_top_bar", so the title/leading/trailing ids become
<sheet>_top_bar_title_key / _leading_key / _trailing_key instead of the shared
modal_top_bar_* fallback. Files with two top bars use the class name:
send_help_page_top_bar, picker_top_bar, picker_slider_page_top_bar.

* Surface send sheet ids on their accessibility nodes

- NewSendAddressInput: identifier from its *_key key on the field's existing
MergeSemantics>Semantics(label) node (send_page_address_input_key).
- NewSendAmountInput: the TextField is deliberately unlabeled (an authored
label made Android announce the amount twice), so it gets a label-less
TestId.merge with the key-derived id; a widget test confirms it stays its
own isTextField node (send_page_amount_input_key).
- ConfirmSwiper: key-derived id on both the swiper's single Semantics node and
the accessible-navigation NewPrimaryButton fallback
(send_page_confirm_swiper_key).
- Fee and coin-control rows in Advanced settings get
send_page_fee_row_key / send_page_coin_control_row_key.
send_page_send_button_key already resolves through NewFuturePrimaryButton.

* Surface swap sheet ids on their accessibility nodes

SwapAmountBox's amount TextField and currency-picker GestureDetector are keyed
with a ternary ValueKey (receive vs deposit), which neither the lint nor the
codemod sees, so they are wrapped in TestId.merge with the same existing key
names: swap_page_{deposit,receive}_amount_field_key and
swap_amount_box_{deposit,receive}_currency_button_key.
The provider preview row gets swap_page_provider_row_key and the unlabeled
direction toggle gets swap_page_reverse_button_key. The swap button already
resolves via LoadingPrimaryButton's exchange_page_exchange_button_key.

* Give receive sheet controls stable ids

- Bottom buttons: receive_page_{copy,set_amount,label,addresses}_button_key via
ModernButton.testId.
- QR (receive_page_qr_code_key), address-type row
(receive_page_address_type_button_key) and label chip
(receive_page_label_chip_key): identifier on their existing
MergeSemantics>Semantics nodes.
- Address text: TestId.merge with its existing receive_page_address_key so the
segmented address is one labelled node.
- Top-bar trailing button: receive_page_share_button_key in large-QR mode,
receive_page_rotate_button_key otherwise.
- Address-type picker rows: index-based
receive_address_type_{common,other}_<index>_key on the row Semantics via
TestId.fromKey(key).
receive_amount_modal.dart is left to the a11y gap-fix PR.

* Index the new-ui wallet picker rows

SwapAddressSelectionModal is the new UI's wallet switcher (swap from/to wallet
picker). Each wallet row gets swap_wallet_picker_wallet_<index>_key, surfaced
on the row's tap target through TestId.merge(TestId.fromKey(widget.key)).
The index is used rather than the wallet name so no user data reaches the
identifier.

* Test new-ui identifiers on settings, send and receive

newui_identifiers_test pumps SettingsMainPage with a mocked dashboard and
checks five settings_page_*_row_key rows plus the settings_page_top_bar ids,
the send amount field staying its own text-field node with its id, the
confirm swiper id, and the four receive bottom-button ids.

platformNodesWithId now reads the identifier from getSemanticsData(), which
is what the platform receives: a merged parent (e.g. CopyWrapper's
MergeSemantics around the copy ModernButton) carries its descendant's
identifier there while its own config field stays empty.

* Use double-quoted test_id imports per prefer_double_quotes

* Apply semantics_ids codemod to lib/src and cake_pay, placed by hand

Wraps keyed framework controls in TestId.merge so their existing test keys
surface as accessibility identifiers. Where a Semantics node already labels
the control, the identifier goes on that node instead of a new wrapper
(contact_list_page add button, header_row transaction filter). The
new_wallet_page generate-name button swaps its label-only Semantics for
TestId.merge with the same label, so label, button role, tap and id are one
node instead of a label node over an unlabelled button.

new_wallet_type_${item.name} keeps its id: item is a WalletType, so .name is
an enum name and not user data.

* Index picker item ids instead of interpolating item names

Picker is generic and built ids from item.toString() (or Currency.name),
which the interpolation lint cannot prove is free of user data. Ids now use
the item's position in the picker's unfiltered items list, so they stay
stable while the search filter is applied, and the button ids surface via
TestId.merge.

Robots resolve the index from the open Picker's items through a new
BaseRobot.pickerIndexWhere helper.

* Index seed verification option ids instead of the seed word

seed_verification_option_<word>_button_key would publish seed words as
release-build accessibility identifiers. Use the option's index, surfaced
with TestId.merge. The robot finds the correct word's index in the view
model's currentOptions.

* Index wallet list row and edit ids instead of the wallet name

Wallets tab ids no longer carry wallet names:
- wallet_list_single_wallet_<i>_key on a single wallet's tappable title
- wallet_list_group_<i>_key on a group header
- wallet_list_group_<i>_wallet_<j>_key on a wallet row inside a group
- wallet_list_single_wallet_<i>_edit_button_key and
wallet_list_group_<i>_wallet_<j>_edit_button_key on edit buttons

GroupedWalletExpansionTile derives the title and child-row ids from its
tileKey via TestId.fromKey, so tiles without a test key are unchanged.
EditWalletButtonWidget surfaces its key on the edit button with
TestId.merge.

WalletListPageRobot.openEditFor looks the wallet up in the page's
singleWalletsList, and WalletFlows expands groups by the new group key.

* Keep tx, trade, order and address data out of data-model test keys

Transaction, trade, order, payjoin and anonpay list items were keyed with
their ids. These ActionListItem keys are never read (renaming the field
breaks nothing), but they are test keys, so they now use the item's
position in the list being built.

The saved recipient-address row reuses the static
standard_list_item_transaction_details_recipient_address_key; it is only
added when the definition-driven row with that key was not shown.

WalletKeysViewModel's _walletName was the wallet type name, not the wallet
name. Interpolate _wallet.type.name directly so the lint can see it is an
enum name; ids are unchanged.

* Use enum names for internal test key prefixes

ExchangeCard's cardInstanceName and DEuroSavingsPage's tooltip key were
app-internal constants passed as Strings, which the interpolation lint
cannot distinguish from user data. Type them as enums and interpolate
.name. The deuro ids are unchanged. ExchangeCard has had no callers since
the old exchange page was removed, so its ids have no consumers. Its two
address buttons get identifiers on their existing labelled Semantics.

* Pass alert dialog keys to the dialog widget

AlertWithOneAction accepted a key and dropped it, and BaseAlertDialog put
its own (always null) key on the barrier GestureDetector. BaseAlertDialog
now forwards super.key, AlertWithOneAction passes its key through,
AlertWithTwoActions passes alertDialogKey, and the GestureDetector no
longer repeats it, so find.byKey on a dialog key matches exactly one
widget.

* Test legacy wallet list, seed verification and alert identifiers

* Publish transaction detail row identifiers from their model keys

Removing the keyValue fallback in #3690 left TransactionDetailsModal rows without identifiers. The rows now pass the view model's static key through testId; every key in that model is a constant and the interpolation lint keeps it that way.

* Namespace transaction row ids by history view

The home preview indexes itemsShort (no date headers) and the All modal indexes items, so the same home_page_transaction_<i>_key meant different transactions in each. Preview rows keep home_page_transaction_<i>_key; modal rows become history_modal_transaction_<i>_key, and the robot reads the modal prefix.

* Keep transaction history keys unique across incremental updates; edit grouped wallets in the robot

History keys came from a local counter reset to 0 on every update, so appended items reused keys held by existing rows. The keys are never read, but they should still be unique: all six sites now share one view-model counter. WalletListPageRobot.openEditFor also resolves wallets inside groups, expanding the group first when its edit button is not built.

* Suffix the Lightning preimage row key with _key

It was the only transaction-detail key without the suffix, so TestId.fromKey rejected it and the row published no identifier.

* Address review: codemod guards, container on amount fields, ids on five top bars

- The codemod wraps TextField/TextFormField in TestId.container, like the lint
quick fix, and no longer picks up interpolated keys: one hit at this head
would have copied a seed word into an identifier.
- The send and swap amount fields use TestId.container.
- Five ModalTopBars that arrived through base merges get their own testId.

* Address review: unique saved-recipient key, delete dead ExchangeCard, CI check for test keys

- The saved-recipient fallback row no longer shares its key with the
recipient-address row.
- ExchangeCard is built by no screen, so it is deleted instead of retyped.
- A workflow fails when a test key under lib/ interpolates anything other
than a list index or an enum name. Until now only an IDE lint kept seed
words, addresses and wallet names out of release identifiers.

* Test-key check: allow a list position from indexOf

chart_range_${ChartRange.ranges.indexOf(item)}_key on the next branch in the
stack interpolates an int index and tripped the check.

* Tidy spacing in picker merge resolution

* Wallet list id test: expect the coin name and current-wallet labels from dev

* Restart transaction history key indexes when the list is rebuilt

* Merge picker and wallet selector rows with their checkbox for screen readers

* Expose the contact currency picker as a button, not a text field

* Test-key check: stop allowing item.name

* Keep the checkbox a separate stop on rows with their own tap

---------

Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
access controldefensive validationsigning or wallet pathauthentication path
AI analysis · Low 39/100

This is a large accessibility and test-automation improvement for the Cake Wallet Flutter app. It adds stable identifiers to buttons, text fields, lists, and dialogs so screen readers and automated UI tests can find them. The patch also removes user data such as wallet names, transaction IDs, and seed words from those identifiers, which reduces the risk of leaking sensitive information through the operating system's accessibility tree. There is no traditional security vulnerability being fixed, but the change hardens privacy in the accessibility layer and improves automated testing coverage.

Security candidateQA: report-only e2e lanes (android / iOS / cache nightly) (#3700)by Seth For Privacy · 12f17920 · Nov 20, 2026 · 4 filesMessage 100 · StrongLow 27Details
Commit message · Seth For Privacy

QA: report-only e2e lanes (android / iOS / cache nightly) (#3700)

* QA lanes: e2e_android (report-only, artifact reuse), e2e_ios (self-hosted), e2e_cache nightly (QA handoff §6 4-a/4-b/4-c)

* e2e_android: wait for the pr_test_build artifact instead of racing it

* e2e_android: 90min artifact wait (pr_test_build includes integration tests), 240min job cap

* e2e_android: qa_ref input (test an arbitrary cake-qa branch; 4-e broken-label leg)

* e2e_android + nightly: disable animations in-script with a settle/retry (action's step broke with 'Broken pipe' after a 764s boot)

* e2e lanes: emulator-boot-timeout 1200s + 4 cores (600s default flaked after a 764s boot)

* e2e lanes: POSIX-sh script (action runs dash: no pipefail, no arrays)

* e2e lanes: single-line scripts (parseScript runs each line as its own dash -c)

* e2e lanes: self-contained script lines (per-line sh -c: cd does not persist; proxy path root-relative, npx gets 'cd cake-qa &&')

* e2e lanes: derive CW_PACKAGE from the installed APK (PR builds use com.cakewallet.test_<branch>, config default is the RC id — caused ENGINE_FAILURE on app.clearState)

* e2e lanes: adb daemon reset before the suite (hosted adb wedged mid-run: 'Unable to connect to adb daemon' -> 39 cascading failures)

* e2e lanes: wait for adb reconnect after daemon reset (fresh server exited the package query in 6ms -> device offline)

* e2e_android: split artifact-wait into its own job (the shared 4h cap canceled the suite twice before it started)

* e2e_android: 190min artifact wait (builds run 60-190min), suite gated on resolve run_id, resolve job timeout 215

* e2e_android: run ONLY the no-funds slice (bare 'npx e2e run' ran the whole project — map verification + the expected-fail known-defects — and the job was canceled mid-suite)

* e2e lanes: KVM udev rule (action fell back to -accel off) + 3072M AVD memory like the funds lane

* nightly: KVM udev rule + 3072M memory (same as the android lane)

* e2e_android resolve: auto-retry the build's failed jobs once on a flaky packageRelease failure (3rd occurrence; stops the push-per-fix churn)

* e2e_android: actions:write so the build auto-retry actually runs (403 was swallowed)

* e2e_android: suite input (default = no-funds slice; the 4-e broken-label run selects its fixture)

* e2e_android: retry only the packageRelease flake; fail fast on manual runs with no build

The resolve step re-ran every failed pr_test_build when no artifact appeared, so a PR that does not compile had its failed build jobs re-run on every push before the lane gave up. It now reads the failed jobs' logs and retries only when they contain the gradle packageRelease IncrementalSplitterRunnable failure; anything else fails the lane at once.

A workflow_dispatch without build_run on a SHA that has no pr_test_build run never matched the early exit and polled for the full 190-minute deadline. It now fails immediately with a hint to pass build_run. The comment that still said the wait gives up after an hour is corrected.

* e2e_ios: one fresh qa-e2e simulator per run, deleted afterwards, and the suite targets it

Every run created another qa-e2e device (simctl allows duplicate names) and booted it, and nothing shut it down, so booted simulators piled up on the persistent runner. The step now deletes any existing qa-e2e devices, creates one, and an always() step shuts down and deletes it. The get_app_container fallback, which could never return a UDID, is gone.

The device type came from sorting all device types by name, which picks iPhone Xr on current Xcode and fails against the iOS 27 runtime; it now comes from the chosen runtime's supported iPhone types. The suite step also sets CW_IOS_DEVICE=qa-e2e: cake-qa's sim target otherwise defaults to the simulator named iPhone 18 Pro, not the device the build was installed on.

* e2e_android: grep input, redact seed-like word runs before upload, 4GB emulator

* e2e lanes: use the llm.cakewallet.com router

dspark.privacy.family is deprecated. The router address is not a secret, so
it is set in the workflow; the key is read from LLM_API_KEY, falling back to
the existing DSPARK_API_KEY (the same key works on the new router).

* e2e lanes: find the x86_64 APK under the build's per-branch artifact name

The build now uploads <branch>_x86.apk instead of one 'android apk' artifact.
The lanes accept either and normalise the file name for the install step.

* e2e iOS lane: call flutter by path in the install step

GITHUB_PATH only applies to later steps, so 'flutter --version' in the same
step failed with 'command not found' on every run.

* e2e iOS lane: do not GPG-sign the dependency patch commits

The runner account signs commits by default and gpg is not on the runner's
PATH, so 'git am' in apply_patches.sh failed.

* e2e iOS lane: put Homebrew and ~/go/bin on the runner's PATH

The runner service starts with a bare PATH, so go, cmake, pod and gomobile
were not found by the simulator build.

* e2e iOS lane: keep the pinned Flutter ahead of Homebrew on PATH

Homebrew's standalone dart shadowed Flutter's, so 'dart run ffigen' in
cw_decred failed with 'requires the Flutter SDK'.

* e2e iOS lane: qa_ref, suite and grep inputs for manual runs

Same inputs as the Android lane, so a cake-qa branch or a single charter can
be run on the simulator without merging first.

* e2e lanes: run the test runner with node, default the iOS lane to the no-funds slice

- npx (npm exec) rewrites its process title; on macOS the overflow exposes the
job's environment, including the wallet seed secrets, in the process list.
The lanes now call node node_modules/.bin/e2e directly.
- The iOS lane passed no suite, so it ran every test file (293 tests, 143 min)
instead of the 17-test no-funds slice its step is named after.

* e2e iOS lane: tell the suite where the simulator build is

The suite reinstalls the app between tests on iOS, where wiping app data
leaves preferences and the Keychain behind.

* e2e lanes: keep the cake-qa key off disk, publish only redacted junit and summary, build dev for the nightly

* e2e iOS lane: dispatch-only until it runs in an ephemeral VM

* e2e lanes: retry the flake-log read, wait for the simulator, stop the proxy, let the nightly survive a red build test

* e2e iOS lane: build without secrets and test in separate throwaway VMs

* e2e iOS lane: install protoc for the build, run the suite only when an app was built

* e2e iOS lane: download the simulator runtime unless an available one exists

* e2e Android lane: a cancelled run no longer overwrites the PR comment

* e2e Android lane: a failed run listing while waiting for the APK is retried

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetydefensive validation
AI analysis · Low 27/100

This commit adds three new automated testing pipelines for the Cake Wallet mobile app: one for Android, one for iOS, and a weekly overnight test. These are explicitly marked as 'reply-only' experiments, meaning a failure will not block releases. The pipelines run real app builds in cloud test environments, send test commands to the app, and use sensitive test wallet seed phrases and API keys. The commit also includes several safety measures: it keeps secrets out of logs, uses encrypted storage for detailed test recordings, and avoids a subtle iOS issue where a common test runner could accidentally expose secrets in the process list. Because this is new infrastructure handling real secrets and running real app code, it deserves a security review, but it is not a known vulnerability in the app itself.

Security candidateAdd TestId helper, identifier plumbing for shared widgets, and test-key lints (#3690)by Seth For Privacy · e5505f89 · Nov 20, 2026 · 164 filesMessage 100 · StrongLow 30Details
Commit message · Seth For Privacy

Add TestId helper, identifier plumbing for shared widgets, and test-key lints (#3690)

* Add TestId helper for accessibility identifiers

Semantics(identifier:) is what XCUITest (accessibilityIdentifier) and
UIAutomator (resource-id) drivers match on; Flutter keys are invisible to
them. TestId.merge folds a leaf control into one node carrying the id,
TestId.container gives a group its own node; both return the child
unchanged for a null id.

TestId.fromKey only accepts ValueKey<String> values matching
^[a-z0-9_]+_key$. Identifiers ship in release builds and identity keys
(AnimatedSwitcher, contact names, balances) can hold user data, so keys
are never published wholesale. The pattern still accepts an interpolated
lowercase seed word, so the no_string_interpolation_in_test_key lint is
the actual guard.

On iOS a node with no label/value/action is not an accessibility
element, so ids belong on the control node (merge), not on bare
containers.

* Plumb testId into shared widgets

Each shared widget takes an optional testId and otherwise falls back to
TestId.fromKey(key), so the ~125 existing *_key keys on Cake widgets
surface as identifiers without touching call sites. Existing keys stay
where they are for find.byKey robots.

Placement:
- Widgets that already build a Semantics/MergeSemantics node get
identifier: on that node (ModernButton, CoinActionButton,
LoadingPrimaryButton, FloatingIconButton, SeedCheckboxRow,
CurrencyPickerRow, AlertCloseButton, StandardSwitch, LineTabSwitcher,
main nav bar).
- Widgets built on framework buttons are wrapped in TestId.merge only
when an id resolves (NewPrimaryButton, PrimaryButton,
PrimaryImageButton, OptionTile, StandardListRow/SettingsCellWithArrow,
SettingsSwitcherCell, StackedButtons link button), so label, role,
toggled state and id share one node.
- BaseAlertDialog action buttons get a button role and ids from their
keys, defaulting to alert_dialog_left/right_button_key, or
alert_dialog_action_button_key for single-action alerts.
- ModalTopBar: title gets its own container header node
<base>_title_key, chrome buttons <base>_leading_key /
<base>_trailing_key, base defaulting to modal_top_bar. The hashCode
keys stay because the trailing AnimatedSwitcher relies on them.
- ListItem.testId is applied by NewListSections; rows with a trailing or
bottom widget use a container so their own buttons stay separately
focusable, all other rows merge.
- BaseTextFormField uses a container, not MergeSemantics: merging folded
suffix buttons (paste, scan) into the text-field node. Only applied
when the field has a hint/label.
- SettingsChoicesCell and LineTabSwitcher use index-based ids so
localized option text never becomes an identifier.

* Add test-key semantics lints

require_test_key_semantics_identifier warns when a ValueKey/Key "*_key"
literal is the key of a framework interactive widget (GestureDetector,
InkWell, Text/Icon/Elevated/Outlined/FilledButton, TextField,
TextFormField, Switch, Checkbox, Radio, ListTile, CupertinoButton) and no
TestId.merge/TestId.container or Semantics(identifier:) encloses it in
the same method. Such keys work for find.byKey but are invisible to
XCUITest/UIAutomator. Cake widgets are not flagged because they now
derive an identifier from their key. A quick fix wraps the widget in
TestId.merge with the same id and adds the import; it is single-location
(IDE) only, dart fix does not apply it.

no_string_interpolation_in_test_key warns when a String or dynamic value
is interpolated into a "*_key" ValueKey/Key. Test keys become release
build accessibility identifiers, and the plan's inventory found seed
words, recipient addresses, wallet names and tx/order ids interpolated
into keys. ints, enums and enum .name are allowed. integration_test/ is
skipped: robots only look keys up, they never ship them.

Tests drive analyzer_testing's AnalysisRuleTest from plain package:test
cases against the mock flutter package. They avoid test_reflective_loader
because its test_ method names would need a nested analysis_options.yaml,
and a nested options file that includes the root one stops the plugin
from reporting on multi-file runs.

* Apply text-field identifier regardless of hint

* Key list text fields by keyValue so the identifier fallback applies

* Never derive list row identifiers from keyValue

NewListSections builds each row's key from ListItem.keyValue, which is an arbitrary runtime string (routes, provider titles, wallet names, node URIs). A user-chosen wallet name such as savings_key passed the fallback regex and shipped as a release accessibility identifier via WalletRemovalPopup. List rows now publish only an explicit ListItem.testId; the five security page rows that relied on the fallback get explicit ids.

* Use TestId.container in the test-key quick fix for text fields

MergeSemantics would fold a field's suffix controls (paste, scan) into the
field node, so they stop being separately focusable. Text fields get
TestId.container instead, as BaseTextFormField already does.

* Drop the unused key on list text-field rows

It was added so a keyValue identifier fallback would apply; that fallback was
removed and the widget never reads its key.

* Add semantics identifiers to new-UI release-checklist screens and a semantics_ids codemod (#3694)

* Add semantics_ids codemod for test keys on framework widgets

dart run tool/semantics_ids/main.dart [--apply] [paths...] lists ValueKey/Key
'*_key' literals passed as key: to framework interactive widgets with no
enclosing TestId or Semantics(identifier:), mirroring the
require_test_key_semantics_identifier lint (same widget list and ancestor
walk). --apply wraps each hit in TestId.merge(<same id>, child: ...) and adds
the test_id.dart import.

It parses without resolution so it runs in seconds, matching both
InstanceCreationExpression and unresolved MethodInvocation call forms. It
imports package:analyzer, already a transitive dependency of the root package
via build_runner/mobx_codegen, so no pubspec change is needed (tool/ already
imports other transitive packages such as args/convert). Verified against the
lint: identical 21 hits across lib/.

* Apply semantics_ids codemod to new-ui, placed by hand

The codemod found two hits in lib/new-ui; both sit under an existing
Semantics node, so per the placement rules the identifier goes on that node
instead of a new TestId.merge wrapper:
- assets_top_bar: identifier on the existing MergeSemantics>Semantics(button).
- history_top_bar: the key is inside ExcludeSemantics, so the identifier goes
on the outer Semantics(button, label).
Also moves home_page_wallet_name_text_key onto WalletInfoBar's outer
Semantics(label) for the same ExcludeSemantics reason (Text is not a lint
target, so the codemod does not report it).

* Index home history row ids instead of interpolating the tx id

home_page_transaction_<tx id>_key would publish transaction ids as release
accessibility identifiers (no_string_interpolation_in_test_key). Use the list
index, and surface it as the identifier on the row's existing merged
Semantics via TestId.fromKey(child.key).

HomePageRobot.firstTransactionIdInAllView now maps the index back to the
transaction through dashboardViewModel.items, so transaction_details_test
keeps comparing tx ids.

* Give new-ui settings rows and top bar stable ids

Each SettingsListItem carries a static testId,
settings_page_<route constant in snake_case, minus a trailing Page>_row_key
(e.g. settings_page_privacy_row_key), passed to ListItemRegularRow.testId so
the PR1 wrapper puts it on the row's merged node. keyValue stays the route so
NewSettingsPageRobot and find.byKey keep working. The top bar gets the
settings_page_top_bar base name.

* Give every new-ui ModalTopBar a per-sheet testId base name

All ModalTopBar instances in lib/new-ui (except receive_amount_modal and
wallet_accounts_page, owned by the a11y gap-fix PR) get
testId: "<file stem>_top_bar", so the title/leading/trailing ids become
<sheet>_top_bar_title_key / _leading_key / _trailing_key instead of the shared
modal_top_bar_* fallback. Files with two top bars use the class name:
send_help_page_top_bar, picker_top_bar, picker_slider_page_top_bar.

* Surface send sheet ids on their accessibility nodes

- NewSendAddressInput: identifier from its *_key key on the field's existing
MergeSemantics>Semantics(label) node (send_page_address_input_key).
- NewSendAmountInput: the TextField is deliberately unlabeled (an authored
label made Android announce the amount twice), so it gets a label-less
TestId.merge with the key-derived id; a widget test confirms it stays its
own isTextField node (send_page_amount_input_key).
- ConfirmSwiper: key-derived id on both the swiper's single Semantics node and
the accessible-navigation NewPrimaryButton fallback
(send_page_confirm_swiper_key).
- Fee and coin-control rows in Advanced settings get
send_page_fee_row_key / send_page_coin_control_row_key.
send_page_send_button_key already resolves through NewFuturePrimaryButton.

* Surface swap sheet ids on their accessibility nodes

SwapAmountBox's amount TextField and currency-picker GestureDetector are keyed
with a ternary ValueKey (receive vs deposit), which neither the lint nor the
codemod sees, so they are wrapped in TestId.merge with the same existing key
names: swap_page_{deposit,receive}_amount_field_key and
swap_amount_box_{deposit,receive}_currency_button_key.
The provider preview row gets swap_page_provider_row_key and the unlabeled
direction toggle gets swap_page_reverse_button_key. The swap button already
resolves via LoadingPrimaryButton's exchange_page_exchange_button_key.

* Give receive sheet controls stable ids

- Bottom buttons: receive_page_{copy,set_amount,label,addresses}_button_key via
ModernButton.testId.
- QR (receive_page_qr_code_key), address-type row
(receive_page_address_type_button_key) and label chip
(receive_page_label_chip_key): identifier on their existing
MergeSemantics>Semantics nodes.
- Address text: TestId.merge with its existing receive_page_address_key so the
segmented address is one labelled node.
- Top-bar trailing button: receive_page_share_button_key in large-QR mode,
receive_page_rotate_button_key otherwise.
- Address-type picker rows: index-based
receive_address_type_{common,other}_<index>_key on the row Semantics via
TestId.fromKey(key).
receive_amount_modal.dart is left to the a11y gap-fix PR.

* Index the new-ui wallet picker rows

SwapAddressSelectionModal is the new UI's wallet switcher (swap from/to wallet
picker). Each wallet row gets swap_wallet_picker_wallet_<index>_key, surfaced
on the row's tap target through TestId.merge(TestId.fromKey(widget.key)).
The index is used rather than the wallet name so no user data reaches the
identifier.

* Test new-ui identifiers on settings, send and receive

newui_identifiers_test pumps SettingsMainPage with a mocked dashboard and
checks five settings_page_*_row_key rows plus the settings_page_top_bar ids,
the send amount field staying its own text-field node with its id, the
confirm swiper id, and the four receive bottom-button ids.

platformNodesWithId now reads the identifier from getSemanticsData(), which
is what the platform receives: a merged parent (e.g. CopyWrapper's
MergeSemantics around the copy ModernButton) carries its descendant's
identifier there while its own config field stays empty.

* Use double-quoted test_id imports per prefer_double_quotes

* Namespace transaction row ids by history view

The home preview indexes itemsShort (no date headers) and the All modal indexes items, so the same home_page_transaction_<i>_key meant different transactions in each. Preview rows keep home_page_transaction_<i>_key; modal rows become history_modal_transaction_<i>_key, and the robot reads the modal prefix.

* Address review: codemod guards, container on amount fields, ids on five top bars

- The codemod wraps TextField/TextFormField in TestId.container, like the lint
quick fix, and no longer picks up interpolated keys: one hit at this head
would have copied a seed word into an identifier.
- The send and swap amount fields use TestId.container.
- Five ModalTopBars that arrived through base merges get their own testId.

* Put list text-field test ids on the field, not the merged row

* Surface legacy screen test keys as accessibility identifiers and drop user data from ids (#3695)

* Add semantics_ids codemod for test keys on framework widgets

dart run tool/semantics_ids/main.dart [--apply] [paths...] lists ValueKey/Key
'*_key' literals passed as key: to framework interactive widgets with no
enclosing TestId or Semantics(identifier:), mirroring the
require_test_key_semantics_identifier lint (same widget list and ancestor
walk). --apply wraps each hit in TestId.merge(<same id>, child: ...) and adds
the test_id.dart import.

It parses without resolution so it runs in seconds, matching both
InstanceCreationExpression and unresolved MethodInvocation call forms. It
imports package:analyzer, already a transitive dependency of the root package
via build_runner/mobx_codegen, so no pubspec change is needed (tool/ already
imports other transitive packages such as args/convert). Verified against the
lint: identical 21 hits across lib/.

* Apply semantics_ids codemod to new-ui, placed by hand

The codemod found two hits in lib/new-ui; both sit under an existing
Semantics node, so per the placement rules the identifier goes on that node
instead of a new TestId.merge wrapper:
- assets_top_bar: identifier on the existing MergeSemantics>Semantics(button).
- history_top_bar: the key is inside ExcludeSemantics, so the identifier goes
on the outer Semantics(button, label).
Also moves home_page_wallet_name_text_key onto WalletInfoBar's outer
Semantics(label) for the same ExcludeSemantics reason (Text is not a lint
target, so the codemod does not report it).

* Index home history row ids instead of interpolating the tx id

home_page_transaction_<tx id>_key would publish transaction ids as release
accessibility identifiers (no_string_interpolation_in_test_key). Use the list
index, and surface it as the identifier on the row's existing merged
Semantics via TestId.fromKey(child.key).

HomePageRobot.firstTransactionIdInAllView now maps the index back to the
transaction through dashboardViewModel.items, so transaction_details_test
keeps comparing tx ids.

* Give new-ui settings rows and top bar stable ids

Each SettingsListItem carries a static testId,
settings_page_<route constant in snake_case, minus a trailing Page>_row_key
(e.g. settings_page_privacy_row_key), passed to ListItemRegularRow.testId so
the PR1 wrapper puts it on the row's merged node. keyValue stays the route so
NewSettingsPageRobot and find.byKey keep working. The top bar gets the
settings_page_top_bar base name.

* Give every new-ui ModalTopBar a per-sheet testId base name

All ModalTopBar instances in lib/new-ui (except receive_amount_modal and
wallet_accounts_page, owned by the a11y gap-fix PR) get
testId: "<file stem>_top_bar", so the title/leading/trailing ids become
<sheet>_top_bar_title_key / _leading_key / _trailing_key instead of the shared
modal_top_bar_* fallback. Files with two top bars use the class name:
send_help_page_top_bar, picker_top_bar, picker_slider_page_top_bar.

* Surface send sheet ids on their accessibility nodes

- NewSendAddressInput: identifier from its *_key key on the field's existing
MergeSemantics>Semantics(label) node (send_page_address_input_key).
- NewSendAmountInput: the TextField is deliberately unlabeled (an authored
label made Android announce the amount twice), so it gets a label-less
TestId.merge with the key-derived id; a widget test confirms it stays its
own isTextField node (send_page_amount_input_key).
- ConfirmSwiper: key-derived id on both the swiper's single Semantics node and
the accessible-navigation NewPrimaryButton fallback
(send_page_confirm_swiper_key).
- Fee and coin-control rows in Advanced settings get
send_page_fee_row_key / send_page_coin_control_row_key.
send_page_send_button_key already resolves through NewFuturePrimaryButton.

* Surface swap sheet ids on their accessibility nodes

SwapAmountBox's amount TextField and currency-picker GestureDetector are keyed
with a ternary ValueKey (receive vs deposit), which neither the lint nor the
codemod sees, so they are wrapped in TestId.merge with the same existing key
names: swap_page_{deposit,receive}_amount_field_key and
swap_amount_box_{deposit,receive}_currency_button_key.
The provider preview row gets swap_page_provider_row_key and the unlabeled
direction toggle gets swap_page_reverse_button_key. The swap button already
resolves via LoadingPrimaryButton's exchange_page_exchange_button_key.

* Give receive sheet controls stable ids

- Bottom buttons: receive_page_{copy,set_amount,label,addresses}_button_key via
ModernButton.testId.
- QR (receive_page_qr_code_key), address-type row
(receive_page_address_type_button_key) and label chip
(receive_page_label_chip_key): identifier on their existing
MergeSemantics>Semantics nodes.
- Address text: TestId.merge with its existing receive_page_address_key so the
segmented address is one labelled node.
- Top-bar trailing button: receive_page_share_button_key in large-QR mode,
receive_page_rotate_button_key otherwise.
- Address-type picker rows: index-based
receive_address_type_{common,other}_<index>_key on the row Semantics via
TestId.fromKey(key).
receive_amount_modal.dart is left to the a11y gap-fix PR.

* Index the new-ui wallet picker rows

SwapAddressSelectionModal is the new UI's wallet switcher (swap from/to wallet
picker). Each wallet row gets swap_wallet_picker_wallet_<index>_key, surfaced
on the row's tap target through TestId.merge(TestId.fromKey(widget.key)).
The index is used rather than the wallet name so no user data reaches the
identifier.

* Test new-ui identifiers on settings, send and receive

newui_identifiers_test pumps SettingsMainPage with a mocked dashboard and
checks five settings_page_*_row_key rows plus the settings_page_top_bar ids,
the send amount field staying its own text-field node with its id, the
confirm swiper id, and the four receive bottom-button ids.

platformNodesWithId now reads the identifier from getSemanticsData(), which
is what the platform receives: a merged parent (e.g. CopyWrapper's
MergeSemantics around the copy ModernButton) carries its descendant's
identifier there while its own config field stays empty.

* Use double-quoted test_id imports per prefer_double_quotes

* Apply semantics_ids codemod to lib/src and cake_pay, placed by hand

Wraps keyed framework controls in TestId.merge so their existing test keys
surface as accessibility identifiers. Where a Semantics node already labels
the control, the identifier goes on that node instead of a new wrapper
(contact_list_page add button, header_row transaction filter). The
new_wallet_page generate-name button swaps its label-only Semantics for
TestId.merge with the same label, so label, button role, tap and id are one
node instead of a label node over an unlabelled button.

new_wallet_type_${item.name} keeps its id: item is a WalletType, so .name is
an enum name and not user data.

* Index picker item ids instead of interpolating item names

Picker is generic and built ids from item.toString() (or Currency.name),
which the interpolation lint cannot prove is free of user data. Ids now use
the item's position in the picker's unfiltered items list, so they stay
stable while the search filter is applied, and the button ids surface via
TestId.merge.

Robots resolve the index from the open Picker's items through a new
BaseRobot.pickerIndexWhere helper.

* Index seed verification option ids instead of the seed word

seed_verification_option_<word>_button_key would publish seed words as
release-build accessibility identifiers. Use the option's index, surfaced
with TestId.merge. The robot finds the correct word's index in the view
model's currentOptions.

* Index wallet list row and edit ids instead of the wallet name

Wallets tab ids no longer carry wallet names:
- wallet_list_single_wallet_<i>_key on a single wallet's tappable title
- wallet_list_group_<i>_key on a group header
- wallet_list_group_<i>_wallet_<j>_key on a wallet row inside a group
- wallet_list_single_wallet_<i>_edit_button_key and
wallet_list_group_<i>_wallet_<j>_edit_button_key on edit buttons

GroupedWalletExpansionTile derives the title and child-row ids from its
tileKey via TestId.fromKey, so tiles without a test key are unchanged.
EditWalletButtonWidget surfaces its key on the edit button with
TestId.merge.

WalletListPageRobot.openEditFor looks the wallet up in the page's
singleWalletsList, and WalletFlows expands groups by the new group key.

* Keep tx, trade, order and address data out of data-model test keys

Transaction, trade, order, payjoin and anonpay list items were keyed with
their ids. These ActionListItem keys are never read (renaming the field
breaks nothing), but they are test keys, so they now use the item's
position in the list being built.

The saved recipient-address row reuses the static
standard_list_item_transaction_details_recipient_address_key; it is only
added when the definition-driven row with that key was not shown.

WalletKeysViewModel's _walletName was the wallet type name, not the wallet
name. Interpolate _wallet.type.name directly so the lint can see it is an
enum name; ids are unchanged.

* Use enum names for internal test key prefixes

ExchangeCard's cardInstanceName and DEuroSavingsPage's tooltip key were
app-internal constants passed as Strings, which the interpolation lint
cannot distinguish from user data. Type them as enums and interpolate
.name. The deuro ids are unchanged. ExchangeCard has had no callers since
the old exchange page was removed, so its ids have no consumers. Its two
address buttons get identifiers on their existing labelled Semantics.

* Pass alert dialog keys to the dialog widget

AlertWithOneAction accepted a key and dropped it, and BaseAlertDialog put
its own (always null) key on the barrier GestureDetector. BaseAlertDialog
now forwards super.key, AlertWithOneAction passes its key through,
AlertWithTwoActions passes alertDialogKey, and the GestureDetector no
longer repeats it, so find.byKey on a dialog key matches exactly one
widget.

* Test legacy wallet list, seed verification and alert identifiers

* Publish transaction detail row identifiers from their model keys

Removing the keyValue fallback in #3690 left TransactionDetailsModal rows without identifiers. The rows now pass the view model's static key through testId; every key in that model is a constant and the interpolation lint keeps it that way.

* Namespace transaction row ids by history view

The home preview indexes itemsShort (no date headers) and the All modal indexes items, so the same home_page_transaction_<i>_key meant different transactions in each. Preview rows keep home_page_transaction_<i>_key; modal rows become history_modal_transaction_<i>_key, and the robot reads the modal prefix.

* Keep transaction history keys unique across incremental updates; edit grouped wallets in the robot

History keys came from a local counter reset to 0 on every update, so appended items reused keys held by existing rows. The keys are never read, but they should still be unique: all six sites now share one view-model counter. WalletListPageRobot.openEditFor also resolves wallets inside groups, expanding the group first when its edit button is not built.

* Suffix the Lightning preimage row key with _key

It was the only transaction-detail key without the suffix, so TestId.fromKey rejected it and the row published no identifier.

* Address review: codemod guards, container on amount fields, ids on five top bars

- The codemod wraps TextField/TextFormField in TestId.container, like the lint
quick fix, and no longer picks up interpolated keys: one hit at this head
would have copied a seed word into an identifier.
- The send and swap amount fields use TestId.container.
- Five ModalTopBars that arrived through base merges get their own testId.

* Address review: unique saved-recipient key, delete dead ExchangeCard, CI check for test keys

- The saved-recipient fallback row no longer shares its key with the
recipient-address row.
- ExchangeCard is built by no screen, so it is deleted instead of retyped.
- A workflow fails when a test key under lib/ interpolates anything other
than a list index or an enum name. Until now only an IDE lint kept seed
words, addresses and wallet names out of release identifiers.

* Test-key check: allow a list position from indexOf

chart_range_${ChartRange.ranges.indexOf(item)}_key on the next branch in the
stack interpolates an int index and tripped the check.

* Tidy spacing in picker merge resolution

* Wallet list id test: expect the coin name and current-wallet labels from dev

* Restart transaction history key indexes when the list is rebuilt

* Expose the contact currency picker as a button, not a text field

* Test-key check: stop allowing item.name

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
defensive validationseed or entropy pathsigning or wallet path
AI analysis · Low 30/100

This is a large cleanup of how the app labels its on-screen buttons and fields for automated testing and accessibility tools. Previously, many test labels were accidentally built from private user data such as wallet names, transaction IDs, seed words, and crypto addresses. Those labels can be read by iOS/Android accessibility services and by UI-automation testing tools, so a malicious or overly curious app on the same device could have harvested them. The patch replaces those dynamic labels with fixed or index-based identifiers, adds lint rules and a CI check to stop developers from reintroducing user data into labels, and deletes an unused widget. It is a privacy improvement, not a remote hack, but it meaningfully reduces the amount of sensitive information exposed through the accessibility tree in release builds.

Security candidateRefactor swap logic and state management (#3472)by malik1004x · d62183e3 · Nov 19, 2026 · 257 filesMessage 100 · StrongLow 48Details
Commit message · malik1004x

Refactor swap logic and state management (#3472)

* add unit tests for provider code

* fix provider issues uncovered by unit test

* readd providerName

* fix migration from hive

* delete unused widget

* remove ExchangeViewModel and ExchangeTradeViewModel. good riddance!

* remove dead providers from trade monitor

* adjust old ui that we still temporarily use

* add states for sending

* adjust confirm sheet and external modal

* adjust filter store

* remove dead import

* remove unreachable widget

* add SwapConfirmBottomWidget (bloc-based rather than mobx-based)

* add handler (wip)

* string

* WHY the FUCK was this EVER done here? TODO fix solana balances in a bit

* move swapsxyz registration to swapsxyz provider

* make everything final

* back by popular demand (2 calls), mergeFindTradeByIdResult. also, copyWith

* adjust mergeFindTradeByIdResult calls to new format

* remove old quick-fixes that will now be handled properly

* add safeParse to Money

* add di defs for the new classes

* fix currency fetching when balances are not loaded

* add(_Init()); (i forgor)

* add transformers to bloc

* properly fetch rates after actions

* add cubit to context because of course i forgot

* refactor rates cubit to load the rates async (sync took two business days)

* set source correctly in source selector modal

* do not display spinny loady thingie when it's not loading

* apparently we sent the wrong request to swaptrade and nobody noticed for years. that's why it worked like shit!

* minor integration fixes

* add nice toString to provider rate

* ugly ahh workaround because flutter is shit

* properly load rates on toggling providers

* don't show disabled providers in selector

* remove observers

* slight fixes to improve performance

* move SwapBloc to its own folder

* minor perf fixes

* add currency provider and allow switching currencies

* reset swap source if wallet doesn't support it

* readd refund address button

* fix setting fiat amount controller

* add button disable condition

* pop that sheet

* proper failure state

* stealthex extra id oopsie

* ()

* new db table

* add wallet switch

* add uri for external send

* transaction creation, i guess?

* adjust old ui to new state

* are glasses a valid company expense atp?

* actually display the error if tx creation throws

* up pubspec

* memo support

* add bloc_presentation

* add address validation and aliaspay support

* prevent going to unreachable widget in input state

* no ugly ahh blank field for trade id

* Transakcja Wysłana!

* proper provider during rate fetch

* show "no rates found" if no rates found

* save to TradesStore

* store provider settings

* don't store 1 = 0 rates

* small save/load fix

* fix trade tile

* fallback to different providers on fail

* change payoutAddress in TradeRequest to String

* fix exolix error message

* ln receive support

* remove unused methods

* fix zero bug

* stop cards from disappearing when state is gone

* reformat

* logs

* migration

* fix old trades not showing in history

* rate timer

* fix secrets parse

* remove print

* parse -> safeParse

* dispose properly

* state emit fix since this was made before i did more than 2 states

* account check that makes sense

* only allow proceeding if we have rates

* disable dragging down the confirm sheet (like on send)

* better input validation

* fix no_http_imports ci

* fix select all on centralized

* chainflip throw on status code

* actually pass the trocador provider name

* pass changenow amounts

* check script

* letsexchange String -> double

* changenow nullable fields + status code check

* trocador print body

* swaptrade rate is null check

* expand provider check to all providers

* [slop] new exchange provider check script

* fix many minor provider bugs

* fix near intents bug? i think? it doesn't fail anymore so...

* [slop] update test script

* trocador integration that actually works

* minor parse fixes

* fix text

* cleanup _onSwapInitiated because it was absurdly long

* add a way to disable forced provider if they don't have a rate

* spacing

* refactor TradeRequest to only hold Money instead of SwapAmount since only cryptoAmount was ever actually used

* swap all is back!

* persist swap all on changing currency (or drop it)

* add "ALL" text

* ci

* remove pubspec.lock because i think it fucked up ci?

* [revert this] pin bitcoin_base to commit hash

* restore low fee alert

* fix extremely embarassing swapsxyz bug

* findTradeById -> updateTrade

* move SwapAmountBox into separate file

* adjust to Money.toDouble no longer existing

* fix imports in swap

* adjust anypay to refactor

* remove double di registration

* minor fixes for the new widgets

* fixed rate fix

* adjust to money object improvements

* remove version

* remove dead import

* fix changenow payout addr

* fix csv export

* disable exolix

* fix letsexchange creation time

* fix confirm sheet overflow

* reset sources on direction reversal

* fix fiat amount decimals

* fix error color

* disable stealthex

* fix swaptrade

* restore guards for swap all and decentralized providers

* bugfixes

* add extra id to external modal

* block providers that don't support external send

* disable swap all for external send

* properly switch wallet

* fail on db save fail

* don't fail fetching all trades if one deserialize fails

* fix serialization

* make id the primary key instead of autoincrement

* readd providerName to db

* fix swapsxyz updates

* bugfixes

* hide address after swap

* add external refund addresses for internal swaps

* timeout for providers

* fix low fee alert if bloc is closed too fast

* fix

* fixes

* remove some unused stuff

* remove some unused stuff

* fix race

* fixes

* pass empty amount

* fix altvm

* fix swaptrade rate

* make jupiter executeswap use schemas properly

* fixes

* remove title param

* fixes

* fixes

* fixes

* get rid of the stupid if/elses

* move converter

* nicer provider apis

* fix jupiter, sigh

* fix swapsxyz, double sigh

* more fixes

* fix trocador providers

* fix

* fix

* fix exchange rate

* yup

* do fetchRate in a way that actually fucking makes sense

* get zec addrs

* for best results git add the fucking file

* more tests, i guess

* make :czarek: happy

* DAMNIT

* fixes

* finally fix trocador

* finally fix trocador... again

* fixes

* fix swapsxyz update

* fix pay anything

* fix tests

* format

* ughhhhhh fix the chain id

* remove dead code (this was dead since its addition and nobody noticed, lol)

* swaptrade fix. damnit

* add hardware wallet confirmation popup

* add hardware wallet confirmation popup... again

* sigh

* ci

* prevent trocador ratelimits

* fixes

* fixes and stuff

* yup

* cache

* tests ig

* make FiatAmountBar nicer :)

* sighhhh unspentcointype or sth i am so triggered by this little enum

* bitcoin accounts, kinda

* handle ln invoices and addresses in generic way

* rename

* rename

* nanogpt

* fixed rate? more like broken rate amirite

* fail on trade.save() error

* update overrides

* this really should be the default...

* swapsxyz decimals fix

* more decimals to make amounts parsing less likely to fail

* sigh.

* delete empty files

* imports

* fix

* this check didn't actually do anything

* overrides

* fix tests

* revert changes for pubspec

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Omar <omarh.ismail1@gmail.com>

100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
access controlmemory safetycryptography-sensitive pathsigning or wallet pathboot or update pathauthentication path
AI analysis · Low 48/100

This is a very large code refactor of the cryptocurrency swap/exchange feature in Cake Wallet. It rewrites how exchange rates are fetched, how trades are created and tracked, and how trade history is stored in the local database. The commit also adds many unit tests and fixes numerous small bugs in individual exchange providers. While the changes touch security-sensitive areas (sending money, storing trade data, parsing amounts), the commit message and diff do not describe this as a security patch, and there is no explicit disclosure of a vulnerability. The biggest security-relevant change is a database migration that restructures how past trades are stored; a bug here could affect user records but is not shown to be exploitable by an attacker.

Security candidatei18n: fit the long Tamil strings on the new UI (#3878)by Seth For Privacy · 8c3365fd · Nov 19, 2026 · 6 filesMessage 96 · StrongInformational 22Details
Commit message · Seth For Privacy

i18n: fit the long Tamil strings on the new UI (#3878)

* i18n: fit the long Tamil strings on the new UI

On-device QA of the merged i18n work on `dev` (Pixel 8 AVD, debug build)
found three places where Tamil copy is drawn outside its box:

- Welcome headline: it sits in a `Positioned` with only `top`, which
Flutter lays out with unbounded width, so the 13-glyph word was painted
past both screen edges with no overflow report. Bound the Positioned by
the visible width, let AutoSizeText shrink the word, and scale the
"to <logo> Cake Wallet" row beside it.
- Dashboard action row: captions were wider than their circles and pushed
the row 11 px past the edge. Captions now live inside their button and
auto-size.
- Receive buttons: the same caption problem overflowed by 56 px. Each
control takes an equal share of the row, the horizontal padding drops
from 32 to 16 and the caption shrinks to fit, so English stays on one
line (Copy / Set amount / Label / Addresses) while Tamil wraps inside it.

Verified on the emulator with the final APK: 0 `RenderFlex overflowed`
events for en, bn, hi, mr, ta and te on the dashboard and receive screens,
and the Tamil welcome screen renders fully.

* fix: keep action captions inside the row on narrow screens

Review follow-up (Bugbot on #3878):

- `CoinActionButton` captions were pinned to `effectiveSize + 12`, so even
short English captions made each button 12 dp wider than its circle and
four of them plus gaps exceeded a 360 dp row. The caption is now capped
with `ConstrainedBox`, and the row gives every action an equal `Expanded`
share, so a caption can never widen the row.
- Captions no longer break words: `wrapWords: false` makes a long single
word (Tamil "பரிமாற்றம்") shrink to fit one line instead of splitting
mid-glyph.

Also unblocks the `unit_tests` check, which is red on `dev` itself: the
settings page started reading `dashboardViewModel.settingsStore`, and
`test/new-ui/pages/settings_page_test.dart` never stubbed it, so the build
threw `type 'Null' is not a subtype of type 'SettingsStore'`. The mock now
exists and the amount display mode is stubbed; all 11 tests in that file
pass.

Verified on the Pixel 8 AVD at 360 dp and 320 dp (density 420): en and ta
dashboards and receive screens report 0 `RenderFlex overflowed`.

* fix: keep the welcome subtitle row inside the headline box

Bounding the headline `Positioned` also bounds the "to <logo> Cake Wallet"
row below it; with Tamil's "பெறுநர்" it overflowed by 3.2 px. Scaling that
row down keeps it inside the same box (verified at 360 dp and 411 dp).

* fix: never clip a long caption in the action buttons

`wrapWords: false` stopped mid-glyph breaks, but a single unbreakable word
that does not fit at `minFontSize` was still drawn clipped with no visible
report. Tamil "நகலெடுக்கப்பட்டது" (the Copy button's copied state) is the
case that hits it.

- Lower the floor to 6 sp, which fits it in the 76 dp caption box at
411/360 dp (single line) and allows a two-line fit in the narrower 320 dp
slot.
- Add `TextOverflow.ellipsis` as a last resort so nothing is ever clipped
silently.

The copied label only renders on Android < 13 (`CopyWrapper.shouldShowCopied`),
so it was verified by temporarily forcing that branch in a scratch build:
the caption renders complete at 411 dp and wraps to two lines at 320 dp,
with 0 `RenderFlex overflowed`.

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetyauthentication path
AI analysis · Informational 22/100

This commit fixes visual layout bugs in the Cake Wallet mobile app where long Tamil translations were being drawn off-screen or clipped. It also fixes a broken unit test by adding a missing mock object. There is no security vulnerability here; it is a routine user-interface polish and test-maintenance change.

Security candidatei18n: add Bengali, Marathi, Tamil, Telugu and repair Hindi (#3859)by Seth For Privacy · 87a71a84 · Nov 19, 2026 · 18 filesMessage 100 · StrongInformational 20Details
Commit message · Seth For Privacy

i18n: add Bengali, Marathi, Tamil, Telugu and repair Hindi (#3859)

* i18n: add ARB lint gate and review-sheet generator

- tool/i18n_lint.dart: key parity, placeholder order and drops, script
coverage, stray English, length and spacing per locale.
- tool/i18n_baseline.json rebuilt on dev so the gate starts green.
- tool/gen_review_sheet.dart: per-locale reviewer sheets by screen tier.
- are_translations_sane.yml runs the lint after the JSON check.

* i18n: add Bengali, Marathi, Tamil and Telugu; repair Hindi

- New locales at dev's full key set: 1,682 keys each. 517 keys that
did not exist on main were translated, 42 retranslated because the
English changed, and 1,123 carried over unchanged.
- Hindi repaired on dev's file, not replaced: terminology normalized
(86 strings), the four placeholder reorders fixed, 56 missing keys
translated.
- Wiring: language_service (bn -> bgd, others ind), translation
constants, CFBundleLocalizations, README list.
- Layout: select-button labels ellipsize; Picker gained an optional
imageSize used only by the language picker, so other icon sets keep
their natural size.

* i18n(hi): fix doubled शेष in balance strings

- The बैलेंस → शेष normalization collided with strings that already
used शेष: favorite_token_desc and gift_card_balance_note read
'शेष शेष'. Reworded to 'शेष बैलेंस कार्ड' and 'शेष राशि बची होगी'.

* i18n: make the gate safe for dev's workflow

- Missing keys are warnings, not errors: append_translation adds keys
to every file in langs, and pt_BR was not in that list, so a new key
would have failed the PR. pt_BR is now covered.
- Workflow keeps dev's permissions block, puzl-ubuntu runner and
PR_test_build job id; only the lint step is added, with setup-dart
pinned to the same SHA as the iOS workflow.
- checkString() is shared with gen_review_sheet.dart, so the sheet and
CI use identical thresholds; the sheet's call-site regex now matches
S.of(anyContext) and a dot on the next line.
- New highlight check: each *_highlight value must appear in its
paired _title string.
- Baseline pruned after the Hindi fixes (2,079 -> 2,015 entries).

* i18n: fix Tamil highlight, amount digits and stale wiring

- Tamil recovery highlight now matches the inflected form in its title,
so the education page highlights instead of silently missing.
- Amounts keep ASCII digits for locales with native numerals: only the
integer part was localised, so bn/mr/fa/my showed mixed scripts.
- Drop the unused SettingsPickerCell.imageSize (only Picker uses it).
- iOS CFBundleLocalizations no longer lists Guarani, which is disabled.

* i18n: add fixture tests for the lint

- i18n_lint accepts --arb-dir and --baseline so it can run against
fixtures instead of the repo tree.
- tool/i18n_lint_selftest.sh covers missing keys (warn, and fail under
--strict), placeholder reorder, dropped placeholder, and baseline
filtering; wired into the translations CI job.

* i18n: correct repeat kind and highlight pairing

- errorKinds listed ph-count, which nothing emits; dropped repeats are
reported as ph-repeat and stay warnings because the generator builds
parameter lists from a Set, so a repeat changes copy, not binding.
- Highlights are applied to a title OR a description depending on the
slide (order_highlight sits in order_description), so the check now
accepts either and reports only when the value is in neither.
- Fixture test for a highlight that matches nothing.

* i18n: pair highlights with the host the slide draws them in

- Accepting "title or description" still let a highlight pass when it
matched the title, while the slide renders it inside the description
(accounts_education_order_highlight is drawn against
accounts_education_order_description), so the text drew unhighlighted.
- English decides the pairing; the translation must highlight the same
host. Either host is accepted when English is ambiguous or the key has
no English counterpart.
- Fixture covers a highlight that matches the wrong host.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
credential or privilege statecryptography-sensitive pathsigning or wallet path
AI analysis · Informational 20/100

This commit adds new language translations (Bengali, Marathi, Tamil, Telugu), fixes Hindi translations, and introduces automated tools to check translation quality. It also makes a small formatting fix so cryptocurrency amounts display with regular ASCII digits instead of mixing different numeral scripts. There is no indication of a security vulnerability being fixed or introduced.

Security candidatea11y: name settings switches by their row title and expose selected state on Fiat API choices (#3808)by Seth For Privacy · b4192b14 · Nov 18, 2026 · 5 filesMessage 96 · StrongInformational 19Details
Commit message · Seth For Privacy

a11y: name settings switches by their row title and expose selected state on Fiat API choices (#3808)

* a11y: name settings switches by their row title

ListItemToggleWidget (Privacy, Connections, Display, Security and the
other new-list settings pages) and SettingsSwitcherCell (domain lookups,
silent payments, MWEB, background sync, home settings, 2FA, advanced
privacy) put the row text and the StandardSwitch in sibling semantics
nodes: the row tap target carried the title and the switch carried only
its toggled state, so TalkBack announced "Switch, off" with no name.

Wrap both shared rows in MergeSemantics. The title, subtitle, toggled
state and tap action now form one node, which Android reports as an
android.widget.Switch named by the row title ("Auto generate addresses,
switch, off"). The switch itself has no label, so nothing is read twice.
MergeSemantics is a semantics boundary, so the row is not absorbed into
an ancestor. ValueKeys and hit testing are unchanged.

* a11y: expose selected state on Picker and settings choice options

The Fiat API and Swap pickers on Connections (Picker) and the Fiat API /
Swap / seed type segmented choices on the wallet-creation privacy
settings page (SettingsChoicesCell) exposed each option as a plain
clickable group, so a screen reader could not tell which of "Enabled /
Tor only / Disabled" was active.

Give each option button role, selected state and mutually-exclusive
grouping. Picker renders the current item through buildSelectedItem and
every other item through buildItem, so the selected flag is constant in
each builder.

The SettingsChoicesCell line matches the one in draft #3693 (which also
wraps the row in TestId.merge). Landing it on dev first means #3693's
hunk resolves to its existing form when that stack is rebased, instead
of the two Semantics wrappers nesting.

* test: semantics contract for settings switches, choices and picker options

* a11y: keep row and switch actions apart when SettingsSwitcherCell has onTap

Merging the whole row into one semantics node leaves room for a single
tap action. For rows that pass onTap (Home settings token rows: tap
opens the token editor, the switch changes visibility) the merged node
kept the row's handler, so a screen reader could no longer toggle the
switch.

Merge only when onTap is null, where row tap and switch tap do the same
thing. When onTap is set, the row stays its own button and the switch
becomes its own container node labelled with the row title, so both
actions stay reachable and the switch is still named.

The new test drives both actions through the semantics tree; at the
previous head the switch action ran the row's onTap instead of toggling.

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
access control
AI analysis · Informational 19/100

This commit improves screen-reader accessibility in the Cake Wallet mobile app. It makes settings switches announce their name (e.g., 'Auto generate addresses, switch, off') and makes choice options like 'Enabled / Tor only / Disabled' tell the user which one is currently selected. There is no security vulnerability being fixed here; it is purely an accessibility (a11y) improvement.

Security candidate- Fix signing messages to include change addresses as wellby Omar · 40ffab7d · Nov 15, 2026 · 8 filesMessage 50 · ThinModerate 51Details
Commit message · Omar

- Fix signing messages to include change addresses as well
- cleanup signing messages logic

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 51/100

This commit fixes a bug in how Cake Wallet signs Bitcoin-style messages. Previously, the app could not correctly sign messages with 'change addresses' (a special type of address used when sending leftover funds back to yourself). The fix moves the address lookup logic into a shared helper so all wallet types use the same rules, and it adds tests proving that both regular and change addresses can now be signed. It also blocks signing with Taproot and MWEB addresses, which would otherwise produce misleading signatures. There is no direct evidence in the commit that this was exploited or reported as a security flaw.

Security candidatefix: refuse Bitcoin message signing for an address the wallet cannot derive (#3826)by Omid · a2e88dad · Nov 15, 2026 · 3 filesMessage 98 · StrongModerate 60Details
Commit message · Omid

fix: refuse Bitcoin message signing for an address the wallet cannot derive (#3826)

Selecting a silent payment address still signed with the main key, so the signature did not belong to the address on screen. A requested address that is not a held receive address now fails instead of falling back.

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 60/100

This commit fixes a bug in Cake Wallet's Bitcoin message signing. Previously, if a user chose a silent payment address (a newer privacy-focused Bitcoin address type), the app would still sign the message using the wallet's main key. That signature would not actually prove ownership of the silent payment address shown on screen, which could mislead someone verifying the signature. Now the app refuses to sign for any address the wallet cannot directly derive, including silent payment and Taproot addresses, instead of silently falling back to the main key.

Security candidateAdd Bitcoin Cash Ledger wallet support (#3847)by Konstantin Ullrich · f90b4c60 · Nov 14, 2026 · 17 filesMessage 76 · AdequateInformational 15Details
Commit message · Konstantin Ullrich

Add Bitcoin Cash Ledger wallet support (#3847)

* feat: add Bitcoin Cash Ledger hardware wallet support

* feat: add Ledger message signing for Litecoin and Bitcoin Cash

* Update cw_bitcoin_cash/lib/src/bitcoin_cash_wallet.dart

---------

Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit adds support for using Ledger hardware wallets with Bitcoin Cash in Cake Wallet, and also enables message signing for Litecoin and Bitcoin Cash on Ledger devices. It is a feature addition, not a security fix. There is no indication in the commit or supplied references that this change addresses a vulnerability or security incident.

Security candidatefix: don't leave a ghost WalletInfo row when wallet creation fails (#3830)by Omar Hatem · d3c74388 · Nov 14, 2026 · 4 filesMessage 98 · StrongLow 45Details
Commit message · Omar Hatem

fix: don't leave a ghost WalletInfo row when wallet creation fails (#3830)

* fix: don't leave a ghost WalletInfo row when wallet creation fails

EVM wallet init() saves the WalletInfo row (through saveAddressesInBox)
before save() writes the wallet file, and WalletCreationVM only set a
FailureState when process() threw. Any failure in that window left a row
without a wallet file, so the wallet showed up in the list but could never
be opened:

PathNotFoundException: Cannot open file,
path = '.../wallets/polygon/<name>/<name>'

The reproducible trigger is "restore from private key" for an EVM chain:
the keys form validates only the wallet name, so a non-hex or empty key
reached EthPrivateKey.fromHex inside init(), after the row was saved.

- EVMChainWalletService.restoreFromKeys rejects an invalid private key
with a BadKeysException before anything is persisted.
EVMChainUtils.isValidPrivateKey accepts a 32-byte hex key, optionally
0x-prefixed, with 0 < k < secp256k1 order.
- WalletCreationVM._create removes the WalletInfo row when process()
throws, but only if the wallet directory holds no wallet file for that
name. That is the same check _validateWalletInfoBoxData uses, so a row
is dropped only when the startup validation would not re-create it. A
failure after the wallet files exist keeps today's behaviour.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix: only drop the WalletInfo row when the wallet directory is empty

The cleanup gate matched the "<name>/<name>" path substring that
_validateWalletInfoBoxData uses. Directory.listSync joins entries with
the platform separator, so on Windows the substring never matches and
the row was dropped on every failure, even with wallet files on disk
(Cursor Bugbot). The check also assumed every coin names its on-disk
files after the wallet, which Decred does not before save().

Delete the row only when the directory is missing or empty: a failed
EVM restore writes nothing before the throw, so the ghost row still goes
away, and any coin that got as far as writing a file keeps today's
behaviour.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix: accept every private key that restored before, reject only unusable ones

The first revision of isValidPrivateKey required exactly 32 bytes. The
wallet never had that rule: EthPrivateKey.fromHex takes any even-length
hex, the address and every signature derive from the integer value of
the bytes, and the key is stored as entered, so a 62- or 128-character
input produced a working wallet. Re-restoring such an input on a new
device would have been refused.

Now the check rejects only what never produced a usable wallet: hex that
does not parse (previously a throw inside init() after the WalletInfo
row was saved) and keys that are zero modulo the secp256k1 order, which
have no key pair.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialsigning boundarydefensive validationsigning or wallet path
AI analysis · Low 45/100

This commit fixes a bug in Cake Wallet where creating or restoring an EVM wallet could leave a 'ghost' wallet entry in the app's list. The ghost appeared because the wallet's metadata was saved to the app's database before the actual wallet file was written. If the next step failed—for example, because the private key was invalid—the app showed a wallet that could never be opened. The fix validates the private key before saving anything, and cleans up the metadata row if the wallet file was never actually created. It also makes sure the cleanup only happens when the wallet directory is empty, so it doesn't accidentally delete real wallets.

Security candidatefeat(exchange): add cbBTC, BNB and USDT-on-BSC to Chainflip (#3840)by David Cumps · 4461119c · Nov 14, 2026 · 2 filesMessage 93 · StrongLow 34Details
Commit message · David Cumps

feat(exchange): add cbBTC, BNB and USDT-on-BSC to Chainflip (#3840)

Chainflip added cbBTC on Ethereum and BNB/USDT on BNB Smart Chain.
Enable all three for swaps in the Chainflip provider.

- _supported: add cbbtc, bnb, usdtbsc
- _toCurrency: reverse-map cbbtc.eth, bnb.bsc, usdt.bsc; also fix the
missing usdt.sol -> usdtSol arm so USDT-on-Solana trades resolve
- _amountToNative: convert with AmountConverter.toBaseUnits instead of
double->int, fixing 18-decimal amounts (USDT-BSC minimum 10 is 1e19,
above int max) and the live ETH/FLIP/ARB-ETH above-9.223 defect
- crypto_currency.dart: add cbbtc to CryptoCurrency.all so it appears in
the picker and deserialize(raw: 103) works; all is app-wide, so cbBTC
also appears in buy/sell, contacts and charts (#3050 precedent)

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Low 34/100

This commit adds support for three new cryptocurrencies (cbBTC, BNB, and USDT-on-BSC) to the Chainflip exchange provider in Cake Wallet. It also fixes a numeric conversion bug where very large token amounts could be calculated incorrectly or even overflow, which could have caused swap quotes or trades to use the wrong amount. There is no direct evidence in the commit of an active security vulnerability being exploited.

Security candidatefix ln invoice not configured correctly for applinksby Omar · 3713f80f · Nov 13, 2026 · 2 filesMessage 50 · ThinLow 32Details
Commit message · Omar

fix ln invoice not configured correctly for applinks
gracefully handle monero subaddresses

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocol
AI analysis · Low 32/100

This commit fixes two separate bugs in a cryptocurrency wallet app. First, it corrects how Lightning Network invoice links are formatted so that Android/iOS 'applinks' open properly. Second, it adds a safety check so that if the Monero wallet isn't loaded yet, the app returns an empty list of subaddresses instead of crashing. Neither change appears to be a security vulnerability fix in the traditional sense; they are reliability/bug fixes.

Security candidateFix address search to match address or label case-insensitively (#3837)by claude[bot] · e0981df1 · Nov 11, 2026 · 2 filesMessage 81 · StrongInformational 20Details
Commit message · claude[bot]

Fix address search to match address or label case-insensitively (#3837)

* Fix address search to match address or label case-insensitively

The Receive > Addresses search only checked the label when an address had
a non-empty name (always the case for Monero subaddresses), and compared
the address case-sensitively against a lowercased query, which broke
search for mixed-case address formats (Zcash t-addresses, EVM checksummed
addresses, Solana, Tron, etc.).

Match either the address or the label, case-insensitively.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X8UF8vbBPx9f167TvAzjnk

* Restore print_verbose import in buy_sell_view_model

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X8UF8vbBPx9f167TvAzjnk

---------

Co-authored-by: Claude <noreply@anthropic.com>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
privacy or spend-authorization protocol
AI analysis · Informational 20/100

This commit fixes a user-interface bug in the wallet's address search. Previously, searching for an address sometimes returned no results if the address contained uppercase letters (common for Zcash, Ethereum, Solana, Tron) because the search was comparing a lowercased query against the original mixed-case address. The fix makes the comparison case-insensitive and also allows searching by address even when the address has a label. There is no security vulnerability here—just a usability fix.

Security candidateMerge branch 'dev' into cw-1476-cake-pay-failure-uxby Robert Malikowski · b4259b29 · Nov 10, 2026 · 300 filesMessage 65 · AdequateInformational 15Details
Commit message · Robert Malikowski

Merge branch 'dev' into cw-1476-cake-pay-failure-ux

# Conflicts:
# lib/cake_pay/src/cards/cake_pay_buy_card_page.dart

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a large routine merge from the 'dev' branch into a feature branch named 'cw-1476-cake-pay-failure-ux'. The visible changes are almost entirely build-system, CI/CD, asset, and translation updates. There is no direct evidence in the supplied diff of a security vulnerability being introduced or fixed.

Security candidateMerge branch 'dev' into cw-1595-swap-deposit-qrby Robert Malikowski · 4385a637 · Nov 10, 2026 · 300 filesMessage 60 · AdequateLow 31Details
Commit message · Robert Malikowski

Merge branch 'dev' into cw-1595-swap-deposit-qr

# Conflicts:
# lib/view_model/exchange/exchange_trade_view_model.dart

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Low 31/100

This is a large merge commit bringing the 'dev' branch into a feature branch named 'cw-1595-swap-deposit-qr'. Most visible changes are routine development: new CI workflows for iOS/Linux/Android, updated translations and changelogs, new asset images, new Robinhood chain support, Tor node updates, and wallet code refactoring. The commit itself is a merge with 300 files changed and no explicit security claims. There is no direct evidence in the supplied diff of a vulnerability being fixed or introduced, but the breadth of changes means security-relevant code was touched and should be reviewed further.

Security candidateMerge branch 'dev' into fix/cw-1633-cakepay-lightning-balanceby malik1004x · 33a41c42 · Nov 10, 2026 · 300 filesMessage 50 · ThinInformational 15Details
Commit message · malik1004x

Merge branch 'dev' into fix/cw-1633-cakepay-lightning-balance

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a large merge commit that brings the 'dev' branch into a feature branch named 'fix/cw-1633-cakepay-lightning-balance'. The visible changes are almost entirely routine project maintenance: new CI/CD workflows for iOS, Linux and Android builds, translation and changelog updates, asset additions (logos, stock icons, font files), new Electrum/Tor server entries, and a Robinhood wallet URL scheme. None of the supplied diff content shows a security fix, vulnerability, malicious change, or disclosure of sensitive data. The commit title and message do not describe any security relevance.

Security candidateMerge branch 'dev' into cw-1628-sell-fixesby Robert Malikowski · 0b61e95b · Nov 10, 2026 · 300 filesMessage 60 · AdequateInformational 15Details
Commit message · Robert Malikowski

Merge branch 'dev' into cw-1628-sell-fixes

# Conflicts:
# lib/view_model/buy/buy_sell_view_model.dart

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a large routine merge of the 'dev' branch into a feature branch named 'cw-1628-sell-fixes'. The visible changes are almost entirely build-system, CI, asset, and infrastructure updates (new GitHub Actions workflows, runner labels, Docker-based builds, new image assets, translation files, node lists, etc.). There is no clear security fix or vulnerability patch in the supplied diff, and no vendor statement says this commit addresses a security issue.

Security candidatefeat: add walletconnect support for tron wallets (#3598)by David Adegoke · 8a81db52 · Nov 7, 2026 · 45 filesMessage 93 · StrongModerate 64Details
Commit message · David Adegoke

feat: add walletconnect support for tron wallets (#3598)

* feat: add walletconnect support for tron wallets

* feat: enhance Tron transaction summary for WC and localization updates

* feat: make approval sheet more readable, update permission refusal and add fail soft for history

* feat: add dapp transctions to history and fix other minor issues pending

* fix(tron): keep the network fee when a TRC20 row replaces a TRX row

The TRC20 history loop now replaces a saved TRX row for the same hash (e.g. a
dApp swap), but TronTRC20TransactionModel.fee is always 0, never null, so the
saved?.fee fallback never ran and the real fee was overwritten with 0 TRX.
Prefer the saved row's fee.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(walletconnect): only sign requests on chains the open wallet has keys for

Every EVM, Solana and Tron request handler is registered on every wallet, and a
dApp can get a chain approved with no account on it (a required namespace keyed
by the chain id, e.g. "eip155:1"). The handlers only checked that the session
holds the open wallet's address, so such a request was signed with the open
wallet's key, e.g. EVM personal_sign / typed data with a Tron wallet's key, or
tron_signMessage with an EVM or Solana wallet's key.

Refuse a request unless the open wallet's key covers the handler's chain. Every
chain a wallet registers accounts for is in its key, so normal requests are
unaffected; Solana devnet/testnet requests (only reachable through such an
account-less namespace) are now refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Omar <omarh.ismail1@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
credential or privilege statesigning or wallet path
AI analysis · Moderate 64/100

This commit adds WalletConnect support for Tron wallets to Cake Wallet. It also fixes two security issues: one where a dApp could trick the app into signing messages or transactions with the wrong wallet's private key (for example, using a Tron wallet's key to sign an Ethereum request), and another where Tron transaction fees could be incorrectly displayed or overwritten. The commit is mostly a feature addition, but the included fixes address real authorization weaknesses in the WalletConnect integration.

Security candidatebump: 6.5.3 (#3801)by Omar Hatem · b9533b46 · Nov 6, 2026 · 43 filesMessage 96 · StrongLow 44Details
Commit message · Omar Hatem

bump: 6.5.3 (#3801)

* **Zcash**: Added Ledger support for ZEC (receive, shield, send) and compatibility with the NU7 network upgrade.
* **Hardware Wallets**: Added BitBox02 Nova support for iOS via Bluetooth.
* **BTC Map**: Integrated BTC Map into the Apps tab to locate merchants accepting Bitcoin.
* **Performance**: Improved app launch speed and wallet switching/loading times, particularly for older devices or users with multiple wallets.
* **RBF (Replace-By-Fee)**: Enhanced Bitcoin RBF logic with improved input/output verification and signature checks.
* **Changelog**: Updated the automated translation script to preserve technical terms (e.g., Ledger, Arbitrum, sats) and localized the 6.5.3 changelog across all supported languages.
* **Bug Fixes**:
* Strengthened 2FA and backup protections.
* Fixed Bitcoin and Litecoin wallets getting stuck in the "Connecting" state.
* Added `mounted` checks to `setState` calls in `BuySellAmountPage` and `SendPage` to prevent crashes.
* Resolved issues with MoonPay on Arbitrum.

96/100 · StrongMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryaccess controldefensive validationsigning or wallet path
AI analysis · Low 44/100

This is a routine version-bump release (6.5.2 → 6.5.3) for Cake Wallet/Monero.com. The visible code changes are mostly changelog translations, version-number bumps, and a few small hardening tweaks in the Bitcoin replace-by-fee (RBF) logic plus Flutter UI safety checks. The commit message claims stronger 2FA/backup protections and RBF improvements, but the actual diff does not show the underlying security changes—only the changelog text and a handful of related code fixes. There is no direct evidence in the diff of a vulnerability being patched.

Security candidateMigrate and enhance BitBox integration with updated library (#3765)by Konstantin Ullrich · 7f7fc4a2 · Nov 3, 2026 · 60 filesMessage 91 · StrongInformational 22Details
Commit message · Konstantin Ullrich

Migrate and enhance BitBox integration with updated library (#3765)

* feat: migrate Bitbox integration to updated bitbox_flutter library

- Replaced `BitboxManager` with `BitboxConnection` across services and files.
- Updated `pubspec.yaml` to use the new bitbox_flutter library via Git dependency.
- Refactored Bitbox service classes (`BitcoinBitboxService`, `LitecoinBitboxService`, and `EVMChainBitboxService`) to align with the updated library's API.
- Adjusted DI and ViewModels to support the new connection manager logic.
- Improved modularity with helper methods for Bitbox functionality like signing and address derivation.

* feat: add BitBox initialization and channel hash verification steps in connection process

* feat: add channel hash verification UI for BitBox pairing process

* refactor: remove BitBox Flutter build scripts and Docker integration

* feat: add BLE support for BitBox devices and refactor BitBox hardware wallet handling

* feat: improve bitbox connection handling

* refactor: simplify BitboxViewModel initialization and cleanup unused reactions

* `chore: remove BitBox build steps from CI workflows`

* feat: enhance hardware wallet UI and allow BitBox BLE only on ios

* refactor: improve BitBox connection logic and remove debug prints

* refactor: replace `SvgPicture` with `CakeImageWidget` for hardware wallet manufacturer images

* chore: update BitBox Flutter dependency URLs and commit refs

* feat: add conditional inclusion of BitBox hardware wallet option for mobile devices

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Informational 22/100

This commit updates Cake Wallet's integration with BitBox hardware wallets. It swaps an older local library for a newer one fetched from GitHub, rewrites the connection code to support both USB and Bluetooth (BLE), and adds a user-facing pairing-code confirmation screen. The changes are mostly a feature/refactor rather than a clear security fix, but they touch sensitive areas: how the app talks to a hardware wallet, verifies the pairing channel, and signs cryptocurrency transactions.

Security candidatederive Nano HD seeds with bip39MnemonicToSeed (#3778)by malik1004x · 99bba541 · Nov 2, 2026 · 4 filesMessage 96 · StrongInformational 19Details
Commit message · malik1004x

derive Nano HD seeds with bip39MnemonicToSeed (#3778)

Nano HD wallets derived the BIP39 seed through nanoutil's hdMnemonicListToSeed: PointyCastle PBKDF2-SHA512 in a freshly spawned isolate, on every open as well as create/restore. On a low-end phone that was ~2.8 s per create and ~3.4 s per open. Use cw_core's bip39MnemonicToSeed instead (same PBKDF2-HMAC-SHA512, 2048 rounds, salt "mnemonic", 64 bytes, hex-encoded). Mnemonics with non-ASCII characters keep the old path, since nanoutil UTF-8 encodes while bip39MnemonicToSeed uses code units. A test checks both give the same seed for random 12 and 24 word mnemonics.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialseed or entropy pathsigning or wallet path
AI analysis · Informational 19/100

This commit swaps the way Nano HD wallets turn a recovery phrase into a cryptographic seed. It replaces a slow, per-operation computation done in a separate isolate with a shared, faster utility that produces the same bytes for normal ASCII phrases. For phrases containing non-ASCII characters, it keeps the old, slower method because the two implementations disagree on how to encode those characters. A test verifies the outputs match for random 12- and 24-word phrases. The change is framed as a performance improvement, not a security fix.

Security candidatechore: fix type casting and safety across multiple coin packages (#3791)by Omar Hatem · 89f5de4b · Oct 30, 2026 · 20 filesMessage 93 · StrongLow 47Details
Commit message · Omar Hatem

chore: fix type casting and safety across multiple coin packages (#3791)

* chore: fix type casting and safety across multiple coin packages

* **cw_decred**: Add explicit type casts for JSON decoding in wallet and address management, including transaction history, unspents, and sync status. Fix `amount` and `fee` decoding to handle `num` values from Go.
* **cw_evm**: Apply type safety to Trezor transaction credential parsing and Etherscan API response handling. Fix potential crashes in transaction merging and spam filtering.
* **cw_solana**: Add explicit casts for RPC response data, transaction signatures, and SPL token metadata.
* **cw_tron**: Ensure proper type casting for transaction info, balances, and TRC20 transaction models.
* **cw_zcash**: Fix `crc32` byte validation and add explicit casts to `YwalletAccountInfo` migration logic.
* **cw_wownero**: Explicitly type `newWptr` as `wownero.wallet`.
* **cw_monero**: Cast serialized wallet cache to `Map<String, dynamic>`.

* Update cw_decred/lib/api/libdcrwallet.dart

Co-authored-by: malik1004x <malikowskirobert@gmail.com>

---------

Co-authored-by: malik1004x <malikowskirobert@gmail.com>

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarycredential or privilege statesigning or wallet path
AI analysis · Low 47/100

This commit is a broad cleanup across multiple cryptocurrency wallet packages that adds explicit type casts when handling JSON and binary data. The changes mostly prevent runtime crashes caused by unexpected data types (for example, a number arriving as an integer instead of a decimal, or a string where a list was expected). In a few places, the casts also make the code safer when parsing values that could be attacker-influenced, such as Etherscan API responses or Trezor hardware-wallet transaction data. The patch is defensive and does not appear to introduce new vulnerabilities, but it is also partial: it fixes many symptoms without addressing the underlying lack of structured validation, so some edge cases may still crash or behave incorrectly.

Security candidateSummary of changes:by Omar · ec61b405 · Oct 30, 2026 · 8 filesMessage 61 · AdequateLow 26Details
Commit message · Omar

Summary of changes:

* **Tests**:
* Added `proxy_wrapper_prefer_ipv6_test.dart` to verify IPv6 connection handling and fallback logic in `ProxyWrapper`.
* Added `auth_pin_unreadable_test.dart` to test `AuthService` behavior and error states when PIN codes are unreadable from secure storage.
* Renamed `crypto_amount_format.dart` to `crypto_amount_format_test.dart`.
* **iOS/macOS Configuration**:
* Bumped app versions and build numbers in `scripts/ios/app_env.sh` (Monero.com to 6.5.2, Cake Wallet to 6.5.2).
* Increased the `MACOSX_DEPLOYMENT_TARGET` from 12.0 to 13.0 in the macOS `Podfile`.

61/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
access controlcryptography-sensitive pathauthentication path
AI analysis · Low 26/100

This commit is mostly a routine test-and-version update. It adds tests for network IPv6 fallback and for PIN-unreadable error handling, bumps app versions, raises the minimum macOS version, and switches two dependencies from local paths to Git references. The only functional code change is a single commented-out error-reporting line in the authentication view model, which stops sending a crash report when the device's stored PIN cannot be read. There is no direct evidence in the commit that this fixes an active security vulnerability.