derive Nano HD seeds with bip39MnemonicToSeed (#3778)
What changed, and why it matters
This commit swaps the way Nano HD wallets turn a recovery phrase into a cryptographic seed. It replaces a slow, per-operation computation done in a separate isolate with a shared, faster utility that produces the same bytes for normal ASCII phrases. For phrases containing non-ASCII characters, it keeps the old, slower method because the two implementations disagree on how to encode those characters. A test verifies the outputs match for random 12- and 24-word phrases. The change is framed as a performance improvement, not a security fix.
Treat as a routine performance refactor. Reviewers should confirm that cw_core's bip39MnemonicToSeed is byte-for-byte equivalent to nanoutil's hdMnemonicListToSeed for the full ASCII input space and that the non-ASCII fallback is correctly triggered and preserves existing wallets. No immediate security response is indicated by the supplied materials.
Security signals we found
Cryptographic key derivation changed from one implementation to another in wallet open/create/restore paths
Fallback to legacy path for non-ASCII mnemonics due to UTF-8 vs code-unit encoding mismatch
No explicit security rationale or advisory in commit message or diff
Equivalence test added, but only covers random ASCII BIP39 mnemonics
Evidence from the diff
The patch introduces NanoMnemomics.hdMnemonicToSeed, which routes ASCII mnemonics to cw_core’s bip39MnemonicToSeed (PBKDF2-HMAC-SHA512, 2048 rounds, salt ‘mnemonic’, 64-byte output, hex-encoded) and falls back to nanoutil’s hdMnemonicListToSeed for any mnemonic containing non-ASCII code points. The wallet open/create/restore paths and address-derivation helper are updated to call this wrapper. A new unit test asserts equivalence between the two implementations for 20 random BIP39 mnemonics.
Changed components
cw_nano/lib/nano_mnemonic.dartcw_nano/lib/nano_wallet.dartcw_nano/test/hd_seed_test.dartlib/nano/cw_nano.dartInspect captured patch +31 / −3
### cw_nano/lib/nano_mnemonic.dart
@@ -1,6 +1,9 @@
import 'package:bip39/bip39.dart' as bip39;
import "package:cw_core/exceptions/cake_exception.dart";
+import "package:cw_core/utils/bip39_seed.dart";
+import "package:hex/hex.dart";
import 'package:nanodart/nanodart.dart';
+import "package:nanoutil/nanoutil.dart" show NanoDerivations;
class NanoMnemonicIsIncorrectException implements Exception {
@override
@@ -26,6 +29,14 @@ class NanoMnemomics {
return bip39.mnemonicToEntropy(words.join(' ')).toUpperCase();
}
+ /// BIP39 seed (hex) of an HD mnemonic, same as [NanoDerivations.hdMnemonicListToSeed] but through
+ /// [bip39MnemonicToSeed]. Non-ASCII input keeps the nanoutil path, which UTF-8 encodes where
+ /// [bip39MnemonicToSeed] takes code units.
+ static Future<String> hdMnemonicToSeed(String mnemonic) async =>
+ mnemonic.codeUnits.every((unit) => unit < 0x80)
+ ? HEX.encode(bip39MnemonicToSeed(mnemonic))
+ : await NanoDerivations.hdMnemonicListToSeed(mnemonic.split(' '));
+
/// Validate a mnemonic word list
static bool validateMnemonic(List<String> words) {
return bip39.validateMnemonic(words.join(' '));
### cw_nano/lib/nano_wallet.dart
@@ -23,6 +23,7 @@ import 'package:cw_core/wallet_info.dart';
import 'package:cw_core/wallet_keys_file.dart';
import 'package:cw_nano/nano_balance.dart';
import 'package:cw_nano/nano_client.dart';
+import 'package:cw_nano/nano_mnemonic.dart';
import "package:cw_nano/nano_exceptions.dart";
import 'package:cw_nano/nano_transaction_credentials.dart';
import 'package:cw_nano/nano_transaction_history.dart';
@@ -126,7 +127,7 @@ abstract class NanoWalletBase
if (_derivationType == DerivationType.nano) {
_hexSeed = bip39.mnemonicToEntropy(_mnemonic).toUpperCase();
} else {
- _hexSeed = await NanoDerivations.hdMnemonicListToSeed(_mnemonic.split(' '));
+ _hexSeed = await NanoMnemomics.hdMnemonicToSeed(_mnemonic);
}
}
### cw_nano/test/hd_seed_test.dart
@@ -0,0 +1,16 @@
+import "package:bip39/bip39.dart" as bip39;
+import "package:cw_nano/nano_mnemonic.dart";
+import "package:flutter_test/flutter_test.dart";
+import "package:nanoutil/nanoutil.dart" show NanoDerivations;
+
+void main() {
+ test("hdMnemonicToSeed matches nanoutil", () async {
+ for (var i = 0; i < 20; i++) {
+ final mnemonic = bip39.generateMnemonic(strength: i.isEven ? 128 : 256);
+ expect(
+ await NanoMnemomics.hdMnemonicToSeed(mnemonic),
+ await NanoDerivations.hdMnemonicListToSeed(mnemonic.split(" ")),
+ );
+ }
+ });
+}
### lib/nano/cw_nano.dart
@@ -253,7 +253,7 @@ class CWNanoUtil extends NanoUtil {
if (derivationType == DerivationType.bip39) {
if (mnemonic != null) {
- seedKey = await NanoDerivations.hdMnemonicListToSeed(mnemonic.split(' '));
+ seedKey = await NanoMnemomics.hdMnemonicToSeed(mnemonic);
publicAddress = await NanoDerivations.hdSeedToAddress(seedKey, index: 0);
}
}
@@ -310,7 +310,7 @@ class CWNanoUtil extends NanoUtil {
nanoClient.connect(node);
if (mnemonic != null) {
- seedKey = await NanoDerivations.hdMnemonicListToSeed(mnemonic.split(' '));
+ seedKey = await NanoMnemomics.hdMnemonicToSeed(mnemonic);
publicAddressBip39 = await NanoDerivations.hdSeedToAddress(seedKey, index: 0);
seedKey = await NanoDerivations.standardMnemonicToSeed(mnemonic);Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.