BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 51 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge bitcoin/bitcoin#36425: guix: declare python-setuptools in codesign manifestby merge-script · 60ebd98c · Oct 14, 2026 · 1 fileMessage 91 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36425: guix: declare python-setuptools in codesign manifest

c04e968b2b8b7c8778910f907ed8c26ba59edd85 guix: update certvalidator for Python 3.12 (will)
11977b42acc54e2abcd8e06272a8f44865cf40a4 guix: declare python-setuptools (will)

Pull request description:

Since we bumped to python 3.12, `setuptools` is no longer provided by default: https://docs.python.org/3.12/whatsnew/3.12.html#ensurepip Declare this explicitly.

Also bypass `certvalidator`'s custom test loader using `unittest`, until [this upstream patch](https://github.com/LRGH/elfesteem/commit/000d6bbcd3a4b3d132ad6d932eedb3158b3313e9) makes it into our Guix time machine commit.

Commits split to allow easy reversion of only the `imp` test loader patch.

Fixes: #36421

ACKs for top commit:
hebasto:
ACK c04e968b2b8b7c8778910f907ed8c26ba59edd85.
pinheadmz:
ACK c04e968b2b8b7c8778910f907ed8c26ba59edd85

Tree-SHA512: 8068f62e403ced160aa9fedf673f65c43327e58d148e2cf14332e2e563a99ac649b3b337be5dc4c1b46b414d3dc1c865f57b619f9e195393d0ba7ebc6377454c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This is a build-system maintenance patch for Bitcoin Core's Guix codesigning environment. It explicitly adds python-setuptools (which Python 3.12 no longer includes by default) and updates a certificate-validation library used during the release signing process. There is no direct vulnerability in the shipped Bitcoin Core software; the change prevents release-build failures and keeps the signing toolchain working.

AI review queuedMerge bitcoin/bitcoin#36440: test: speed up functional tests by removing avoidable waitsby merge-script · 1605d887 · Oct 13, 2026 · 8 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36440: test: speed up functional tests by removing avoidable waits

8dc80cafa2ee5932c9ff499c02d6ab8e3cf2f5ef test: wake p2p wait_until on message delivery instead of polling (ViniciusCestarii)
10cfeb33357c937ddd9f588a35e0f8f33abd6ece test: set noban_tx_relay to speed up slow tx relay tests (ViniciusCestarii)

Pull request description:

Reduce functional test runtime:

- set noban_tx_relay = True for tests that can benefit from it.
- wake P2PInterface.wait_until as soon as a message is delivered or the connection state changes, instead of polling every 50ms.

Tested on my x86-64 machine:

Wall time (-j=18): 110.8s to 99.1s (-11%)
Accumulated: 1715s to 1411s (-17.5%)

Tests that were most affected:

| test | before | after |
|---|---|---|
| feature_maxuploadtarget | 57.9s | 6.2s |
| wallet_conflicts | 49.2s | 7.0s |
| p2p_sendheaders | 31.1s | 6.8s |
| p2p_compactblocks | 11.1s | 1.7s |
| wallet_orphanedreward | 9.3s | 5.2s |
| wallet_importprunedfunds | 4.9s | 2.9s |

ACKs for top commit:
maflcko:
review ACK 8dc80cafa2ee5932c9ff499c02d6ab8e3cf2f5ef 🏏
w0xlt:
ACK 8dc80cafa2ee5932c9ff499c02d6ab8e3cf2f5ef

Tree-SHA512: e01654de189d33957e5c9794c3be0aad08a1628480af11ab2365bd6c8b5d6e1130e561fa85380e2b23daad21248993a5658f1740d9d03d1fe5485eef0a9c3851

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's functional test framework to make tests run faster. It replaces a slow polling wait with an event-driven notification and enables a test-only peer-whitelist flag for transaction relay. There is no change to production node code, no user-facing behavior change, and no security issue.

AI review queuedMerge bitcoin/bitcoin#36471: bitcoin-util: print genesis hash in display orderby merge-script · 6b937883 · Oct 8, 2026 · 7 filesMessage 93 · StrongInformational 17Details
Commit message · merge-script

Merge bitcoin/bitcoin#36471: bitcoin-util: print genesis hash in display order

cc8285e8c98ac91a380eec899bab2aed5863a458 bitcoin-util: print genesis hash in display order (ViniciusCestarii)

Pull request description:

`bitcoin-util getchainparams` prints the genesis hash byte-reversed compared to `getblockhash 0`:
```
bitcoin-util getchainparams | grep genesis
```
"genesis": "6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000",
```
bitcoin-cli getblockhash 0
```
000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f

Use `GetHex()` instead of `HexStr()`, consistent with `pow.limit` in the same output and with the RPCs.

The command is new in v32.0 (#35736), so I believe this should be backported before final release to avoid changing the output format afterwards.

ACKs for top commit:
maflcko:
lgtm ACK cc8285e8c98ac91a380eec899bab2aed5863a458
sedited:
ACK cc8285e8c98ac91a380eec899bab2aed5863a458
brunoerg:
code review ACK cc8285e8c98ac91a380eec899bab2aed5863a458

Tree-SHA512: dc45152dfbcb92f32e19088c303953468cce3e9f4dbdb942cc730903ae6824e2edad7c10a65ea363531a7e8b8b7d90277d297f6f1ee37db58455992ddb2da4a2

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit fixes a display bug in the new bitcoin-util getchainparams command. The genesis block hash was being printed backwards (byte-reversed) compared to how it is normally shown elsewhere in Bitcoin. The change makes the output consistent with bitcoin-cli getblockhash 0 and other RPC commands. This is a cosmetic/output-format fix, not a security issue.

AI review queuedbitcoin-util: print genesis hash in display orderby ViniciusCestarii · cc8285e8 · Oct 8, 2026 · 7 filesMessage 45 · ThinInformational 15Details
Commit message · ViniciusCestarii

bitcoin-util: print genesis hash in display order

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a display bug in a command-line utility so that the Bitcoin genesis block hash is printed in the same byte order humans normally see it (big-endian), instead of the reversed internal storage order. It only changes output formatting and matching test data; it does not affect money, transactions, consensus rules, or network security.

AI review queuedMerge bitcoin/bitcoin#36447: test: Misc fixes for pending validation events racesby merge-script · 9dfde64c · Oct 7, 2026 · 15 filesMessage 100 · StrongInformational 17Details
Commit message · merge-script

Merge bitcoin/bitcoin#36447: test: Misc fixes for pending validation events races

fa466dea808dedfc281cdff842cbefafae574d8a test: Avoid pending validation events from TestChain100Setup (MarcoFalke)
fa339713dbc58e36b0da0f2f1cce8a231939893f test: Drain all validation events before stopping indexes (MarcoFalke)
fa21ac647dc2e28f3b67ea0f057393a3b61e0aa6 test: [move-only] wallet rescan tests to separate TU (MarcoFalke)

Pull request description:

`TestChain100Setup` enqueues 100 validation events from blocks. Unit tests using that setup and their own validation events may run into non-determinism and even intermittent test failures.

Fix all issues by draining the pending validation events in the ctor.

This can be tested with a diff like:

```diff
diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
index 128f14a6d5..2ea3ec8d4c 100644
--- a/src/validationinterface.cpp
+++ b/src/validationinterface.cpp
@@ -14,2 +14,3 @@
#include <primitives/transaction.h>
+#include <random.h>
#include <util/check.h>
@@ -156,2 +157,4 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()

+static FastRandomContext g_rnd{};
+
// Use a macro instead of a function for conditional logging to prevent
@@ -168,2 +171,3 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
LOG_EVENT("%s", local_log_msg); \
+ UninterruptibleSleep(1ms * g_rnd.randrange(105)); \
local_event(); \
```

and then running the test `scan_for_wallet_transactions_attach_chain` a few times.

Or master (or the first commit), it should fail with: `error: scan_for_wallet_transactions_attach_chain": check wallet->mapWallet.size() == static_cast<size_t>(NEW_BLOCKS + 1) has failed [7 != 6]`.

(Also included is a commit to move-only the many rescan tests to a separate file)

(Also included is a commit to fix unsafe index shutdowns in tests)

ACKs for top commit:
willcl-ark:
reACK fa466dea808dedfc281cdff842cbefafae574d8a
sedited:
ACK fa466dea808dedfc281cdff842cbefafae574d8a

Tree-SHA512: 3e3e57f373f150fecaef397e95ff0d6a120fea1fd7768e4de4f79708ed09e6b73311afb662a4d7967b5beddc53d28677e3707208e0da95752139d9adba76d559

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit fixes timing problems in Bitcoin Core's own unit and benchmark tests. It does not change how the live Bitcoin node behaves. The changes make test setups wait for background 'validation' notifications to finish before tests run or shut down, which removes random test failures and unsafe shutdown races during testing. A large block of wallet rescan tests was also moved to a new file with no functional changes.

AI review queuedMerge bitcoin/bitcoin#36432: wallet: show real fee_reason strings in helpby merge-script · 5661a65c · Oct 7, 2026 · 4 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36432: wallet: show real fee_reason strings in help

781d8dbd500d4f7b6577ed4b37d1d913c25052af wallet: show real fee_reason strings in help (Jehudi Castro-Sierra)

Pull request description:

The verbose help for sendtoaddress and sendmany paraphrased
fee_reason and left out "User Specified Fee". The strings the RPC
returns are the ones in StringForFeeReason.

Join that map for both help lines, the same way estimate_mode help
is built from FeeModeMap, so the list cannot drift again.

wallet_basic.py checks that an explicit fee_rate returns
"User Specified Fee" for sendtoaddress and sendmany.

ACKs for top commit:
maflcko:
lgtm ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
ismaelsadeeq:
Code review ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
sedited:
ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af

Tree-SHA512: 83a8cc240dffeab5b01cb54f146b38e63499f893163ae4c6ee184e23e658ea054c5a7e28cc12e02e15c084352808b3a4eefe4a96216accead9010163d529d0da

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This change only updates the help text shown by two wallet RPC commands (sendtoaddress and sendmany) so the list of possible fee reasons matches the actual strings returned by the software. It also adds a test to confirm that an explicit fee rate returns the string 'User Specified Fee'. There is no security issue here—just a documentation/help-text consistency fix.

AI review queuedMerge bitcoin/bitcoin#34907: wallet, test: make wallet_fast_rescan robustby merge-script · 36e9e52f · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#34907: wallet, test: make wallet_fast_rescan robust

f217da5c59f43b43abca96de66b95c24ae99eed7 wallet, test: wallet_fast_rescan follow-ups (rkrux)

Pull request description:

This patch addresses my own review comments from the review of #34667 and adds some more changes that I find helpful. It was observed in the review of the earlier PR that there is a tendency for the test code to cause the topups not being done that defeats the purpose of the test. Combine that with the earlier issue where the block filter was not being updated ever since this test was written, I think it's helpful that some robustness is added in the test.

Exact details are in the commit message.

ACKs for top commit:
Bicaru20:
lgtm ACK f217da5c59
polespinasa:
lgtm ACK f217da5c59f43b43abca96de66b95c24ae99eed7
sedited:
ACK f217da5c59f43b43abca96de66b95c24ae99eed7

Tree-SHA512: 781aeee4607a6750f370d4370b28da47f01428eb894ce59ac7de930396864a7c3708d1d1c05efb607fae8e5c2888a2503573140c37eed5c285c79d3e5155a3af

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a test-only change to a Bitcoin Core functional test file. It makes the wallet_fast_rescan test more robust by ensuring the test actually triggers wallet keypool top-ups and verifies block filter rescans find the expected transactions. There is no change to production wallet, node, or consensus code, and no security vulnerability is being fixed.

AI review queuedMerge bitcoin/bitcoin#36299: cli: Improve empty-response and fix -rpcclienttimeout regressionby Ava Chow · dd809d2c · Oct 2, 2026 · 2 filesMessage 100 · StrongLow 38Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36299: cli: Improve empty-response and fix -rpcclienttimeout regression

1805716354b49ecb96e49b949a61e2c72ad2c1a3 cli: Apply -rpcclienttimeout per socket wait instead of per phase (Fabian Jahr)
b841ab694215699cba53c4de8a7cc08b9fce259a cli: Treat a response with Content-Length: 0 as complete (Fabian Jahr)

Pull request description:

Two follow-ups to #34342

First commit: An empty body was not treated as a complete response. We currently check if `Content-Length` is greater than zero instead of whether the header was sent, so a response with a `Content-Length` of 0 falls into the branch for responses that carry no length and confinues to read until the peer disconnects. Our server sends an empty body with several types of errors such as a wrong RPC password but it does close the connection as well, which mitigates this from causing any serious issue. However, it would still be good to handle this correctly on the client side that we don't have to rely on the server to save us from hanging.

b-l-u-e found this in post-merge review in https://github.com/bitcoin/bitcoin/pull/34342#discussion_r3358700705 but I didn't manage to look into it until now.

Second commit: `-rpcclienttimeout` no longer measures real idle time. Before the libevent removal, it used to mean give up if really nothing arrives for this long, and any newly incoming data did reset the counter. With the new code the countdown ignores progress, so a large/slow response could be cut off while data still arrives. Revert this to the old behavior.

The second commit does not have a test because I didn't manage to construct one that didn't turn out to be flaky. It may be possible but I couldn't come up with something within a scope of complexity that seems reasonable for this.

ACKs for top commit:
achow101:
ACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
0tuedon:
tACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
winterrdog:
tACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
hodlinator:
ACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3

Tree-SHA512: 6139328c84480af7c7ccd5beec3361a28bbd639459e36b3f033ffc5946840ac0e589d987d4ce2414e58110b73ce48e34b449f9dd5ca577d07e334589a280a136

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 38/100

This update fixes two bugs in bitcoin-cli, the command-line tool used to talk to a Bitcoin node. First, when a server replied with an empty body but said it was intentionally empty (Content-Length: 0), the client would keep waiting instead of accepting the reply. Second, the client timeout stopped measuring actual idle time, so a slow but ongoing download could be cut off. The patch makes the timeout reset whenever new data arrives and treats a declared empty body as complete. The hang-on-empty-body case is the more security-relevant one, because a malicious or misbehaving server that keeps the connection open could make bitcoin-cli hang until the user kills it.

AI review queuedMerge bitcoin/bitcoin#35833: log: prevent user input from injecting fake log linesby Ava Chow · d4b0e1e4 · Sep 30, 2026 · 4 filesMessage 100 · StrongModerate 60Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35833: log: prevent user input from injecting fake log lines

d93d366e204e95e873ef0b89425f84a520f8fabd log: escape newlines in messages (Lőrinc)
960dcdb62529a6498d1397e1cf1077fe3cb19d9f test: characterize RPC and wallet input logs (Lőrinc)

Pull request description:

**Problem:** Restricted RPC users and callers of `createwallet` or `restorewallet` can inject newlines through rejected methods or wallet names, and [global log escaping preserves them](https://github.com/bitcoin/bitcoin/pull/17095), making forged lines look like node messages.

**Fix:** Escape embedded newlines in log messages.

<details>
<summary>Manual reproducer</summary>

```bash
DATADIR="$(mktemp -d /tmp/bitcoin-log-injection.XXXXXX)"
M="$(date -u +%Y-%m-%dT%H:%M:%SZ) ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent"
cmake -B build >/dev/null 2>&1 && cmake --build build -j >/dev/null 2>&1
build/bin/bitcoind -regtest -daemonwait -datadir="$DATADIR" -rpcwhitelist=__cookie__:getblock,stop >/dev/null 2>&1
build/bin/bitcoin-cli -regtest -datadir="$DATADIR" $'getblock\n'"$M" >/dev/null 2>&1; killall bitcoind >/dev/null
echo; grep -E 'ConnectTip|not allowed' "$DATADIR/regtest/debug.log"
```

> Before

```bash
2026-07-28T23:18:57Z [warning] RPC User __cookie__ not allowed to call method getblock
2026-07-28T23:18:55Z ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent
```

> After

```bash
2026-07-28T23:19:45Z [warning] RPC User __cookie__ not allowed to call method getblock\x0a2026-07-28T23:19:41Z ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent
```
</details>

ACKs for top commit:
achow101:
ACK d93d366e204e95e873ef0b89425f84a520f8fabd
ryanofsky:
Code review ACK d93d366e204e95e873ef0b89425f84a520f8fabd. Fix is minimal now and tests have been expanded to ensure that newlines can't sneak into log messages through `InitWarning` or `InitError` calls by testing the `load_on_startup` case w0xlt reported https://github.com/bitcoin/bitcoin/pull/35833#issuecomment-5849713749.
w0xlt:
ACK d93d366e204e95e873ef0b89425f84a520f8fabd

Tree-SHA512: 6a19f937a2d362fd4dd2960d1551d7e630dc61e4200bd1f61eb65fd02286b2500ac5eb4fee01c1f1aed5fb4899daa56c11e800ccb4572a3372b180f8ec44c6db

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 60/100

This update fixes a way that people with limited access to a Bitcoin node could make fake log entries appear real. Normally, the node cleans up special characters in log messages but was leaving newlines alone. A clever user could slip a newline into a wallet name or a blocked RPC command, causing the log file to show a forged line that looks like an official node error or warning. The fix now escapes newlines too, so the whole injected text stays on one line and is clearly not a real log entry. This is mainly a log-integrity and anti-confusion issue, not a direct theft or remote-control bug.

AI review queuedMerge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendallby Ava Chow · e7aef7e8 · Sep 29, 2026 · 2 filesMessage 81 · StrongLow 27Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendall

df2994b14a4ba26c4ccebd6df4c24d8aaf22d851 wallet: accept uppercase addresses without amount in sendall (FlashW)

Pull request description:

`sendall` keeps the recipients that were given without an amount as the strings the user passed (spend.cpp:1399). Later it finds their outputs by comparing against `EncodeDestination` of each output script (spend.cpp:1564), which for bech32 is the canonical lowercase form.

An address given in uppercase is valid bech32, and `validateaddress` and `sendtoaddress` accept it. In `sendall` it never matches, so its output keeps the placeholder amount of 0 and the call fails:

```
sendall '["BCRT1Q..."]'
error code: -8
Specified output amount to bcrt1q... is below dust threshold.
```

This stores the decoded destinations of those addresses instead and compares them with the destinations of the outputs, so the match doesn't depend on how the address was written. Invalid addresses are still rejected later when the transaction is constructed.

The new `sendall_uppercase_address` in `wallet_sendall.py` sweeps the wallet to the uppercase form of an address. It fails on master with the dust error above and passes with the fix. `wallet_send.py` still passes.

ACKs for top commit:
maflcko:
lgtm ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
achow101:
ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
polespinasa:
ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851

Tree-SHA512: 57fc356d52c69517aaef2ed67abad8c7c8350a984be914b4f6e1d79b871b269d6bb6d4bbc0b0a87cb55c560fe215b0fd310977f95856c3d54134a65fc92bf15c

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100

This patch fixes a bug in Bitcoin Core's `sendall` wallet command. If a user typed a bech32 address in uppercase letters, the command would fail with a confusing 'below dust threshold' error instead of sending the funds. The fix compares decoded address data rather than raw text, so uppercase and lowercase addresses are treated the same. It is a usability/functional bug, not a vulnerability that lets someone steal funds.

AI review queuedMerge bitcoin/bitcoin#36233: guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8`by merge-script · 619185d5 · Sep 29, 2026 · 3 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36233: guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8`

feb77d838eda70dfc27df78537da89f2b568f52c guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8` (Hennadii Stepanov)
f14a3ef8c5c6480f2e452d9668db71786cdb83fc guix: Skip some packages' tests in `python-lief` and `nsis-x86_64` (fanquake)

Pull request description:

On the master branch @ 17817818da3cb67c95320b7a5d4d69bd649c1fbf, building on a RISC-V system [fails](https://github.com/bitcoin/bitcoin/issues/36232):
```
guix shell: error: package python-lief@0.17.5 does not support riscv64-linux
```

Also see https://github.com/bitcoin/bitcoin/pull/34550#issuecomment-3921035276.

This is caused by the `python-msgspec` package, an indirect dependency of `python-lief`:

`python-lief` <-- `python-scikit-build-core` <-- `python-cattrs` <-- `python-msgspec`

Also see https://github.com/bitcoin/bitcoin/pull/34550#issuecomment-3926767282.

This [commit](https://codeberg.org/guix/guix/commit/b35905695afd2e24c56e6950433dd4f571581873) updates `python-msgspec` and removes `(supported-systems (list "x86_64-linux" "aarch64-linux"))` from its definition.

Package updates:
- `git-minimal`: 2.52.0 -> 2.54.0
- `linux-headers` 6.1.166 -> 6.1.172
- `python-lief`: 0.17.5 -> 0.17.6
- `python-minimal`: 3.11.14 -> 3.12.12

Additionally, `python-lief` and `nsis-x86_64` transitively pull in packages whose tests fail when building natively on `riscv64`:
- `python-lief`: `python-psutil`, `python-pytest-xprocess`, `python-sh`
- `nsis-x86_64`: `python-psutil`

Tests for the problematic packages are temporarily disabled.

Fixes https://github.com/bitcoin/bitcoin/issues/36232.

ACKs for top commit:
maflcko:
re-review ACK feb77d838eda70dfc27df78537da89f2b568f52c 🦏
willcl-ark:
ACK feb77d838eda70dfc27df78537da89f2b568f52c

Tree-SHA512: c89c57e0f3f8090c3eaa52cbc6b55c6564f297158afebf8306bcae692f4f5121156e64e5af3fb9e6dcb0091a9cd2d65e002854abb5befd7df6df31f1618ed280

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 20/100

This is a build-system maintenance update for Bitcoin Core's reproducible build environment (Guix). It updates the Guix time-machine commit and several dependency versions, and temporarily disables some test suites that fail when building on the RISC-V processor architecture. The change is not a security fix for Bitcoin's consensus or networking code; it is a portability fix so that builds work on RISC-V machines.

AI review queuedMerge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactionsby Ava Chow · ed7dd7cf · Sep 25, 2026 · 3 filesMessage 91 · StrongLow 32Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

c2da52d3660f178a9c11210216d295515988e89d wallet: allow importprunedfunds for spending transactions (8144225309)

Pull request description:

`importprunedfunds` only allowed importing transactions that credit the wallet
(checked via `IsMine`), rejecting transactions that spend from it. This could
leave a pruned wallet showing an incorrect balance: if a spending transaction
was removed with `removeprunedfunds`, it couldn't be re-imported and would fail
with "No addresses in wallet correspond to included transaction".

This routes the import through `AddToWalletIfInvolvingMe()`, which already
checks both `IsMine()` and `IsFromMe()`, so spending transactions are accepted
and the involvement check is no longer duplicated in `importprunedfunds`. A
functional test imports a transaction that spends from the wallet but has no
outputs to it (entire UTXO sent externally).

Fixes #21647

ACKs for top commit:
achow101:
ACK c2da52d3660f178a9c11210216d295515988e89d
Bicaru20:
re-ACK c2da52d366

Tree-SHA512: 0ece38c75d3608948f1c29c5fca29b6420197b0a153e361decf232fd27edd5dd1f2e5d6f9625eee6f7691abd9992f95ef89c904d486ee927d03c88475e479b9c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 32/100

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing transactions can be re-imported, so a pruned wallet's balance and transaction history stay accurate.

AI review queuedMerge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup optionby Ava Chow · f80aaf4b · Sep 25, 2026 · 30 filesMessage 91 · StrongLow 28Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9 [doc]: add release notes (ismaelsadeeq)
40ab7aa90de5a6382fe6f8946cde735e05308a20 [wallet]: warn when `-maxtxfee` conflicts with `-minrelaytxfee` (ismaelsadeeq)
df1feeb487dc54dc44ac8eff96650319bb3a2584 [wallet]: enforce `-maxfeerate` on wallet transactions (ismaelsadeeq)
d2c832e9e79d0f8691e64f25bcfe198ae34805d5 [util]: add a new transaction error type (ismaelsadeeq)
633c08d3f7af95953a818c645a4ad4c90f0bbdb0 [node]: update `BroadcastTransaction` to check fee rate limit (ismaelsadeeq)
7bfce65801bf5a7ae45f5f75a627e6cd03d9c8c0 [wallet]: add `maxfeerate` wallet startup option (ismaelsadeeq)
607568f2b00260ac54fd4c2c904002be17edebfd [wallet]: update `max_fee` to `max_tx_fee` (ismaelsadeeq)
6b913b6224bdafac6b83328441a347a00d7d4d06 doc: add missing verb to make sentence readable (ismaelsadeeq)
a9c39696f4be2ffe02cd78d152f4e5960692c833 scripted-diff: rename `m_default_max_tx_fee` to `m_max_tx_fee` (ismaelsadeeq)

Pull request description:

This PR fixes #29220

- The PR adds a wallet `-maxfeerate` startup option, as the upper limit of wallet transactions fee rate.

- This fixes the ambiguity of using `maxtxfee` value to check the upper limit of transactions fee rate.

- Wallet will not create a transaction with fee rate above `maxfeerate` value.

- This PR adds a functional test that ensure the behavior is enforced.

ACKs for top commit:
achow101:
ACK f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9
polespinasa:
ACK f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9

Tree-SHA512: 595f451a2fd49ca887705e16ca82373c840c610d079de893bb67fba06e8b5c78646fb723255f226fdae7a6ad57a6f2b42e5d54b07d320c5c2b3a17c943add4ab

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wallet only had -maxtxfee, which limits the total absolute fee. The change also makes the error messages clearer so users can tell whether a transaction was rejected because of the total fee or the fee rate. It is a defensive feature, not a fix for an active vulnerability, and it helps prevent users from accidentally paying extremely high per-byte fees.

AI review queuedMerge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspendsby Ava Chow · e8e7e91a · Sep 24, 2026 · 4 filesMessage 91 · StrongLow 44Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

719324977a41ab5132699d9c81032f8b2687f599 test: Check that ineligible output groups are discarded only once (Fabian Jahr)
20307f0ac0e17c6e478e2e11318dc7a9b18fc5d1 wallet: don't double count discarded output groups with avoidpartialspends (Fabian Jahr)

Pull request description:

With `-avoidpartialspends` or `avoid_reuse`, `GroupOutputs` puts every positive-value output into both the mixed and the positive-only map and runs `push_output_groups` on each, so a group rejected by the eligibility filters lands in `discarded_groups` twice. `AutomaticCoinSelection` then subtracts it twice and could fail with an insufficient funds error even when there would be enough confirmed coins to cover the payment.

Not a problem in a default wallet but it can happen with `sendtoaddress` from an `avoid_reuse` wallet, or with `-avoidpartialspends=1`.

The simplest possible fix is to record discards only from the mixed map pass, which contains every output anyway. Also adds a test that reproduces the issue.

ACKs for top commit:
achow101:
ACK 719324977a41ab5132699d9c81032f8b2687f599
pablomartin4btc:
ACK 719324977a41ab5132699d9c81032f8b2687f599
vicjuma:
ACK 719324977a41ab5132699d9c81032f8b2687f599
polespinasa:
code reviewed ACK 719324977a41ab5132699d9c81032f8b2687f599

Tree-SHA512: 3028f8feeacecc601aacfce757fc885b7bd25cf6ea2ad9d9b65c56b5da71096aa48d0d70ce04d80fc2b147d67109c47d190e5dc925d06c67dfcf33cf8cc715d8

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That double-counting could make the wallet wrongly believe there are not enough spendable coins and fail to create a transaction, even though the user actually has enough confirmed funds. The fix makes sure each rejected group is recorded only once, and adds tests to prove it.

AI review queuedMerge bitcoin/bitcoin#35675: mining: add block template managerby Ryan Ofsky · 5c726f20 · Sep 24, 2026 · 26 filesMessage 91 · StrongInformational 19Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#35675: mining: add block template manager

3d7d190b6995b3c0adb6528c2d9eac81a8f839d9 ci: enforce iwyu for block template manager (ismaelsadeeq)
ffe3a631f38b1224db8b0ea246a3c976f358c59e node: remove NodeContext::mining and EnsureMining (ismaelsadeeq)
6c71166bcfa4339d5019f2b27d477eb45ce7fe86 test: create templates via BlockTemplateManager (ismaelsadeeq)
ec4f24ef181a7987bcea72a21e507f59dc1b8126 rpc: wait for tips via BlockTemplateManager (ismaelsadeeq)
8372721f20e2ea2c15bae38a046476736169d801 rpc: build generation templates via BlockTemplateManager (ismaelsadeeq)
38556f817e060187b48cd31490f578cdf63134ee rpc: only copy the header in getblocktemplate (ismaelsadeeq)
951fac807d37302e7de5e289c0ab05f8dfcb1e1c rpc: do not copy template data in getblocktemplate (ismaelsadeeq)
0998c0bbdfcc3c3f7c105a1fb7223bace529556a rpc: build getblocktemplate via BlockTemplateManager (ismaelsadeeq)
011cbfbcd2e3a3282ae7e5afdfd923bc444d1845 rpc: route getblocktemplate internals through node (ismaelsadeeq)
400ac328c91b653e793bd140b89e8fabfb42e3ac interfaces: create block template via BlockTemplateManager (ismaelsadeeq)
037d3519f2ff9937aa82060a42939aafab4179f1 node: move tip and wait helpers into BlockTemplateManager (ismaelsadeeq)
07964c525d4769d00004b9942225a2cb1306e09d miner: move SubmitBlock into BlockTemplateManager (ismaelsadeeq)
bcdadf2b7111a061d2bbeba350233db7b258a787 node: move mining_args to BlockTemplateManager (ismaelsadeeq)
482a5d27124c4241c27ed323659914cd38409650 node: introduce BlockTemplateManager (ismaelsadeeq)

Pull request description:

This PR introduces `node::BlockTemplateManager` and moves block template
creation, submission, and mining wait helpers behind it.

#### Motivation

Instead of keeping template-related state and helper functions spread across
`NodeContext`, `miner.cpp`, the mining interface, RPC, and tests, the manager
now owns the node's init-time mining options and exposes methods needed by callers.

This also prevents some redundant copies previously done when using the mining
interface to create a block template and then retrieve the template data.

This keeps the IPC `Mining` interface focused on IPC-facing mining objects, while RPC
and tests use the block template manager directly.

#### Changes

- `NodeContext` no longer stores `BlockCreateOptions` directly.
- `BlockTemplateManager` stores the parsed init-time mining options and applies
them to unset per-call options before creating templates.
- Block submission through the mining interface is routed through
`BlockTemplateManager::SubmitBlock()`, preserving the existing
`BlockChecked` state-capture behavior.
- Tip lookup, tip waiting, cooldown, and `waitNext()` template creation helpers
are moved from miner helper functions into `BlockTemplateManager`.
- In-process RPC and tests create raw `CBlockTemplate` objects directly through
`BlockTemplateManager`, avoiding cached `BlockTemplateImpl` objects that hold
`NodeContext` references during shutdown.

#### Note: This change is intended to be a pure refactor that preserves behavior.

ACKs for top commit:
Sjors:
re-ACK 3d7d190b6995b3c0adb6528c2d9eac81a8f839d9
marcofleon:
light code review ACK 3d7d190b6995b3c0adb6528c2d9eac81a8f839d9
pablomartin4btc:
re-ACK 3d7d190b6995b3c0adb6528c2d9eac81a8f839d9

Tree-SHA512: 885af752ecd105f9813e75de87b9e022b151e5959aae3ef00de838ca4b07ce19ee24a80629dd80bb5261d4b090b4f7832f09c4d8147e4265c54c7f8926694590

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 19/100

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across several modules. The pull request description explicitly says it is intended to be a pure refactor that preserves behavior. No new user-facing feature is added and no vulnerability is evident in the diff.

AI review queuedMerge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-upsby merge-script · 248ce46f · Sep 22, 2026 · 4 filesMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-ups

a34861d280b3db81175b6692ba00ccc62edff52e test: unify how to avoid the creation of the default wallet in nodes (rkrux)
3458837a0b76fb7f5d4c2f5d9ebb9bd7818794be test: use ExtendedPrivateKey in wallet_importdescriptors.py (rkrux)

Pull request description:

Looks like a case was missed in PR #35543 that introduced the utility xprv
and xpub classes.

Also, unify how to avoid the creation of the default wallet in nodes.

ACKs for top commit:
davidgumberg:
reACK https://github.com/bitcoin/bitcoin/pull/35619/commits/a34861d280b3db81175b6692ba00ccc62edff52e
nebula-21:
ACK a34861d280b3db81175b6692ba00ccc62edff52e
sedited:
ACK a34861d280b3db81175b6692ba00ccc62edff52e

Tree-SHA512: 4ed5d2375d915bfff1898babdd7311ead15169bc1156ab5168b5c7ca2e969c850f752d36caa585b8fe856dca26f3ceb3f7a98ce091d4a8a7c38f532b87250d3f

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There is no change to the actual Bitcoin Core software that users run, so it cannot affect live wallets, transactions, or network security.

AI review queuedMerge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followupsby merge-script · 4a583f38 · Sep 19, 2026 · 9 filesMessage 100 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followups

61edcf92532502e91c2e17b8c2a23b45f5773936 test: Add 31.1 to wallet back compat (Ava Chow)
ebf2f69ee81925057cdcc881e42e861dbdf39ae5 test: Simplify miniscript descriptor check in wallet back compat (Ava Chow)
f6cbcfd98a000deb17521520074ba46965c410b1 wallet: Document WalletDescriptor::UpdateFrom (Ava Chow)
f0f6dce849634e801ac81705176ca8b96abbaa09 descriptor, doc: Clarify miniscript CompatDescriptorHash (Ava Chow)
405b1d6055e78866fe2d86ba6fb16534f9554a32 descriptor: Explicitly handle use_apostrophe cases (Ava Chow)
64abb3e8d3610449d541bfff2db23b9ace3fa111 wallet: Compare descriptors by hash of canonical string (Ava Chow)
bb5e8320d76f5175fdf86bdc4c2d24bfc1eed438 wallet: Make WalletDescriptor's descriptor const (Ava Chow)
4cc00f7bc04b4c07827728ba5ce1094b338a76a8 wallet: Remove WalletDescriptor's default constructor (Ava Chow)

Pull request description:

Instead of re-computing the canonical descriptor string for every call to `HasWalletDescriptor`. `WalletDescriptor` will now compute it once upon construction and cache the hash of that string. The comparison uses a new `WalletDescriptor::Equals` function which compares the canonical string hashes. The hash is used to avoid holding possibly a large amount of memory for a string that is rarely used. This should fix the performance regression described in https://github.com/bitcoin/bitcoin/pull/35445#issuecomment-5633483553

Also addresses several review comments related to documentation and code readability:
- https://github.com/bitcoin/bitcoin/pull/35445#discussion_r3924705885
- https://github.com/bitcoin/bitcoin/pull/35445#discussion_r3924785232
- https://github.com/bitcoin/bitcoin/pull/35445#discussion_r3925352894
- https://github.com/bitcoin/bitcoin/pull/35445#discussion_r3925462409
- https://github.com/bitcoin/bitcoin/pull/35445#discussion_r3937800942
- https://github.com/bitcoin/bitcoin/pull/35445#discussion_r3961028442

ACKs for top commit:
Sjors:
ACK 61edcf92532502e91c2e17b8c2a23b45f5773936
polespinasa:
ACK 61edcf92532502e91c2e17b8c2a23b45f5773936

Tree-SHA512: d13057cdfa89f9831950502f19159a40ca1da693f47d8ae63613fbc74b588994f6748b9124947b29ad1f035cff6650f8ae3d7396025a2363fcf3d32de002adf1

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidies up serialization code, removes a default constructor, and adds v31.1 to backwards-compatibility tests. There is no indication this fixes an exploitable security bug.

AI review queuedMerge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaultsby merge-script · 5f05d8c5 · Sep 19, 2026 · 3 filesMessage 81 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

b7f740c594ba1482344a7906b799fb62c533464f rpc: Correct OpenRPC default metadata (will)

Pull request description:

`getopenrpcinfo` emits two defaults that do not satisfy their schemas.

This changes `getdeploymentinfo.blockhash` to a default hint, since its fallback describes the current chain tip, and makes `send.options.include_watching` default to boolean `false`.

ACKs for top commit:
nervana21:
ACK b7f740c594ba1482344a7906b799fb62c533464f
sedited:
ACK b7f740c594ba1482344a7906b799fb62c533464f

Tree-SHA512: fd99c3642ff39ef13116f7f18e2a93b398e347330ea24e5bfd01744528744e5c6fbff12a56213961f8703218a6100f0ea74a10fe3b1d9a221ba8b1fa307a907a

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from the string "false" to the actual value false. It does not change how Bitcoin Core processes transactions, validates blocks, or handles money. The only risk is that tools reading the OpenRPC metadata could previously receive invalid schema examples; this patch makes those examples valid.

AI review queuedrpc: Correct OpenRPC default metadataby will · b7f740c5 · Sep 18, 2026 · 3 filesMessage 68 · AdequateInformational 20Details
Commit message · will

rpc: Correct OpenRPC default metadata

Correct six argument metadata entries that produce misleading or invalid
OpenRPC defaults.

The getdeploymentinfo blockhash fallback and four sighashtype fallbacks
describe how omitted arguments are resolved. They are not literal values
accepted by the RPCs, so mark them as DefaultHint values.

The send include_watching option is boolean, but its string default makes
the generated schema internally inconsistent. Use a boolean value,
matching the analogous sendall option.

Runtime behavior is unchanged.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is unchanged, so there is no direct security risk to users.

AI review queuedMerge bitcoin/bitcoin#36285: refactor: Use static const over inline const to work around ld64 bugby merge-script · ad97933a · Sep 17, 2026 · 2 filesMessage 93 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36285: refactor: Use static const over inline const to work around ld64 bug

fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0 refactor: Use static const over inline const to work around ld64 bug (MarcoFalke)

Pull request description:

This partially reverts fa74f58a262096f25d5a3a4ec4951f4ce2a31792 to avoid initialization dependencies, which ld64 fails to handle properly.

Works around https://github.com/bitcoin/bitcoin/issues/36281 for now.

Obviously this will increase the bin size again (70kB for me), but this shouldn't matter much.

ACKs for top commit:
janb84:
ACK fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0
sedited:
ACK fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0

Tree-SHA512: a31f3f4503dbc1898f346a5ceb94de61d82fd5902feec65f3716dc785dc199223c66cf223dcbe8a434e0a05af04bc1b0e7a066c3361deded947691c501ab0228

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures, but it does not fix any vulnerability that could be exploited by an attacker.

AI review queuedMerge bitcoin/bitcoin#34861: wallet: Add importdescriptors interfaceby Ava Chow · 2bbbeaa6 · Sep 17, 2026 · 15 filesMessage 91 · StrongInformational 23Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#34861: wallet: Add importdescriptors interface

2c249dbdf5c9d8c7dd71ac90ea29a8b52ec4b2ba wallet: Add an importDescriptors() interface for the wallet (Pol Espinasa)
3be5f401370ee18dc263149c8a23a33cba9baef5 wallet: add CheckDescriptorRangeBounds (Pol Espinasa)
a9cd985d0a54877ef3ba9b844f725a2d3065f1bb wallet: Move ImportDescriptor and ProcessDescriptorsImport to imports.cpp (Pol Espinasa)
c9650d8f0e2f664b4f4362a42e8dfc7efc82af18 wallet: rename ProcessDescriptorImport to ImportDescriptor and add ProcessDescriptorsImport (Pol Espinasa)
a40ee4ec26590c4e485f5bb0155d90b4438ee590 wallet: rpc: refactor: ProcessDescriptorImport returns ImportDescriptorResult (Pol Espinasa)
48d3d717fb6e3f61acbaf867404e51a1cac77e78 wallet, util: Add HandleWalletErrorCode (Pol Espinasa)
04c73a91d2cc4165b90dc43b8932b128b8e1923f wallet: Add ImportError struct and new WalletError codes (Pol Espinasa)
975215618505e2d62c17cb63ce94ca2a72e79ffc wallet: rpc: refactor: Extract UniValue processing from ProcessDescriptorImport (Pol Espinasa)
f1f61af357275f277c169e895d39699f918ef7aa wallet: Add ImportDescriptorRequest structs (Pol Espinasa)
7375124f4c9a7d998bf6e0f1eed3975f0ea761e3 wallet: refactor: make is_ranged no longer an optional (Pol Espinasa)
90485103c67d2454efa10743b1a2e6d844f74c58 wallet: lower the minimum timestamp to 0 (Pol Espinasa)
380d3ae0deab72c2652b3290bfe00195cca4f8e9 wallet: rpc: Use std::optional in GetImportTimestamp (Pol Espinasa)

Pull request description:

This PR adds an interface for importing descriptors.

The motivation behind this is that currently, importing descriptors is only possible via RPC. Bitcoin Core GUI doesn't use the RPC interface so it cannot offer descriptor import functionality, which is needed to support more complex wallet setups such as multisig.

This PR also adds a refactor by moving the `importdescriptors` logic from the RPC layer into `CWallet::ImportDescriptor`, making it reusable by both the RPC and this new interface.

The main changes are:

- Introduces `CWallet::ImportDescriptor()` containing the core import logic, previously embedded in the RPC `ProcessDescriptorImport` function.
- Introduces `wallet::ImportDescriptorResult`, a new result struct that carries success status, error message, warnings, and a `FailureReason` enum. The RPC layer uses `FailureReason` to map results back to the appropriate JSON-RPC error codes, keeping RPC concerns out of `CWallet`.
- Updates `ProcessDescriptorImport` in `rpc/backup.cpp` to delegate to `CWallet::ImportDescriptor`.
- Adds `interfaces::Wallet::importDescriptors()` as a new interface method, allowing the GUI to import descriptors without going through RPC.

I have a GUI menu here: https://github.com/polespinasa/bitcoin/pull/7 so it can be tested. I will open a PR against the main GUI repo, once this gets merged.

ACKs for top commit:
achow101:
re-ACK 2c249dbdf5c9d8c7dd71ac90ea29a8b52ec4b2ba
w0xlt:
reACK 2c249dbdf5c9d8c7dd71ac90ea29a8b52ec4b2ba
arejula27:
reACK 2c249dbdf5c9d8c7dd71ac90ea29a8b52ec4b2ba

Tree-SHA512: fa6fefc404c1015793cf5da53fe8a4352bbe46865eeb5c65d95afb3fa897667956ed9b912a11163dc7194b10bcb9f6b74211622c846e57908524e910a3c5a2ef

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100

This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the minimum allowed timestamp is changed from 1 to 0. There is no direct evidence in the commit of a security vulnerability; it appears to be a normal feature/refactor change. The small behavior change around timestamps is a stricter validation, not a weakening.

AI review queuedMerge bitcoin/bitcoin#36260: torcontrol: Use reconnect backoff after dropped connectionsby merge-script · fb68c270 · Sep 16, 2026 · 2 filesMessage 100 · StrongLow 30Details
Commit message · merge-script

Merge bitcoin/bitcoin#36260: torcontrol: Use reconnect backoff after dropped connections

4556ef62675400a4702d73c0a3e1dd4c7061a077 torcontrol: Apply reconnect backoff after dropped connections (Fabian Jahr)

Pull request description:

Since #34158 the reconnect backoff was only applied when connecting to the Tor control port failed. When an established connection was dropped, for example by Tor closing it after a failed `AUTHENTICATE` because of a wrong password, the control thread reconnected immediately in a loop without any wait. This was resulting in us trying to make tons of connections to torcontrol and producing tons of log entries in very short time. The fix restores the pre-#34158 behavior where every reconnect waits for the backoff timeout by going through `disconnected_cb`, which now also does the waiting. Also adds a functional test to cover that the waiting behavior is actually applied.

ACKs for top commit:
willcl-ark:
reACK 4556ef62675400a4702d73c0a3e1dd4c7061a077
winterrdog:
tACK 4556ef62675400a4702d73c0a3e1dd4c7061a077
sedited:
ACK 4556ef62675400a4702d73c0a3e1dd4c7061a077

Tree-SHA512: bfc4cee5f2f5cd9d7c251ca4f1201a32bff05340986500a9b883dc80c73ddf313a4ae611cefcc3abf463ec6b729264d41794608175644d1d064d53985543e815

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 30/100

This change fixes a bug in how Bitcoin Core reconnects to the Tor control port. A previous update accidentally removed the wait time between reconnect attempts when an already-established Tor control connection was dropped. Without the wait, Bitcoin Core would rapidly reconnect in a tight loop, creating a flood of connection attempts and log messages. The fix restores the intended pause between reconnect attempts. It is primarily a denial-of-service/operational-stability issue for the local node, not a remote code execution or theft vulnerability.

AI review queuedMerge bitcoin/bitcoin#36083: test: cover getrawtransaction on a stale block via txindexby merge-script · dd3c62c5 · Sep 14, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36083: test: cover getrawtransaction on a stale block via txindex

793e22eed586306d41e05811f749da6cbe29f3de test: cover getrawtransaction on a stale block via txindex (Íñigo Aréjula Aísa)
a84fbf9dfd2cc173499fdc6b2267246cf9403292 test: name the getrawtransaction test nodes (Íñigo Aréjula Aísa)

Pull request description:

<!--
*** Please remove the following help text before submitting: ***

Pull requests may be closed immediately if they:
- do not have a rationale and clear improvement
- do not adhere to doc/AI_POLICY.md

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui first.
See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or
functional tests (see `test/`). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
* Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
* Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Bitcoin Core, if possible.
* Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they *significantly* improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the [developer notes](/doc/developer-notes.md), stylistic code
changes are usually rejected.
-->

<!--
Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.
-->
This checks the `txindex` as the only possible source for a transaction in a stale block. **The response of `getrawtransaction `is checked to report that block as stale: confirmations 0, no time, no blocktime**.

It uses one transaction that cannot come back to the mempool once the block is disconnected: the block's coinbase which is asserted to be out of the mempool.

I didn't find an existing test that reaches the index this way.

ACKs for top commit:
l0rinc:
ACK 793e22eed586306d41e05811f749da6cbe29f3de
sedited:
ACK 793e22eed586306d41e05811f749da6cbe29f3de

Tree-SHA512: ec1df499f4ddaf30e5667c6ec9e8f94c54635040485f16d7b911785d2b9fdc52e9a59f3865f1707d250032c8c2b89d5f988c76d0cccb684366f683a849bd71a9

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new functional test to Bitcoin Core. It checks that the getrawtransaction RPC can retrieve a stale block's coinbase transaction via the optional txindex, and that the response correctly shows the block is no longer in the active chain (confirmations 0, no time/blocktime). There is no change to production code, no bug fix, and no security patch.

AI review queuedMerge bitcoin/bitcoin#35472: test: add coverage for feebumper uncomputable cluster error pathby merge-script · 36c1b149 · Sep 14, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35472: test: add coverage for feebumper uncomputable cluster error path

47632ab2a3876825576b3f07e6f80e799e6ed58f test: add coverage for feebumper uncomputable cluster error path (Henry Romp)

Pull request description:

Add functional test coverage for the error path in `CheckFeeRate()` when `calculateCombinedBumpFee()` returns `nullopt` because unconfirmed inputs span more than 500 mempool transactions (`CTxMemPool::GatherClusters` DoS limit).

The crash on this path was fixed in #34870; this PR adds the missing test requested in #34902.

The test builds eight independent 64-transaction clusters (512 total, above the 500 limit), keeps a wallet-owned RBF transaction that spends one output from each cluster out of the mempool, and asserts that `bumpfee` with an explicit `fee_rate` returns the expected wallet error instead of proceeding with an empty optional.

Closes #34902.

## Testing
- [ ] `./build/test/functional/wallet_bumpfee.py`
- [ ] Temporarily removed the early return in `CheckFeeRate()` and confirmed the test fails with `bad optional_access` instead of the expected error message

ACKs for top commit:
rapennas:
Tested ACK 47632ab2a3
furszy:
ACK 47632ab2a3876825576b3f07e6f80e799e6ed58f
sedited:
ACK 47632ab2a3876825576b3f07e6f80e799e6ed58f

Tree-SHA512: d44e774579131a476654f6ba26cd349c5a02c6a6a41bafdaca6727646ffe1083f49a2e4448fb4a8ef73638ca086bf9f4ffeaba18bb819c22e20a7d79a5bc49d2

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new automated test to Bitcoin Core. It does not change any production wallet, mempool, or node code. The test verifies that when a user tries to bump the fee of a transaction whose unconfirmed inputs depend on too many other unconfirmed transactions (more than 500), the wallet returns a clear error message instead of crashing. The underlying crash was already fixed in an earlier pull request; this change simply adds the missing test coverage.

AI review queuedMerge bitcoin/bitcoin#36081: rpc: add bestblockhash to getmininginfoby merge-script · 7c4facb5 · Sep 14, 2026 · 4 filesMessage 81 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36081: rpc: add bestblockhash to getmininginfo

74e1cd38f2a381977b5e46fab6bb15ca17efd349 rpc: add bestblockhash to getmininginfo (Jakub Trnka)

Pull request description:

I'm working with pool side mining software.

I noticed there is a race condition between obtaining bestblockhash and next block nbits.
The chaintips may change.

I thought it might be useful to include bestblockhash in `getmininginfo` rpc response.

ACKs for top commit:
Sjors:
re-ACK 74e1cd38f2a381977b5e46fab6bb15ca17efd349 (just the release note file rename)
ismaelsadeeq:
Code review ACK 74e1cd38f2a381977b5e46fab6bb15ca17efd349
pablomartin4btc:
ACK 74e1cd38f2a381977b5e46fab6bb15ca17efd349
sedited:
ACK 74e1cd38f2a381977b5e46fab6bb15ca17efd349

Tree-SHA512: 9b2e897e03e3405eeb8855041c14efa9929233685218c015e74569328d0fd6bba8ba41f36d12d970041780fd7d24619437afb19e723a69c8e432a4015e31007a

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 20/100

This commit adds a new 'bestblockhash' field to the getmininginfo RPC response in Bitcoin Core. It is a feature enhancement, not a security fix. The change lets mining software read the current chain tip hash and the next block's difficulty bits in a single API call, avoiding a harmless race where the chain tip might change between two separate calls. There is no vulnerability being patched.