Bitcoin Core

rpc: fix race condition in gettxoutsetinfo

Fix an assertion failure in gettxoutsetinfo (issue #34263) caused by
capturing the best block before releasing cs_main, then checking it
against a potentially newer best block in GetUTXOStats().

Remove the early pindex capture since ComputeUTXOStats() independently
fetches the current best block under lock. Use stats.hashBlock and
stats.nHeight (the actual computed values) instead of the potentially
stale pindex when building the response.

fuzz: Use NodeClockContext

This refactor does not change any behavior.

However, it is nice to know that no global mocktime leaks from the fuzz
init step to the first fuzz input, or from one fuzz input execution to
the next.
With the clock context, the global is re-set at the end of the context.

qt: 31.0 translations update

walletdb: hash pubkey/privkey in one shot to avoid leaking secret data

Avoid storing the privkey in a vector, which could linger in memory
and potentially leak sensitive data. An alternative approach is to
use `secure_allocator` for the `std::vector` instances, but this
commit has the advantage of also deduplicating code at the same shot.

Thanks to @theuni for suggesting this.

refactor: improve benchmark setup and execution for various tests

Note that `make_hard_case` already clears the UTXO pool in `coin_selection.cpp`.

./build/bin/bench_bitcoin -filter='^(BnBExhaustion|AddrManAddThenGood|DeserializeBlockTest|DeserializeAndCheckBlockTest|CheckBlockTest|LoadExternalBlockFile|FindByte|WalletCreatePlain|WalletCreateEncrypted|WalletLoadingDescriptors)$'

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 15,088,500.00 | 66.28 | 0.2% | 0.17 | `AddrManAddThenGood`
| 179,208.00 | 5,580.11 | 2.0% | 0.00 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 318,166.00 | 3,143.01 | 3.5% | 0.00 | `CheckBlockTest`
| 886,750.00 | 1,127.71 | 0.8% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 42.00 | 23,809,523.81 | 2.4% | 0.00 | `FindByte`
| 5,473,208.00 | 182.71 | 0.4% | 0.06 | `LoadExternalBlockFile`
| 584,168,041.00 | 1.71 | 0.3% | 6.43 | `WalletCreateEncrypted`
| 168,040,458.00 | 5.95 | 1.1% | 1.85 | `WalletCreatePlain`
| 155,446,625.00 | 6.43 | 0.7% | 0.78 | `WalletLoadingDescriptors`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 14,894,917.00 | 67.14 | 0.3% | 0.16 | `AddrManAddThenGood`
| 177,667.00 | 5,628.51 | 1.3% | 0.00 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 313,791.00 | 3,186.83 | 3.8% | 0.00 | `CheckBlockTest`
| 888,208.00 | 1,125.86 | 0.7% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 41.00 | 24,390,243.90 | 2.4% | 0.00 | `FindByte`
| 5,445,208.00 | 183.65 | 1.0% | 0.06 | `LoadExternalBlockFile`
| 581,800,500.00 | 1.72 | 0.4% | 6.40 | `WalletCreateEncrypted`
| 166,035,583.00 | 6.02 | 0.5% | 1.82 | `WalletCreatePlain`
| 153,574,792.00 | 6.51 | 0.1% | 0.77 | `WalletLoadingDescriptors`

bench: add fluent API for untimed setup steps in `nanobench`

Some benchmarks need per-epoch state reset so every measured run does the same work.
Add `Bench::setup(...).run(...)` for untimed per-epoch setup.
The existing `run()` now delegates to `runImpl()` with an empty setup lambda, keeping the old API unchanged.

This vendors the upstream change from `martinus/nanobench`.
The upstream PR also adds tests that verify setup is excluded from timing and runs once before each epoch's iterations.
Those tests are not copied here because wiring them into `src/bench/nanobench.h` outside the benchmarking setup would be awkward.

The `Default is 1ms, so we are mostly relying ...` comment update matches current upstream `nanobench` master.

-------

Running a few benchmarks (which will be migrated in the next commit to use the new setup method) several times to showcase the spread:

./build/bin/bench_bitcoin -filter='^(BnBExhaustion|AddrManAddThenGood|DeserializeBlockTest|DeserializeAndCheckBlockTest|CheckBlockTest|LoadExternalBlockFile|FindByte|WalletCreatePlain|WalletCreateEncrypted|WalletLoadingDescriptors)$'

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 26,400,542.00 | 37.88 | 0.4% | 0.29 | `AddrManAddThenGood`
| 189,075.00 | 5,288.91 | 0.4% | 0.01 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 1,237,000.00 | 808.41 | 2.4% | 0.01 | `DeserializeAndCheckBlockTest`
| 893,333.00 | 1,119.40 | 0.6% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 31.62 | 31,622,370.70 | 0.2% | 0.01 | `FindByte`
| 5,506,875.00 | 181.59 | 1.4% | 0.06 | `LoadExternalBlockFile`
| 593,480,333.00 | 1.68 | 0.4% | 6.53 | `WalletCreateEncrypted`
| 174,305,167.00 | 5.74 | 0.7% | 1.93 | `WalletCreatePlain`
| 160,833,875.00 | 6.22 | 0.2% | 0.80 | `WalletLoadingDescriptors`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 26,005,125.00 | 38.45 | 1.3% | 0.29 | `AddrManAddThenGood`
| 181,909.67 | 5,497.23 | 0.1% | 0.01 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 1,223,000.00 | 817.66 | 2.8% | 0.01 | `DeserializeAndCheckBlockTest`
| 892,917.00 | 1,119.92 | 0.7% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 31.58 | 31,660,608.70 | 0.5% | 0.01 | `FindByte`
| 5,612,750.00 | 178.17 | 1.1% | 0.06 | `LoadExternalBlockFile`
| 594,012,250.00 | 1.68 | 0.2% | 6.53 | `WalletCreateEncrypted`
| 174,668,334.00 | 5.73 | 0.8% | 1.92 | `WalletCreatePlain`
| 158,494,375.00 | 6.31 | 0.3% | 0.79 | `WalletLoadingDescriptors`

test: Fix intermittent issue in wallet_assumeutxo.py

prevector: simplify `operator==`

doc: add release notes

policy: update `AreInputsStandard` to return error string

This commit renames AreInputsStandard to ValidateInputsStandardness.

ValidateInputsStandardness now returns valid TxValidationState if all inputs
(scriptSigs) use only standard transaction forms else returns invalid
TxValidationState which states why an input is not standard.

test: avoid interface_ipc.py race and null pointer dereference

Avoid race condition in run_deprecated_mining_test caused by creating and
immediately destroying an unused worker thread. This leads to test failures
reported by maflcko in #34711

test: improve `wallet_backup` test

Remove the unused functions that were ported many years back.

test: improve `wallet_assumeutxo` func test

Reduce the number of blocks that need to be generated before pruning
the blockchain.

Unload the wallet that was restored in a prior test because it is not
needed anymore after the test.

Both the above steps should reduce the number of chain notifications
that need to be processed by the wallet(s) when an erroneous scenario
of restoring wallet is checked.

doc: Improve dependencies.md IPC documentation

Improve dependencies.md to document IPC dependencies better:

- Link to native_capnp.mk file not capnp.mk file so it's possible to see what
version of Cap'n Proto is being used in release binaries. This is important
since #31895 dropped the "Version Used" column and the capnp.mk file does not
include version number.
- Indicate Capn"Proto is used for IPC and link to multiprocess.md documenting
the feature.
- Link to correct PR requiring Cap'n Proto 0.7.1. Previous link was
pointing at PR which required 0.7.0.
- Mention libmultiprocess as a dependency even though it is included as a git
subtree and can be built as a cmake subproject. Libmultiprocess still needs
to be built separately when cross compiling, and is useful to build separately
when developing, and is still a depends package.

Based on 2cf352fd8e6a77003e38d954b6c879b20d4b960a from #33623 by willcl-ark
which made similar changes in the 29.x branch.

refactor: Add ExecuteHTTPRPC function

Add ExecuteHTTPRPC to provide a way to execute an HTTP request without relying
on HTTPRequest and libevent types.

Behavior is not changing in any way, this is just moving code. This commit may
be easiest to review using git's --color-moved option.

fuzz: wallet: add target for `MigrateToDescriptor`

wallet: Drain validation interface queue after notifications disconnect

When unloading a wallet, there may be unexecuted callbacks in the
validation interface queue that can still execute after we have
completed all of the other wallet shutdown tasks. Instead of letting
these run in the background, once the notifications are disconnected,
wait for the queue to drain before continuing with wallet shutdown.

doc: Use relative markdown links

test: add test for rebroadcast of transaction received via p2p

The wallet doesn't only rebroadcast transactions it created, but
also relevant transactions received via p2p. Since this is not
self-evident, add test coverage for it.

test: refactor, decouple HasReason from test framework machinery

Avoid providing the entire unit test framework dependency to tests that only
require access to the HasReason utility class.

E.g. reverselock_tests.cpp, sync_tests.cpp, util_check_tests.cpp, util_string_tests.cpp,
and script_parse_tests.cpp only require access to HasReason and nothing else.

kernel: Update headerssync params

kernel: update chainTxData

Squashed 'src/ipc/libmultiprocess/' changes from 1fc65008f7d..1868a84451f

1868a84451f Merge bitcoin-core/libmultiprocess#245: type-context.h: Extent cancel_mutex lock to prevent theoretical race
fd4a90d3103 Merge bitcoin-core/libmultiprocess#244: ci: suppress two tidy lint issues
16dfc368640 ci: avoid bugprone-unused-return-value lint in test
dacd5eda464 ci: suppress nontrivial-threadlocal lint in proxy.cpp
ef96a5b2be2 doc: Comment cleanups after #240
e0f1cd76219 type-context.h: Extent cancel_mutex lock to prevent theoretical race
290702c74ce Merge bitcoin-core/libmultiprocess#240: Avoid errors from asynchronous (non-c++) clients
3a69d4755af Merge bitcoin-core/libmultiprocess#241: doc: Bump version number v7 -> v8
0174450ca2e Prevent crash on unclean disconnect if abandoned IPC call returns interface pointer
ddb5f74196f Allow simultaneous calls on same Context.thread
c4762c7b513 refactor: Add ProxyServer<Thread>::post() method
0ade1b40ac5 doc: Bump version number

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 1868a84451fe1b6a00116375a5f717230bb2533e

threadpool: guard against Start-Stop race

Stop() has two windows where Start() could cause troubles:

1) m_workers is temporarily empty while workers are being joined,
this creates a window where Start() could slip through and reset
m_interrupt to false, preventing the old workers from exiting and
causing a deadlock.

2) Start() could be called after workers are joined but before the
empty() sanity check on m_work_queue, causing a crash.

Fix both races by keeping m_interrupt set for the entire duration
of Stop(), so any concurrent Start() call is rejected until all
workers have exited.

Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>

clusterlin: rescale costs (preparation)