What changed, and why it matters
This commit only cleans up an unused helper functions in a test file and fixes a grammar typo in a comment. It does not change any production code, network behavior, or wallet logic, so it has no security relevance.
No action needed; this is a routine test-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff removes three unused Python helper methods (start_three, stop_three, erase_three) from test/functional/wallet_backup.py and corrects a comment typo (‘assume’ → ‘assumes’). No runtime code in Bitcoin Core is modified.
Changed components
test/functional/wallet_backup.pyInspect captured patch +1 / −20
diff --git a/test/functional/wallet_backup.py b/test/functional/wallet_backup.py
index 06b8799d..14aa31ce 100755
--- a/test/functional/wallet_backup.py
+++ b/test/functional/wallet_backup.py
@@ -91,25 +91,6 @@ class WalletBackupTest(BitcoinTestFramework):
self.sync_mempools()
self.generate(self.nodes[3], 1)
- # As above, this mirrors the original bash test.
- def start_three(self, args=()):
- self.start_node(0, self.extra_args[0] + list(args))
- self.start_node(1, self.extra_args[1] + list(args))
- self.start_node(2, self.extra_args[2] + list(args))
- self.connect_nodes(0, 3)
- self.connect_nodes(1, 3)
- self.connect_nodes(2, 3)
- self.connect_nodes(2, 0)
-
- def stop_three(self):
- self.stop_node(0)
- self.stop_node(1)
- self.stop_node(2)
-
- def erase_three(self):
- for node_num in range(3):
- (self.nodes[node_num].wallets_path / self.default_wallet_name / self.wallet_data_filename).unlink()
-
def restore_invalid_wallet(self):
node = self.nodes[3]
invalid_wallet_file = self.nodes[0].datadir_path / 'invalid_wallet_file.bak'
@@ -191,7 +172,7 @@ class WalletBackupTest(BitcoinTestFramework):
self.log.info("Test loading backup on a pruned node when the backup was created close to the prune height of the restoring node")
node = self.nodes[3]
self.restart_node(3, ["-prune=1", "-fastprune=1"])
- # Ensure the chain tip is at height 214, because this test assume it is.
+ # Ensure the chain tip is at height 214, because this test assumes it is.
assert_equal(node.getchaintips()[0]["height"], 214)
# We need a few more blocks so we can actually get above an realistic
# minimal prune height
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.