BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 41 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge bitcoin/bitcoin#36805: Enclose all header content in include guardsby merge-script · 36be848e · Nov 10, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36805: Enclose all header content in include guards

ca14da90250fb5211983021a754473cde194d59e lint: Require all code in a header to be inside its include guard (Hennadii Stepanov)
00e1f35524ac52e3936db1f1d9ba44fda4911544 Enclose all header content in include guards (Hennadii Stepanov)

Pull request description:

From https://gcc.gnu.org/onlinedocs/cpp/Once-Only-Headers.html:
> If a header file happens to be included twice, the compiler will process its contents twice. This is very likely to cause an error, e.g. when the compiler sees the same structure definition twice. Even if it does not, it will certainly waste time.

This PR fixes the three headers that have content outside their guards and modifies [`test/lint/lint-include-guards.py`](https://github.com/bitcoin/bitcoin/blob/master/test/lint/lint-include-guards.py) to catch such violations in the future.

A prerequisite for https://github.com/bitcoin/bitcoin/pull/36808.

ACKs for top commit:
maflcko:
review ACK ca14da90250fb5211983021a754473cde194d59e 🖨

Tree-SHA512: 79a3e7591d4393343df9dcd39d48fe637d62b640e4dad71079fdc2bbbbcf2c01db36c3de77e82d26f90bbc0bdd2864f0e289eb45536f9df9f6e797ee7467874d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code-quality cleanup, not a security fix. It moves include guards in three header files so they wrap all content, and updates a lint script to enforce that rule going forward. Include guards prevent the compiler from accidentally processing the same header twice, which avoids build errors and wasted compile time. There is no runtime security impact.

AI review queuedMerge bitcoin/bitcoin#36810: test: construct `miner_tests` transactions declarativelyby merge-script · 0b9c2c30 · Nov 10, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36810: test: construct `miner_tests` transactions declaratively

8d33ffe47e38ebf84e2c832d426d307484a8d342 test: construct miner_tests sigops transactions declaratively (yuvicc)
b2ce6c1727e762cd63eb5353df52a529861d8af8 test: construct miner_tests package selection transactions declaratively (yuvicc)

Pull request description:

Part of #36692.

Add `MakeTx()` and use it in `TestPackageSelection` and `TestPrioritisedMining` so each transaction is fully specified where it is created, instead of overwriting the `prevout` and `nValue` of the previous one. Also build the `CreateBigSigOpsTx()` and `CreateBigSigOpsCluster()` transactions in place.

One implicit dependency is now explicit: BulkTransaction() pads the output script of hashFreeTx2, and the next two transactions inherited it. Their size matters for the fee rate checks, so the padded script is now passed to `MakeTx()` explicitly.

The txid, wtxid and fee of every transaction added to the mempool are unchanged.

ACKs for top commit:
purpleKarrot:
ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342
alexanderwiederin:
ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342
maflcko:
review ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342 🦆

Tree-SHA512: ce4a052769e3dc78e1ba2aacded671c61a226fa5e501e07e4ab2325421abae78cdc8a6e3b3731983db0cbe8cb9f8e9ba5c291bda9481ed94d4c7ce266b09d51c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit is a pure test-code cleanup. It refactors how fake transactions are built in Bitcoin Core's miner unit tests, making them more explicit and easier to read. It does not change any production code, network behavior, or transaction hashes used in the tests.

AI review queuedEnclose all header content in include guardsby Hennadii Stepanov · 00e1f355 · Nov 10, 2026 · 3 filesMessage 45 · ThinInformational 20Details
Commit message · Hennadii Stepanov

Enclose all header content in include guards

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit fixes the placement of include guards in three C++ header files. Include guards prevent the same header from being processed multiple times, which avoids compilation errors and can prevent subtle bugs from duplicate definitions. The changes are purely structural code-quality fixes with no direct security exploit path.

Security candidateMerge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertionsby merge-script · 232cb541 · Nov 10, 2026 · 95 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertions

fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4 scripted-diff: [test] Sort includes (MarcoFalke)
fa3d6b0cf1e37f87b063edc6a159f96b35701884 scripted-diff: [fuzz] Add util/check.h includes for Assert (MarcoFalke)

Pull request description:

In test code, `assert` is used. This is perfectly fine, but sometimes confusion arises, when it is unclear whether `NDEBUG` can disable the assertions, or whether to use `assert` or `Assert`.

Avoid that confusion in test code with a scripted replacement to add the util/check.h include. The changes here will also make it easier to run IWYU.

Scope: This change is only about test code (fuzz), other code can be done later, if there is need to.

ACKs for top commit:
hebasto:
ACK fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4.

Tree-SHA512: ca0d180adc67ddff2e571393dbd35345917137699e44a8b67da653e6b75419593c4b7f78229c4cd46a48973af0cae64887ae5fcb0fdade5d9f1e5415dbe288d1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencecryptography-sensitive pathsigning or wallet pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine cleanup of Bitcoin Core's fuzz test files. It adds the include for util/check.h (which provides the project's own Assert macro) and removes or reorders some standard C assert includes. The changes only affect test/fuzz code, not the live Bitcoin node software, and the commit message explicitly says the goal is to reduce developer confusion and improve automated include checking. There is no security fix or vulnerability here.

AI review queuedMerge bitcoin/bitcoin#36815: doc: Fix Doxygen attribution of file-level commentsby merge-script · 229e7932 · Nov 10, 2026 · 12 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36815: doc: Fix Doxygen attribution of file-level comments

c4a68cc5ceb62ac160b7adc44ebf6388aa803ed5 doc: Attach `subprocess.h` header comment to the file (Hennadii Stepanov)
4cb432772c45e791209d96d893f6f7145096b748 doc: Fix `@file` descriptions that start with the file name (Hennadii Stepanov)
c7ebbbba6c9b81e9d38ec27a79ea57be487d0b59 doc: Fix Doxygen attribution of file-level comments (Hennadii Stepanov)

Pull request description:

Doxygen attaches a comment block that lacks a `@file` command to the next declaration rather than to the file.

For example:
<img width="742" height="265" alt="image" src="https://github.com/user-attachments/assets/eb555197-eb33-41e8-abcb-3a03afa8a5ff" />

This PR fixes that.

Requested in https://github.com/bitcoin/bitcoin/pull/36805#discussion_r4511737767:
> ... they are wrong, ... it may be best to fix them instead of ignoring them?

Required for https://github.com/bitcoin/bitcoin/pull/36805.

ACKs for top commit:
fanquake:
ACK c4a68cc5ceb62ac160b7adc44ebf6388aa803ed5

Tree-SHA512: f2f1402c61c7e114b3ccd502eac90542321892bbe985b95671c3c551b8f227b9c5b07ad57364fee37b61fd7d636545264df7edb4d52acf72b166f30fcf8d568f

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes documentation comments in 12 source-code header files so that the Doxygen documentation generator correctly attributes file-level descriptions. No program logic, compiled code, or security behavior is changed. There is no security risk.

AI review queueddoc: Fix `@file` descriptions that start with the file nameby Hennadii Stepanov · 4cb43277 · Nov 9, 2026 · 7 filesMessage 73 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

doc: Fix `@file` descriptions that start with the file name

Doxygen treats the word after `@file` as the name of the documented
file and drops it from the text. Use a bare `@file` and `@brief`
instead.

Co-Authored-By: fanquake <fanquake@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a pure documentation fix. It changes how Doxygen (a tool that generates documentation from source code comments) interprets file descriptions in seven header files. There is no change to actual program code, behavior, or security.

Security candidateMerge bitcoin/bitcoin#36788: test, bench: construct inputs/outputs declaratively in txpackage, duplicate_inputs and p2sh testsby merge-script · 4ef7904c · Nov 8, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36788: test, bench: construct inputs/outputs declaratively in txpackage, duplicate_inputs and p2sh tests

a4a2647834ad0cc4576b2eb38bddf02c42081173 test: construct script_p2sh_tests inputs/outputs declaratively (yuvicc)
7fc7d26e7507ad753cbcab2698404debcf63ca71 bench: construct duplicate_inputs inputs/outputs declaratively (yuvicc)
5336eaa7fa70c55fe4a137df721e691e61b80131 test: construct txpackage_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. Follow-up to #36750

Replaces field-by-field construction of inputs and outputs with `COutPoint`, `CTxIn` and `CTxOut` ctor calls in `txpackage_tests`, `bench/duplicate_inputs` and `script_p2sh_tests`.

`CMutableTransaction` is kept as the builder while a `CTransaction` constructor is discussed in #36696. Witnesses are still assigned after `vin`, since `CTxIn` has no witness argument yet.

Test-only; the constructed transactions are unchanged.

- `script_p2sh_tests`: two outputs created by `vout.resize(1)` never had a value, so their null `nValue` (`-1`) is now explicit.
- Intentional mutations are left as they are: the `scriptSig` swap in `sign`, the dummy signing in `ValidateInputsStandardness`, and the witness-only copies in `txpackage_tests` (`mtx_child2`, `mtx_parent2_v2`).

ACKs for top commit:
alexanderwiederin:
ACK a4a2647834a
purpleKarrot:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173
maflcko:
review ACK a4a2647834ad0cc4576b2eb38bddf02c42081173 👒
janb84:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173
jpk68:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173

Tree-SHA512: ca452697a5bcccfbed2778785906f75c22e95fea04a1e79fb2d6fdae80ebe4badf5d8cb49a8b6add6e80a480b4826436caaee43ec534d4e6aae22f6584935b86

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a cleanup of Bitcoin Core's internal test and benchmark code only. It changes how dummy transactions are built in three test files, making the code more readable without changing what the transactions actually are. There is no change to the live Bitcoin network code, no security fix, and no vulnerability introduced.

AI review queuedMerge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarationsby Hennadii Stepanov · c6dcda33 · Nov 7, 2026 · 7 filesMessage 81 · StrongInformational 16Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarations

5f972485ffd139852d5d64a38079ab500f8a4c7c http: use MockableSteadyClock::time_point in ShouldDisconnect declaration (fanquake)
bad11ff68ec276c8c1415331e4b0d67ec84766a4 qt: remove undefined BanTableModel::{start,stop}AutoRefresh (fanquake)
0ae65892445d00e9cbaebf220cc70f63140a52fb rpc: remove undefined RPCResult::ToStringObj and ToDescriptionString (fanquake)
3fa42941d16fc76e346152d690cdf96fa031d60d common: make FeeModeInfo static, remove mismatched declaration (fanquake)
410843a684d8258c57aa55d7bc2b4e53a67de9ca rpc: make AddInputs static, remove mismatched declaration (fanquake)

Pull request description:

Remove or fix function declarations that don't match any definition.

Split out of #36743. Ideally we can have the compiler enforce/flag this in future.

ACKs for top commit:
maflcko:
review ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c 🏈
sedited:
ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c
hebasto:
ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c, I have reviewed the code and it looks OK.

Tree-SHA512: aaab43a8c79834b8a55a3c40e3f6a1f07a7454dcac9e00c3a09e3d95ab26dfd93290a3f62e2f84e79ccb917b0b1bedd2f9fd04bc9c736f76430fee33174f4175

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 16/100

This is a routine code cleanup that removes or fixes function declarations which did not match any actual function definition. It does not change program behavior, fix a bug, or close a security hole. Two helper functions were made 'static' (only usable inside their own source file), two unused declarations were removed from headers, and one declaration was updated to use the exact same type as its definition. There is no security impact.

AI review queuedMerge bitcoin/bitcoin#36378: test: Add SKIP_WRITE edge case to wallet_startupby merge-script · cabee965 · Nov 6, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36378: test: Add SKIP_WRITE edge case to wallet_startup

774dd9b034b3930dd1b5eba350558acc1d9da03c test: Add SKIP_WRITE edge case to wallet_startup (Aaron Leeb)

Pull request description:

Verifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.

This improves test coverage for the dynamic settings logic introduced in [#36176](https://github.com/bitcoin/bitcoin/pull/36176) by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.

This specific edge case was suggested by contributor jeanpablojp [here](https://github.com/bitcoin/bitcoin/pull/36176#discussion_r3944837660).

ACKs for top commit:
mercie-ux:
ACK 774dd9b
sedited:
ACK 774dd9b034b3930dd1b5eba350558acc1d9da03c

Tree-SHA512: 01cde53303e94dbecc9c0f69bb2c816f7faac08f4218dc81e8f37ed1b276104a7e12d212714751d60b998a3a6ca20837ef64e296932b2b7c7f23b4ab534dfd00

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new test case to Bitcoin Core's functional test suite. It checks that reloading a wallet already marked to start automatically does not trigger an unnecessary settings write or warning when settings are disabled. There is no change to production code, no bug fix, and no security-relevant behavior change.

Security candidateMerge bitcoin/bitcoin#36591: test: deduplicate PSBT unknown-field coverage in `rpc_psbt.py`by merge-script · 654d74cc · Nov 6, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36591: test: deduplicate PSBT unknown-field coverage in `rpc_psbt.py`

ef4310097bd651497a98a9d1bb59560a7055ae01 test: combine redundant PSBT unknown field merge cases into `test_combinepsbt_preserves_unknown_fields` (nebula-21)
40eba5eb20ba0041a6328ba3482fcc26ddbe0185 test: extract unknown fields passthrough to its own method (nebula-21)

Pull request description:

I've tested some mutations related to test coverage for PSBT unknown field merging and discovered an inconsistency.
<details>

If line 71 of `psbt.cpp` "`unknown.insert(psbt.unknown.begin(), psbt.unknown.end());`" (inside `bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)` function) is removed then, the expected test fails: *"Test that combining PSBTs preserves unknown fields with the same and with distinct values per map."*

If line 434 of `psbt.cpp` "`unknown.insert(input.unknown.begin(), input.unknown.end());`" (inside `bool PSBTInput::Merge(const PSBTInput& input)` function), is removed, a different unexpected test fails: "*Test that unknown values are just passed through*".

If line 537 of `psbt.cpp` "`unknown.insert(output.unknown.begin(), output.unknown.end());`" (inside `bool PSBTOutput::Merge(const PSBTOutput& output)` function), is removed, the expected test fails: "*Test that combining PSBTs preserves unknown fields with the same and with distinct values per map.*".
</details>

This PR solves this inconsistency.
The old code did 3 different things:
1. Test the pass-through of unknown values for `walletprocesspsbt`.
2. Combine two v0 PSBTs with different unknown input keys and check that both keys survive.
3. Combine implicit v0 PSBT with explicit v0 and check that both keys survive.

Case 2 is already fully covered by the existing `test_combinepsbt_preseves_unknown_fields` so keeping it is redundant and misleading.

Commit 40eba5eb20ba0041a6328ba3482fcc26ddbe0185 moves the old code into a new method called `test_unknown_fields_passthrough` and commit ef4310097bd651497a98a9d1bb59560a7055ae01 removes the redundant code of Case 2 and moves Case 3 inside `test_combinepsbt_preserves_unknown_fields`.

ACKs for top commit:
Naomi-Gift:
tACK ef4310097bd651497a98a9d1bb59560a7055ae01
polespinasa:
ACK ef4310097bd651497a98a9d1bb59560a7055ae01

Tree-SHA512: 14476cffc28a8548fe58e42d8862d4fdb300c36d81679551fa8f9af83b49da3c65c2fe3283e9a4ec3e5c45abe3f34b8270dc2208a4f0534ff1f6062948bfcae9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only reorganizes existing test code in Bitcoin Core's functional test suite. It moves and deduplicates tests that check how unknown PSBT fields are preserved when PSBTs are combined or processed by the wallet. No production code was changed, and no security bug was fixed or introduced.

Security candidateMerge bitcoin/bitcoin#36783: Update minisketch subtree to latest masterby merge-script · f12cc4ae · Nov 6, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36783: Update minisketch subtree to latest master

be064af99df3870d3d01d9969da7268cc3881375 Squashed 'src/minisketch/' changes from a12f5de1c9..d44dca4e3f (fanquake)

Pull request description:

Includes:
* https://github.com/bitcoin-core/minisketch/pull/106

Used in #36623.

ACKs for top commit:
willcl-ark:
utACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3
sedited:
ACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3

Tree-SHA512: 8464382c5bab000ce347136b67e0966aa97f388af0d864ee0c38306aab9ba7c7a91fb96d6e4b14dee3b58a99501c62ec52d596a392857afac07deb9ada32fa84

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 19/100

This is a routine update of an internal math library (minisketch) used by Bitcoin Core. The visible code change removes an unreachable 'break' statement that followed a 'return' inside a switch case. That kind of cleanup is cosmetic and does not change program behavior. There is no indication in the commit message or diff that this fixes a security vulnerability.

Security candidateMerge bitcoin/bitcoin#36731: test: use monotonic clock for durations in test framework and http_interfaceby merge-script · 521bbaf4 · Nov 6, 2026 · 6 filesMessage 91 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36731: test: use monotonic clock for durations in test framework and http_interface

a7d3a4297321274ced64294e0bbd3252167e8879 test: use monotonic clock in interface_http (ViniciusCestarii)
eccca10e6460507e553e61a1cdaf664fa7738375 test: use monotonic clock for durations in test framework (ViniciusCestarii)

Pull request description:

Replace `time.time()` used to measure durations by `time.monotonic()` in test framework and http_interface.

This helps preventing future clock jump flakiness (same class of bug as #36529) on tests and fix:

```
faketime --exclude-monotonic -f "+0 x0.5" build/test/functional/feature_torcontrol.py
faketime --exclude-monotonic -f "+0 x0.1" build/test/functional/interface_http.py
```

ACKs for top commit:
nervana21:
tACK a7d3a4297321274ced64294e0bbd3252167e8879
maflcko:
review ACK a7d3a4297321274ced64294e0bbd3252167e8879 🕐
sedited:
ACK a7d3a4297321274ced64294e0bbd3252167e8879

Tree-SHA512: d1c6b98ceab4c4bf5b97a44b4a4577b0868292d2aaa359aa67a807be469700737f0d330da83e8b6f85403635db6809c41dcd4041a84f3ab6dad9ef16e50a44d1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
authentication pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit only changes the test code that runs Bitcoin Core's automated tests. It swaps the clock used to measure how long things take from the regular system clock (which can jump forward or backward, for example when the system time is adjusted) to a monotonic clock (which only ever moves forward steadily). This makes the tests more reliable and less likely to fail randomly due to clock jumps, but it does not change the actual Bitcoin Core software that users run, nor does it fix any security vulnerability in the live network or node software.

AI review queuedMerge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19by Hennadii Stepanov · f22abab4 · Nov 6, 2026 · 10 filesMessage 81 · StrongInformational 15Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19

fa8c3c014d1eb17c69a7a286b121134a1c310e54 refactor: Remove unused include for clang-cl on Windows (MarcoFalke)
faffaeb2b66ea3573b8a37bda0154822a216c1d7 build: Drop unused clang-17 -Wno-c++23-extensions workaround (MarcoFalke)
fa31e2595569ad2c6f0f61401917ca6b42a3b45b refactor: Drop unused libc++-16 workarounds (MarcoFalke)
fa6299f87a27853a170be49b67e6e319d244928e clang-format: Use Standard: Latest (MarcoFalke)
fa909de36f3b44d3fd531a3f2f68662b0a37c718 build: Bump clang minimum supported version to 19 (MarcoFalke)

Pull request description:

Most supported operating systems ship with clang-19 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs.

(For this bump, only C++20 CTAD will become available.)

This patch will only be released in version 33.x, next year (2027).

For reference:

* https://packages.debian.org/bookworm/clang-22
* https://packages.ubuntu.com/noble/clang-20
* CentOS-like 8/9/10 ship clang-21 via Stream
* Free/Open/Net*BSD ship clang-19
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (clang22); leap:latest with clang-19
* macOS 14: depends/release cross-builds are unaffected and use clang-19
* macOS 14: Native builds use llvm-19-ish via XCode CLT 26.3 since https://github.com/bitcoin/bitcoin/pull/36287
* Windows: VS ships Clang 22

On operating systems where the minimum Clang version is not shipped by default, the user would have to use GCC, or install Clang in a different way. For example:

* https://packages.debian.org/bookworm/g++ (g++-12)
* https://packages.ubuntu.com/jammy/g++-12
* https://apt.llvm.org/, brew, nix, guix, or compile clang from source, ...

ACKs for top commit:
fanquake:
utACK fa8c3c014d1eb17c69a7a286b121134a1c310e54
hebasto:
re-ACK fa8c3c014d1eb17c69a7a286b121134a1c310e54, rebased and removed `-Wno-c++23-extensions` since my last [review](https://github.com/bitcoin/bitcoin/pull/36036#pullrequestreview-5777417373).

Tree-SHA512: 519f018f6b7f7f1a50e72f0f0ba53f60209ebd8a613a973cf0b91638e1bc732c1084b3a6c63cc30c4f0b8b5991d76adde24752e20cd4aead942450a1a8879c68

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit raises the minimum supported version of the Clang compiler used to build Bitcoin Core from version 17 to version 19. It also removes some old workarounds that were only needed for older compiler versions. There is no change to how Bitcoin Core processes transactions, network messages, wallets, or consensus rules. It is a routine build-system maintenance change.

AI review queuedMerge bitcoin/bitcoin#36333: wallet: Delete `removeprunedfunds` RPCby Ava Chow · fcf76ea5 · Nov 6, 2026 · 5 filesMessage 91 · StrongInformational 19Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36333: wallet: Delete `removeprunedfunds` RPC

ec7f64d02e370e04354e64fa745fca240bcb3cbe doc: release note for removeprunedfunds rpc deletion (David Gumberg)
3d8c55734e91049f50bb90637be2678bf3ab3619 wallet: rpc: Delete removeprunedfunds (David Gumberg)

Pull request description:

Deprecated in v32 (https://github.com/bitcoin/bitcoin/pull/35605), this deletes the useless and harmful `removeprunedfunds` RPC.

~~It also removes deleting of watchonly transactions from the not-watchonly migrated wallet, which in theory we should clean up, but in practice this does nothing for the user, the only observable change is that if the user knows the txid they can do `gettransaction` and the migrated wallet will return the transaction information even though it does not have keys for the transaction, AFAICT for both GUI and RPC having irrelevant transactions inside of wallet is harmless and does not affect the output of anything, since most stuff is gated behind `IsMine()` anyways.~~

~~Removing both the RPC and the deletion of watchonly tx'es allows deleting the logic for transaction removal and the associated tests.~~

Edit: This will be done in a follow-up, all this PR does is delete the `removeprunedfunds` RPC.

_LLM Disclosure: Not used to write this PR or PR description, but I recently replaced clang on my machine with gemma-4-26B directly generating machine code._

ACKs for top commit:
achow101:
ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
pablomartin4btc:
re-ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
w0xlt:
ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
polespinasa:
untested ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe

Tree-SHA512: dd9f982db05f0b74eafe0fac11e4f8b9b59ffba26a7c9d04b15dba7b6d0b070ef4115e44d9ae9c0f619b0b401c3df3a0f9181ed49e080f300406513267faee81

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit removes an old Bitcoin Core wallet RPC command called removeprunedfunds that was already marked deprecated in the previous release. The change is a planned cleanup, not a security fix. It deletes the command's code, its registration, release notes, and related tests. There is no indication in the commit that this fixes a vulnerability or that the removal itself creates a security issue.

Security candidateMerge bitcoin/bitcoin#36725: refactor: Use u64 consistently for flatfile sizesby merge-script · 6996cf7a · Nov 5, 2026 · 10 filesMessage 96 · StrongLow 27Details
Commit message · merge-script

Merge bitcoin/bitcoin#36725: refactor: Use u64 consistently for flatfile sizes

fa2c8df1810f23e1c510e310eb246fd5abd3a066 Add test coverage for varint overflow (MarcoFalke)
faed02f6d0aba80e1f99842fcd575625d9e89fc1 refactor: Use LARGE_INTEGER QuadPart on Windows (MarcoFalke)
faf8d0e33ad000f72539aeedf4ab47c2e25b97ba refactor: Use u64 consistently for flatfile sizes (MarcoFalke)

Pull request description:

`unsigned` is a 32-bit integer (even on 64-bit platforms). File sizes are generally measured in 64-bit integers and using 32-bit integers or architecture-dependent integers is brittle and confusing.

So use u64 consistently for flatfile sizes in this refactor.

Also, use `LARGE_INTEGER`'s `QuadPart` on Windows, which is recommended since C++11.

Also, unit test VarInt overflow errors.

ACKs for top commit:
darosior:
utACK fa2c8df1810f23e1c510e310eb246fd5abd3a066
frankomosh:
ACK fa2c8df1810f23e1c510e310eb246fd5abd3a066
sedited:
ACK fa2c8df1810f23e1c510e310eb246fd5abd3a066

Tree-SHA512: f79593a6d01296177e432a25d9ce2af0fb8a2cbcea3a2ba8160f6ac03c16ea6a26ba97341475bf9a22c3bc4a28f7fce741bc544b82d604fe209c43786508966d

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 27/100

This is a code cleanup (refactor) that switches file-size variables from 32-bit or platform-dependent types to a consistent 64-bit unsigned type. It also adds unit tests for variable-integer overflow and simplifies a Windows file-size API call. The changes reduce the risk of future bugs related to very large files or integer overflow, but they do not by themselves fix a known exploitable vulnerability.

AI review queuedMerge bitcoin/bitcoin#36775: test: wallet: BnB marks exhaustive search completeby merge-script · 80d1da3c · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36775: test: wallet: BnB marks exhaustive search complete

ac2c946d3b211e90abb48357b0cb2afadbc64a38 test: BnB marks exhaustive search complete (conradgabe)

Pull request description:

`SelectCoinsBnB` marks its result as completed when it exhausts the search space before reaching `TOTAL_TRIES`. Only the incomplete case is checked in the unit tests (`bnb_exhaustion_with_solution_test`), and the `bnb_finds_min_waste` fuzz target only reads the flag to decide whether to assert optimality, so reporting false goes unnoticed.

This PR checks `GetAlgoCompleted()` in `TestBnBSuccess` for cases that finish below the attempt limit (100,000).

Kills the following mutant (https://mutanthub.space/mutants/1096):
```diff
--- a/src/wallet/coinselection.cpp
+++ b/src/wallet/coinselection.cpp
@@ -233,7 +233,7 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
if (curr_selection.empty()) {
// Exhausted search space before running into attempt limit
is_done = true;
- result.SetAlgoCompleted(true);
+ result.SetAlgoCompleted(false);
break;
}
// Set `next_utxo` to one after last selected, then deselect last selected UTXO
```

ACKs for top commit:
yancyribbens:
ACK ac2c946d3b211e90abb48357b0cb2afadbc64a38
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/ac2c946d3b211e90abb48357b0cb2afadbc64a38
murchandamus:
ACK ac2c946d3b211e90abb48357b0cb2afadbc64a38

Tree-SHA512: f7c00f01fba900557fe26e2b7c6651ea6217508bd1f55202122e1b64ce1efa30f36ab474d24c61b29112b4e5594c7bed8d1e4787492dcd73ae61ca7592450d0e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new check to an existing unit test. It makes sure that when Bitcoin Core's coin-selection algorithm (called Branch-and-Bound or BnB) finishes searching all possible coin combinations, it correctly reports that the search was completed. The actual production code is unchanged; only the test is strengthened. There is no security fix or vulnerability being patched.

AI review queuedMerge bitcoin/bitcoin#36777: refactor: rpc: doc: Mark longpoll counter u32by merge-script · 83e4347e · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36777: refactor: rpc: doc: Mark longpoll counter u32

fa8817e6087e0d112f6421de47cb2bc7504b3ca1 refactor: rpc: doc: Mark longpoll counter u32 (MarcoFalke)

Pull request description:

The counter will only ever be a valid u32 value in normal operation, so document that without changing any behavior.

In theory, the behavior could be changed to use `LocaleIndependentAtoi<uint32_t>()`, but this is left for the future.

The change is needed to be able to fuzz the `rpc` target.

To test after compiling with `-DSANITIZERS=undefined,integer,float-divide-by-zero`:

```
$ base64 /tmp/a.crash
Z2V0YmxvY2t0ZW1wbGF0ZVyzXC1sb25ncG9sbGlkXNHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
AAAAAAAAAAAAAAAgAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAABCQkJCQkJCQkJCQkJCQkJCQkJC
QkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJC
QkJCQkJCQkJCQkJCQkLR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRZ2VsA6NjA2+pYysAmfcAuMXhQwjp7WJsXA==

$ FUZZ=rpc ./bld-cmake/test/with_sanitizer_env.py ./bld-cmake/bin/fuzz /tmp/a.crash
src/rpc/mining.cpp:842:42: runtime error: implicit conversion from type 'long' of value 9223372036854775807 (64-bit, signed) to type 'unsigned int' changed the value to 4294967295 (32-bit, unsigned)
#0 0x5603ba69a874 in getblocktemplate()::$_0::operator()(RPCMethod const&, JSONRPCRequest const&) const
...
```

Or:

```
$ UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=0:report_error_type=1" ./bld-cmake/bin/bitcoind -datadir=/tmp -regtest &

$ ./bld-cmake/bin/bitcoin-cli -datadir=/tmp -regtest getblocktemplate '{"rules":["segwit"],"longpollid":"00000000000000000000000000000000000000000000000000000000000000009223372036854775807"}'

ACKs for top commit:
sedited:
ACK fa8817e6087e0d112f6421de47cb2bc7504b3ca1
darosior:
utACK fa8817e6087e0d112f6421de47cb2bc7504b3ca1

Tree-SHA512: 607c14632d900c3a99b82560c858967bfd1475f6d274c97942428ebe2f26fb47d5086de4fb142814107a7231d2443d732addb4b27b23b01ab21202b4bf47848b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationfuzzing or regression evidencemerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 21/100

This is a small code cleanup in Bitcoin Core's getblocktemplate RPC. It changes the type of an internal counter from 'unsigned int' to the explicitly-sized 'uint32_t' and documents that the long-poll counter is expected to be a 32-bit value. The patch does not change runtime behavior; it merely makes the existing implicit truncation explicit so that fuzzing and sanitizer tools don't flag it as suspicious. There is no direct security fix here, but making the code's assumptions explicit helps future testing catch real bugs.

Security candidateMerge bitcoin/bitcoin#36384: rpc: Use self.Arg<_>(name) helper over manual and duplicate parsingby merge-script · 9f03a91c · Nov 5, 2026 · 15 filesMessage 81 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36384: rpc: Use self.Arg<_>(name) helper over manual and duplicate parsing

fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b doc: Fix typo in walletcreatefundedpsbt dev comment (MarcoFalke)
fa62bc2b42f129495541f122707183185da1062b refactor: rpc: Use self.Arg<_>(name) helper over manual isNull() ? fallback : getter() (MarcoFalke)
faee904d88faa33aeac317119b245730e5e0fcfe rpc: Align psbt_version parsing (MarcoFalke)
fab17591d5155dc5e903025ff8d021f9ac3e42de rpc: Parse generatetoaddress maxtries as u64 (MarcoFalke)
fa105f82c3cb4b48c992cdb3e04096c86a34f2c9 rpc: doc: Use proper RPCArg::Default in verifychain (MarcoFalke)
6666c799b956c0403cb68a85fe9f1d8a3935ed76 rpc: Use the first arg name in GetParamIndex (MarcoFalke)

Pull request description:

The `Arg()` helper has many benefits:

* It does not require manual `isNull` checks
* It does not require hard-coding the fallback/default value a second time
* It does not require manually specifying the getter for the type. Specifying the type is enough.

So use it more broadly.

ACKs for top commit:
stickies-v:
re-ACK fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b
fanquake:
ACK fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b

Tree-SHA512: d057a5be92656cc6b5d4104e7adc43075e9e78852ce99c3ded73a967e08c51d0eba5d02442c57f19b7c62b0ae368031581e10677bbad29f87de1ed0af2498d27

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 21/100

This is a code cleanup change in Bitcoin Core's RPC (remote procedure call) handling. It replaces manual argument parsing with a helper called self.Arg<_>(name). The goal is to reduce duplicated code and make defaults easier to maintain. There is no obvious security vulnerability introduced, but any refactor touching many RPC commands carries a small risk of subtle behavior changes.

AI review queuedMerge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding optionsby merge-script · 0fe899d0 · Nov 5, 2026 · 7 filesMessage 91 · StrongLow 33Details
Commit message · merge-script

Merge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding options

faeb073ca68348bc663c80b3f2b70d7014466b07 test: Use new named arg aliases in tests (MarcoFalke)
fac8ef10f4c618136dd318f642fd7ccb4587d509 wallet: rpc: Add snake_case aliases for wallet funding options (MarcoFalke)

Pull request description:

The options for wallet funding RPCs have several issues:

* snake_case aliases are accepted by the server, but unsupported by bitcoin-cli, not mentioned in the docs and rejected by the schema.
* If both the snake_case and camelCase are provided, the camelCase is silently ignored.
* The server silently ignores `subtract_fee_from_outputs`. (reported by stutxo in https://github.com/bitcoin/bitcoin/pull/35317)

Fix all issues, by:

* Adding the snake_case aliases to the CLI, docs and the schema.
* Rejecting if both are supplied.
* Reading `subtract_fee_from_outputs` instead of silently ignoring it.

ACKs for top commit:
Conradgabe:
tACK faeb073ca68348bc663c80b3f2b70d7014466b07
sedited:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07
willcl-ark:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07

Tree-SHA512: d434c98d9a2aacf3d547d727f7d31a052beea7079f6ca32ed08877523f28231ae0bc7f1ff9a909856b7b14f7e89560058ec723918277d259b2810bcb90982804

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 33/100

This update fixes a quirk in Bitcoin Core's wallet commands where some option names using underscores (like subtract_fee_from_outputs) were accepted by the server but not properly handled by the command-line tool or documentation. More importantly, the server was silently ignoring subtract_fee_from_outputs, meaning a user who thought they had told the wallet to deduct the transaction fee from a recipient's payment would actually end up paying the fee themselves. The patch also now rejects supplying both the old camelCase name and the new snake_case name at the same time, preventing confusion. It is a bug fix with a mild financial-impact risk rather than a direct theft or remote-code-execution vulnerability.

Security candidateMerge bitcoin/bitcoin#36192: test: cover unsatisfiable mining timestampby merge-script · b4f341a9 · Nov 5, 2026 · 6 filesMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36192: test: cover unsatisfiable mining timestamp

c000f6ef15e06856b9111ee433877a2b1bf31eb4 test: assert Murch-Zawy period boundaries (Sjors Provoost)
9b4f05a240a3feaf99976fd14952a21b3f96e029 test: cover unsatisfiable mining timestamp (Sjors Provoost)
2137b7b2ee3ae3c39aa74a9ac7e26d821c1b4988 test: share block timing constants through blocktools (Sjors Provoost)
bb32ef4d541d14752f2dca9b1a633aecea9d40a7 test: drop REGTEST_ prefix from block difficulty constants (Sjors Provoost)
9f34ea1605bd0c8726cc69ecf5686cc6d3d0d125 test: rename REGTEST_RETARGET_PERIOD to HALVING_INTERVAL (Sjors Provoost)

Pull request description:

This PR adds test coverage for what happens in the (extremely unlikely) event that the miner can't satisfy the constraints. This is inspired by the recently added timewarp-protection and Murch-Zawy rules (for the miner, not for consensus, see #30681 and #35949), but this is a pre-existing issue. It is not made worse by these rules.

The test has an attacker mine 6 blocks, which set MTP at the victim's future-time limit. It calls `getblocktemplate` and the equivalent IPC method, which both fail. It then moves mock time one second forward, and demonstrates mining works again (and we don't drop the IPC connection).

This (impractical) attack can be done at any height, be we illustrate it for blocks 142, 143 and 0 of a retarget period, to clarify that the timewarp-protection and Murch-Zawy rules do not matter.

The test was added to `ipc_mining.py`, to avoid having to add IPC support to `mining_basic.py`. Mining coverage is currently split between various test files and not always mirrored between RPC and IPC. A followup could unify these, while still skipping the IPC side when that's not compiled.

A few refactor commits to prepare:

- fix incorrect name: `REGTEST_RETARGET_PERIOD` -> `HALVING_INTERVAL`
- drop `REGTEST_` prefix from `REGTEST_N_BITS` and `REGTEST_TARGET` (consistent with `HALVING_INTERVAL`, `DIFFICULTY_ADJUSTMENT_INTERVAL` and `TIME_GENESIS_BLOCK`).
- move `DIFFICULTY_ADJUSTMENT_INTERVAL` to the framework

The last commit picks up a Murch-Zawy followup suggested in https://github.com/bitcoin/bitcoin/pull/35949#discussion_r3944011135 and takes advantage of our refactor, but is otherwise unrelated.

ACKs for top commit:
fjahr:
reACK c000f6ef15e06856b9111ee433877a2b1bf31eb4
ismaelsadeeq:
reACK c000f6ef15e06856b9111ee433877a2b1bf31eb4
sedited:
ACK c000f6ef15e06856b9111ee433877a2b1bf31eb4

Tree-SHA512: e92c46ba5366024eca6d2af5569f3665bea22db232608ca8b94abf3c921a2cc39e70af1aa2612c972a4ad2838da0d9ad47941d676b6f802bbc8987ed8ac6639c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languageconsensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds and reorganizes Bitcoin Core's own functional tests. It renames some test constants, moves a shared constant into the test framework, and adds a new test that checks how the mining code behaves when an attacker manipulates block timestamps to make template creation temporarily fail. The commit does not change any production consensus, networking, or wallet code, and the pull request description explicitly calls the scenario an 'impractical' test-case. There is no security patch or vulnerability fix here.

Security candidateMerge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0by merge-script · fefea34e · Nov 5, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0

eaa8d1f5a5fcfeefcb3ff432aeb969e8f8f14a7d build: Bump macOS SDK version to 15.0 (Hennadii Stepanov)

Pull request description:

Qt 6.12, which supports deployment targets up to macOS 26, requires the macOS 15 SDK or higher.

See https://doc.qt.io/qt-6.12/macos.html.

This is a prerequisite for the upcoming update of Qt in depends from 6.8 LTS to 6.12 LTS.

My partial Guix build:
```console
$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
727bcc7343afc599cadad3891a6aaa73883594a5feea6695b81056eaf1881914 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/SHA256SUMS.part
cea76395e4761c9cc6c1e7fc0eae52abd3bb024caeed62a3461a9cf0de2f4b08 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-codesigning.tar.gz
8886c05cca9f518441284be4cb415d275b7d118e8150e441d053e3fc61d27807 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-unsigned.tar.gz
7c6c4423e6272a821fd6adefaac6dd4a1e09f7f85ecf9efa6bd7e97c0ddc79bc guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-unsigned.zip
a74db20b1a8acd1a570a733d02ea7e3aa28ac8902462e9be9fac10e0f84e4ca1 guix-build-eaa8d1f5a5fc/output/dist-archive/bitcoin-eaa8d1f5a5fc.tar.gz
f708d94dc0343a5057d3b8791242acd67dbb1f481b2da7fc778aa981e9fc2e42 guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/SHA256SUMS.part
98ddcc471b967208e491c06f697e94d09005631da463e085ee88e281c035180e guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-codesigning.tar.gz
7aeb9b6f84679f11d22ffe1faf4b0aa386c09f641a6d742f70ef727466b24d0f guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-unsigned.tar.gz
de23e46dbe3c0886fd689b16ab345120907445212ffb6fcb41ccca8cfc8d628e guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-unsigned.zip
```

ACKs for top commit:
maflcko:
lgtm ACK eaa8d1f5a5fcfeefcb3ff432aeb969e8f8f14a7d

Tree-SHA512: 6dd679e9dfdae60e4a2cb6f891c3779699dc27045fe877a820dd839972fd0771dcdf9d0a432a0cb64a1de58b138e4e5fe24d1ab43af7cd8aa3fe632f4717cab4

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100

This commit simply updates the version number of the Apple macOS software development kit (SDK) used to build Bitcoin Core from 14.0 to 15.0. It is a routine build-system change needed to support a future Qt GUI library upgrade. There is no indication of a security vulnerability, bug fix, or behavior change in the running software.

Security candidateMerge bitcoin/bitcoin#36747: Update libmultiprocess subtree to add nonunix platform support and fix race conditionsby merge-script · 93bd4e1d · Nov 5, 2026 · 68 filesMessage 100 · StrongModerate 59Details
Commit message · merge-script

Merge bitcoin/bitcoin#36747: Update libmultiprocess subtree to add nonunix platform support and fix race conditions

d5f7524897dd5ec638cebf7d61607c561c3b9e2b doc: Bump minimum required Cap'n Proto version to 0.9.2 (Ryan Ofsky)
4898199d8f97cad75cfd54a9caed3ffd3ce2948c build: suppress -Wc++23-lambda-attributes in warn_interface (Ryan Ofsky)
270f5dbe3ddac5191ec6b21ceb17c3dddb79b12f Squashed 'src/ipc/libmultiprocess/' changes from e8de5c7b68e..acded1aafae (Ryan Ofsky)

Pull request description:

The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh).

Changes since last subtree update (#35720):

- Adds support for nonunix platforms, making API changes that are not backwards compatible ([#274](https://github.com/bitcoin-core/libmultiprocess/pull/274)). Follow-ups add a `CurrentThread()` accessor matching compatibility code in [bitcoin/bitcoin#35084](https://github.com/bitcoin/bitcoin/pull/35084) ([#323](https://github.com/bitcoin-core/libmultiprocess/pull/323)) and remove code for Cap'n Proto versions before 0.9 ([#331](https://github.com/bitcoin-core/libmultiprocess/pull/331)).
- Fixes a data race between IPC calls running on worker threads and disconnects, found by Antithesis ([#349](https://github.com/bitcoin-core/libmultiprocess/pull/349)).
- Fixes a use-after-free when a socket disconnects before `ConnectStream` connects, and leaks and hangs when a client `construct()` call throws ([#298](https://github.com/bitcoin-core/libmultiprocess/pull/298)).
- Fixes a race where file descriptors from `SpawnProcess` could leak into processes forked at the same time by other threads, by clearing `FD_CLOEXEC` in the child after forking ([#311](https://github.com/bitcoin-core/libmultiprocess/pull/311)).
- Makes `SpawnProcess` report `exec` failures back to the parent and throw, reaping the child ([#312](https://github.com/bitcoin-core/libmultiprocess/pull/312)).
- Adds support for `std::chrono::time_point` fields ([#303](https://github.com/bitcoin-core/libmultiprocess/pull/303)) and for serializing lists of interface objects that need to be moved from ([#304](https://github.com/bitcoin-core/libmultiprocess/pull/304)), both needed by [bitcoin/bitcoin#10102](https://github.com/bitcoin/bitcoin/pull/10102).
- Accepts container fields and parameters with any comparator, hash, and allocator types, like Bitcoin Core's `GCSFilter::ElementSet`, needed by [bitcoin/bitcoin#29409](https://github.com/bitcoin/bitcoin/pull/29409) ([#379](https://github.com/bitcoin-core/libmultiprocess/pull/379)).
- Finds the `capnp` tool in vcpkg and Windows builds, needed by [bitcoin/bitcoin#32387](https://github.com/bitcoin/bitcoin/pull/32387) ([#317](https://github.com/bitcoin-core/libmultiprocess/pull/317)).
- Adds a `destroy_connection` option to `ServeStream` and `ConnectStream`, lets `ServeStream` take ownership of the init object and return the new server and its connection, and adds an `EventLoop::incomingConnections()` accessor, simplifying test setup in both repositories and needed by [bitcoin/bitcoin#35932](https://github.com/bitcoin/bitcoin/pull/35932) ([#365](https://github.com/bitcoin-core/libmultiprocess/pull/365)).
- Replaces `EventLoop::post()` with `sync()` taking a `kj::FunctionParam`, avoiding a heap allocation per call ([#347](https://github.com/bitcoin-core/libmultiprocess/pull/347)).
- Names threads spawned by the event loop so they can be told apart in tools and logs ([#324](https://github.com/bitcoin-core/libmultiprocess/pull/324)).
- Fixes warnings that Bitcoin Core enables or plans to enable: adds `[[noreturn]]` attributes for `-Wmissing-noreturn` ([#339](https://github.com/bitcoin-core/libmultiprocess/pull/339), for [bitcoin/bitcoin#35911](https://github.com/bitcoin/bitcoin/pull/35911)), and fixes `-Wunused` ([#362](https://github.com/bitcoin-core/libmultiprocess/pull/362), for [bitcoin/bitcoin#36167](https://github.com/bitcoin/bitcoin/pull/36167)), `-Wunused-const-variable` and `-Wundef` ([#370](https://github.com/bitcoin-core/libmultiprocess/pull/370)), and `-Wmissing-prototypes` ([#386](https://github.com/bitcoin-core/libmultiprocess/pull/386), for [bitcoin/bitcoin#36743](https://github.com/bitcoin/bitcoin/pull/36743)) warnings.
- Fails at compile time with a suggested workaround when Cap'n Proto misdetects exception support (`KJ_NO_EXCEPTIONS`), as happens on NetBSD ([#364](https://github.com/bitcoin-core/libmultiprocess/pull/364)).
- Build improvements: fixes stale generated code when the `mpgen` binary changes ([#316](https://github.com/bitcoin-core/libmultiprocess/pull/316)), fixes `mpgen` link order for static Cap'n Proto builds ([#367](https://github.com/bitcoin-core/libmultiprocess/pull/367)), links `mpgen` against `kj-async` instead of `capnp-rpc` ([#327](https://github.com/bitcoin-core/libmultiprocess/pull/327)), shows Cap'n Proto `find_package` diagnostics ([#325](https://github.com/bitcoin-core/libmultiprocess/pull/325)), installs `type-unordered-set.h` and `version.h` ([#350](https://github.com/bitcoin-core/libmultiprocess/pull/350)), and shows include-what-you-use errors instead of failing silently ([#371](https://github.com/bitcoin-core/libmultiprocess/pull/371)).
- Test, CI, documentation, and minor code improvements: fix for a startup race in the example program ([#315](https://github.com/bitcoin-core/libmultiprocess/pull/315)), new test for immediate client disconnects in `ListenConnections` ([#310](https://github.com/bitcoin-core/libmultiprocess/pull/310)), `ReadList` return value check ([#338](https://github.com/bitcoin-core/libmultiprocess/pull/338)), connect test race fix ([#343](https://github.com/bitcoin-core/libmultiprocess/pull/343)) and cleanups ([#344](https://github.com/bitcoin-core/libmultiprocess/pull/344)), `std::ranges::copy` follow-ups ([#307](https://github.com/bitcoin-core/libmultiprocess/pull/307)), trailing whitespace removal ([#345](https://github.com/bitcoin-core/libmultiprocess/pull/345)), Cap'n Proto version documentation fix ([#357](https://github.com/bitcoin-core/libmultiprocess/pull/357)), clang-tidy updates ([#358](https://github.com/bitcoin-core/libmultiprocess/pull/358), [#360](https://github.com/bitcoin-core/libmultiprocess/pull/360), [#380](https://github.com/bitcoin-core/libmultiprocess/pull/380), [#389](https://github.com/bitcoin-core/libmultiprocess/pull/389)), new CI job testing newer cmake and Cap'n Proto versions ([#212](https://github.com/bitcoin-core/libmultiprocess/pull/212), [#359](https://github.com/bitcoin-core/libmultiprocess/pull/359)), CI coverage for the minimum supported g++ ([#330](https://github.com/bitcoin-core/libmultiprocess/pull/330), [#366](https://github.com/bitcoin-core/libmultiprocess/pull/366)), new CI warnings ([#332](https://github.com/bitcoin-core/libmultiprocess/pull/332), [#341](https://github.com/bitcoin-core/libmultiprocess/pull/341)), CI parallelism ([#334](https://github.com/bitcoin-core/libmultiprocess/pull/334), [#356](https://github.com/bitcoin-core/libmultiprocess/pull/356)), CI diagnostics ([#351](https://github.com/bitcoin-core/libmultiprocess/pull/351), [#352](https://github.com/bitcoin-core/libmultiprocess/pull/352)), Nix and LLVM updates ([#296](https://github.com/bitcoin-core/libmultiprocess/pull/296), [#363](https://github.com/bitcoin-core/libmultiprocess/pull/363)), NetBSD and OpenBSD CI fixes ([#321](https://github.com/bitcoin-core/libmultiprocess/pull/321), [#340](https://github.com/bitcoin-core/libmultiprocess/pull/340), [#381](https://github.com/bitcoin-core/libmultiprocess/pull/381)), building Cap'n Proto with GCC in the 32-bit CI job to avoid an ABI mismatch ([#383](https://github.com/bitcoin-core/libmultiprocess/pull/383)), and GitHub Actions updates ([#387](https://github.com/bitcoin-core/libmultiprocess/pull/387)).

The second commit suppresses the clang `-Wc++23-lambda-attributes` warning, which the new `[[noreturn]]` lambda attribute in `mp/proxy-types.h` triggers in C++20 builds. Since #31507 the Windows build uses clang-cl, so the same flag covers it.

The third commit updates the minimum Cap'n Proto version in `doc/dependencies.md` to 0.9.2 (1.0 with Clang). This update raises libmultiprocess's own minimum from 0.7 to 0.9 (bitcoin-core/libmultiprocess#331), and libmultiprocess rejects 0.9.0 and 0.9.1 for CVE-2022-46149 and, with Clang 16 or newer, every version before 1.0.

ACKs for top commit:
fanquake:
ACK d5f7524897dd5ec638cebf7d61607c561c3b9e2b
willcl-ark:
ACK d5f7524897dd5ec638cebf7d61607c561c3b9e2b

Tree-SHA512: 4064944f4d8bb6c1665ddc7d5fae838492235d7dfdafab88b19b687ff6892460a3f450b90a145b287866330c569b862d748c941a70c65abc7f273ef13e490fd7

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languagesigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 59/100

This is a routine subtree update that pulls in a newer version of the libmultiprocess inter-process communication library used by Bitcoin Core. The commit message and code changes explicitly describe several bug fixes for race conditions, use-after-free, and file-descriptor leaks in the IPC layer. It also raises the minimum required Cap'n Proto version because older versions have a known memory-safety vulnerability (CVE-2022-46149). The changes are defensive: they fix bugs rather than introduce new attack surface, but the bugs being fixed are in security-relevant areas (cross-process communication, threading, and process spawning).

Security candidateMerge bitcoin/bitcoin#35170: test: Better test coverage for ParseHDKeypath()by merge-script · e0b4592e · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35170: test: Better test coverage for ParseHDKeypath()

3ce364124c09157722781720ee60aabb5a99e133 test: bip32_tests: Add some more tests cases (optout)
72414a709d57308e4fe69d5d96188beeeebb6855 test: bip32_tests: Add round-trip tests (optout)
60bdfdb19e98b7574b0a2c565f81c8dfec514e2f test: bip32_tests: Add expected result checks (optout)
7b5ce9c529bd38f29c1216a93fd44ae62edb56bb test: Refactor in bip32_tests: extract test data in an array (optout)

Pull request description:

Background: The `ParseHDKeypath` method (`src/util/bip32.cpp`) is used directly only in a limited way: when loading legacy wallets. However, it shares internals with parsing within descriptors (`ParseKeyPath`, `ParseKeyPathNum` in `src/script/descriptor.cpp`, c.f. #35069).

Deficiencies: The method has a unit test, but it checks only the bool result, and not the parsed keypath. This can be demonstrated by breaking the implementation by adding a `keypath.clear();` statement just before the final `return true;`. With this obviously broken implementation the tests pass.

Solution proposed: Extend the tests with checks (without modifying the behavior).

Changes:

- Extend the unit tests with checks for the returned parsed keypath. Add the expected parsed numerical keypath as test data. Note: breaking the production code as described above now results in test failure.

- In the unit test also perform round-trip conversion: convert to string, then parse again, and convert to string again. In the last two steps the results should match the input before the round-trip (note: this is not true for the first roundtrip). Additionally, add negative tests for the unsupported 'h' hardened delimiter.

ACKs for top commit:
Sjors:
re-ACK 3ce3641
achow101:
ACK 3ce364124c09157722781720ee60aabb5a99e133

Tree-SHA512: 4b0450da1c5cccf12e15aeb272c927ef3b119466ae14d9fcea3e34c5ef6e02068c43e22d68a4433c9d1a4f3c111c799f8165c13147a7317706b03e056dfb86dd

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialdefensive validationcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds and improves unit tests for the ParseHDKeypath() function. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The change makes the tests verify the actual parsed output and adds round-trip checks, which improves test quality but has no runtime security impact on its own.

Security candidateMerge bitcoin/bitcoin#36142: net: validate Tor onion service replies and cached keysby merge-script · fdd93cbb · Nov 5, 2026 · 3 filesMessage 96 · StrongHigh 70Details
Commit message · merge-script

Merge bitcoin/bitcoin#36142: net: validate Tor onion service replies and cached keys

0a53d12589c3116495a50a694006ce5ee220fb2d torcontrol: reject invalid service IDs (Lőrinc)
d0b447cf7f11d791622c919d2a0731bf33a7d33f torcontrol: validate returned and cached keys (Lőrinc)
3413d17028da5f5658af5637297013f8e396bafa torcontrol: discard replies missing a service ID (Lőrinc)
3601a1d1086b132f11db3b5e969d8fac9203decc test: characterize ADD_ONION reply handling (Lőrinc)
d63a8576d9beef910c54aabc388278897c16a41f refactor: prepare ADD_ONION validation (Lőrinc)

Pull request description:

**Problem:** A node creates its onion service through Tor's control protocol and caches the returned `PrivateKey` value for reconnects.
Tor reply parsing unescapes quoted values, so a control endpoint can return a value containing a line break or space.
On reconnect, the node inserts that value unquoted into an `ADD_ONION` command.
CRLF frames the remainder as a separate command, while a space adds further arguments.
An unprivileged local process can exploit this by impersonating the default loopback endpoint while Tor is unavailable, seeding the cache, and releasing the port before Tor is available again.
A compromised operator-configured endpoint can return the same malicious value.
The reply handler also continues after receiving an invalid service ID, logging it and caching the key before attempting to advertise the invalid address.
A later reply without a service ID can reuse an ID left by an earlier reply.

**Fix:** This PR validates the returned service ID as a Tor v3 onion address before logging it, caching the key, or advertising the service.
Each reply must provide its own service ID, and reply fields stay local until validation succeeds.
Key validation accepts `NEW:ED25519-V3` or an `ED25519-V3` key whose Base64 payload decodes to 64 bytes.
Returned keys are validated before adoption or caching, and cached keys are validated before reuse.
A malformed cached key leaves the onion service unavailable until the operator removes the file and restarts the node. It cannot inject another command or argument.

ACKs for top commit:
jpk68:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d
vasild:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d
winterrdog:
tACK 0a53d12589c3116495a50a694006ce5ee220fb2d
sedited:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d

Tree-SHA512: ce3d75da56d9d2ef52655c15b8c85995cdec38305abc4c7af6baf45e03288e08e8ab13b67925b8f1c0a0734ae062101cb2bb912e962b517b8f99ee0e9911f882

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagedefensive validationcredential or privilege statemerge-commit duplicate discount
AI analysis · High 70/100

This update fixes a weakness in how Bitcoin Core talks to the Tor control port when setting up a hidden onion service. A fake or compromised Tor control endpoint could trick the node into storing a malicious private key. On a later reconnect, that bad key could be inserted into an 'ADD_ONION' command in a way that adds extra commands or arguments for Tor to run. The fix checks that any returned or cached private key has the expected format and that the returned onion address is a valid Tor v3 service ID before using or saving it.

Security candidateMerge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declarativelyby merge-script · 3b1ba022 · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declaratively

c723c37de69fd95e6ec795e848efb03d944999ba test: construct multisig_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. This replaces the field-by-field construction of transaction inputs and outputs in `multisig_tests` with `COutPoint`, `CTxIn` and `CTxOut` constructor calls.

It keeps `CMutableTransaction` as the builder, since a `CTransaction` constructor taking inputs and outputs directly is still under discussion (#36696). If one is added, the `vin`/`vout` lists here can be passed to it directly.

This change is test-only and does not change the constructed transactions:

- The funding outputs were previously created by `vout.resize(3)` and only had their `scriptPubKey` assigned, leaving `nValue` at its null value (`-1`). The `-1` is now spelled out explicitly, which makes this previously hidden value visible
- The loop index is changed from `int` to `uint32_t` to match `COutPoint::n`

ACKs for top commit:
purpleKarrot:
ACK c723c37
maflcko:
review ACK c723c37de69fd95e6ec795e848efb03d944999ba 🍯
alexanderwiederin:
ACK c723c37

Tree-SHA512: 3122762dae1e4fbc1a4ad79ce67128e83d29da965b3c8b6009f075c39310b8f983a96e3c4f30844a57af2faca4c658149808176aa4bb67d940ebeec147031676

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a test-only code cleanup in Bitcoin Core. It changes how fake transactions are built inside unit tests, making the test code more readable without altering the actual transactions being tested. There is no effect on the live Bitcoin network or wallet software.