Bitcoin Core

This commit fixes a typo in the NetBSD build documentation. The correct command to install packages with pkgin is 'pkgin install <package>', not 'pkgin <package>'. It does not change any code, build scripts, or runtime behavior.

This commit only removes a now-outdated sentence from five documentation files. The sentence told readers that some tests are skipped if Python 3 is missing, but that is no longer true after other recent changes. No code, build scripts, tests, or configuration were modified.

This is a straightforward code cleanup: a single missing C++ standard library header, <exception>, was added to a wrapper header file. It does not change program behavior, fix a crash, or address any security issue. It simply ensures the header compiles correctly on its own in all build configurations.

This is a tiny code cleanup in a CI (Continuous Integration) helper script. It replaces the hardcoded build directory name 'build' with a variable named 'build_dir' set to 'ci_build'. There is no security relevance; it is purely a refactor to make the script easier to maintain.

This is a routine cleanup of Bitcoin Core's internal continuous integration (CI) script. It replaces a long list of build options with a single shorthand preset ('dev-mode') and adds a compiler warning tolerance flag. There is no user-facing change, no network code change, and no security-relevant behavior change.

This commit changes one line in a Bitcoin Core continuous integration (CI) script. It replaces a manually written list of build options with a pre-defined developer-mode preset so that the automated code-quality (clang-tidy) job also covers the project's new kernel code. There is no change to the software users run, no bug fix, and no security-relevant behavior change.

This commit is a code cleanup that replaces several hand-written internal-error messages with a single standard macro. It does not change what the program does, only how error messages are formatted. There is no security issue here.

This is a documentation and code-cleanup change only. It removes an outdated compiler-lint suppression comment and slightly reformats a macro that throws an error when unreachable code is reached. There is no functional change to Bitcoin Core's behavior, and no security issue is introduced or fixed.

This change adjusts how Bitcoin Core is packaged for Linux so that the libgcc runtime library is bundled directly into the released binaries instead of being expected to come from the user's operating system. It also removes checks that previously ensured the released binaries only relied on specific system versions of libgcc. The goal is to make the official Linux releases work on a wider range of older or differently-configured distributions without requiring a particular libgcc to be installed. It is a build/packaging improvement rather than a fix for an active software bug or exploit.

This commit changes Bitcoin Core's Guix build setup so that a reproducibility patch for the GCC compiler is also applied when building Linux binaries, not just Windows ones. The patch strips out architecture-specific Guix store paths from debug symbols and now also from libunwind, making the resulting binaries more deterministic across different build machines. It is a build-hygiene/reproducibility fix, not a runtime security patch.

This is a small code cleanup change. It removes an unused optional parameter from a helper function that calculates the witness Merkle root for a Bitcoin block. All callers were already passing a special 'not used' value (nullptr), so the behavior of the program does not change. There is no security bug being fixed here.

This is a small code cleanup in Bitcoin Core's merkle tree calculation. It removes two unused parameters (`proot` and `pmutated`) from an internal helper function because the only place that called it always passed `nullptr` for both. There is no security issue here—just simplification of the code.

This is a small internal code cleanup in Bitcoin Core's merkle tree calculation. It changes one function so that a list of hash values is passed by reference instead of by pointer, removing optional null-pointer checks that were no longer needed. There is no change to network behavior, consensus rules, or user-visible security.

This commit is a pure build-system and file relocation cleanup. It moves the bitcoin_ipc_test library definition and its associated test files from src/test/ to src/ipc/test/ so the Cap'n Proto compiler can use simpler relative import paths. No runtime behavior of Bitcoin Core changes, and no security vulnerability is introduced or fixed.

This commit only adds a new test case to Bitcoin Core's automated test suite. It demonstrates an existing behavior of the CoinGrinder coin-selection algorithm: if too many combinations must be tried, the algorithm stops before finding a valid solution. The commit does not change any production wallet code, so it cannot by itself introduce a security vulnerability or fix one in live software.

This commit is a build-system cleanup for Bitcoin Core's Guix reproducible-build scripts. It moves the '-static-libstdc++' linker flag from the general host linker flags into the CMake executable-only linker flags, so the static C++ standard library is linked only for executables and not accidentally applied elsewhere. There is no security-relevant change here.

This commit is a simple code cleanup in Bitcoin Core's test suite. It moves a helper function that creates a deliberately broken transaction from one test file into a shared test library so other tests can reuse it. No production code, network rules, or wallet behavior are changed.

This is a tiny, non-functional code cleanup in Bitcoin Core's public C kernel API header. It changes one function parameter from a plain unsigned integer to a named enumeration type, and fixes a grammar typo in a comment. There is no security relevance.

This commit only updates two Windows build instruction documents to mention a standard CMake help command. It does not change any program code, build scripts, or configuration logic, and has no security relevance.

This is a minor code cleanup (refactor) that changes how a diagnostic helper passes a C++ standard library object. It does not fix a security bug, change behavior, or introduce a vulnerability. The accompanying build-script changes only suppress a compiler warning that newer compilers would not emit anyway.

This is a routine code-quality change that swaps the old way of recording file, line, and function names in assertion helpers for a modern C++ standard feature. It fixes a compiler warning that could appear when assertions are used in certain contexts, but it does not change what the program does or fix any security bug.

This commit is a code cleanup: it removes an unused 'nullptr witness' code path from a Bitcoin Core function that counts signature operations in SegWit transactions. The change does not alter behavior in normal operation because the nullptr path was never reached. It is not a security fix.

This commit changes how Bitcoin Core's test files are copied into the build directory during compilation. It replaces a broad 'grab everything recursively' approach with explicit lists of file types per folder. There is no security vulnerability here; it is a build-system cleanup that makes the test setup more predictable and avoids accidentally linking unexpected files.

This commit simply removes two unused helper functions from Bitcoin Core's test code. The helpers relied on an old wallet command that no longer works and were only used for another removed test feature. There is no security issue here.

This is a minor code cleanup change. It removes a comment marker used by an automated linting tool (clang-tidy) because the tool no longer needs it. The actual code behavior is unchanged.