ci: Use cmake --preset=dev-mode in test-each-commit task
What the developer wrote
Authored by MarcoFalke
ci: Use cmake --preset=dev-mode in test-each-commit task
What changed, and why it matters
This is a routine cleanup of Bitcoin Core's internal continuous integration (CI) script. It replaces a long list of build options with a single shorthand preset ('dev-mode') and adds a compiler warning tolerance flag. There is no user-facing change, no network code change, and no security-relevant behavior change.
No security action required. Treat as normal infrastructure/maintenance change.
Security signals we found
No security signals detected: change is confined to CI build invocation.
No changes to consensus, networking, wallet, cryptography, or RPC code.
No new dependencies, permissions, secrets, or external inputs introduced.
Evidence from the diff
The commit modifies .github/ci-test-each-commit-exec.py, a GitHub Actions helper that builds and tests each commit in a pull request. The explicit CMake flags (WITH_ZMQ, BUILD_GUI, BUILD_BENCH, BUILD_FUZZ_BINARY, WITH_USDT, BUILD_KERNEL_LIB, BUILD_KERNEL_TEST) are replaced by –preset=dev-mode, which presumably enables the same or similar options centrally. A new -DCMAKE_CXX_FLAGS=-Wno-error=unused-member-function flag is added so intermediate commits in a PR do not fail CI on unused member functions. The build type, warnings-as-error, and optimization flags remain.
Changed components
.github/ci-test-each-commit-exec.pyInspect captured patch +2 / −7
diff --git a/.github/ci-test-each-commit-exec.py b/.github/ci-test-each-commit-exec.py
index 959a1579..67534ec6 100755
--- a/.github/ci-test-each-commit-exec.py
+++ b/.github/ci-test-each-commit-exec.py
@@ -37,13 +37,8 @@ def main():
"-DAPPEND_CFLAGS='-O3 -g2'",
"-DCMAKE_BUILD_TYPE=Debug",
"-DWERROR=ON",
- "-DWITH_ZMQ=ON",
- "-DBUILD_GUI=ON",
- "-DBUILD_BENCH=ON",
- "-DBUILD_FUZZ_BINARY=ON",
- "-DWITH_USDT=ON",
- "-DBUILD_KERNEL_LIB=ON",
- "-DBUILD_KERNEL_TEST=ON",
+ "--preset=dev-mode",
+ # Tolerate unused member functions in intermediate commits in a pull request
"-DCMAKE_CXX_FLAGS=-Wno-error=unused-member-function",
])
run(["cmake", "--build", "build", "-j", str(num_procs)])
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.