Bitcoin Core

This is a test-only change that lets one of Bitcoin Core's automated functional tests run using the bitcoin-cli command-line tool in addition to the existing Python RPC proxy path. It does not change the actual Bitcoin node software, network protocol, wallet handling, or any user-facing behavior. There is no security issue here.

This is a minor code cleanup in a test file. It replaces a manual way of creating a connection to the Bitcoin node with a helper method that does the same thing. There is no security issue here.

This is a minor test-only change. It removes a flag that prevented a shutdown test from running with the command-line interface option and switches to a standard helper for creating an RPC connection. There is no change to the actual Bitcoin Core software that users run, and no security relevance.

This is a test-only change that lets one of Bitcoin Core's automated functional tests run in a mode where it calls the node through the command-line bitcoin-cli tool instead of only through the Python RPC library. It does not change any production code, consensus rules, wallet handling, or network behavior that real users rely on.

This commit is a cleanup of compiler warning annotations in a public C header. It removes 'you must use the return value' warnings from simple getter functions (like asking for the number of inputs in a transaction) and adds them to functions that return error codes or newly created objects. The change does not alter program behavior, fix a crash, or close a security hole; it only makes developer tooling warnings more accurate.

This is a test-only fix for a flaky automated test on Windows. It adds one more network error code (ECONNABORTED) to the list of temporary connection errors that the test framework should ignore while waiting for a Bitcoin node to start or shut down. It does not change Bitcoin Core's production code, network behavior, or security.

This is a minor GitHub Actions CI configuration fix. It moves a comment onto its own line so that the cache save and restore steps use identical path patterns. There is no security issue in the code change itself.

This is a routine Continuous Integration (CI) script cleanup. It turns on a stricter shell error mode (`pipefail`) and adjusts how build statistics are parsed so the script keeps working. There is no user-facing Bitcoin node behavior change and no security issue.

This commit simply removes two unused library links from the build configuration for bitcoin-cli, the command-line tool. There is no code change and no security issue is indicated.

This commit replaces the HTTP client library used by bitcoin-cli (libevent) with a new custom-built HTTP client. It is a large refactoring change that touches network communication, credential handling, and error messages. There is no direct evidence in the commit that this fixes a known security bug, but any rewrite of network and authentication code carries a risk of introducing subtle bugs in how bitcoin-cli talks to the Bitcoin server.

This commit only changes Bitcoin Core's internal functional test code. It replaces hardcoded {'rules': ['segwit']} parameters with a shared constant NORMAL_GBT_REQUEST_PARAMS when calling getblocktemplate in tests. There is no change to production node code, no change to consensus rules, and no security fix or vulnerability introduced.

This commit simply marks an old wallet startup option called -walletrbf as deprecated. Since a recent release already makes all transactions replaceable by default, the option is now redundant. The change adds a warning when the option is used and updates tests to expect that warning. There is no security vulnerability here.

This is a routine Bitcoin Core change that hides an old transaction status field called 'bip125-replaceable' from wallet RPC responses by default, marking it as deprecated. Users can still get it back by starting the node with -deprecatedrpc=bip125. It is not a security fix and does not introduce a vulnerability; it is a user-interface/API cleanup following earlier changes that made transactions replaceable by default.

This commit only adds a new automated test for an existing Bitcoin Core data structure. It does not change any production code, network behavior, or wallet logic. There is no security issue here.

This commit fixes a bug in how Bitcoin Core lists external hardware wallets (signers). Previously, if the list contained duplicate signers, the code would stop processing entirely after the first duplicate, potentially hiding valid non-duplicate signers from the user. The fix changes the behavior so duplicates are skipped while the rest of the list is still processed. This is a correctness and usability fix rather than a direct theft-of-funds vulnerability, but it could mislead a user about which hardware wallets are available.

This is a straightforward internal code cleanup in Bitcoin Core's wallet migration feature. It changes how wallet names are passed around so that the code stores names directly in a result structure rather than fetching names from live wallet objects. There is no security-relevant change visible in the diff, and the commit message explicitly calls it a refactor.

This commit only updates hardcoded test data used by Bitcoin Core's internal unit tests. The data is a pre-generated regtest (regression test) blockchain, and the change regenerates it so the tests continue to work with the current code. There is no change to production code, no network-facing change, and no security fix or vulnerability introduced.

This change tightens a safety check in Bitcoin Core's transaction memory pool (mempool) handling. When a group (package) of related transactions is submitted and one fails a final consensus check, the code now removes that failing transaction plus every transaction that comes after it in the package. The commit message calls it a 'belt-and-suspenders' fix to prevent the mempool from becoming internally inconsistent if a parent transaction fails but a child transaction does not. It is a defensive hardening patch rather than a confirmed exploitable bug.

This commit is a straightforward internal code reorganization. It moves the logic that applies custom soft-fork activation settings from one place in the code to another, grouping it into a reusable helper function. There is no change to how Bitcoin Core behaves, no bug fix, and no security-relevant change visible in the diff.

This commit only adds new fuzz testing code and a sanitizer suppression for a known, harmless LevelDB sign-conversion issue. It does not change any production Bitcoin Core code, so it cannot introduce a runtime vulnerability in the software users run.

This change makes a LevelDB database file-size setting configurable rather than hard-coded. It is described by the author as useful for fuzzing (automated testing with random inputs). There is no direct security fix here; it is a test/development plumbing change.

This change adds a new testing-only option for Bitcoin Core's internal database wrapper. It lets fuzz tests and other test code inject a fake, deterministic LevelDB environment. It does not change normal node behavior and is not a security fix or vulnerability.

This commit simply moves a small helper function from one internal source file to a header file so it can be reused elsewhere. There is no change to what the function does, no bug fix, and no security-relevant behavior change.

This commit is a straightforward code cleanup: it adds a timeout parameter to a low-level network connection helper function. Existing callers keep using the same default timeout they used before, so observable behavior is unchanged. There is no indication this fixes a security bug.

This is a harmless code cleanup in Bitcoin Core's internal test framework. A developer extracted a small block of code that creates an RPC connection into a reusable helper function. No behavior changed, no user-facing code was modified, and there is no security issue.