test: Allow feature_shutdown.py --usecli
What the developer wrote
Authored by MarcoFalke
test: Allow feature_shutdown.py --usecli
What changed, and why it matters
This is a minor test-only change. It removes a flag that prevented a shutdown test from running with the command-line interface option and switches to a standard helper for creating an RPC connection. There is no change to the actual Bitcoin Core software that users run, and no security relevance.
No action needed. This is a benign test maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies test/functional/feature_shutdown.py. It removes self.supports_cli = False, allowing the test to be run with –usecli. It also replaces a manual get_rpc_proxy() call with self.nodes[0].create_new_rpc_connection(). These are test-framework internal cleanups with no effect on bitcoind consensus, networking, wallet, or RPC security behavior.
Changed components
test/functional/feature_shutdown.pyInspect captured patch +2 / −3
diff --git a/test/functional/feature_shutdown.py b/test/functional/feature_shutdown.py
index 3b4c35cb..50ae234e 100755
--- a/test/functional/feature_shutdown.py
+++ b/test/functional/feature_shutdown.py
@@ -5,7 +5,7 @@
"""Test bitcoind shutdown."""
from test_framework.test_framework import BitcoinTestFramework
-from test_framework.util import assert_equal, get_rpc_proxy
+from test_framework.util import assert_equal
from threading import Thread
def test_long_call(node):
@@ -17,10 +17,9 @@ class ShutdownTest(BitcoinTestFramework):
def set_test_params(self):
self.setup_clean_chain = True
self.num_nodes = 1
- self.supports_cli = False
def run_test(self):
- node = get_rpc_proxy(self.nodes[0].url, 1, timeout=600, coveragedir=self.nodes[0].coverage_dir)
+ node = self.nodes[0].create_new_rpc_connection()
# Force connection establishment by executing a dummy command.
node.getblockcount()
Thread(target=test_long_call, args=(node,)).start()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.