Bitcoin Core

guix: Update `python-signapple` and wrap with OpenSSL paths

mining: add submitBlock IPC method to Mining interface

Add a submitBlock method to the Mining IPC interface, similar to the
submitblock RPC. This accepts a fully assembled block, validates it, and
if accepted as new, processes it into chainstate.

This is needed for Stratum v2 Job Declarator Server (JDS), where accepted
solutions may correspond to jobs not tied to a Bitcoin Core BlockTemplate.
JDS receives PushSolution fields and reconstructs full blocks; without an
IPC submitBlock method, final submission requires the submitblock RPC.

The method returns detailed status (reason/debug strings) matching the
checkBlock pattern, giving callers enough information to handle
validation failures.

test: add IPC submitBlock functional test

Test the new Mining.submitBlock IPC method:
- Invalid block (bad version) returns failure with reason
- Valid block (with a real mempool tx) is accepted and propagates
- Duplicate block returns failure with "duplicate" reason
- Witness commitment without coinbase witness nonce is rejected
(bad-witness-nonce-size), confirming no auto-fix behavior
- submitBlock then submitSolution: duplicate is accepted (submitSolution
returns true for already-known blocks)
- submitSolution then submitBlock interaction (duplicate)

Build candidate blocks from BlockTemplate data in the existing coinbase and
submission test, then exercise checkBlock(), submitSolution(), and
submitBlock() against those candidates. submitBlock() uses an isolated IPC
node for cases that would otherwise affect the main submitSolution() and
checkBlock() assertions.

refactor: introduce SubmitBlock helper

Introduce a SubmitBlock() helper in node/miner.cpp that wraps
ProcessNewBlock submission and captures validation state through
the BlockChecked callback.

Route submitSolution through the helper before adding any new IPC method.

No behavior change.

wallet: refactor to read -walletrbf only once instead of twice

test: Allow --usecli in tests that already support it

test: Catch CalledProcessError to support --usecli in feature_dbcrash.py

test: use echojson to allow rpc_named_arguments.py --usecli

The echo and echojson RPCs are identical in the server. The only
difference is that echojson is in the client conversion table.

test: Stop node before modifying config to support rpc_users.py --usecli

Otherwise, bitcoin-cli will read the wrong config from the "future".

chainparams: add overloads for RegTest and SigNet with no options

For consistency with the overloads introduced in the previous commit,
and because there is already a few places where they are useful.

chainparams: make deployment configuration available on all test networks

This allows unit tests to set `-testactivationheight` and `-vbparams` on
all networks instead of exclusively on regtest. Those are kept
test-network-only when used as startup parameters.

util: Require integers for SaturatingAdd() and AdditionOverflow()

Previously we could fall back to using an unspecialized implementation of std::numeric_limits<T> which would compile as long as the numeric operators existed, but would return 0 for min() & max().

doc: add release notes for #35319

net: ensure no direct private broadcast connections

Private broadcast connections use either Tor or I2P, which require a
proxy intrinsically or IPv4 or IPv6 which must use a proxy in the
context of private broadcast to avoid leaking the originator's IP
address.

Add a safety check to guard against future mistakes.

Co-authored-by: Andrew Toth <andrewstoth@gmail.com>

net: use the proxy if overriden when doing v2->v1 reconnections

`OpenNetworkConnection()` supports overriding the proxy to use for
connecting. However when v2 connection is attempted and it fails a v1
connection is tried without that proxy.

Store the override proxy in `CNode` and pass it to
`CConnman::m_reconnections` to be used for v1 retries.

rpc: Correct type for tx_sigops

Broken out from larger effort to make CAmount more type safe.

test: remove the lazy import of util in authproxy

This lazy import prompted the removal of the circular dependency, so
remove it now that we can.

test: move out JSONRPCException from authproxy to util

So that util is not dependent on authproxy at all and going
forward authproxy can use util methods.

Reviewing with --color-moved=dimmed-zebra option can be helpful.

doc: add feature deprecation and removal process to developer notes

Adds a dedicated "Feature deprecation and removal process" section to
developer-notes.md covering the deprecation lifecycle for RPC methods,
startup options, REST interface, and ZMQ.

Closes #31980

test: Set TestNode url field early, so that feature_loadblock.py --usecli works

doc: add release notes for deprecation of wallet rbf & bip125 fields

wallet: remove "RPC Only" from -walletrbf option help description

Effective post https://github.com/bitcoin-core/gui/pull/936.

Co-authored-by: Pol Espinasa <pol.espinasa@uab.cat>

ci: switch to GitHub cache for all runners

Cirrus is winding down and github now offers more than 10GB cache.

Switch to GH cache for all runner-types. Simplify docker build arg
construction, and reduce the number of needed action permissions.

rpc: avoid moving RPC enum types

`RPCArg::Type` and `RPCResult::Type` are enum values, so moving them in constructors is no different from copying them.

Initialize the stored type fields directly.

txgraph: avoid moving primitive members

`CommitStaging()` moved primitive staging members into the main cluster set even though moving them only copies the values.

Assign the primitive members directly and keep moves for the owning containers.