What changed, and why it matters
This commit is a documentation cleanup. It removes libevent from build instructions and dependency lists because Bitcoin Core no longer uses libevent. It also updates a code comment in the wallet encryption file to remove an outdated reference to a macOS/libevent bug, explaining instead that the timeout is clamped to prevent overflow. There are no code behavior changes and no security fix.
No security action needed. This is a routine documentation and comment maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is entirely non-functional. Six documentation files have libevent removed from package lists and dependency tables. In src/wallet/rpc/encrypt.cpp, only a comment is changed: the old comment mentioning a ‘macos/libevent bug’ is replaced with a comment about avoiding overflow when computing the relock time. The constant MAX_SLEEP_TIME and all surrounding logic remain unchanged.
Changed components
doc/build-freebsd.mddoc/build-netbsd.mddoc/build-openbsd.mddoc/build-osx.mddoc/build-unix.mddoc/dependencies.mdsrc/wallet/rpc/encrypt.cpp (comment only)Inspect captured patch +10 / −11
diff --git a/doc/build-freebsd.md b/doc/build-freebsd.md
index 40740d7f..11f53e08 100644
--- a/doc/build-freebsd.md
+++ b/doc/build-freebsd.md
@@ -10,7 +10,7 @@ This guide describes how to build bitcoind, command-line utilities, and GUI on F
Run the following as root to install the base dependencies for building.
```bash
-pkg install boost-libs cmake git libevent pkgconf
+pkg install boost-libs cmake git pkgconf
```
SQLite is required for the wallet:
diff --git a/doc/build-netbsd.md b/doc/build-netbsd.md
index f50baab4..b1b9e461 100644
--- a/doc/build-netbsd.md
+++ b/doc/build-netbsd.md
@@ -12,7 +12,7 @@ Install the required dependencies the usual way you [install software on NetBSD]
The example commands below use `pkgin`.
```bash
-pkgin install git cmake pkg-config boost libevent
+pkgin install git cmake pkg-config boost
```
NetBSD currently ships with an older version of `gcc` than is needed to build. You should upgrade your `gcc` and then pass this new version to the CMake configuration.
diff --git a/doc/build-openbsd.md b/doc/build-openbsd.md
index 5edc56f0..d64fd909 100644
--- a/doc/build-openbsd.md
+++ b/doc/build-openbsd.md
@@ -10,7 +10,7 @@ This guide describes how to build bitcoind, command-line utilities, and GUI on O
Run the following as root to install the base dependencies for building.
```bash
-pkg_add git cmake boost libevent
+pkg_add git cmake boost
```
SQLite is required for the wallet:
diff --git a/doc/build-osx.md b/doc/build-osx.md
index a6a2d3be..f895ce88 100644
--- a/doc/build-osx.md
+++ b/doc/build-osx.md
@@ -50,7 +50,7 @@ See [dependencies.md](dependencies.md) for a complete overview.
To install, run the following from your terminal:
``` bash
-brew install cmake boost pkgconf libevent capnp
+brew install cmake boost pkgconf capnp
```
#### Wallet Dependencies
diff --git a/doc/build-unix.md b/doc/build-unix.md
index f1120d39..e1d2364e 100644
--- a/doc/build-unix.md
+++ b/doc/build-unix.md
@@ -46,10 +46,10 @@ for additional features in later columns are optional.
| Package manager | Required build dependencies | SQLite (wallet) | Cap'n Proto (IPC) | ZMQ | USDT | Qt and libqrencode (GUI) |
| ----------------------- | --------------------------- | --------------- | ----------------- | --- | ---- | ------------------------ |
-| Debian / Ubuntu (`apt`) | `build-essential cmake pkgconf python3 libevent-dev libboost-dev` | `libsqlite3-dev` | `libcapnp-dev capnproto` | `libzmq3-dev` | `systemtap-sdt-dev` | `qt6-base-dev qt6-tools-dev qt6-l10n-tools qt6-tools-dev-tools libgl-dev qt6-wayland libqrencode-dev` |
-| Fedora (`dnf`) | `gcc-c++ cmake make python3 libevent-devel boost-devel` | `sqlite-devel` | `capnproto capnproto-devel` | `zeromq-devel` | `systemtap-sdt-devel` | `qt6-qtbase-devel qt6-qttools-devel qt6-qtwayland qrencode-devel` |
-| Alpine (`apk`) | `build-base cmake linux-headers pkgconf python3 libevent-dev boost-dev` | `sqlite-dev` | `capnproto capnproto-dev` | `zeromq-dev` | Not supported | `qt6-qtbase-dev qt6-qttools-dev libqrencode-dev` |
-| Arch (`pacman`) | `gcc make cmake pkgconf python libevent boost` | `sqlite` | `capnproto` | `zeromq` | `systemtap` | `qt6-base qt6-tools qt6-wayland qrencode` |
+| Debian / Ubuntu (`apt`) | `build-essential cmake pkgconf python3 libboost-dev` | `libsqlite3-dev` | `libcapnp-dev capnproto` | `libzmq3-dev` | `systemtap-sdt-dev` | `qt6-base-dev qt6-tools-dev qt6-l10n-tools qt6-tools-dev-tools libgl-dev qt6-wayland libqrencode-dev` |
+| Fedora (`dnf`) | `gcc-c++ cmake make python3 boost-devel` | `sqlite-devel` | `capnproto capnproto-devel` | `zeromq-devel` | `systemtap-sdt-devel` | `qt6-qtbase-devel qt6-qttools-devel qt6-qtwayland qrencode-devel` |
+| Alpine (`apk`) | `build-base cmake linux-headers pkgconf python3 boost-dev` | `sqlite-dev` | `capnproto capnproto-dev` | `zeromq-dev` | Not supported | `qt6-qtbase-dev qt6-qttools-dev libqrencode-dev` |
+| Arch (`pacman`) | `gcc make cmake pkgconf python boost` | `sqlite` | `capnproto` | `zeromq` | `systemtap` | `qt6-base qt6-tools qt6-wayland qrencode` |
For Debian "oldstable", or earlier Ubuntu LTS releases, you may need to pick a
later compiler version, according to the [dependencies](/doc/dependencies.md)
diff --git a/doc/dependencies.md b/doc/dependencies.md
index 5e1a1948..23e30784 100644
--- a/doc/dependencies.md
+++ b/doc/dependencies.md
@@ -23,7 +23,6 @@ Bitcoin Core requires one of the following compilers.
| --- | --- | --- |
| [Boost](../depends/packages/boost.mk) | [link](https://www.boost.org/users/download/) | [1.74.0](https://github.com/bitcoin/bitcoin/pull/34107) |
| CMake | [link](https://cmake.org/) | [3.22](https://github.com/bitcoin/bitcoin/pull/30454) |
-| [libevent](../depends/packages/libevent.mk) | [link](https://github.com/libevent/libevent/releases) | [2.1.8](https://github.com/bitcoin/bitcoin/pull/24681) |
### Runtime
diff --git a/src/wallet/rpc/encrypt.cpp b/src/wallet/rpc/encrypt.cpp
index 68a80eb8..49490d57 100644
--- a/src/wallet/rpc/encrypt.cpp
+++ b/src/wallet/rpc/encrypt.cpp
@@ -60,8 +60,8 @@ RPCMethod walletpassphrase()
if (nSleepTime < 0) {
throw JSONRPCError(RPC_INVALID_PARAMETER, "Timeout cannot be negative.");
}
- // Clamp timeout
- constexpr int64_t MAX_SLEEP_TIME = 100000000; // larger values trigger a macos/libevent bug?
+ // Clamp timeout to ~3 years to avoid overflow when computing the relock time
+ constexpr int64_t MAX_SLEEP_TIME = 100000000;
if (nSleepTime > MAX_SLEEP_TIME) {
nSleepTime = MAX_SLEEP_TIME;
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.