Bitcoin Core

This is a minor cleanup in Bitcoin Core's dependency build system. It removes an extra file-existence check that was already being handled elsewhere. There is no security issue visible in the change.

This commit fixes a build-system bug in Bitcoin Core's dependency downloader. Previously, the build system would create a 'download finished' timestamp file before the download actually completed. If the download was interrupted or failed, that timestamp file could still exist, making the build system think the dependency was already downloaded and skip retrying. The fix moves the timestamp creation to after the download and checksum steps succeed. This is primarily a reliability/build correctness issue; direct security impact is limited and indirect.

This commit fixes a bug in Bitcoin Core's transaction memory pool (mempool) handling during blockchain reorganizations (reorgs). A reorg happens when the network briefly has two competing versions of recent history and one wins. The bug caused the mempool to wrongly enforce new TRUC topology rules on old transactions being restored after a reorg. That could reject a chain of historically valid, high-fee transactions and waste CPU checking rules that were never meant to apply in that situation. The fix adds a bypass flag so those checks are skipped during reorg recovery, matching the original design intent.

This commit only adds and improves test coverage in Bitcoin Core's functional test suite. It changes one test file (mempool_truc.py) to more thoroughly exercise how TRUC (a new transaction relay policy) behaves during blockchain reorganizations. There is no change to production code, consensus rules, or network behavior, so it does not introduce or fix a security vulnerability on its own.

This change only modifies Bitcoin Core's internal fuzz testing code, not the production mempool logic. It adjusts how test harnesses feed random data into the mempool acceptance routine so that most harnesses no longer skip standard policy limits. The patch improves test coverage for a new transaction type (TRUC) but does not fix a security bug in live software.

This commit simply updates the versions of several linting tools used in Bitcoin Core's continuous integration (CI) pipeline. Linting tools check code style and catch common mistakes but are not part of the actual Bitcoin software that users run. There is no security-relevant code change here.

This is a one-line fix in Bitcoin Core's internal Python test framework. It adds a wait to ensure a background network thread has fully started before tests continue. The change only affects test code, not the live Bitcoin node software that users run, so it cannot be used to attack real Bitcoin wallets or the network. It addresses a timing-related test flakiness issue, not a security vulnerability in production code.

This is a routine code cleanup in Bitcoin Core's networking layer. It merges two internal functions that check whether the node is already connected to a given internet address, and removes a now-redundant unit test. There is no security-relevant change: the function still does the same basic check, just with slightly simpler code.

This commit simply changes the size of a virtual machine used for one automated testing job in Bitcoin Core's GitHub Actions setup, switching from a large to a medium-sized runner. It has no effect on the Bitcoin software users run, on wallets, transactions, consensus rules, or network security.

This change only affects Bitcoin Core's internal functional test framework. It limits the number of script verification threads used during automated tests to avoid running out of file descriptors or hitting other resource limits on the test machine. It does not change production Bitcoin node behavior and is not a security fix for live software.

This is a small quality-of-life improvement to Bitcoin Core's internal testing tools. It changes how test error messages are printed so that only the log messages that were actually missing are reported, rather than the whole list. It also avoids rechecking messages that were already found. There is no change to the live Bitcoin network code, wallet, consensus rules, or any user-facing behavior.

This is a small code-quality cleanup in Bitcoin Core's test framework. It replaces regular-expression searches with simple string searches because the search strings were always being escaped anyway, making regex unnecessary. There is no security impact.

This is a minor internal cleanup in Bitcoin Core's automated testing code. It changes how debug log messages are formatted only when a test fails, and tweaks the wording of error messages. There is no security issue.

This commit only removes a two-line comment in a test helper file because the comment no longer matched what the function actually does. No code behavior was changed, so there is no security impact.

This commit fixes a capitalization typo in the help text for the `finalizepsbt` RPC command. The documentation previously referred to `final_scriptWitness` but the actual PSBT field name is `final_scriptwitness` (all lowercase). This is purely a documentation string change and has no effect on code behavior, transaction processing, or security.

This is a build-script bug fix. The macOS packaging helper would crash with an error if no Qt translation directory was provided, because it tried to use a NULL/default value. The fix simply skips the translation-copying step when no directory is configured. It does not affect Bitcoin's network code, wallet security, or consensus rules.

This change updates a Bitcoin Core GitHub Actions workflow so that it no longer downloads and runs a third-party JavaScript action (ilammy/msvc-dev-cmd) to set up the Microsoft Visual Studio build environment on Windows. Instead, it uses a small PowerShell script that runs a tool already installed with Visual Studio (vswhere.exe) and then calls the official Microsoft batch file (vsdevcmd.bat). The main benefit is reducing supply-chain risk: the project no longer depends on an external, pinned-but-third-party action that could be compromised or behave unexpectedly. There is no direct vulnerability being fixed in Bitcoin Core's own code.

This commit swaps one continuous-integration (CI) test runner from CentOS to Alpine Linux (musl). It only changes build/test automation files, not the Bitcoin Core software that users run. There is no security-relevant code change here.

This commit only changes how many log messages Bitcoin Core prints while replaying blocks after an interrupted reindex. It reduces noisy 'Rolling back/forward' lines to avoid triggering a new log rate limiter. There is no security bug being fixed here.

This commit fixes a math bug in the Bitcoin Core block-building code. The original code subtracted a safety margin from the maximum block weight and then compared the current block weight to that lower number. Because the variables are unsigned integers, if the block weight was already larger than expected, the subtraction could underflow and wrap around to a huge number, making the comparison behave incorrectly. The fix rewrites the comparison as an addition on the other side, which cannot underflow. The practical effect is on when the miner decides to stop trying to add more transactions; the bug could make it give up too early or keep going too long in edge cases.

This commit is a routine cleanup of Bitcoin Core's functional test code. It removes a helper method called convert_to_json_for_cli that was used to wrap arguments when tests were run against the command-line bitcoin-cli tool. The change only affects internal test scripts and has no impact on the live Bitcoin network, wallets, or node security.

This commit changes how Bitcoin Core's command-line tool (bitcoin-cli) handles certain arguments. Previously, some RPC parameters like 'hash_or_height' and 'rollback' were always treated as JSON, meaning plain strings would be rejected with a JSON parsing error. Now, for a small set of parameters, the tool accepts either a valid JSON value or a plain string. This is a usability fix, not a security patch, and it does not change the Bitcoin node itself—only the client-side argument parser.

This Bitcoin Core change tweaks how the node picks a secret 'network key' used when replying to peer address requests. Previously the key was computed fresh each time from the peer's network type and the local bind address. Now it is computed once when a connection is created and stored on the CNode object. The stated goal is to make it easier to reuse the same anti-fingerprinting key in other parts of the code later. It is a refactoring/hardening patch, not a fix for an active bug or exploit.

This change makes Bitcoin Core's graphical wallet link a small X11 cursor helper library statically instead of relying on the operating system to provide it. That removes a runtime installation step for users on recent Ubuntu and other Linux distributions. It is a build/packaging convenience change, not a fix for an exploitable security bug.

This commit changes Bitcoin Core's internal continuous integration (CI) build scripts for a memory-sanitizer fuzz-testing job. It switches from building a custom Clang compiler from source to using pre-packaged Ubuntu LLVM 21 packages, and adds a linker flag (-lstdc++) to work around packaging-related link issues. There is no change to the Bitcoin Core software that users run, no change to consensus or networking code, and no security vulnerability is being fixed.