depends: Drop redundant check for downloaded file
What the developer wrote
Authored by Hennadii Stepanov
depends: Drop redundant check for downloaded file
The `fetch_file` commands are invoked for the `$($(package)_fetched)`
target, so the existence of the download stamp has already been tested.
What changed, and why it matters
This is a minor cleanup in Bitcoin Core's dependency build system. It removes an extra file-existence check that was already being handled elsewhere. There is no security issue visible in the change.
No security action needed. This is a routine build-system refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes a redundant test -f guard in depends/funcs.mk’s fetch_file macro. The fetch_file commands are only invoked for the $($(package)_fetched) target, where the download stamp’s existence has already been verified, making the inline check unnecessary. The functional behavior of fetching from the primary URL or the fallback path remains unchanged.
Changed components
depends/funcs.mkInspect captured patch +1 / −2
diff --git a/depends/funcs.mk b/depends/funcs.mk
index 31ce5f67..33c9c68c 100644
--- a/depends/funcs.mk
+++ b/depends/funcs.mk
@@ -36,9 +36,8 @@ define fetch_file_inner
endef
define fetch_file
- ( test -f $$($(1)_source_dir)/$(4) || \
( $(call fetch_file_inner,$(1),$(2),$(3),$(4),$(5)) || \
- $(call fetch_file_inner,$(1),$(FALLBACK_DOWNLOAD_PATH),$(3),$(4),$(5))))
+ $(call fetch_file_inner,$(1),$(FALLBACK_DOWNLOAD_PATH),$(3),$(4),$(5)))
endef
# Shell script to create a source tarball in $(1)_source from local directory
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.