Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…
Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…
Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.
This commit simply renames two groups of internal status labels (called enums) in the Trezor firmware's cryptographic code. The old names like WAITING_FOR_REQUEST1 were shared between two different parts of the code, so the developer gave …
This commit fixes three places in the Trezor firmware's cryptographic code where a memory-clearing function could be called with a NULL pointer. In practice, passing NULL to memzero is harmless on Trezor's platform (it does nothing), but i…
NULL pointer passed to memory-zeroing helper in cryptographic codeUndefined behavior in C standard library contractDefensive hardening in Noise protocol implementation
This commit is a code cleanup (refactor) for the cryptographic handshake code used in Trezor devices. It changes how the other party's long-term public key is returned to the caller: instead of storing it inside an internal state structure…
Removal of long-term public key storage from internal handshake stateCaller-supplied output buffer for remote static public key reduces internal secret retentionError-path memzero of returned key material on failure
This commit only updates test data. It corrects the capitalization (checksum) of Ethereum addresses used in automated tests and refreshes the expected screen-shot hashes those tests compare against. There are no changes to the actual Trezo…
This commit changes the Trezor Python library so that, when setting up a Trezor Model One (the original Trezor 1 device), it now performs an entropy check by default if the device runs firmware 1.13.1 or newer. Previously, the library only…
Enables a previously disabled security/validation feature (entropy check) for a specific device modelAdds version-gated behavior to avoid errors on older firmwareDefensive hardening of wallet setup randomness verification
This commit is a routine cleanup that removes the old SCons build system files from the Trezor Core firmware repository. It deletes Makefiles, SConscripts, and related Python helper scripts, but does not change any firmware source code, cr…
This commit updates Trezor's embedded MicroPython interpreter from an older version to 1.28.0. It pulls in several upstream MicroPython bug fixes, including stricter buffer-size checks for converting integers to bytes, a new stack-safety A…
Synchronizes upstream MicroPython fixes that include buffer-size and stack-safety hardeningPrevents Ctrl+C interruption of frozen boot code, reducing denial-of-service/control-flow risk during bootFixes sys.stdout.buffer.write() return value, which could affect code relying on correct I/O semantics
This commit is a simple code cleanup that replaces a common MicroPython string-creation pattern with a new helper function. It does not change what the code does, only how it is written. There is no security issue visible in the change.
This is a large but straightforward internal cleanup: the project switched from using the MicroPython `ubinascii` module's `hexlify`/`unhexlify` functions to the standard Python `bytes.hex()` and `bytes.fromhex()` methods. The change remov…
This commit is a routine code cleanup in the Trezor firmware's embedded MicroPython modules. It replaces an older, two-step object allocation pattern with a newer helper that allocates memory and sets the object type in one step. The chang…
No security-relevant logic changes observedNo input validation changesNo memory safety bug fixes (e.g., no overflow, use-after-free, or uninitialized memory fixes)
This is a code cleanup change in Trezor's firmware that swaps one MicroPython internal helper for another. It replaces calls that create byte or string objects from a vstr buffer with newer, purpose-built helpers. The commit message says t…
Refactor only: helper function renames with equivalent semanticsNew str helper adds UTF-8 validation; bytes helper does not validateNo input validation, length, or error-handling changes observed
This commit is a routine internal cleanup that switches how Trezor's firmware defines built-in MicroPython object types. It replaces older, manually-written type structures with a newer macro provided by the upstream MicroPython project. T…
This commit is a large but purely mechanical code cleanup: it replaces the custom STATIC macro with the standard C keyword static across many MicroPython module files. There is no change to program logic, security boundaries, or behavior. …
This commit is a routine code cleanup that updates Trezor firmware to match a newer MicroPython version where built-in module names dropped the 'u' prefix (for example, 'uos' became 'os' and 'ustruct' became 'struct'). It renames imports, …
This commit only updates the firmware version number from 2.12.4 to 2.12.5 in the source code and translation files. It does not change any security-related logic, fix any bug, or alter any cryptographic behavior. It is a routine release b…
This is a routine build-system cleanup for the Trezor firmware. It switches the internal 'trezor_lib' Rust crate to be built with the project's own 'xbuild' tool, removes transitional feature flags, and reorganizes Cargo.toml files. There …
This commit adds Bluetooth Low Energy (BLE) support for the Trezor T3T2 hardware model. It introduces new board configuration files, pin mappings, build scripts, and firmware binaries for the Nordic nRF54LS05A BLE radio used in T3T2. There…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidatefix(clear_signing): parse arrays of static structs per the ABI spec.by PrisionMike · 6cf0c47d · Jul 23, 2026 · 5 filesMessage 100 · StrongModerate 62Details
Commit message · PrisionMike
fix(clear_signing): parse arrays of static structs per the ABI spec.
Unify head handling in ABIValue.parse(): a static value is encoded in place (head_size bytes), a dynamic value's head is one word holding its body offset, relative to the enclosing block. Subclasses now implement only parse_body(). This replaces the four-branch isinstance dispatch in Array and the two-mode Tuple.parse.
Previously the Array unconditionally dereferenced element heads, assuming every struct element is a dynamic type, and from_proto compensated by mislabeling array-nested tuples as is_dynamic=False ("don't dereference again"). That pair is correct for dynamic structs (e.g. LiFi's, with bytes callData) but misparses arrays of fully static structs, whose elements are canonically encoded in place at a stride of the struct size, with no offsets at all.
is_dynamic is now the truthful, type-level ABI property everywhere: the four LiFi array-nested tuples become is_dynamic=True, and from_proto derives the flag for array-nested tuples from their fields (the wire flag stays ignored in that position, as it always was).
The two hand-crafted vectors for the debug paths descriptor encoded the old non-canonical layout (offset heads for a static struct array) and are re-encoded canonically; the JSON fixture's signature is recomputed accordingly. Note the signature assertions cannot catch encoding regressions (blind-signing fallback signs the same bytes); the new array-of-static-structs unit test and the token-request assertions in test_definitions_request.py are the real guards.
[no changelog]
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 62/100
This commit fixes a bug in how Trezor firmware parses Ethereum transaction data for 'clear signing' of complex smart-contract calls. The parser previously misread arrays of simple structs (e.g., lists of token-swap details) because it assumed every struct element was stored via an offset pointer, which is only true for structs containing variable-length data. With the correct ABI behavior, static structs are now read directly in sequence. The bug could cause Trezor to display wrong values or fall back to blind signing, but it does not leak private keys or directly steal funds. The fix also hardens parsing against malformed empty structs and out-of-bounds reads.
fix(clear_signing): fix bytes[] and strings[] parsing. [no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100
This commit fixes how Trezor firmware parses certain Ethereum transaction data types—specifically arrays of byte blobs (bytes[]) and arrays of strings (string[])—when showing clear signing details on the device screen. Before the fix, the code would follow an offset pointer twice, likely reading the wrong memory location and producing incorrect decoded values. That could cause the Trezor to display misleading transaction details to the user, potentially tricking them into approving a transaction that does what the screen does not show.
Security candidatefeat(common,core,python,tests): add support for StellarInvokeHostFunctionOp.by Jun Luo · 05344ecd · Jul 23, 2026 · 43 filesMessage 72 · AdequateLow 36Details
Commit message · Jun Luo
feat(common,core,python,tests): add support for StellarInvokeHostFunctionOp.
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathboot or update pathauthentication path
AI analysis · Low 36/100
This commit adds support for signing Stellar Soroban smart-contract transactions on Trezor hardware wallets. It introduces new message types, on-device confirmation screens, and serialization logic for complex contract arguments and authorization trees. The change is a feature addition rather than a bug fix; it does not by itself fix a known vulnerability, but it does expand the attack surface of the Stellar signing flow and includes several security-relevant design choices (e.g., showing externally signed authorizations only on request).
refactor(core): rename `MsgInSignTx` to `HandlerChainIdArg`
`MsgInSignTx` was used for both `with_keychain_from_chain_id` message handler and by clearsigning-related code.
`with_keychain_from_chain_id` message handler will be used also for EthereumSignAuth7702, which is not compatible with clearsigning - so it's better to separate the types.
[no changelog]
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Informational 15/100
This is a clean internal code rename in the Trezor firmware's Ethereum module. A shared type variable used by two different pieces of code is split into two separate type variables so that a future feature (EthereumSignAuth7702) can use the keychain helper without being incorrectly tied to transaction-signing code. No behavior changes, no bug fixes, and no security issue is present in the diff.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 19/100
This commit removes built-in, hard-coded display rules for the LI.FI swap/bridge protocol from Trezor's Ethereum 'clear signing' feature. It is a feature cleanup, not a fix for a code vulnerability. The change means Trezor will no longer automatically show friendly LI.FI transaction labels unless the user or wallet later loads an external definition file. The commit itself does not introduce a security bug, but it slightly changes how users verify LI.FI transactions on the device screen.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit is purely a test-data update for Trezor's Ethereum 'clear signing' feature. It removes old built-in test fixtures and adds new externally-supplied token/chain definition files so the test suite can exercise how the device handles user-provided definitions. There is no change to firmware, wallet logic, or security-critical code.
Instead of relying on the fixtures as the single source of truth, let's verify the fixtures as well. This should prevent taking a wrong device-produced signature and declaring it as the correct one when adding a new fixture.
95/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 12/100
This commit only changes a test file for Stellar cryptocurrency transaction signing. It adds a check that the expected signatures stored in test fixtures are mathematically valid, so that future tests don't accidentally treat a bad signature as correct. It does not change the actual Trezor firmware code that users rely on, so it has no direct security impact on devices.
test(ethereum): check function signature at source.
- Improves on #7308 - instead of copying func sig, we import it from source. - We can also safely use raw bytes instead of unhexlify at source.
[no changelog]
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This is a test-only refactoring commit. It changes how Ethereum function signatures are represented in firmware source code (from hex strings converted at runtime to raw byte literals) and updates the corresponding unit test to verify those signatures against Solidity function definitions. There is no runtime behavior change and no security fix or vulnerability.
Security candidaterefactor(core): use simpler `interact` in FIDO & ButtonRequest waitingby Roman Zeyde · c3895435 · Jul 22, 2026 · 6 filesMessage 77 · AdequateInformational 12Details
Commit message · Roman Zeyde
refactor(core): use simpler `interact` in FIDO & ButtonRequest waiting
Refactor FIDO-related layouts and ButtonRequest-waiting layout, so they use the new helper function.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathauthentication pathparser or protocol path
AI analysis · Informational 12/100
This commit is a straightforward internal code cleanup. It replaces several direct uses of a lower-level UI helper (`Layout(...).get_result()`) with a simpler wrapper function (`interact_simple`). The behavior described in the comments—specifically that the waiting screen must not start its own ButtonRequest handler—is preserved in the new helper usage. There is no indication this change fixes or introduces a security vulnerability.
fix(core): re-implement `draw_simple()` to avoid scoping violations
Use a basic form of `interact()`, to be sure that passphrase prompt layout will be properly stopped.
Following #7282.
[no changelog]
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlcryptography-sensitive pathboot or update pathauthentication path
AI analysis · Low 32/100
This commit fixes a UI lifecycle bug in Trezor firmware. The old `draw_simple()` function started a layout but did not properly wait for it to finish or stop it, which could leave stale UI tasks running ('scoping violations'). The new `interact_simple()` runs the layout to completion and returns its result, ensuring the passphrase prompt is correctly stopped. The security relevance is implied by the commit title and comments, but no explicit security disclosure or CVE is present.
Security candidatefix: build-docker.sh: build T1B1 firmware only for firmware targetby Andrew Kozlik · 17890ebf · Jul 21, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Andrew Kozlik
fix: build-docker.sh: build T1B1 firmware only for firmware target
The legacy build ignored --targets and ran on every invocation that included T1B1. CI invokes the script separately for prodtest/bootloader and for firmware, so each T1B1 job built the identical legacy firmware twice.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
update trust
AI analysis · Informational 15/100
This commit fixes a CI/build script inefficiency. The build script was building the same T1B1 (original Trezor) firmware twice because it ignored the requested build target. The fix makes the legacy T1B1 firmware build run only when the 'firmware' target is explicitly requested, and adjusts the CI workflow to initialize the build environment once and skip the redundant bootloader/prodtest step for T1B1. There is no security vulnerability here—just wasted build time.
- Updated to the last successful build of nixpkgs-unstable, hash: f600ea449c7b5bb596fa1cf21c871cc5b9e31316 - Includes minor formatting adjustments.
[no changelog]
63/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
boot or update path
Security candidatefix(l10n): updating and fixing English strings - fewer versions per different layout - added period in places where it was missing - new description string for PIN reenter on Delizia [no changelog]by Michal Kazda · 42dbc643 · Jul 21, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Michal Kazda
fix(l10n): updating and fixing English strings - fewer versions per different layout - added period in places where it was missing - new description string for PIN reenter on Delizia [no changelog]
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
access control
AI analysis · Informational 15/100
This commit only changes user-visible text strings in the Trezor firmware. It updates English translations, removes duplicate layout-specific versions of the same phrase, adds missing periods, and introduces a new description string shown when re-entering a PIN on the Delizia device layout. There is no code behavior change that would affect security.
Security candidatefix(core/delizia): warning title should be red if `danger=true`by Roman Zeyde · f3b6bb5f · Jul 21, 2026 · 2 filesMessage 62 · AdequateTriage 12Details
Commit message · Roman Zeyde
fix(core/delizia): warning title should be red if `danger=true`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 24/100
This commit adds a new optional 'chunkify' setting to Tron transaction signing on Trezor hardware wallets. When enabled, addresses are shown on the device screen in small groups of characters (chunks of 4) instead of one long string, making them easier for users to read and verify. The change also makes chunking disabled by default for Tron sign-transaction screens, whereas some Tron screens previously always chunked addresses. There is no direct security vulnerability in the diff, but any change to how addresses are displayed can subtly affect how well users detect address-rewriting attacks.
Test vectors validated with Foundry: ``` cast wallet sign-auth $ADDRESS --mnemonic $MNEMONIC --mnemonic-derivation-path "m/44'/60'/0'/0/0" --nonce $NONCE --chain $CHAINID ``` https://www.getfoundry.sh/reference/cast/wallet/sign-auth
[no changelog]
Co-authored-by: Roman Zeyde <roman.zeyde@satoshilabs.com>
100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
defensive validationfuzzing or regression evidencesigning or wallet pathauthentication path
AI analysis · Informational 15/100
This commit only adds a new test data file containing example inputs and expected outputs for Ethereum's EIP-7702 authorization signing feature. It does not change any production firmware code, so it cannot introduce a security vulnerability or fix one. The test vectors are public, use a well-known test mnemonic, and are explicitly marked as not requiring a changelog.
rust `make ruststyle` on the previous comment, producing a cross-repository style diff.
this also means wrap_comments=true now applies in places it didn't before, so some line noise about that
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100
This is a purely cosmetic code-style commit. It runs the project's Rust formatter across hundreds of files, changing only how import statements are grouped and how long comments are wrapped. No program logic, security behavior, or functionality was altered.
refactor(core): move `compact_size()` from `common.py` to `tools.py`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathauthentication path
AI analysis · Informational 15/100
This commit simply moves a helper function called compact_size from one internal file to another and updates the import statements in files that use it. There is no change to what the function does, no bug fix, and no security impact.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
update trust
AI analysis · Informational 17/100
This commit adds a test-only digital certificate for the T3W1 hardware emulator. It is explicitly labeled as a testing certificate for emulators, lives in a 'unix' emulator directory, and is not used in real Trezor devices. There is no direct evidence it introduces a security vulnerability, but shipping test credentials in source code always deserves a quick check that they cannot accidentally be enabled in production firmware.
Security candidatefeat(tests): test serial numbers in certificates matchby Ondřej Vejpustek · a789984f · Jul 17, 2026 · 2 filesMessage 72 · AdequateTriage 10Details
Commit message · Ondřej Vejpustek
feat(tests): test serial numbers in certificates match
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body