Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…
Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…
Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.
This commit simply renames two groups of internal status labels (called enums) in the Trezor firmware's cryptographic code. The old names like WAITING_FOR_REQUEST1 were shared between two different parts of the code, so the developer gave …
This commit fixes three places in the Trezor firmware's cryptographic code where a memory-clearing function could be called with a NULL pointer. In practice, passing NULL to memzero is harmless on Trezor's platform (it does nothing), but i…
NULL pointer passed to memory-zeroing helper in cryptographic codeUndefined behavior in C standard library contractDefensive hardening in Noise protocol implementation
This commit is a code cleanup (refactor) for the cryptographic handshake code used in Trezor devices. It changes how the other party's long-term public key is returned to the caller: instead of storing it inside an internal state structure…
Removal of long-term public key storage from internal handshake stateCaller-supplied output buffer for remote static public key reduces internal secret retentionError-path memzero of returned key material on failure
This commit is a build-system refactoring for Trezor firmware. It moves the mapping of command-line build options to Rust/cargo features out of hard-coded Rust logic and into per-project TOML files. It also adds a small change so debug bui…
Build-option mapping now lives in project.toml files, increasing the attack surface for supply-chain/build-configuration tamperingMakefile change automatically enables debug-link for PYOPT=0 debug buildsValidation added to reject storage_insecure_testing_mode in production builds
This commit only updates test data. It corrects the capitalization (checksum) of Ethereum addresses used in automated tests and refreshes the expected screen-shot hashes those tests compare against. There are no changes to the actual Trezo…
This commit changes the Trezor Python library so that, when setting up a Trezor Model One (the original Trezor 1 device), it now performs an entropy check by default if the device runs firmware 1.13.1 or newer. Previously, the library only…
Enables a previously disabled security/validation feature (entropy check) for a specific device modelAdds version-gated behavior to avoid errors on older firmwareDefensive hardening of wallet setup randomness verification
This commit is a routine cleanup that removes the old SCons build system files from the Trezor Core firmware repository. It deletes Makefiles, SConscripts, and related Python helper scripts, but does not change any firmware source code, cr…
This commit updates Trezor's embedded MicroPython interpreter from an older version to 1.28.0. It pulls in several upstream MicroPython bug fixes, including stricter buffer-size checks for converting integers to bytes, a new stack-safety A…
Synchronizes upstream MicroPython fixes that include buffer-size and stack-safety hardeningPrevents Ctrl+C interruption of frozen boot code, reducing denial-of-service/control-flow risk during bootFixes sys.stdout.buffer.write() return value, which could affect code relying on correct I/O semantics
This commit is a simple code cleanup that replaces a common MicroPython string-creation pattern with a new helper function. It does not change what the code does, only how it is written. There is no security issue visible in the change.
This is a large but straightforward internal cleanup: the project switched from using the MicroPython `ubinascii` module's `hexlify`/`unhexlify` functions to the standard Python `bytes.hex()` and `bytes.fromhex()` methods. The change remov…
This commit is a routine code cleanup in the Trezor firmware's embedded MicroPython modules. It replaces an older, two-step object allocation pattern with a newer helper that allocates memory and sets the object type in one step. The chang…
No security-relevant logic changes observedNo input validation changesNo memory safety bug fixes (e.g., no overflow, use-after-free, or uninitialized memory fixes)
This commit is a routine maintenance refactor. MicroPython removed its built-in 'utimeq' module, so Trezor copied the same code into its own firmware tree and renamed it to 'timeq'. There is no security bug being fixed and no new vulnerabi…
This is a code cleanup change in Trezor's firmware that swaps one MicroPython internal helper for another. It replaces calls that create byte or string objects from a vstr buffer with newer, purpose-built helpers. The commit message says t…
Refactor only: helper function renames with equivalent semanticsNew str helper adds UTF-8 validation; bytes helper does not validateNo input validation, length, or error-handling changes observed
This commit is a routine internal cleanup that switches how Trezor's firmware defines built-in MicroPython object types. It replaces older, manually-written type structures with a newer macro provided by the upstream MicroPython project. T…
This commit is a straightforward internal code refactor. It adds a small C wrapper file so that Rust code can call two specific internal MicroPython functions that are declared as static/inline in headers. There is no user-facing change, n…
This commit is a routine build-system update for the Trezor firmware. It changes where the build process looks for the MicroPython cross-compiler binary (mpy-cross) and synchronizes a configuration header with newer MicroPython code. There…
This commit updates the Trezor firmware build system to use a newer MicroPython mechanism for tracking special memory pointers called 'root pointers.' It removes hard-coded lists of these pointers from configuration files and instead colle…
GC root pointer handling changedBuild system now auto-collects root pointers instead of hard-coding themRemoves manual MICROPY_PORT_ROOT_POINTERS lists
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidatefix(core/delizia): warning title should be red if `danger=true`by Roman Zeyde · f3b6bb5f · Jul 21, 2026 · 2 filesMessage 62 · AdequateInformational 20Details
Commit message · Roman Zeyde
fix(core/delizia): warning title should be red if `danger=true`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 20/100
This is a visual-only bug fix for the Trezor hardware wallet's Delizia user interface. When a warning screen is marked as dangerous, the title text was supposed to appear red, but it was only showing a danger icon. The fix adds the missing red title styling. There is no change to transaction logic, cryptography, or security checks.
feat(core/delizia): enable external menus for `confirm_properties()`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Low 25/100
This commit changes a Trezor firmware UI function so that a previously ignored 'external menu' flag is now actually used. When the flag is set, the confirmation screen uses an externally supplied menu instead of the built-in one. The change is small and appears to be a feature enablement rather than a fix for an active security bug, but it touches user-confirmation flow code where mistakes could affect what options a user sees.
feat(core/eckhart): enable external menus for `confirm_properties()`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 15/100
This commit is a routine UI feature addition for the upcoming Trezor Safe 7 (Eckhart layout). It lets the device show a simplified external menu during certain confirmation screens, and currently rejects combinations that aren't yet supported. There is no indication of a security bug or fix.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 24/100
This commit adds a new optional 'chunkify' setting to Tron transaction signing on Trezor hardware wallets. When enabled, addresses are shown on the device screen in small groups of characters (chunks of 4) instead of one long string, making them easier for users to read and verify. The change also makes chunking disabled by default for Tron sign-transaction screens, whereas some Tron screens previously always chunked addresses. There is no direct security vulnerability in the diff, but any change to how addresses are displayed can subtly affect how well users detect address-rewriting attacks.
Test vectors validated with Foundry: ``` cast wallet sign-auth $ADDRESS --mnemonic $MNEMONIC --mnemonic-derivation-path "m/44'/60'/0'/0/0" --nonce $NONCE --chain $CHAINID ``` https://www.getfoundry.sh/reference/cast/wallet/sign-auth
[no changelog]
Co-authored-by: Roman Zeyde <roman.zeyde@satoshilabs.com>
100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
defensive validationfuzzing or regression evidencesigning or wallet pathauthentication path
AI analysis · Informational 15/100
This commit only adds a new test data file containing example inputs and expected outputs for Ethereum's EIP-7702 authorization signing feature. It does not change any production firmware code, so it cannot introduce a security vulnerability or fix one. The test vectors are public, use a well-known test mnemonic, and are explicitly marked as not requiring a changelog.
AI review queuedrefactor(core/ethereum): make `ConfirmDataFn` a classby Roman Zeyde · f560b6f0 · Jul 21, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Roman Zeyde
refactor(core/ethereum): make `ConfirmDataFn` a class
It can be created inside `_confirm_data_chunks()`. Also, make `get_progress_indicator` private and return a non-async callback.
[no changelog]
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a straightforward internal code cleanup in the Ethereum transaction signing flow. It turns a callback-creating helper function into a class and moves where that object is created. There is no change to user-visible behavior, security checks, or cryptographic handling.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100
This commit only adds new automated tests for the Trezor hardware wallet's Ethereum transaction signing. It checks that the device correctly rejects malformed transaction data sent during signing. There are no changes to the actual firmware code that users run, so this commit does not fix or introduce a security issue by itself.
No need to call `get_progress_indicator()` if there is not calldata. We don't need to confirm/hash it as well.
[no changelog]
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This is a small code cleanup in Trezor's Ethereum transaction signing. When an Ethereum transaction has no extra data (calldata), the device no longer runs a now-unnecessary progress-indicator step. This only changes the user-interface flow for no-data transactions; it does not change what is signed or how the signature is computed. The large diff is mostly updated test screenshot fingerprints (hashes) reflecting the changed on-screen sequence.
Also, deduplicate RLP header and initial data hashing.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100
This commit is a code cleanup in the Ethereum transaction signing module. It replaces a manual byte-copying loop with a simpler buffer extension approach and removes duplicate code that wrote the RLP header and hashed the data in two different places. There is no indication of a security bug being fixed.
AI review queuedrefactor(core/ethereum): simplify and rename `_send_request_chunk()`by Roman Zeyde · 730ea609 · Jul 19, 2026 · 1 fileMessage 77 · AdequateLow 47Details
Commit message · Roman Zeyde
refactor(core/ethereum): simplify and rename `_send_request_chunk()`
Also, check `EthereumTxAck.data_chunk` size, similar to `apps.common.chunked.get_data_chunk()`.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 47/100
This commit refactors how a Trezor hardware wallet asks for pieces of an Ethereum transaction's data from the host computer. It renames an internal helper and, importantly, adds a size check so the host cannot return a chunk larger than the device requested. That oversized-chunk condition could previously lead to memory corruption or unexpected behavior during transaction signing.
AI review queuedrefactor(core/ethereum): import `HashWriter` only for type-checkingby Roman Zeyde · ad23bda4 · Jul 19, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Roman Zeyde
refactor(core/ethereum): import `HashWriter` only for type-checking
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a minor code cleanup in the Ethereum transaction signing module. It moves an import statement so that a helper class (`HashWriter`) is only imported during type-checking, not at runtime. There is no functional change, no bug fix, and no security relevance.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds and updates user-facing text strings (labels, warnings, and confirmation messages) for a new Ethereum feature called EIP-7702. It does not change any code that handles private keys, signing logic, transaction parsing, or security checks. There is no direct security issue visible in this change.
Initialize Tropic on demand in prodtest so that lt_init() failures can be reported with their libtropic error reason.
[no changelog]
92/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
style(core/rust): configure rustfmt for uniform grouping
move rustfmt.toml one level up to cover all of core's rust, not just trezor_lib
uniform grouping of use statements: * group_imports = "StdExternalCrate" to get std imports first, then 3rd party, then crate local (like isort already does in python) * reorder_imports = true to enforce alphabetical sorting * imports_granularity = "Module" to put every module on one line, instead of (the default) compressing with braces
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
rust `make ruststyle` on the previous comment, producing a cross-repository style diff.
this also means wrap_comments=true now applies in places it didn't before, so some line noise about that
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100
This is a purely cosmetic code-style commit. It runs the project's Rust formatter across hundreds of files, changing only how import statements are grouped and how long comments are wrapped. No program logic, security behavior, or functionality was altered.
refactor(core): move `compact_size()` from `common.py` to `tools.py`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathauthentication path
AI analysis · Informational 15/100
This commit simply moves a helper function called compact_size from one internal file to another and updates the import statements in files that use it. There is no change to what the function does, no bug fix, and no security impact.
fix(core): disable writing MCU attestation certificate in firmware
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
update trust
AI analysis · Low 33/100
This commit changes a Trezor firmware function so that, outside of a special factory testing mode (PRODTEST), it refuses to write an MCU attestation certificate. Previously the function accepted and stored such a certificate. The change prevents firmware from installing or overwriting this certificate, likely to reduce attack surface, but the commit message gives no details about any specific security issue.
chore(core): add testing tropic attestation key and certificate
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
update trust
AI analysis · Informational 18/100
This commit updates Trezor's internal test-only files that simulate a TROPIC01 secure chip. It replaces old self-signed test certificates with a new four-level test certificate chain and embeds keys directly into config files instead of referencing separate PEM files. The change is labeled as a testing chore, touches only test/development artifacts, and does not alter production firmware code. The most notable security-relevant detail is that a hardcoded X25519 private key is included in test data, but it is explicitly a test key already present in the public source tree and used only for the emulator/unix test build.
feat(core): use empty MCU attestation certificate in prodtest
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
update trust
AI analysis · Informational 19/100
This commit changes how Trezor hardware wallet firmware handles a special factory-testing mode called 'prodtest'. In prodtest builds, it now uses an empty placeholder certificate for MCU (microcontroller) attestation instead of a real device certificate. This appears to be a development/testing convenience change rather than a fix for a live security vulnerability, because prodtest is not the normal user-facing firmware. However, it touches attestation code, which is security-sensitive, and the commit message gives no security context.
refactor(core/python): factor out `get_challenge_message()`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Informational 15/100
This commit is a simple code cleanup: it moves a small block of code that builds an authentication challenge message into its own reusable function. There is no change to behavior, no bug fix, and no security-related change.
Security candidatefeat(tests): test serial numbers in certificates matchby Ondřej Vejpustek · a789984f · Jul 17, 2026 · 2 filesMessage 72 · AdequateInformational 12Details
Commit message · Ondřej Vejpustek
feat(tests): test serial numbers in certificates match
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Informational 12/100
This commit adds a new automated test that checks whether the serial numbers embedded in three different security certificates inside a Trezor device all match. It does not change any production firmware code, fix a bug, or alter device behavior. It only adds a test and a corresponding test fixture entry.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 15/100
This commit only adds '.PHONY' declarations to many Makefiles. These declarations tell the build system that certain target names are not real files, preventing build mistakes if a file with the same name happens to exist. There is no change to the actual firmware, cryptography, or any code that runs on the device.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
update trust
AI analysis · Informational 24/100
This commit changes a factory-production testing tool (prodtest) so that the commands for writing and reading the device's MCU attestation certificate also work in the software emulator, instead of returning 'not implemented'. In the emulator, the written certificate is only stored in memory and disappears after reboot. The change removes compile-time guards that previously disabled these commands for emulator builds. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a feature-enablement change for testing/development workflows.