Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…
Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…
This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…
Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…
Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…
Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…
BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…
Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…
Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…
Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…
Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…
Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…
Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…
New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…
Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …
Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…
Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…
Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…
This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …
This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …
UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidateDisplay total amount of external inputs when reliableby Salvatore Ingala · 26f631c5 · Jul 20, 2026 · 4 filesMessage 78 · AdequateInformational 21Details
Commit message · Salvatore Ingala
Display total amount of external inputs when reliable
While warning for the presence of external inputs remains necessary (certain attacks are possible), we can show additional info when the amount of external inputs is committed to (that is, when the sighash flag we're signing with does not have ANYONECANPAY, and therefore the signature commits to all inputs).
In that case, we can show: - The total amount of external inputs - The net spend (or receive) from/to the wallet policy, similarly to the transaction summary shown with certain sighash flags.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagesigning boundarysigning or wallet path
AI analysis · Informational 21/100
This commit changes what information the Ledger Bitcoin app shows on its screen when signing a transaction that includes 'external inputs'—coins the user did not provide and whose amounts the device cannot independently verify. Previously the app only warned that such inputs exist. After this change, when the signature commits to the full set of inputs (i.e., no ANYONECANPAY sighash flag), the app also displays the total value of those external inputs and the net amount the user's wallet is spending or receiving. This is a user-interface improvement intended to reduce confusion, not a fix for a code-execution or theft vulnerability. The underlying security model—external inputs are still 'unverified'—is unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarydocumentation-only discount
AI analysis · Informational 15/100
This commit only adds documentation and a changelog entry describing a previously implemented BIP-322 message-signing feature. No code changes are present, so it cannot introduce or fix a security vulnerability on its own.
Security candidatetests: functional tests for BIP-322 message signing and proof of fundsby Ruben Waterman · f0c76851 · Jul 18, 2026 · 269 filesMessage 88 · StrongInformational 15Details
Commit message · Ruben Waterman
tests: functional tests for BIP-322 message signing and proof of funds
Adds test_utils/bip0322.py (to_spend/to_sign PSBT builders, sighash recomputation, signature verification and smp encoding helpers), musig() support in test_utils/wallet_policy.py's plain descriptor derivation, and a ragger suite covering: - P2WPKH, P2TR, legacy P2PKH, registered 2-of-2 multisig, and musig() (taproot keypath and scriptpath) signings, each verifying the returned signature against an independently recomputed sighash; - the address being proven on a change address, the empty message, and an explicit SIGHASH_ALL on a taproot input; - proof of funds (P2WPKH and P2TR), verifying every input's signature and the on-screen total; the unverified inputs warning is shown for a real input missing the non-witness utxo, but never for the to_spend input; proof-of-funds inputs may also have a final sequence, explicit or implied by an omitted PSBT_IN_SEQUENCE; - long and short non-printable messages (hash display); - the review rejected by the user; - rejections: message/to_spend mismatch, first input not spending output 0 of to_spend, non-zero amounts, OP_RETURN with a data push, extra outputs, invalid tx version, timelocks (non-zero locktime, non-zero or omitted sequence on the first input, relative timelock on a proof-of-funds input), external proof-of-funds inputs, and non-ALL sighashes (refused by the generic sighash gating by default, and by the BIP-322 validation when the non-standard sighash setting is enabled).
The message is set with the client's PSBT.generic_signed_message.
Golden snapshots for all five devices.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Salvatore Ingala <6681844+bigspider@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationcryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit only adds automated tests and test helper code for a new Bitcoin message-signing feature (BIP-322). It does not change the actual Ledger app firmware that users run, so it cannot by itself introduce a security vulnerability in shipped software. The tests exercise both valid and invalid signing requests, including many cases designed to make the device reject malformed or suspicious inputs.
Trustworthy sign_psbt amount/fee display for non-default sighash: snapshots
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly fix or introduce a security vulnerability in the shipped app. The snapshots reflect new expected screen output after a prior code change that altered how amounts and fees are displayed when signing transactions with non-default Bitcoin sighash types.
Trustworthy sign_psbt amount/fee display for non-default sighash: integration tests
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 12/100
This commit only adds and updates automated integration tests for the Ledger Bitcoin app. It does not change the app's actual signing code. The tests verify that the device now shows clearer, more trustworthy on-screen amount and fee information when a transaction uses unusual Bitcoin signature modes (non-default 'sighash' types). Because no production firmware code is modified, there is no direct security vulnerability or fix introduced by this commit itself.
Trustworthy sign_psbt amount/fee display for non-default sighash: unit-tests
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 12/100
This commit only adds new automated unit tests for functions that decide how transaction amounts and fees are displayed on a Ledger device when signing a Bitcoin transaction with non-standard signature hash (sighash) modes. It does not change the actual signing or display logic, so by itself it cannot introduce or fix a security bug. The tests appear to be a companion to a separate code change that made the amount/fee display trustworthy for non-default sighash types.
Trustworthy sign_psbt amount/fee display for non-default sighash: implementation
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100
This commit changes how the Ledger Bitcoin app shows transaction amounts and fees on the device screen when a user signs a transaction that does not use the normal 'sign everything' rule (a so-called non-default sighash). Previously the app might have displayed a fee or total that could actually change later, because some sighash types let other people add inputs or change outputs after the signature. Now the app detects those cases and either shows only the net amount the user is spending/receiving, or shows a warning that amounts cannot be verified. It also adds a 'Signing rule' line so the user knows the transaction is not fully committed.
It is redundant, it's simpler to just exit when the sentinel is found. It was also making clang static analyzer detect a false positive out of bounds read.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
memory safety
AI analysis · Informational 11/100
This commit is a small code cleanup in the Ledger Bitcoin app. It removes an initial loop that counted commands and instead checks for the end marker directly while processing. The author says the old loop was unnecessary and caused a harmless false-positive warning in a static analysis tool. There is no indication this fixes a real security bug or changes app behavior in a user-visible way.
Security candidateFix slight mismatch in definition of crypto_hash160by Salvatore Ingala · 54587441 · Jun 3, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala
Fix slight mismatch in definition of crypto_hash160
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only fixes a documentation/declaration inconsistency in a C header file. The function parameter name in the comment is changed from `in_len` to `inlen` to match the actual declaration, and the output pointer is annotated with a fixed-size array hint (`out[static 20]`) instead of a plain pointer. There is no change to executable code or behavior.
Security candidateAdd support for generating PSBTs for MuSig2 in txmakerby Salvatore Ingala · 13d84aca · Jun 1, 2026 · 2 filesMessage 65 · AdequateInformational 19Details
Commit message · Salvatore Ingala
Add support for generating PSBTs for MuSig2 in txmaker
Also, address the remaining some old TODOs.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 19/100
This commit adds test-only helper code for creating Bitcoin transaction fixtures that support newer wallet types (MuSig2 multi-signature and several legacy/wrapped SegWit descriptor forms). It is not a change to the Ledger app firmware itself, but to Python utilities used in automated tests. There is no obvious security bug introduced, and the commit does not claim to fix a vulnerability.
Security candidateDelete mock_include, rely on the speculos_bridge for all testsby Salvatore Ingala · 6f7b4472 · May 29, 2026 · 28 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Delete mock_include, rely on the speculos_bridge for all tests
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is a test-only refactoring: it removes a set of local mock SDK headers and a software SHA-256 implementation used by unit tests, and instead makes those tests run against the real Ledger SDK headers through the existing Speculos emulator bridge. No production application code is changed, and there is no indication this fixes or introduces a security vulnerability.
Security candidateAdd minimal utility functions to work with serialized xpub in unit testsby Salvatore Ingala · 31a302d2 · May 29, 2026 · 4 filesMessage 75 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Add minimal utility functions to work with serialized xpub in unit tests
It is much cleaner than encoding in hex.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds helper functions for unit tests to convert Bitcoin extended public keys (xpubs) between base58 string form and raw binary form. It does not change the actual Ledger app code that runs on the device, nor does it fix or introduce any security-relevant behavior. It is a test-code cleanup that replaces hard-coded hex byte arrays with readable xpub strings.
Security candidateVarious improvements, refactorings and simplifications from PR reviewby Salvatore Ingala · 1e4853f1 · May 29, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala
Various improvements, refactorings and simplifications from PR review
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is purely a build-system and test-harness cleanup. It refactors CMakeLists.txt, updates comments, simplifies the speculos test bridge, and removes a workaround in a test file. Nothing here changes the actual Ledger Bitcoin app that runs on the device, so it cannot directly affect user funds or device security.
Security candidateUnit tests for the crypto_tr_* taproot helpersby Salvatore Ingala · cc9ea60d · May 29, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala
Unit tests for the crypto_tr_* taproot helpers
55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds unit tests and test infrastructure for Bitcoin Taproot cryptographic helpers. It does not change the actual app code that runs on the hardware wallet, so it cannot introduce a security vulnerability in shipped firmware. The changes make the test mock more complete by wiring it to the Speculos emulator's real cryptographic functions instead of crashing with a stub.
Security candidateAdd unit tests for crypto_ecdsa_sign_sha256_hash_with_keyby Salvatore Ingala · 96a9203d · May 29, 2026 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Salvatore Ingala
Add unit tests for crypto_ecdsa_sign_sha256_hash_with_key
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100
This commit only adds unit tests and a test-only bridge implementation for cryptographic signing functions. It does not change the actual device application code that users rely on, so it cannot introduce a security vulnerability in the shipped product. The changes make the test suite more complete by exercising an existing signing function with a known, precomputed signature.
Security candidateAdd unit tests for crypto_get_compressed_pubkey_at_pathby Salvatore Ingala · 86fa0b30 · May 29, 2026 · 4 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Add unit tests for crypto_get_compressed_pubkey_at_path
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds unit tests and test-support code. It does not change the actual Bitcoin app that runs on Ledger devices, so it cannot introduce a security vulnerability in shipped firmware. The changes make the test harness able to simulate BIP32 key derivation using the Speculos emulator's own implementation, with a fixed public test seed.
Security candidateAdd unit tests for crypto_ripemd160, crypto_hash160, crypto_get_checksumby Salvatore Ingala · af900978 · May 29, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Add unit tests for crypto_ripemd160, crypto_hash160, crypto_get_checksum
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds new unit tests and renames some existing test functions. It does not change any production code behavior, so it cannot introduce a security vulnerability or fix one on its own.
Security candidateLink unit tests with speculos implementations of crypto syscallsby Salvatore Ingala · 53a997c6 · May 29, 2026 · 6 filesMessage 75 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Link unit tests with speculos implementations of crypto syscalls
This allows writing unit tests for code that calls syscalls. In this commit, tests for bip32_CKDpub are added.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Informational 15/100
This commit is purely about improving the project's automated test setup. It links unit tests to a software simulator (Speculos) so cryptographic code can be tested on a regular computer without a physical Ledger device. It adds tests for a Bitcoin key-derivation function and re-enables an existing test file. There is no change to the actual app code that runs on the device, and nothing in the commit suggests a security vulnerability or fix.
Security candidateAdd unit tests for crypto_{get_key_fingerprint,master_key_fingerprint,derive_symmetric_key_slip21} and get_extended_pubkey_at_pathby Salvatore Ingala · 65279632 · May 29, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Add unit tests for crypto_{get_key_fingerprint,master_key_fingerprint,derive_symmetric_key_slip21} and get_extended_pubkey_at_path
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds new automated unit tests for existing cryptographic functions in the Ledger Bitcoin app. It does not change any production code, fix bugs, or alter behavior. There is no security issue here.
Security candidateGet rid of SKIP_FOR_CMOCKA; compile tests with the speculos bridgeby Salvatore Ingala · c098c659 · May 29, 2026 · 10 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Get rid of SKIP_FOR_CMOCKA; compile tests with the speculos bridge
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit is purely a testing infrastructure cleanup. It removes a workaround called SKIP_FOR_CMOCKA that previously hid parts of the code from unit tests, and instead compiles those parts using a more realistic emulator bridge (speculos). No user-facing behavior of the Bitcoin app changes, and no security bug is fixed or introduced in the diff.
Security candidateNits from reviewby Salvatore Ingala · 9e23b56d · May 19, 2026 · 6 filesMessage 28 · OpaqueInformational 12Details
Commit message · Salvatore Ingala
Nits from review
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100
This commit is a small cleanup following a code review. It updates comments, adds safety checks to a test-only mock function, increases a test mock queue size, and adds a missing standard header include. None of the changes affect the real device firmware's security behavior.
Security candidateSimplify unit test setup/teardown, and allocate state on the heapby Salvatore Ingala · d4be5ca1 · May 19, 2026 · 12 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Simplify unit test setup/teardown, and allocate state on the heap
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is a pure refactoring of the project's unit tests. It replaces manually initialized static mock dispatcher objects with heap-allocated ones managed by cmocka test fixtures, and moves hash-pool reset into the common setup function. There is no change to the actual Ledger Bitcoin app firmware or its security-critical code, so this commit does not introduce or fix any user-facing security vulnerability.
Security candidateAdd utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivationby Salvatore Ingala · e7453297 · May 19, 2026 · 7 filesMessage 60 · AdequateInformational 14Details
Commit message · Salvatore Ingala
Add utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivation
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
secret or key materialsigning boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 14/100
This commit only adds new unit-test helper code and test cases. It does not change the actual Ledger Bitcoin app that runs on the device, nor does it fix or alter any production security logic. The new files parse PSBT data and mock dispatcher responses so developers can test the existing `extract_bip32_derivation` function in isolation. Nothing here is shipped to users or reachable by an attacker.
Security candidateAdd initial mock for the dispatcher, and tests for get_preimageby Salvatore Ingala · 5ac1ec68 · May 19, 2026 · 8 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Add initial mock for the dispatcher, and tests for get_preimage
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds unit-test infrastructure: a mock implementation of the Ledger SDK dispatcher and SHA-256 hashing, plus tests for the get_preimage handler. It does not change any production code in the Bitcoin app, so it cannot introduce a runtime security vulnerability on its own.
Security candidateAdditional unit testsby Salvatore Ingala · e130db4d · May 19, 2026 · 6 filesMessage 73 · AdequateInformational 12Details
Commit message · Salvatore Ingala
Additional unit tests
This reaches 100% coverage, except a few lines that can't be covered (either gcov artifacts, or non-reachable code because of defense-in-depth checks).
73/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100
This commit only adds new unit tests to the Ledger Bitcoin app. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The tests exercise edge cases and adversarial inputs for functions that handle Merkle-tree preimages and BIP32 derivation extraction, which helps confirm existing defensive checks reject malformed data.