FD
← All projectsFoundation

Passport firmware

Firmware for Foundation Passport Bitcoin signing devices.

BitcoinHardware walletsNormal
Repository coverage

263 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

102security candidates79second-pass queue215AI analyses
42commits · 30 days
128commits · 60 days
194commits · 180 days
256commits · 365 days
Backfill bands
Aug 5 → Feb 612 seen0 candidatesComplete
Feb 6 → Jun 659 seen3 candidatesComplete
Jun 6 → Jul 64 seen0 candidatesComplete
Jul 6 → Aug 52 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

61/100 average clarity
16Strong · 80–100
116Adequate · 60–79
118Thin · 40–59
13Opaque · 0–39
4security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jacksper13321424466
Matt Gleason841868351
Jack603454261
mjg-foundation693251269
Jean-Pierre De Jesus DIAZ828061
Ken Carpenter313048
QnA111060
dependabot[bot]505076
BitcoinQnA101045
Analysis record

Published AI watches

Last scanned 56 minutes ago

Informational 12 AI analysisMessage 78 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8696: remove the Security Check from onboarding

This commit removes the 'Security Check' step from the initial device setup (onboarding) for the Passport hardware wallet. To avoid breaking devices that were mid-setup during a firmware update, the old step is kept as a harmless pass-thro…

8d77ba38by Jack+153−124 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #753 from Foundation-Devices/sft-8680-fail-to-sign-dynamic-taproot-qr-message

This commit adds support for signing BIP-322 message requests that wallets like Sparrow send as a PSBT (a Bitcoin transaction-like data format). It is a feature addition, not a reported vulnerability fix. The code includes careful validati…

New input parser for externally supplied PSBT data with explicit structural validationRejects non-Taproot BIP-322 requests and unsafe sighash typesBinds the user-reviewed message and address to the transaction being signed
5e98b6abby mjg-foundation+722−3011 files
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8680: check derivation path length before indexing into it

This commit fixes a bug in the Passport hardware wallet's BIP-322 message signing code. Previously, when parsing a PSBT (a Bitcoin data format), the code could read past the end of an empty or too-short 'derivation path' field because it c…

Out-of-bounds read / index error on untrusted PSBT inputValidation order bug: first-byte check before length checkBIP-322 signing request parsing hardened
cec3925bby Matt Gleason+8−43 files
No security note in commit
Informational 22 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #754 from Foundation-Devices/sft-8681-passport-core-sign-taproot-messages-with

This commit changes how the Passport hardware wallet signs Bitcoin Taproot text messages. Previously it used SIGHASH_DEFAULT (the Taproot default), but now it uses SIGHASH_ALL. The change is for compatibility: the commit message says Sparr…

Change in cryptographic signature hash type (SIGHASH_DEFAULT -> SIGHASH_ALL)Comment explicitly references verifier compatibility and Sparrow wallet acceptanceUnit test asserts new signature encoding and verifies against an external test vector
87f43de1by mjg-foundation+22−172 files
No security note in commit
Low 41 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #752 from Foundation-Devices/sft-8674-passport-core-signing-flow-does-not-show-a-non

This commit adds on-screen warnings to the Passport hardware wallet when a user is reviewing a Bitcoin transaction that contains timelocks. Timelocks can prevent a transaction from confirming until a future date or until certain inputs hav…

UI warning for absolute time-based nLockTimeUI warning for BIP68 relative timelocks on version-2 transactionsHeight-based nLockTime intentionally not flagged to avoid false positives
5defe2c5by mjg-foundation+176−16 files
No security note in commit
Moderate 52 AI analysisMessage 85 · Strong
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8674: warned about timelocks when reviewing a transaction

This commit adds on-screen warnings to the Passport hardware wallet when a Bitcoin transaction being reviewed includes a timelock that could delay confirmation. Before this change, a user could unknowingly sign a transaction that is blocke…

UI now warns users about transaction timelocks that delay confirmationPreviously undisclosed to the signer: absolute date locks and BIP68 relative locksHeight-based nLockTime intentionally not flagged to avoid warning fatigue
7cba5349by Jack+176−16 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #747 from Foundation-Devices/sft-8653-passport-core-recheck-the-firmware-image-while

This update tightens the firmware update process on the Passport hardware wallet. Previously, the device verified the firmware file once, then copied it to internal flash memory without re-checking. A malicious or tampered file swapped in …

Time-of-check/time-of-use (TOCTOU) hardening in firmware update pathNew digest parameter threaded from verification task to staging taskStaging task now re-hashes firmware image and compares against expected digest
3449381fby mjg-foundation+68−264 files
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #736 from Foundation-Devices/sft-8554-bootloader-setup-checks

This commit hardens how Passport's bootloader handles a sensitive factory key during initial device setup. Previously, the code trusted that erasing the key from SPI flash succeeded without checking, and it left a temporary copy of the key…

Sensitive key material (supply-chain validation key) is now explicitly zeroed from stack memory after useSPI flash erase of the SCV key is now verified by read-back instead of assumed successfulBootloader setup now aborts if the SCV key cannot be confirmed erased from SPI flash
ed62d448by mjg-foundation+245−55 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #735 from Foundation-Devices/sft-8555-update-restore-checks

This commit adds security checks when restoring a backup file to a Passport hardware wallet. Previously, multisig wallet configurations stored in a backup were restored without verifying that they actually belong to the seed being restored…

Validation of multisig backup records against restored seedDerivation verification for xpubs claiming backup root fingerprintDropping malformed records instead of failing entire restore
8dbae7e1by mjg-foundation+242−75 files
Vendor flagged security relevance
Moderate 60 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #748 from Foundation-Devices/sft-8654-passport-core-bounded-text-building-in-the

This commit replaces unsafe string-copying functions in the Passport hardware wallet's bootloader with a bounded helper that prevents text fields from overflowing their buffers. The change is defensive: it stops malicious or malformed firm…

Replacement of strcpy/strcat with bounded append_text helperHandling of non-NUL-terminated firmware header text fieldsBuffer overflow mitigation in bootloader UI message construction
e2d735f0by mjg-foundation+89−222 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #732 from Foundation-Devices/sft-8545-native-taproot-key-signing

This commit adds a new, dedicated way for the Passport hardware wallet to sign Bitcoin Taproot transactions. It moves the cryptographic 'tweak' calculation from Python code into a Rust library and adds unit tests. There is nothing in the c…

5e3ed701by mjg-foundation+234−185 files
No security note in commit
Moderate 60 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #742 from Foundation-Devices/sft-8530-distinct-cosigners

This update to the Passport hardware wallet firmware adds a safety check when importing multi-signature wallet configurations. Previously, the same cosigner public key could be listed more than once under different fingerprints or address …

Adds duplicate-key detection during multisig wallet importCompares raw public-key x-coordinates rather than fingerprints or encoded xpub stringsPrevents a single key from being counted as multiple independent cosigners
92c68c63by mjg-foundation+69−03 files
Vendor flagged security relevance
Low 48 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #739 from Foundation-Devices/sft-8559-psbt-file-errors

This update fixes a bug where the Passport hardware wallet could freeze (hang) when reading a malformed or unreadable PSBT transaction file from a microSD card. Now the device reports a clear error instead of getting stuck, so users know s…

Denial-of-service / UI hang on malformed input now returns an errorUnhandled exception path now caught and reported instead of leaving task unresolvedMissing microSD card case explicitly reported
6a461136by mjg-foundation+144−62 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #740 from Foundation-Devices/sft-4482-update-card-missing

This commit fixes a user-experience bug in the Passport hardware wallet's firmware update flow. Previously, if the user removed the microSD card while the device was reading a firmware update file, the process would crash with an unhandled…

Adds exception handling for a removable-media failure during a privileged operation (firmware update)Prevents unhandled CardMissingError from aborting the update flow abruptlyDoes not alter firmware signature, timestamp, or header validation logic
06ec8d6aby mjg-foundation+109−23 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #741 from Foundation-Devices/sft-737-multisig-match-n

This firmware update fixes a bug in how the Passport hardware wallet matches multisignature (multisig) wallets. Previously, when looking for a saved wallet that matches the cosigners in a transaction, the device only checked that the cosig…

Incorrect multisig wallet matching could lead to signing with the wrong wallet policySubset-only cosigner matching allowed a smaller wallet to be conflated with a larger oneFix adds N filter to wallet candidate enumeration
d2d30a58by mjg-foundation+59−23 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #746 from Foundation-Devices/sft-8260-evaluate-miniscript-no-compatible-path

This commit only changes the wording of an on-screen warning message shown to users when a Bitcoin transaction's timelock conditions are not yet met. It does not change any security logic, validation, or behavior. The old message said no s…

f6ab63ceby Jacksper13+5−42 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8260: Update the policy no-compatible-path warning copy

This commit only changes the wording of an on-screen warning message shown to users when a Bitcoin transaction cannot be signed because no spending path's time-lock conditions are currently satisfied. It does not change any security logic,…

e024471eby Jack+5−42 files
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #731 from Foundation-Devices/SFT-974-miniscript-ui-followup

This commit is a follow-up to the miniscript wallet-policy user interface. It mostly fixes UI wording, memory cleanup, and policy display logic. The only potentially security-relevant change is that wallet policy IDs are now computed with …

Incremental SHA-256 digest used for policy ID computationRemoval of explicit `validate(miniscript, context)` call before compilationNew default-name derivation from descriptor checksum
83d1d576by mjg-foundation+415−5312 files
No security note in commit
Low 32 AI analysisMessage 50 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

SFT-974: unwrapped miniscript parsing recursion, added default policy

This firmware update changes how the Passport hardware wallet handles complex Bitcoin wallet policies. The main visible change is replacing a recursive parser walk with an iterative one, which prevents the device from crashing due to exces…

Recursion in miniscript parsing replaced with explicit stack to avoid RecursionError on deeply nested templatesPolicy validation path changed: explicit `validate()` call removed, safety now enforced via `compile_miniscript()` during registrationDefault empty policy name now auto-populated from descriptor checksum to avoid unnamed policies
96b2aa9fby Matt Gleason+160−216 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

SFT-974: improved miniscript UI, working on OOM issues

This commit is a routine feature and stability patch for the Passport hardware wallet's miniscript wallet-policy support. It improves on-screen descriptions of wallet policies, adds explicit memory cleanup (garbage collection) during polic…

Memory pressure mitigation via explicit garbage collection during policy operationsNew verify-address flow for registered wallet policiesUI clarity improvements for timelock and signer-role descriptions
cb7478a5by Matt Gleason+255−3210 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedSFT-8192: rename the test double to Mock*, matching the rest of the suiteby Jack · a73fb7ff · Sep 30, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Jack

SFT-8192: rename the test double to Mock*, matching the rest of the suite

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only renames a test helper class from FakePSBT to MockPSBT inside a single unit-test file. No production code, behavior, or security logic changed.

Security candidateMerge remote-tracking branch 'origin/dev-v2.4.0' into taproot-bip322-message-signingby Jack · d8086007 · Sep 30, 2026 · 11 filesMessage 75 · AdequateModerate 61Details
Commit message · Jack

Merge remote-tracking branch 'origin/dev-v2.4.0' into taproot-bip322-message-signing

# Conflicts:
# ports/stm32/boards/Passport/modules/tests/test_unit.py

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
secret or key materialsigning boundaryauthentication pathmerge-commit duplicate discount
AI analysis · Moderate 61/100

This merge commit pulls in several defensive fixes for the Passport hardware wallet. The most important changes reduce the maximum passphrase length from 1000 to 256 characters so passphrases are not silently truncated when deriving a wallet, prevent backup files from restoring sensitive identity values (like the wallet fingerprint and extended public key) that could otherwise be forged, and fix a typo in the error-code list that was accidentally joining two error names together. It also adds missing early returns in backup verification so the same result is not reported twice. These are hardening fixes rather than a single obvious exploit, but they close real security-relevant bugs.

AI review queuedSFT-8192: rename Fake* test doubles to Mock*by Jack · f05921e1 · Sep 30, 2026 · 7 filesMessage 78 · AdequateInformational 15Details
Commit message · Jack

SFT-8192: rename Fake* test doubles to Mock*

Review feedback on the backup restore hardening: the test doubles read
better as Mock*. The tree was Fake* throughout with no Mock* anywhere, so
renaming one file would have left it the odd one out. This renames all of
them in one pass.

28 class names across 7 files, plus the three lowercase helpers and the
pytest fixture that went with them. No behaviour change.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only renames test helper classes from 'Fake*' to 'Mock*' across seven test files. It does not change any actual product code or test behavior, so it has no security relevance on its own.

Security candidateMerge pull request #702 from Foundation-Devices/SFT-7378-passphrase-length-capby mjg-foundation · 41711800 · Sep 30, 2026 · 3 filesMessage 73 · AdequateModerate 60Details
Commit message · mjg-foundation

Merge pull request #702 from Foundation-Devices/SFT-7378-passphrase-length-cap

SFT-7378: cap passphrase entry at what the KDF reads

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlauthentication pathmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes a design flaw in the Passport hardware wallet where users could enter a passphrase longer than the wallet's key-derivation function actually reads. Previously, extra characters were silently ignored, meaning two different long passphrases could unlock the same wallet. The fix caps passphrase entry at 256 characters and adds a test to ensure the cap matches what the cryptographic code reads. It is a correctness and interoperability fix rather than a remote hack, but it prevents users from accidentally creating wallets that cannot be reproduced on other BIP39 wallets.

Security candidateMerge pull request #685 from Foundation-Devices/fix/errors-enum-missing-commaby Jacksper13 · 670c3886 · Sep 29, 2026 · 2 filesMessage 73 · AdequateLow 33Details
Commit message · Jacksper13

Merge pull request #685 from Foundation-Devices/fix/errors-enum-missing-comma

SFT-8184: restore the NOT_BIP39_MODE and MULTISIG_STORAGE_IDX_ERROR error codes

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialmerge-commit duplicate discount
AI analysis · Low 33/100

This commit adds a regression test to make sure two specific error codes (NOT_BIP39_MODE and MULTISIG_STORAGE_IDX_ERROR) actually exist in the firmware's error list. The underlying bug was a missing comma in a tuple of error names, which silently merged the two names into one long, nonsense name. The commit only adds tests; it does not show the actual fix to the error list, though the branch name and message imply the fix happened elsewhere. Because the missing error codes would cause the device to crash with an AttributeError when those error conditions are hit, this is a real reliability/defensive issue, but it is not a remotely exploitable vulnerability.

Security candidateSFT-8161: honour USE_BIP39_GENERATEby Jack · 94ec6c40 · Sep 29, 2026 · 4 filesMessage 58 · ThinLow 26Details
Commit message · Jack

SFT-8161: honour USE_BIP39_GENERATE

py.mk sets -DUSE_BIP39_GENERATE=0, but nothing in the tree read the flag,
so the binding was exposed regardless. Guard it on that flag, defaulting
to on where the flag is not defined so upstream builds of the vendored
tree are unchanged.

Nothing calls it, so the effect is to drop an unused name from
trezorcrypto.bip39. Everything else in that module stays.

Also record beside random32()/random_buffer() which consumers are on
them, so the next reader does not have to work it out.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
secret or key materialcryptography-sensitive pathboot or update path
AI analysis · Low 26/100

This commit removes an unused function called `trezorcrypto.bip39.generate()` from the firmware's exposed programming interface. The function was supposed to be disabled by a build flag (`USE_BIP39_GENERATE=0`) but the flag was being ignored, so the function was still visible. Passport does not actually use this function to create wallet seeds—it creates seeds through a different path—so the change is mostly cleanup and defense in depth. A new test checks that the function stays removed and that the rest of the crypto API still works.

Security candidateSFT-8162: validate and confirm a developer pubkey before installing itby Jack · dded7d41 · Sep 29, 2026 · 4 filesMessage 73 · AdequateModerate 60Details
Commit message · Jack

SFT-8162: validate and confirm a developer pubkey before installing it

The install flow checked only that the file was 88 bytes long, and showed
no screen for what was about to be trusted.

Add is_valid_firmware_pubkey(), which checks the 64 bytes are a reduced
point on secp256k1, and reject the file when they are not. The all zero
key fails that check, which is what this flow wants, since clearing the
slot goes through RemoveDevPubkeyFlow and its own confirmation.

Then show the key in the same form as View Developer PubKey and ask
before writing it. The card is also released before either screen rather
than held open across a prompt.

The C binding keeps accepting the all zero removal key and is unchanged.
The bootloader verifier is out of scope per the recorded decision on
SFT-7355.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
update trustdefensive validationboot or update path
AI analysis · Moderate 60/100

This commit fixes a security gap in the Passport hardware wallet's developer-public-key installation flow. Previously, the device only checked that the key file was 88 bytes long and installed whatever 64-byte blob it found without showing it to the user. Now it verifies that the 64 bytes actually form a valid point on the secp256k1 cryptographic curve, and it shows the key on screen and asks for user confirmation before writing it to the secure element. The change prevents installing malformed or all-zero keys that could never verify a firmware signature, and it closes a social-engineering path where a user might blindly trust a malicious key file.

Security candidateSFT-8167 SFT-8168: validate sighash types per input typeby Jack · 3286a7d9 · Sep 29, 2026 · 4 filesMessage 78 · AdequateModerate 59Details
Commit message · Jack

SFT-8167 SFT-8168: validate sighash types per input type

Sighash validation was shared across every input type, but the three
signers support different sets. Validate per input type instead:
SIGHASH_DEFAULT only exists for taproot (BIP-341), and the error now
names the input and the type.

Taproot takes both documented ALL modes. The rest of
make_txn_taproot_sighash() was already generic - it writes the hash type
byte into the message, and taproot_sign_key() already appends it as a
65th signature byte for anything but SIGHASH_DEFAULT - so only the
assertion had to change.

The legacy preimage also packs the type it is given rather than a
constant, and the assertions on the signing path carry messages.

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 59/100

This commit tightens how a Bitcoin hardware wallet (Passport) checks the 'sighash' flag for each transaction input. Previously the same allowed list was used for every input type, which meant a non-taproot input could in principle be asked to use SIGHASH_DEFAULT (a taproot-only value), or a taproot input could be asked to use an unsupported type. The code now validates sighash types per input type, uses the actual requested type when building the transaction digest, and gives clearer error messages. It also adds unit tests that independently recompute the digests and verify taproot signatures. The change is defensive hardening rather than a confirmed exploitable bug, but it removes a class of type-confusion risks in the signing path.

Security candidateSFT-8171: bounds accounting in BIP39 prefix matchingby Jack · fd77dd1e · Sep 29, 2026 · 4 filesMessage 73 · AdequateModerate 60Details
Commit message · Jack

SFT-8171: bounds accounting in BIP39 prefix matching

get_words_matching_prefix() worked in whole entries and did not account
for the separators it writes, so its accounting did not hold for every
buffer size and match count. Compute the room needed up front and count
the separator, and move the match cap into the loop condition so a count
of zero means zero rather than unlimited.

Also reject a negative count in the binding rather than converting it to
an unsigned one.

Shipped callers ask for at most 10 matches and are unaffected.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Moderate 60/100

This commit fixes a buffer-size accounting bug in the Passport hardware wallet's BIP39 word lookup feature. The function that returns matching seed-phrase words could write slightly past the end of its output buffer in some edge cases, and a negative match count could be misinterpreted as 'unlimited matches.' The patch corrects the size math, caps matches inside the loop, and rejects negative counts. The commit message says current callers are unaffected, and new unit tests verify the bounds.

Security candidateSFT-981: expose HDNode.blank() again and call it where it was commented outby Jack · 82f73907 · Sep 29, 2026 · 5 filesMessage 73 · AdequateModerate 60Details
Commit message · Jack

SFT-981: expose HDNode.blank() again and call it where it was commented out

stash.blank_object() has been a no-op for HD nodes since node.blank() was
dropped from the bindings, so every node SensitiveValues registered was
left in the heap when the context exited. export_summary_flow had the
same gap twice, with the wipe replaced by a TODO.

The wipe itself already exists: __del__ zeroes the whole hdnode. Register
that same function under blank as well, behind FOUNDATION_ADDITIONS, and
call it from blank_object() and both flow sites. A blanked node loses its
curve pointer too, so it is inert afterwards; every call site drops it on
the next line.

Also wipe the 64 byte BIP39 master seed in SecretStash.decode(), which is
never returned to the caller in the seed-words branch, and give
bip32.deserialize() the finaliser every other HDNode allocation in that
file already has.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialcryptography-sensitive pathboot or update path
AI analysis · Moderate 60/100

This commit fixes a security hygiene issue in the Passport hardware wallet firmware where sensitive cryptographic key material (HD wallet nodes and a BIP39 master seed) was not being actively wiped from device memory when no longer needed. Previously, the wipe function had been removed from the code bindings, leaving a no-op placeholder. The patch restores an explicit 'blank' wipe for HD nodes, calls it in the two places that had TODO comments, adds a finalizer so nodes are also wiped when garbage collected, and wipes a temporary 64-byte master seed that was otherwise never cleared. The risk is that private key material could remain in heap memory longer than intended, potentially increasing exposure if an attacker could read device memory or if memory is reused.

Security candidateSFT-8169: remove dead witness iterator branch and reject witness serialized unsigned txns clearlyby Jack · f2be0575 · Sep 29, 2026 · 3 filesMessage 73 · AdequateLow 30Details
Commit message · Jack

SFT-8169: remove dead witness iterator branch and reject witness serialized unsigned txns clearly

input_witness_iter() had a branch referencing fd and num_in, neither of
which exists in its scope. It is unreachable: had_witness can only be
true for a witness serialized unsigned transaction, and parse_txn()
already fails on those when _skip_n_objs() hits an unknown 'CTxInWitness'
and raises a bare ValueError.

BIP-174 requires the unsigned transaction to carry no witness data, so
keep rejecting it, but raise FatalPSBTIssue with a message the PSBT tasks
already know how to surface. had_witness and wit_start are then always
false and None, so drop them along with the branch that read them.

No validation is relaxed: the same inputs are rejected at the same point,
with a better message.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 30/100

This commit cleans up how the Passport hardware wallet handles Bitcoin transactions that incorrectly include witness data. It removes a dead, broken code branch that referenced non-existent variables and replaces a confusing low-level error with a clear user-facing message. The same invalid transactions were already being rejected; this change just makes the rejection clearer and safer, and adds tests to prove it.

Security candidateSFT-8173: validate scalar and point buffer lengths in the ECDSA bindingsby Jacksper13 · 78ab7429 · Sep 29, 2026 · 3 filesMessage 50 · ThinModerate 63Details
Commit message · Jacksper13

SFT-8173: validate scalar and point buffer lengths in the ECDSA bindings

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationcryptography-sensitive pathboot or update path
AI analysis · Moderate 63/100

This commit fixes a buffer length bug in the firmware's cryptographic code. Two functions that perform elliptic-curve math were reading exactly 32 bytes from caller-supplied buffers without first checking that the buffers were actually 32 bytes long. A shorter buffer could cause the code to read beyond its end, which on a hardware wallet could leak secret data or crash the device. The fix adds explicit length checks that reject any input that is not exactly 32 bytes, and adds tests to confirm the checks work.

Security candidateSFT-8184: restore the NOT_BIP39_MODE and MULTISIG_STORAGE_IDX_ERROR error codesby Jacksper13 · 0b7c5a05 · Sep 29, 2026 · 3 filesMessage 50 · ThinLow 47Details
Commit message · Jacksper13

SFT-8184: restore the NOT_BIP39_MODE and MULTISIG_STORAGE_IDX_ERROR error codes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
secret or key material
AI analysis · Low 47/100

This commit fixes a simple but consequential typo in a list of error names: a missing comma had caused two distinct error codes to be merged into one long, meaningless name. As a result, any code that tried to use either of the two intended error codes would have crashed with an AttributeError. The patch restores the comma and adds a unit test to catch this in the future. It is a reliability/availability bug rather than a direct theft-of-funds vulnerability, but on a security device like Passport it could cause unexpected failures during multisig or seed-related operations.

AI review queuedSFT-7352: add Blockstream crypto-account exportby BitcoinQnA · 1a596e41 · Sep 27, 2026 · 5 filesMessage 45 · ThinInformational 15Details
Commit message · BitcoinQnA

SFT-7352: add Blockstream crypto-account export

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a new feature that lets Passport hardware wallets export a Bitcoin account as a QR code formatted for Blockstream's Jade wallet. It is a straightforward feature addition with no visible security bug.

AI review queuedMerge pull request #676 from Foundation-Devices/fix/change-verification-error-copyby mjg-foundation · 1d69eb29 · Sep 25, 2026 · 3 filesMessage 83 · StrongInformational 15Details
Commit message · mjg-foundation

Merge pull request #676 from Foundation-Devices/fix/change-verification-error-copy

Clarify change ownership verification error

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes the user-facing error message shown when the Passport hardware wallet cannot verify that a transaction's change address belongs to the wallet. The underlying security check and error handling remain exactly the same; only the wording is clearer and less technical. There is no security vulnerability being fixed.

AI review queuedMerge pull request #665 from Foundation-Devices/casa-crypto-account-exportby mjg-foundation · 5e499107 · Sep 16, 2026 · 5 filesMessage 73 · AdequateInformational 24Details
Commit message · mjg-foundation

Merge pull request #665 from Foundation-Devices/casa-crypto-account-export

Export both Casa pairing keys by QR and microSD

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit adds a new feature to Foundation's Passport hardware wallet that exports two cryptographic public keys for Casa wallet registration: the master extended public key and a separate Casa-specific key derived at path m/45'. The keys can be exported either as a QR code or saved to a microSD card. The change is a feature addition, not a bug fix, and there is no evidence in the commit that it addresses a security vulnerability. However, exporting additional key material always slightly increases the attack surface if the exported data is mishandled.

AI review queuedMerge pull request #669 from Foundation-Devices/add-native-unchained-connect-walletby mjg-foundation · 26bd36d5 · Sep 16, 2026 · 12 filesMessage 73 · AdequateLow 25Details
Commit message · mjg-foundation

Merge pull request #669 from Foundation-Devices/add-native-unchained-connect-wallet

Add native Unchained Connect Wallet support

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit adds support for the Unchained wallet to the Passport hardware wallet. Most of the change is normal feature code, but it also introduces a new way to feed already-encoded data into the QR encoder and tightens up the encoder so it won't produce output if it hasn't been started correctly. The simulator also gets clipboard copy/paste tweaks. There is no vendor statement that this fixes a security bug, and the changes look like defensive hardening rather than a patch for an active vulnerability.

Security candidateMerge pull request #655 from Foundation-Devices/sft-7320-entropy-hardeningby mjg-foundation · 0f1a5325 · Sep 16, 2026 · 9 filesMessage 78 · AdequateModerate 55Details
Commit message · mjg-foundation

Merge pull request #655 from Foundation-Devices/sft-7320-entropy-hardening

SFT-7320: Improve Passport Core hardware error handling

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessdefensive validationseed or entropy pathboot or update pathmerge-commit duplicate discount
AI analysis · Moderate 55/100

This firmware update hardens the way Passport generates random numbers. Previously, a failing or stuck hardware random-number generator could silently produce weak or repeated values, which is dangerous for creating secret keys. The patch makes the device detect bad randomness and either recover or permanently stop with a clear error screen, instead of continuing with potentially guessable secrets. It also routes all MicroPython randomness through the same checked generator.

AI review queuedMerge pull request #675 from Foundation-Devices/fix/verify-change-before-reviewby Jacksper13 · 1fea63c8 · Sep 14, 2026 · 4 filesMessage 83 · StrongHigh 71Details
Commit message · Jacksper13

Merge pull request #675 from Foundation-Devices/fix/verify-change-before-review

Complete change verification before transaction review

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 71/100

This firmware update moves the verification of Bitcoin 'change' addresses to happen before the user reviews the transaction on screen. Previously, the device checked whether change outputs truly belonged to the wallet only after the user had already approved the transaction and while it was about to sign. Because the review screen hides change outputs from the user, a malicious or buggy PSBT could have asked the device to send change to an attacker's address, and the user would never see it before approving. The fix ensures the wallet proves it owns every hidden change output before showing the review screen, so a mismatch aborts the transaction before the user is asked to confirm.

AI review queuedSFT-8098: skip change verification for transactions without changeby Jacksper13 · 3df93748 · Sep 11, 2026 · 2 filesMessage 83 · StrongLow 29Details
Commit message · Jacksper13

SFT-8098: skip change verification for transactions without change

Avoid opening the key store when review does not require change verification. Clarify the spinner label and cover cancellation with and without change.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 29/100

This commit changes how the Passport hardware wallet reviews Bitcoin transactions that have no 'change' output. Previously, the wallet would always run a change-verification step that opens the secure key store, even when there was no change to verify. Now it skips that step when there is no change, and updates the on-screen spinner label from 'Validating transaction' to 'Verifying change' so the user knows what is happening. The change is framed by the developer as a user-experience and clarity improvement, not as a fix for a known security vulnerability.

AI review queuedSFT-8098: complete change verification before transaction reviewby Jacksper13 · fb88001c · Sep 11, 2026 · 4 filesMessage 83 · StrongModerate 59Details
Commit message · Jacksper13

SFT-8098: complete change verification before transaction review

Reuse the existing check after wallet approval and before transaction details. Keep one verification pass and extend the approval flow regressions.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit moves a safety check earlier in the process of approving a Bitcoin transaction on the Passport hardware wallet. Previously, the wallet verified that 'change' outputs (money going back to your own wallet) truly belonged to you only after you had already reviewed the transaction and approved signing. Now that ownership proof happens before the transaction details are shown to the user. This prevents a scenario where a malicious or buggy PSBT (the file describing the transaction) hides a change address that actually belongs to an attacker, because the wallet will refuse to show the review screen if it cannot prove the change is yours. The change is defensive: it closes a window where a user might approve a transaction whose change output has not yet been validated.

Security candidateMerge pull request #673 from Foundation-Devices/SFT-7945-add-pytest-to-devshellby mjg-foundation · d8ee1164 · Sep 11, 2026 · 25 filesMessage 58 · ThinInformational 15Details
Commit message · mjg-foundation

Merge pull request #673 from Foundation-Devices/SFT-7945-add-pytest-to-devshell

SFT-7945: Add Pytest to Nix Devshell

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
seed or entropy pathauthentication pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine development tooling and cleanup change. It adds the Pytest testing framework to the project's Nix development shell, fixes a test runner path, adds a GitHub Actions workflow to run simulator tests automatically, and removes an unused translation system along with its associated tests. There is no indication this change fixes a security vulnerability or introduces a security-relevant behavior.

Security candidateMerge pull request #648 from Foundation-Devices/dependabot-host-tooling-hygieneby Jacksper13 · d6c05830 · Sep 2, 2026 · 5 filesMessage 73 · AdequateInformational 18Details
Commit message · Jacksper13

Merge pull request #648 from Foundation-Devices/dependabot-host-tooling-hygiene

Update Pillow constraints for host tooling

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update pathautomated dependency-update discountmerge-commit duplicate discount
AI analysis · Informational 18/100

This commit updates the Python Pillow image-processing library used in host-side developer tooling from version 8.x to 12.3.x and requires Python 3.10 or newer. Pillow 8.x is known to have many publicly disclosed security vulnerabilities, so the change likely removes exposure to those bugs during firmware build and test workflows. The change does not alter the firmware that runs on the Passport device itself, only the tools that run on a developer's computer.

AI review queuedMerge pull request #649 from Foundation-Devices/bitcoin-safe-wallet-flowby Jacksper13 · 9f1e36b0 · Sep 2, 2026 · 3 filesMessage 58 · ThinInformational 15Details
Commit message · Jacksper13

Merge pull request #649 from Foundation-Devices/bitcoin-safe-wallet-flow

Add Bitcoin Safe wallet flow

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds support for a new Bitcoin software wallet called 'Bitcoin Safe' to the Passport hardware wallet firmware. It is a straightforward feature addition that registers the wallet in the firmware's list of supported software wallets and defines how to export wallet data to it (via QR code or microSD card). There is no indication of a security bug, vulnerability, or fix in the changed code.

AI review queuedMerge pull request #653 from Foundation-Devices/show-op-return-output-amountby Jacksper13 · 433c4a20 · Sep 2, 2026 · 3 filesMessage 58 · ThinModerate 62Details
Commit message · Jacksper13

Merge pull request #653 from Foundation-Devices/show-op-return-output-amount

Show amounts for OP_RETURN outputs

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 62/100

This update changes how the Passport hardware wallet displays Bitcoin transaction outputs that carry data (OP_RETURN outputs). Previously, only the embedded message was shown. Now the device also shows the amount of bitcoin assigned to that output and escapes the message text so a crafted message cannot fake extra user-interface labels (like a fake 'Amount' or 'Destination' section). The included tests demonstrate that an attacker who controls an OP_RETURN message can no longer make the screen look like a real payment destination is being sent funds.