AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 25 Bitcoin

Merge pull request #669 from Foundation-Devices/add-native-unchained-connect-wallet

Public commit record

What the developer wrote

Authored by mjg-foundation

73/100 · Adequate
Merge pull request #669 from Foundation-Devices/add-native-unchained-connect-wallet

Add native Unchained Connect Wallet support
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds support for the Unchained wallet to the Passport hardware wallet. Most of the change is normal feature code, but it also introduces a new way to feed already-encoded data into the QR encoder and tightens up the encoder so it won't produce output if it hasn't been started correctly. The simulator also gets clipboard copy/paste tweaks. There is no vendor statement that this fixes a security bug, and the changes look like defensive hardening rather than a patch for an active vulnerability.

Recommended action

Review the new `ur_encoder_start_raw` path for memory-safety invariants, ensure callers cannot pass attacker-controlled UR types or CBOR lengths, and confirm the `started` flag is reset consistently on all failure paths. Treat as routine feature code with minor defensive hardening; no urgent security response indicated.

Security signals we found

01

New unsafe FFI function `ur_encoder_start_raw` added with documented safety preconditions

02

UR type string is validated (length, charset, UTF-8) before use in encoder

03

Encoder now tracks a `started` flag and returns empty output if not started, reducing use-after-free/misuse risk

04

No vendor disclosure of security relevance, CVE, or researcher attribution in commit or references

Risk score

Why this scored 25/100

Our methodology →
Potential impact 3/30
Exploitability 4/25
Stealth signal 3/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.