SFT-3235: re-enabled btcpay taproot
What the developer wrote
Authored by Matt Gleason
SFT-3235: re-enabled btcpay taproot
What changed, and why it matters
This commit re-enables the option for BTCPay wallet exports on the Passport hardware wallet to use the newer Taproot (P2TR) address format, in addition to the existing SegWit (P2WPKH) format. It is a feature re-enablement, not a fix for a vulnerability. There is no direct evidence in the commit or supplied references that this change addresses a security flaw.
No security action required. Treat as a normal feature change. If reviewing for security, verify that the BTCPay export flow correctly handles P2TR address derivation and that any downstream signing or descriptor parsing supports Taproot as expected.
Security signals we found
No security-relevant code changes observed
Feature re-enablement only
No input validation, memory handling, or cryptographic logic modified
Evidence from the diff
The diff uncomments two configuration lines in ports/stm32/boards/Passport/modules/wallets/btcpay.py: select_addr_type: True and addr_options: [AF_P2WPKH, AF_P2TR]. This restores user-selectable address type support for BTCPay exports, allowing Taproot (P2TR) addresses. The change is minimal (+2/-2) and appears to be a product/feature decision rather than a security patch. No cryptographic, parsing, or protocol changes are present in the diff.
Changed components
ports/stm32/boards/Passport/modules/wallets/btcpay.pyBTCPay wallet export flowAddress type selection UIInspect captured patch +2 / −2
diff --git a/ports/stm32/boards/Passport/modules/wallets/btcpay.py b/ports/stm32/boards/Passport/modules/wallets/btcpay.py
index 72a3c05..ccee415 100644
--- a/ports/stm32/boards/Passport/modules/wallets/btcpay.py
+++ b/ports/stm32/boards/Passport/modules/wallets/btcpay.py
@@ -19,6 +19,6 @@ BtcPayWallet = {
{'id': 'microsd', 'label': 'microSD', 'filename_pattern': '{xfp}-btcpay.json',
'filename_pattern_multisig': '{xfp}-btcpay-multisig.json'}
],
- # 'select_addr_type': True,
- # 'addr_options': [AF_P2WPKH, AF_P2TR],
+ 'select_addr_type': True,
+ 'addr_options': [AF_P2WPKH, AF_P2TR],
}
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.