SFT-6748: first pass to fix github artifacts
What changed, and why it matters
This commit is a routine GitHub Actions CI/CD maintenance change. It simplifies how firmware build artifacts are named and how bootloader build jobs are configured in the automated build pipeline. There is no change to the firmware code itself, no security fix, and no vulnerability introduced.
No security action required. Treat as normal CI/CD housekeeping.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies .github/workflows/build.yaml. It merges two color variants (light/dark) of the color-screen build matrix into a single color entry, and updates the downstream bootloader job to iterate over colorway (light/dark) directly rather than over screen. Artifact names are adjusted from bootloader-${{ env.SCREEN_MODE }}-${{ env.COLORWAY }}.bin to bootloader-COLOR-${{ env.COLORWAY }}.bin. These are purely pipeline/artifact naming changes.
Changed components
.github/workflows/build.yamlInspect captured patch +10 / −8
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 7954b5b..ec982e0 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -15,8 +15,7 @@ jobs:
build:
[
{ screen: 'mono', suffix: '-founders-passport', hash_suffix: '-founders'},
- { screen: 'color', colorway: 'light', suffix: '-passport-light', hash_suffix: '-light'},
- { screen: 'color', colorway: 'dark', suffix: '-passport-dark', hash_suffix: '-dark'},
+ { screen: 'color', suffix: '-passport', hash_suffix: ''},
]
services:
@@ -108,7 +107,11 @@ jobs:
# TODO: SFT-1077.
strategy:
matrix:
- screen: ['color']
+ build:
+ [
+ { colorway: 'light'},
+ { colorway: 'dark'},
+ ]
services:
registry:
@@ -137,17 +140,16 @@ jobs:
- run: cargo install just@1.23.0 --locked
- run: |
echo "DOCKER_IMAGE=localhost:5000/foundation-devices/passport2:latest" >> $GITHUB_ENV
- echo "SCREEN_MODE=$(echo ${{ matrix.screen }} | tr a-z A-Z)" >> $GITHUB_ENV
- echo "COLORWAY=$(echo ${{ matrix.colorway }} | tr a-z A-Z)" >> $GITHUB_ENV
+ echo "COLORWAY=$(echo ${{ matrix.build.colorway }} | tr a-z A-Z)" >> $GITHUB_ENV
- name: Build
- run: just build-bootloader ${{ matrix.screen }}
+ run: just build-bootloader color ${{ matrix.build.colorway }}
- name: Upload bootloader
uses: actions/upload-artifact@v4
with:
- name: bootloader-${{ env.SCREEN_MODE }}-${{ env.COLORWAY }}.bin
- path: ports/stm32/boards/Passport/bootloader/arm/release/bootloader-${{ env.SCREEN_MODE }}-${{ env.COLORWAY }}.bin
+ name: bootloader-COLOR-${{ env.COLORWAY }}.bin
+ path: ports/stm32/boards/Passport/bootloader/arm/release/bootloader-COLOR-${{ env.COLORWAY }}.bin
simulator:
name: Simulator
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.