Electrum

This commit is a small internal code cleanup. It moves a checksum helper function from the Qt (graphical user interface) part of the timelock recovery plugin into the plugin's shared base class so it can be reused and tested without needing to load the Qt GUI code during tests. The checksum logic itself is unchanged, and there is no security fix or behavior change visible in the diff.

This commit only adds a new test case to the Electrum test suite. It verifies that a checksum function used by the timelock_recovery plugin produces a known, expected output for an example taken from a Bitcoin improvement proposal (BIP). No production code was changed, and there is no security fix or vulnerability introduced.

This commit adds a new automated test to verify that a checksum function correctly handles non-ASCII characters (like accented letters, Chinese, Japanese, Arabic, and Hebrew text). It does not change any production code. The test ensures that special characters are kept as-is rather than being converted to Unicode escape sequences before hashing. This is a quality-assurance change, not a security fix or vulnerability.

This commit fixes how a recovery-plan checksum is calculated in Electrum's timelock recovery plugin. Previously, non-English characters were being converted to ASCII escape sequences before hashing, which could produce a different checksum than expected by the BIP-128 standard. The fix makes hashing consistent with the standard and shortens the displayed checksum to 8 hex characters. Plans that used only ordinary ASCII characters are unaffected.

This commit only re-enables an existing automated test for a Lightning Network channel-closing scenario where two sides cannot agree on a fee. It does not change the actual Electrum wallet or Lightning code that users run, so it cannot directly affect real funds or security. It is a testing improvement.

This commit adds a small 50-millisecond delay between Lightning Network commitment signature messages so multiple small updates can be batched into a single signature. It is a performance optimization, not a security fix. The change does not appear to address any known vulnerability.

This commit tidies up when Electrum's Lightning code sends a 'commitment_signed' message during payment channel updates. It removes some calls that happened when receiving certain updates and adds them where the sender has just sent an update. The change is described by the author as a simplification, not a security fix, and the commit message explicitly says the removed calls were safe but unnecessary.

This commit simply updates contact details for one public Electrum server in the app's built-in server list. The server operator changed their domain name from electrum.jochen-hoenicke.de to electrum.jhoenicke.de and switched back to the standard Electrum ports (50001/50002) because they said a non-standard port was being abused by malware. There is no code change and no direct security fix in Electrum itself.

This commit fixes a type mismatch bug in Electrum's mobile/QML user interface. A fee rate value was stored as a number (0) but the QML interface expected text ('0'), causing a crash when certain code paths ran. The fix changes the initial value from a number to a string so the interface no longer crashes. There is no indication this could be used to steal funds or attack users remotely.

This commit fixes a crash in Electrum's mobile-style QML user interface when users try to speed up (RBF) or cancel a transaction while the app hasn't finished downloading all the transaction details from the network. Previously the app would throw an exception; now it shows a warning and stops gracefully. It is a robustness fix, not a security vulnerability that lets an attacker steal funds.

This is a bug-fix patch for the Electrum Bitcoin wallet. It corrects a logic error where a network failure was being silently swallowed instead of being reported, which could cause the wallet's fee-bumping feature to crash later with a confusing error. There is no indication this allows theft, remote code execution, or unauthorized access; it is a reliability and user-experience fix.

This commit fixes a crash in Electrum's Nostr Wallet Connect (NWC) plugin when a user looks up an existing incoming invoice. The code was trying to read a non-existent 'payment_hash' field and instead should use the invoice's existing 'rhash' value. It also changes the response so the BOLT11 invoice string is always included, rather than only when the client originally searched by payment hash. This improves compatibility with a third-party service (sandbox.albylabs.com) that rejects responses missing the invoice string. There is no indication this bug could be exploited by an attacker; it is a functional bug causing request failures.

This commit fixes a bug in Electrum's Nostr Wallet Connect (NWC) plugin where the reported amount and fee for a Lightning payment could be temporarily wrong right after the payment succeeds. Previously, the code only looked at fully settled payment parts. If one part had settled but others were still in flight, the plugin could report an incomplete or zero amount/fee. The fix now includes still-in-flight payment parts when calculating the total, assuming they will also settle. This is mainly a correctness/reliability fix, not a direct theft-of-funds vulnerability, but incorrect payment info could mislead connected apps or users.

This commit adds a simple UI refresh timer to the NWC (Nostr Wallet Connect) plugin's connection list window. Every 5 seconds, the list of wallet connections is refreshed so that users can see updated budget information without manually closing and reopening the window. There is no security-relevant change visible in the diff.

This commit fixes a bug in Electrum's NWC (Nostr Wallet Connect) plugin where a connected client could spend more than its allowed daily budget by deliberately routing a Lightning payment through an expensive path. Previously, only the invoice amount was counted toward the budget, not the routing fees. The fix reserves the maximum expected fee up front and later adjusts the budget to reflect the actual fee paid.

This commit is a code cleanup in Electrum's NWC (Nostr Wallet Connect) plugin. It merges two separate budget-checking functions into one. Previously, the code first checked if a payment was within budget, then recorded it. Now it does both in one step. The commit message and diff do not describe any security bug being fixed; it appears to be a simplification/refactoring change. There is no evidence this fixes a known vulnerability.

This commit is a simple code cleanup in Electrum's test suite. It merges two nearly identical Lightning network reconnection tests into one shared helper method, removing duplicated code. No production code was changed, and nothing about the actual wallet or payment behavior is affected.

This commit only changes a test file. It makes an existing automated test more reliable by waiting for both payment parts to finish before checking the result, instead of assuming both finished at once. There is no change to the actual Electrum wallet or Lightning code that users run.

This commit fixes a user-interface bug in the Electrum Bitcoin wallet's Qt desktop client. Previously, when a user chose to 'fully spend' selected coins to open a Lightning channel or perform a submarine swap, the wallet used the global 'coin control' setting to remember the coin selection. That caused the selected coins to remain locked in coin control after the dialog closed, and a background timer could keep re-creating transactions with the same already-signed coins, leading to an exception. The change passes the selected coins directly to the relevant dialogs instead of relying on coin control, and stops the timer when the dialog finishes. It is a reliability/usability fix rather than a remote-exploitable security vulnerability.

This commit adds safety checks (assert statements) to three helper methods in Electrum's Qt wallet interface. These helpers perform actions like swapping coins, opening a Lightning channel, or paying to a clipboard address. The new checks ensure that at least one coin is selected before proceeding, because otherwise the code would silently default to using all available coins. The commit message says a previous change should prevent this from happening, so these asserts are a defensive backup rather than a fix for an active bug.

This commit only changes a version number in a plugin manifest file from 0.0.1 to 0.0.2. There is no code change, no bug fix, and no security-related content in the diff itself.

This commit updates Electrum's Nostr Wallet Connect (NWC) plugin to add a 'state' field to payment responses, following a recent extension to the NIP-47 protocol standard. The change is described by the developer as fixing a display bug where the Alby Go wallet app was incorrectly showing successful payments as failed. There is no indication this is a security vulnerability or that it introduces one.

This commit fixes a race condition in Electrum's NWC (Nostr Wallet Connect) plugin that could let a user spend more than their daily budget. Previously, the plugin checked the budget before each payment but only recorded the spend after a payment succeeded. If several payments were started at the same time, they could all pass the budget check and collectively exceed the limit. The fix records the spend before attempting the payment and refunds it only if the payment fails. The commit message explicitly describes this as preventing a race condition.

This commit fixes a rounding bug in Electrum's NWC (Nostr Wallet Connect) plugin. The plugin lets users set a daily spending limit in satoshis, but it was internally tracking spent amounts in whole satoshis. Because Lightning invoices are priced in millisatoshis (one-thousandth of a satoshi), rounding down to satoshis could let a user or service spend slightly more than the intended daily limit over many small payments. The patch now tracks the budget in millisatoshis and converts the limit to millisatoshis for comparison, closing the rounding gap. It also migrates existing saved budget data from satoshis to millisatoshis.

This commit fixes a user-interface glitch in the Electrum desktop wallet's Qt GUI. If a user right-clicked an address or a coin (UTXO) to open a menu, and the wallet's background update refreshed the list while the menu was still open, the menu could remain visible even though the item it referred to no longer existed or had changed. The fix automatically closes such stale context menus. It is a usability/reliability fix rather than a cryptographic or network security flaw, but acting on a stale menu could in principle lead to user confusion or unintended transactions.