tests: timelock_recovery plugin: add test vector for checksum from bip

Electrum/Electrum

907ceb9f View source ↗

Public commit record

What the developer wrote

Authored by SomberNight

60/100 · Adequate

tests: timelock_recovery plugin: add test vector for checksum from bip

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body

The short version

What changed, and why it matters

This commit only adds a new test case to the Electrum test suite. It verifies that a checksum function used by the timelock_recovery plugin produces a known, expected output for an example taken from a Bitcoin improvement proposal (BIP). No production code was changed, and there is no security fix or vulnerability introduced.

Recommended action

No action required. This is a routine test-only change.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The diff adds a single test method, test_checksum_bip_example, to tests/test_timelock_recovery.py. The test constructs a JSON timelock recovery plan matching a BIP-0128 reference implementation example and asserts that TimelockRecoveryQtPlugin._checksum returns ‘92f8b3da’. This is purely an expansion of test coverage for an existing checksum helper.

Changed components

tests/test_timelock_recovery.py

Inspect captured patch +42 / −0

diff --git a/tests/test_timelock_recovery.py b/tests/test_timelock_recovery.py
index efe21e3..93b7b72 100644
--- a/tests/test_timelock_recovery.py
+++ b/tests/test_timelock_recovery.py
@@ -127,3 +127,45 @@ class TestTimelockRecovery(ElectrumTestCase):
         json_data = {"wallet_name": "Ωmega Wörld Ñoño 日本語 中文 עברית العربية", "id": "abc-123"}
         result = TimelockRecoveryQtPlugin._checksum(json_data)
         self.assertEqual(result, "74674eca")
+
+    def test_checksum_bip_example(self):
+        # test vector from https://github.com/bitcoin/bips/blob/b3827283792882ed0176a12033944fd63c5d398b/bip-0128.mediawiki#reference-implementation
+        json_data = {
+          "kind": "timelock-recovery-plan",
+          "id": "exported-692452189b301b561ed57cbe",
+          "name": "Recovery Plan ac300e72-7612-497e-96b0-df2fdeda59ea",
+          "description": "RITREK APP 1.1.0: Trezor Account #1",
+          "created_at": "2025-11-24T12:39:53.532Z",
+          "plugin_version": "1.0.1",
+          "wallet_version": "1.0.1",
+          "wallet_name": "RITREK Service",
+          "wallet_kind": "RITREK BACKEND",
+          "timelock_days": 2,
+          "anchor_amount_sats": 600,
+          "anchor_addresses": [
+            "bc1qnda6x2gxdh3yujd2zjpsd7qzx3awxmlaf9wwlk"
+          ],
+          "alert_address": "bc1qj0f9sjenwyjs0u7mlgvptjp05z3syzq7mru3ep",
+          "alert_inputs": [
+            "a265a485df4c6417019b91379257eb387bceeda96f7bb6311794b8ed358cf104:0",
+            "2f621c2151f33173983133cbc1000e3b603b8a18423b0379feffe8513171d5d3:0"
+          ],
+          "alert_tx": "0200000000010204F18C35EDB8941731B67B6FA9EDCE7B38EB579237919B0117644CDF85A465A20000000000FDFFFFFFD3D5713151E8FFFE79033B42188A3B603B0E00C1CB3331987331F351211C622F0000000000FDFFFFFF0258020000000000001600149B7BA329066DE24E49AA148306F802347AE36FFD205600000000000016001493D2584B33712507F3DBFA1815C82FA0A302081E02483045022100DCDBAE77C35EB4A0B3ED0DE5484206AB6B07041BE99B2BBAF0243C125916523C0220396959C3C52B2B1F9E472AEEE7C5D9540531B131C3221DE942754C6D0941397D012103C08FF3ADBA14B742646572BCA6F07AEB910666FB28E4DDDC40E33755E7C869D30248304502210089084472FDA3CF82D6ABC11BF1A5E77C9B423617C8B840F58C02746035B3BA6302203942AA1FA13F952F49FB114D48130A9AAF70151E7D09036D15734DB1F41A8B6001210397064EDED7DAD7D662290DC2847E87C5C27DA8865B89DDB58FDE9A006BA7DB3900000000",
+          "alert_txid": "f1413fedadaf30697820bcd8f6a393fcc73ea00a15bea3253f89d5658690d2f7",
+          "alert_fee": 231,
+          "alert_weight": 834,
+          "recovery_tx": "02000000000101F7D2908665D5893F25A3BE150AA03EC7FC93A3F6D8BC20786930AFADED3F41F101000000005201400001A6550000000000001600149B7BA329066DE24E49AA148306F802347AE36FFD0247304402204AFF87C2127F5697F300C6522067A8D5E5290CA8D140D2E5BCEF4A36606C5FE5022056673BEC5BB459DFFBD4D266EE95AEF0D701383ED80BD433A02C3C486A826D76012102774DBCD59F2D08EFF718BC09972ADC609FBC31C26B551B3E4EA30A1D43EEDB9700000000",
+          "recovery_txid": "bc304610e8f282036345e87163d4cba5b16488a3bf2e4d738379d7bda3a0bca3",
+          "recovery_fee": 122,
+          "recovery_weight": 437,
+          "recovery_outputs": [
+            [
+              "bc1qnda6x2gxdh3yujd2zjpsd7qzx3awxmlaf9wwlk",
+              21926,
+              "My Backup Wallet"
+            ]
+          ],
+          "metadata": "sig:825d6b3858c175c7fc16da3134030e095c4f9089c3c89722247eeedc08a7ef4f",
+        }
+        result = TimelockRecoveryQtPlugin._checksum(json_data)
+        self.assertEqual(result, "92f8b3da")

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

Merge pull request #10791 from SomberNight/202608_wallet_sign_message2

wallet: sign_message: strip whitespaces in GUIs, do not strip in CLI

wallet: decrypt_message: nicer error msg if pubkey is unrelated