EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 38 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityautogenerate-rpc-examples.py: canned blocks.by Rusty Russell · 0dd214af · Jul 14, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: canned blocks.

Unless REGENERATE_BLOCKCHAIN is true, in which case we make them.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit changes only a test helper script that generates example outputs for RPC documentation. It introduces the ability to use pre-recorded ('canned') Bitcoin blockchain data instead of always generating a fresh one. There is no change to production code, wallet handling, networking, or cryptography, and no security relevance is apparent.

Lower-priorityautogenerate-rpc-examples.py: rewrite problematic examples.by Rusty Russell · 4b762330 · Jul 14, 2026 · 2 filesMessage 65 · AdequateInformational 14Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: rewrite problematic examples.

And hand in CLN_NEXT_VERSION to replace the version string.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 14/100

This commit is a test and documentation tooling change. It improves a Python script that auto-generates example RPC outputs for Core Lightning's documentation, making the generated examples more stable across versions and test runs. There is no indication it fixes a security vulnerability or changes production code.

Lower-priorityautogenerate-rpc-examples.py: parameterized base port and cln next versionby ShahanaFarooqui · c928c573 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: parameterized base port and cln next version

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a maintenance update to a test helper script that auto-generates example RPC output for documentation. It makes the base network port and the next Core Lightning version configurable via environment variables, updates hard-coded node IDs used in examples, adjusts a few test amounts and adds some node shutdown calls. There is nothing here that affects real users' funds, network security, or production code.

Lower-priorityautogenerate-rpc-examples.py: added wait functions like wait_for_htlcs_settled, wait_for_wallet_txsby ShahanaFarooqui · c56990f7 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: added wait functions like wait_for_htlcs_settled, wait_for_wallet_txs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes an internal test script that automatically generates documentation examples for RPC commands. It adds wait helpers so the example generator pauses until payments and wallet transactions finish updating, making the generated examples more consistent. There is no change to the actual Core Lightning node software, network protocol, or wallet logic that users run.

Lower-priorityautogenerate-rpc-examples.py: added feature to be able to rewrite the request in Rewriterby ShahanaFarooqui · cf3467a3 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: added feature to be able to rewrite the request in Rewriter

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes an internal test helper script used to generate documentation examples. It adds the ability to rewrite request parameters in example snippets, similar to the existing ability to rewrite responses. There is no change to the actual Core Lightning node software, network protocol, wallet handling, or any user-facing runtime behavior. It is not a security fix and does not introduce a security issue.

Security candidateautogenerate-rpc-examples.py: pin the full sorted UTXO set for multiwithdraw examplesby ShahanaFarooqui · 6f464e46 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: pin the full sorted UTXO set for multiwithdraw examples

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access control
AI analysis · Informational 15/100

This commit only changes an internal test script that automatically generates example RPC commands for documentation. It makes the examples more deterministic by explicitly selecting which coins the test wallet uses, so the generated documentation does not vary randomly between test runs. There is no change to the actual Core Lightning node software that users run, and no security vulnerability is being fixed.

Lower-priorityautogenerate-rpc-examples.py: added more rewrite for other RPCsby ShahanaFarooqui · 2e608edc · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: added more rewrite for other RPCs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a test helper script that automatically rewrites RPC command examples used in documentation. It adds more rules to make generated examples stable across test runs by replacing variable values like network ports, transaction IDs, and timestamps with fixed placeholder values. There is no change to the actual Core Lightning node software or its security behavior.

Lower-priorityautogenerate-rpc-examples.py: added sorting for some list example to stabilise the responseby ShahanaFarooqui · 9a50cc12 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: added sorting for some list example to stabilise the response

And flake fixes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a test helper script that generates documentation examples for RPC commands. It adds sorting and renumbering of example output fields so the generated documentation stays the same across test runs. There is no change to the actual Core Lightning node software, wallet handling, network code, or any user-facing runtime behavior.

Security candidatedoc: generate all examples with newchainby ShahanaFarooqui · e392c7d7 · Jul 14, 2026 · 129 filesMessage 45 · ThinInformational 15Details
Commit message · ShahanaFarooqui

doc: generate all examples with newchain

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100

This commit is a large documentation-only refresh. It regenerates example outputs in the project's JSON API schema files and test data so that all examples use a newer, more realistic test chain setup called 'newchain'. The values shown in the examples (node IDs, transaction IDs, payment hashes, runes, invoices, etc.) are swapped from placeholder/fake-looking strings to ones that look like real Bitcoin Lightning testnet data. There is no code change to the actual lightning node software, no bug fix, and no security patch.

Lower-priorityCI: re-enable docs examples checks.by Rusty Russell · e29915c6 · Jul 14, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Rusty Russell

CI: re-enable docs examples checks.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply turns a disabled GitHub Actions CI job back on. It re-enables automatic checks that update examples in the project's documentation schemas and makes the final documentation build depend on that job completing successfully. There is no code change to the lightning node software itself and no security relevance.

Lower-priorityCI: Add debug and upload artifacts on failureby ShahanaFarooqui · 4aae26dc · Jul 14, 2026 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · ShahanaFarooqui

CI: Add debug and upload artifacts on failure

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only improves GitHub Actions CI debugging. It adds extra logging and uploads test artifacts when a CI job fails. There is no change to the Core Lightning software itself, no user-facing behavior change, and no security issue.

Lower-priorityautogenerate-rpc-examples.py: use fixed port numbers.by Rusty Russell · 8475c95f · Jul 14, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: use fixed port numbers.

Move the elements config writing into an ElementsD.set_port() override. This makes many of our information outputs consistent.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit changes internal test tooling so that example-generation scripts use fixed TCP port numbers instead of random unused ports. It is a test-infrastructure and documentation-consistency change, not a fix for a security vulnerability in the Core Lightning node software itself.

Lower-prioritytests/autogenerate-rpc-examples.py: always use largest UTXO for fundchannel example.by Rusty Russell · 86aa1c04 · Jul 14, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Rusty Russell

tests/autogenerate-rpc-examples.py: always use largest UTXO for fundchannel example.

Now order has changed, the first one is insufficient; this is more robust.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a one-line change to a test script that auto-generates example RPC commands for documentation. It sorts a node's available coins by amount and picks the largest one, instead of picking whichever one happened to be listed first. This only affects documentation generation and has no security relevance.

Lower-prioritymake: Fix repeat-dpc-examples scriptby ShahanaFarooqui · c7605972 · Jul 14, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · ShahanaFarooqui

make: Fix repeat-dpc-examples script

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a tiny Makefile fix for an internal developer script that repeatedly runs documentation example tests. The change defines a BASE_PORTNUM variable so each test iteration uses a different network port range, preventing port collisions between iterations. There is no security relevance.

Security candidatecommon: add randbytes() wrapper to override cryptographic entropy: $CLN_DEV_ENTROPY_SEEDby Rusty Russell · 1c925e0a · Jul 14, 2026 · 5 filesMessage 90 · StrongInformational 18Details
Commit message · Rusty Russell

common: add randbytes() wrapper to override cryptographic entropy: $CLN_DEV_ENTROPY_SEED

Only in developer mode, ofc.

Notes:
1. We have to move the initialization before the lightningd main trace_start,
since that uses pseudorand().
2. To make the results stable, we need to use per-caller values to randbytes().
Otherwise external timing changes the call order.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

90/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomness
AI analysis · Informational 18/100

This commit adds a developer-only feature that lets programmers override the randomness source used by Core Lightning during testing, via an environment variable. It is explicitly gated behind 'developer mode' and is not intended for production use. The patch itself only updates test build files and adds missing stub functions so unit tests compile with the new wrapper. There is no indication it weakens real network security.

Lower-prioritymake: Pinning PATH in doc scripts so generation always uses the tree's own binariesby ShahanaFarooqui · 4f5ca1e0 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

make: Pinning PATH in doc scripts so generation always uses the tree's own binaries

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes the build system so that documentation examples are generated using the project's own freshly-built command-line tools, rather than whatever tools happen to be installed on the developer's system. It is a build-hygiene and reproducibility fix, not a security patch, and it does not fix any vulnerability in running software.

AI review queuedlightningd: cancel watching original funding when we switch to the new one via splice.by Rusty Russell · 3226d686 · Jul 14, 2026 · 2 filesMessage 73 · AdequateLow 41Details
Commit message · Rusty Russell

lightningd: cancel watching original funding when we switch to the new one via splice.

This happens if the channel is *not* announcable yet. Then we hit the assertion
in funding_depth_cb that the txid is the same as the current funding.txid.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: fixed crash when we splice a channel which hasn't been announced yet.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 41/100

This commit fixes a crash in Core Lightning that can happen when a user splices a channel that hasn't been publicly announced yet. Splicing is an experimental feature that changes a channel's funding transaction. The bug caused the program to hit an internal consistency check (assertion) because it was still monitoring the old funding transaction after switching to the new one. The commit only adds test stub functions and does not show the actual fix code, so we can only infer the intended change from the commit message.

Security candidatecommon: don't consume deterministic randbytes stream for trace idsby ShahanaFarooqui · 23b4b38a · Jul 14, 2026 · 1 fileMessage 83 · StrongLow 37Details
Commit message · ShahanaFarooqui

common: don't consume deterministic randbytes stream for trace ids

Trace/span ids now come from a plain counter when CLN_DEV_ENTROPY_SEED is active, so tracing (which CI's HAVE_USDT=1 build enables by default) no longer shifts the deterministic RNG stream that PSBT serial ids and locktime fuzz are drawn from.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
entropy or randomnesssigning boundaryfuzzing or regression evidence
AI analysis · Low 37/100

This change fixes a subtle bug in Core Lightning's tracing code. When running with a special developer-only deterministic randomness override (CLN_DEV_ENTROPY_SEED), trace IDs were being drawn from the same predictable random stream used for actual transaction details like PSBT serial IDs and locktime fuzzing. Because tracing may be enabled or disabled depending on build settings, this meant the same test or operation could produce different transaction outputs depending on whether tracing was compiled in. The fix makes trace IDs use a separate simple counter when deterministic mode is active, so tracing no longer shifts the random stream and transaction results stay consistent.

Security candidatecommon: don't trigger siphash_seed() init from span hashing either.by ShahanaFarooqui · e54fe678 · Jul 14, 2026 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · ShahanaFarooqui

common: don't trigger siphash_seed() init from span hashing either.

Previous commit stopped trace ids consuming the deterministic
randbytes stream, but tracing still touched it once: span_key_hash()
calls siphash_seed(), whose lazy init draws 16 bytes from the stream.
Since randbytes call sites are assigned their offset blocks in
first-use order, that single draw shifts every later draw in the
process by 1000 when tracing is active (HAVE_USDT builds, as in CI):
keysend preimages and invoicerequest payer keys then differ from a
build with tracing disabled, showing up as an 11-file doc-examples
diff.

Use a cheap multiplicative hash for span keys when the deterministic
override is active, so tracing touches the RNG stream zero times.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
entropy or randomness
AI analysis · Informational 19/100

This is a small bug-fix commit in Core Lightning's tracing code. It fixes a situation where enabling tracing accidentally changed the sequence of random numbers used elsewhere in the program, causing test outputs to differ between builds with and without tracing. The change makes tracing use a simple math hash instead of a randomness-seeded hash when deterministic mode is active. There is no direct security vulnerability here; it is a determinism/reproducibility fix.

Lower-priorityautogenerate-rpc-examples.py: more block generation and synchronization.by Rusty Russell · 03b239a4 · Jul 14, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: more block generation and synchronization.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This change only touches an internal test script that automatically generates example RPC output for documentation. It adds extra block generation and synchronization steps to make the example generator more reliable. There is no change to the actual Core Lightning node software, wallet logic, or network protocol, so it has no security impact on users.

Lower-priorityautogenerate-rpc-examples.py: fixed recover examples via `lightning-hsmtool getsecret`by ShahanaFarooqui · 16657264 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: fixed recover examples via `lightning-hsmtool getsecret`

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit updates a test script that automatically generates documentation examples for backup and recovery commands. It changes how the script retrieves a secret value for examples, switching from a developer tool command to a different command and from a raw hex secret to a 12-word mnemonic phrase. There is no indication this affects real user funds, live nodes, or production code paths.

Lower-priorityautogenerate-rpc-examples.py: added 17 new RPC to ignore listby ShahanaFarooqui · c3a3a0ec · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ShahanaFarooqui

autogenerate-rpc-examples.py: added 17 new RPC to ignore list

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates a test script's list of RPC commands that should be skipped when automatically generating documentation examples. It adds 17 more RPC names to an existing ignore list. There is no change to production code, network behavior, or security-sensitive logic.

Security candidatecommon: seed deterministic RNG from basename of argv0, not full pathby ShahanaFarooqui · 4ca60ba6 · Jul 14, 2026 · 1 fileMessage 95 · StrongInformational 19Details
Commit message · ShahanaFarooqui

common: seed deterministic RNG from basename of argv0, not full path

dev_override_randbytes() hashes argv0 into the CLN_DEV_ENTROPY_SEED
stream, so every plugin and subdaemon gets a distinct seed. But
lightningd execs them with absolute paths, so the "deterministic"
stream silently depended on where the source tree was checked out:
canned blocks generated in one directory would not replay in another
(funding tx output order and nlocktime fuzz diverge, so txids change).
This is why check-doc-examples passed locally but failed in CI.

Hash only the basename: binaries still get distinct seeds, but the
stream no longer depends on the checkout path.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
entropy or randomnessfuzzing or regression evidence
AI analysis · Informational 19/100

This change fixes a test-flakiness bug in a developer-only random-number override used during testing. It makes the random stream depend only on the program name, not the full file path, so tests produce the same results on different computers. It is not a security vulnerability fix.

Lower-priorityautogenerate-rpc-examples.py: ensure blockheights are consistent.by Rusty Russell · 5f1a0772 · Jul 14, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: ensure blockheights are consistent.

This makes our transaction generation (nlocktime) consistent, as well as our htlcs
for payment.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This change only touches a test helper script that auto-generates example RPC output for documentation. It adds calls to keep all test nodes synchronized on the current block height during example generation. There is no change to production code, no user-facing behavior change, and no security relevance.

Security candidateglobal: replace randombytes_buf() with randbytes() wrapper.by Rusty Russell · 72fd8b5c · Jul 14, 2026 · 24 filesMessage 65 · AdequateInformational 15Details
Commit message · Rusty Russell

global: replace randombytes_buf() with randbytes() wrapper.

This allows us to override it for deterministic results.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit only adds a new header include (<common/randbytes.h>) to 24 test files. It does not change any production code, cryptographic operations, or runtime behavior. The change is a test-infrastructure refactor to support deterministic randomness in tests, not a security fix or vulnerability.