EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 25 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityxpay: exclude a node that repeats unknown_next_peerby Vincenzo Palazzo · dba2823e · Sep 30, 2026 · 2 filesMessage 100 · StrongTriage 0Details
Commit message · Vincenzo Palazzo

xpay: exclude a node that repeats unknown_next_peer

The previous commit fails because xpay disables only the channel. A
second unknown_next_peer from the same node now calls
askrene-disable-node on this payment's private layer, so getroutes
stops handing back the rest of its channels.

The first failure still only disables that channel. One stale scid
must not take a well-connected node out of every path.
temporary_channel_failure and fee or CLTV errors are unchanged.

Removes the xfail from test_xpay_unknown_next_peer_excludes_node.
With the fix that test stops after two attempts:

Repeated unknown_next_peer from <hub>: disabling node for this payment

Fixes #9590.
Changelog-Fixed: xpay no longer retries every channel through a node that keeps returning unknown_next_peer.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritypytest: show xpay retries every channel on unknown_next_peerby Vincenzo Palazzo · cb80a364 · Sep 30, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Vincenzo Palazzo

pytest: show xpay retries every channel on unknown_next_peer

unknown_next_peer means the reporting node cannot forward, which is
what lnd returns when the next peer is offline. xpay only disables the
failed channel, so getroutes hands back every other channel through the
same node.

This test fails a hub with four exits using that code. On current xpay
it walks all four:

Failed after 4 attempts. We got a weird error (unknown_next_peer)
for 131x1x0/1 ... 124x1x0/1 ... 117x1x0/1 ... 110x2x0/0
assert 4 <= 2

Marked xfail until the next commit excludes the node after the repeat.

Changelog-None.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritypytest: accept HTTP 403 from currencyrate sources in test_apisby Sangbida Chaudhuri · 00fabc30 · Sep 30, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

pytest: accept HTTP 403 from currencyrate sources in test_apis

CoinGecko's keyless tier sometimes answers with a CloudFront 403 instead of 429 when the shared pool is saturated. Same throttle, so skip the source.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritytests: open channels in parallel to catch lost fds on macOSby dovgopoly · 836b4e8f · Sep 29, 2026 · 2 filesMessage 60 · AdequateTriage 0Details
Commit message · dovgopoly

tests: open channels in parallel to catch lost fds on macOS

Changelog-None

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI review queuedconnectd: keep the subd fd until connectd has received itby dovgopoly · 5e19c704 · Sep 29, 2026 · 10 filesMessage 73 · AdequateLow 30Details
Commit message · dovgopoly

connectd: keep the subd fd until connectd has received it

On macOS, a socket passed over SCM_RIGHTS whose sender closes its copy before the receiver's recvmsg completes can arrive unable to read. lightningd closed its end of a new subd's connection right after queueing it for connectd, so openingd or channeld could start with a dead connection: openingd logged "Peer connection lost", and fundchannel failed or hung waiting for accept_channel.

connectd now replies to peer_connect_subd once it has the fd, and lightningd keeps its copy until the reply arrives.

Changelog-Fixed: macOS: fundchannel no longer fails or hangs with "Peer connection lost" when opening channels under load.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100

This commit fixes a macOS-specific bug where opening a Lightning channel could fail or hang with 'Peer connection lost'. The root cause was a race condition in how file descriptors (sockets) were passed between internal processes: the sender closed its copy too early, before the receiver had fully received it. The fix makes the sender wait for an acknowledgment before closing its copy. It is a reliability/availability fix, not an exploitable security vulnerability.

Lower-priorityconnectd: fix reply to query_channel_rangeby Lagrang3 · cf566948 · Sep 29, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

connectd: fix reply to query_channel_range

By protocol: succesive reply_channel_range message must have
first_blocknum equal to or greater than the previous first_blocknum.

Changelog-Fixed: protocol: reply to query_channel_range with channels ranges in correct block order

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

(cherry picked from commit bbae1d9a94e671c5eead7899c3eeaf2726a22213)

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedlightningd: reject newlines in persistent setconfig valuesby Sangbida Chaudhuri · 4cc27c32 · Sep 29, 2026 · 1 fileMessage 73 · AdequateModerate 62Details
Commit message · Sangbida Chaudhuri

lightningd: reject newlines in persistent setconfig values

Changelog-Fixed: `setconfig` no longer permits config-line injection through persistent option values.

(cherry picked from commit 54178251aafc0ef793ab9a4dd9c44320bd40812d)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 62/100

This commit fixes a bug in Core Lightning's `setconfig` RPC command. Previously, a user or attacker who could call `setconfig` could store a configuration value containing newline characters. Because persistent settings are written into a config file line-by-line, those newlines could split one setting into multiple lines, effectively injecting extra configuration directives. The patch now rejects any persistent value containing `\n` or `\r`.

Lower-priorityCHANGELOG: add the 26.06.7 and 26.06.8 release entriesby Níckolas Goline · 0c13f1f1 · Sep 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Níckolas Goline

CHANGELOG: add the 26.06.7 and 26.06.8 release entries

Taken verbatim from the release branches; master's CHANGELOG stopped at
26.06.6.

Changelog-None
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
Lower-prioritytests: fix websocket connect races in test_clnrestby daywalker90 · 5959fd15 · Sep 28, 2026 · 1 fileMessage 95 · StrongTriage 0Details
Commit message · daywalker90

tests: fix websocket connect races in test_clnrest

notifications_received_via_websocket() relied on the socketio client's
connect_error callback and its default 1s wait_timeout to detect the
namespace handshake result. In the flakes the server logged
"Authorized rune" and "Socket.IO connected" well inside that window, yet
the client raised

socketio.exceptions.ConnectionError: One or more namespaces failed to
connect:

so the connect_error callback never fired and, for the rejection tests,
the expected error was compared against an empty string, e.g.

ValueError: Expected error code `Missing rune`, got `One or more
namespaces failed to connect: ` instead

Why the client does not process the server's namespace reply is not
established: it could not be reproduced locally, and the engine.io
upgrade path on both sides looks correct. So this works around it rather
than fixing a root cause.

This affected both the rejection tests (test_websocket_no_rune,
test_websocket_wrong_rune, test_websocket_rune_no_listnotifications,
test_websocket_upgrade_header) and the successful-connection tests
(test_websocket_unrestricted_rune, test_websocket_rune_readonly,
test_websocket_rune_listnotifications, test_numeric_msat_notification).

Give the namespace handshake a longer timeout, disable the client's
background reconnection and retry transient connect failures for the
success path. Keep checking the exact text the server sent when the
connect_error callback fires, and fall back to the node log when it does
not. Also make test_websocket_upgrade_header fail if the connection
unexpectedly succeeds, instead of falling through.

Changelog-None

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Lower-priorityci: remove unused .gitlab-ci.ymlby cdecker · bfdff3dc · Sep 28, 2026 · 1 fileMessage 80 · StrongTriage 0Details
Commit message · cdecker

ci: remove unused .gitlab-ci.yml

The file is no longer used by any pipeline and has gone stale.

Changelog-None

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritytests: fix grpc port flake in test_unix_socket_path_lengthby daywalker90 · 3ed9046e · Sep 28, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: fix grpc port flake in test_unix_socket_path_length

The test builds LightningNode directly instead of via
node_factory.get_node(), so it never allocated a reserved grpc port.
LightningNode then fell back to the hardcoded default 9736, which is not
in the port reservation pool, and cln-grpc failed with:

plugin-cln-grpc: Error running grpc interface: Err(serving requests
Caused by:
1: Address already in use (os error 98)

Pass a reserved port for grpc_port too.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylightningd: time out offered HTLCs on a channel that is shutting downby Níckolas Goline · 0d9f37d6 · Sep 28, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Níckolas Goline

lightningd: time out offered HTLCs on a channel that is shutting down

htlcs_notify_new_block skipped the deadline force-close for any channel
that cannot add an HTLC, treating that as "already dying". A channel in
CHANNELD_SHUTTING_DOWN cannot add an HTLC but is still live in channeld
and can still remove one, so an offered HTLC that expired there was never
timed out on-chain. Instead, once the incoming HTLC neared its own
expiry, we failed it upstream, and a peer that fulfilled the outgoing
HTLC off-chain after that took the amount without us collecting it from
upstream ("FUNDS LOSS of ...: peer took funds onchain before we could
time out the HTLC, but we abandoned incoming HTLC").

Use the same test the fulfilled-HTLC loop below already uses: only skip
channels that are actually failing on-chain. Every other state where the
two predicates differ cannot hold an HTLC.

Changelog-Fixed: lightningd: an offered HTLC that reaches its deadline while the channel is shutting down now force-closes the channel, so forwarded funds cannot be lost to a late fulfill.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

(cherry picked from commit a5750b9bf6ac93a623a9d7823e9dfbbeefe7e32f)

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylightningd: delay dataloss error after channel_reestablish replyby daywalker90 · e2558116 · Sep 28, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

lightningd: delay dataloss error after channel_reestablish reply

handle_peer_spoke() replies to channel_reestablish for a closed channel
and then immediately sends that channel's canned error. We must keep
the reestablish reply: LND's force-close on data loss is triggered by
it (syncChanStates/ProcessChanSyncMsg sees our claimed tail is in the
past and returns ErrCommitSyncRemoteDataLoss, which leads to
LinkFailureForceClose), not by our error, which LND treats as
non-permanent. LDK and Eclair do force-close on our error.

Back-to-back, however, a CLN peer loses the error: its channeld warns
and exits on our stale reestablish (peer-in-the-past revocation
number), and the immediately-following error is fed to that dying
channeld and discarded, so the peer never drops to chain. That is
what flaked test_dataloss_protection after 946f700: when the first
ERROR lost the race with the peer's channeld exiting, the reconnect
rescue answered reestablish-then-error and hit the same loss, so
l1.wait_for_channel_onchain() timed out:

> l1.wait_for_channel_onchain(l2.info['id'])
ValueError: Timeout while waiting for <lambda>

Send the error (and any disconnect) shortly after the reestablish
reply, like channeld's own sleep() before peer_failed_err(), so the
peer's channeld has exited and lightningd handles the error via
handle_peer_spoke() instead.

Changelog-Fixed: Protocol: a peer reconnecting to a channel where we
lost state now reliably force-closes it, instead of our error racing
their channeld exiting.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritylightningd: clean up trace spans on cancellationby daywalker90 · 0a2ccccc · Sep 28, 2026 · 5 filesMessage 88 · StrongTriage 0Details
Commit message · daywalker90

lightningd: clean up trace spans on cancellation

When topology is stopped (e.g. during node shutdown or restart),
stop_topology() frees topo->request_ctx to cancel pending bitcoind
requests. However, bitcoind_getrawblockbyheight_() suspended its
getrawblockbyheight_call span via trace_span_suspend() instead of
trace_span_suspend_may_free(), so freeing the call allocation did not
unregister the span destructor. The orphaned span remained in the
spans hash table.

If a new allocation (such as a struct db_stmt in db_exec_prepared_v2)
was later assigned the exact same address as the freed call,
trace_span_start() found the leftover span and aborted:

lightningd: common/trace.c:369: trace_span_start_: Assertion `trace_span_find(numkey) == NULL' failed.
lightningd: FATAL SIGNAL 6
0x55eb09f3a848 trace_span_start_
common/trace.c:369
0x55eb09f0730e db_exec_prepared_v2
db/utils.c:181
0x55eb09f065ac db_data_version_incr
db/exec.c:146
0x55eb09f067fd db_commit_transaction
db/exec.c:207

Fix this by:

1. Using trace_span_suspend_may_free() for bitcoind_getrawblockbyheight_
so the span is cleaned up if the call context is freed.
2. Suspending the async "extend_tip" span after issuing the bitcoind
request, so the plugin/bitcoind span nests under it, and resuming it
in get_new_block().
3. Ending any in-flight extend_tip span from stop_topology(), after
freeing request_ctx so the child spans are ended first.
4. Preserving the active span across destroy_trace_span(), which
otherwise repoints current at the destroyed span's parent.

Also extend test_tracing() to check that the getrawblockbyheight call is
nested under the extend_tip span.

Fixes: #9415
Changelog-None

88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Lower-prioritychanneld: tx_abort a splice whose txid matches an existing inflightby Sangbida Chaudhuri · 006da58e · Sep 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

channeld: tx_abort a splice whose txid matches an existing inflight

Refuse the duplicate in channeld so the channel stays open, rather than
leaving lightningd to fail the channel when it cannot record it.

Changelog-None

Co-authored-by: Cursor <cursoragent@cursor.com>

(cherry picked from commit 9cb8764bb2f915a7e3bf3d2e4274a8de4e2c90ae)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedlightningd: don't abort when a splice RBF reuses a funding txidby Sangbida Chaudhuri · 834073bf · Sep 28, 2026 · 1 fileMessage 73 · AdequateHigh 70Details
Commit message · Sangbida Chaudhuri

lightningd: don't abort when a splice RBF reuses a funding txid

An RBF that rebuilds a byte-identical splice transaction collides with
the channel_funding_inflights primary key, and the DB layer treats that
as fatal. Fail the pending splice command and the channel instead.

Changelog-Fixed: A channel peer can no longer crash lightningd by RBF-ing a splice into a transaction the node has already recorded.
Co-authored-by: Cursor <cursoragent@cursor.com>

(cherry picked from commit d268f127c6394578125fb3b7be9382548677f238)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · High 70/100

This fix prevents a malicious or misbehaving channel peer from crashing a Core Lightning node by repeatedly proposing the same splice transaction. Before the patch, the node would hit a database primary-key conflict and abort entirely. Now it detects the duplicate funding transaction, fails the splice command, and marks the channel with an internal error instead of crashing.

Lower-prioritybitcoin: reject a block whose tx count or loops outrun its bytesby Kyle 🐆 · 1466f9c1 · Sep 27, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Kyle 🐆

bitcoin: reject a block whose tx count or loops outrun its bytes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityplugin-bip353: bound fetchbip353 with HTTP and overall timeoutsby daywalker90 · 31362721 · Sep 25, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

plugin-bip353: bound fetchbip353 with HTTP and overall timeouts

The resolver client built on the proxy path already had a 30s
timeout, but the default path used HTTPHrnResolver::new(), whose
reqwest client has none: a server that accepts the connection and
never replies left the plugin task, and the xpay command waiting on
fetchbip353, pending forever.

Build a single client with a 30s timeout for both paths, and wrap
PaymentInstructions::parse in tokio::time::timeout so the whole
resolution, not just each HTTP request, has a deadline.

Changelog-Fixed: cln-bip353: fetchbip353 (and xpay payments to a human readable name) no longer hang when a remote endpoint stops responding

(cherry picked from commit 885b70ab14b0353b231420717e44aae9a9288c46)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityinternal API: proper use of peer_billboardby Lagrang3 · 2e0374ea · Sep 25, 2026 · 5 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

internal API: proper use of peer_billboard

peer_billboard function expects a format string and a variable number of
arguments (like printf).

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

(cherry picked from commit 424a0b805569ad1cf00fd2b7153a4704bc2660fd)

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanneld: reject tx_init_rbf after peer sent splice_lockedby Andezion · fe9fdfd4 · Sep 24, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Andezion

channeld: reject tx_init_rbf after peer sent splice_locked

Changelog-Fixed: channeld: reject 'tx_init_rbf' if the peer already sent 'splice_locked', as required by bolt2

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityrenepay: wait for in-flight HTLCs before failing route computationby daywalker90 · 773b7df7 · Sep 24, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

renepay: wait for in-flight HTLCs before failing route computation

When minflow finds no route but pending sendpays or uncollected
results remain, sibling failures may still free capacity in the
uncertainty network. Keep waiting instead of aborting the payment.

Changelog-Fixed: renepay could fail with "minflow couldn't find a
feasible flow" while HTLCs were still in flight.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityhsmd: keep a passed client fd until lightningd has received itby dovgopoly · 826cf934 · Sep 24, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · dovgopoly

hsmd: keep a passed client fd until lightningd has received it

On macOS, a socket passed over SCM_RIGHTS whose sender closes its copy before the receiver's recvmsg completes can arrive unable to read: writes go through, reads return EOF although the peer is open. hsmd closed the client end right after sending it, so channeld's first hsm_req could read EOF and exit(0), leaving the channel stuck in CHANNELD_AWAITING_LOCKIN.

lightningd waits for the fd before sending hsmd anything else, so hold our copy until its next request arrives.

Fixes: #5808

Changelog-Fixed: macOS: channeld no longer dies silently with status 0 right after a channel open under load.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Lower-prioritytests: wait for either OUR_HTLC_SUCCESS_TX in test_onchain_middleman_fulfill_after_failby daywalker90 · 89868881 · Sep 24, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: wait for either OUR_HTLC_SUCCESS_TX in test_onchain_middleman_fulfill_after_fail

The two success txs share a wallet UTXO for fee boost, so only one can
be in the mempool at a time. Waiting for the first broadcast's txid
could latch onto the loser and time out; wait for either instead.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritydocs: fix same-file links to use doc: schemeby daywalker90 · 24cee16b · Sep 24, 2026 · 2 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

docs: fix same-file links to use doc: scheme

Bare #fragment links do not resolve on the hosted docs; same-file
section links must use doc:<slug>#<anchor> like other internal links.

Changelog-None

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
Lower-prioritytests: fix simultaneous-connect flake in test_recoverchannel_closed_siblingby daywalker90 · de88443c · Sep 24, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: fix simultaneous-connect flake in test_recoverchannel_closed_sibling

l1 keeps autoreconnecting while l2 is down, so dialing from l2 here races
l1's attempt. Both sides end up with two connections, each keeps a
different one, and both are torn down: connect fails with
"disconnected during connection".

Connect from l1 instead, which rides the attempt already in flight.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification