AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 70 Bitcoin

lightningd: don't abort when a splice RBF reuses a funding txid

Public commit record

What the developer wrote

Authored by Sangbida Chaudhuri

73/100 · Adequate
lightningd: don't abort when a splice RBF reuses a funding txid

An RBF that rebuilds a byte-identical splice transaction collides with
the channel_funding_inflights primary key, and the DB layer treats that
as fatal. Fail the pending splice command and the channel instead.

Changelog-Fixed: A channel peer can no longer crash lightningd by RBF-ing a splice into a transaction the node has already recorded.
Co-authored-by: Cursor <cursoragent@cursor.com>

(cherry picked from commit d268f127c6394578125fb3b7be9382548677f238)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This fix prevents a malicious or misbehaving channel peer from crashing a Core Lightning node by repeatedly proposing the same splice transaction. Before the patch, the node would hit a database primary-key conflict and abort entirely. Now it detects the duplicate funding transaction, fails the splice command, and marks the channel with an internal error instead of crashing.

Recommended action

Apply the patch and backport to supported releases. Monitor channels for unexpected internal errors after splice RBF. Consider adding tests that exercise duplicate-funding-txid splice scenarios.

Security signals we found

01

Denial-of-service vector: remote peer could crash lightningd via protocol-level RBF splice

02

Database primary-key violation treated as fatal abort before fix

03

Changelog explicitly states security-relevant crash fix

04

No input validation on duplicate funding txid prior to DB insert

Risk score

Why this scored 70/100

Our methodology →
Potential impact 22/30
Exploitability 18/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.