EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 3 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritytests: move the LSPS2 mock test helpers into a moduleby Peter Neuroth · 461aa837 · Oct 20, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: move the LSPS2 mock test helpers into a module

The tests of the LSPS2 client against a misbehaving LSP go into their
own file and need the same helpers to set up nodes and talk to the
mock service. Move them out of test_cln_lsps.py, unchanged.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: move the LSPS2 MPP client test to the mock serviceby Peter Neuroth · 5843e1ac · Oct 20, 2026 · 2 filesMessage 95 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: move the LSPS2 MPP client test to the mock service

The MPP+fixed-invoice test ran the in-tree service with an earlier
Python mock taking over its HTLC handling, because the service does not
support MPP. Run it against the mock service instead, which collects
the parts, opens the channel and spreads the opening fee over the parts
itself, and remove the earlier mock.

The fee stays at 1000000 msat, now computed from a proportional rate,
and the test gains the checks of the mock's own MPP test, which it
replaces: how the fee is spread over the parts, the invoice status and
the oracles.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Lower-prioritytests: run the LSPS client tests against the mock service tooby Peter Neuroth · 04249ccc · Oct 20, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: run the LSPS client tests against the mock service too

The LSPS2 service is to leave Core Lightning, so the client tests need
a counterpart that does not depend on it. Run each client test that
uses the in-tree service against both it and the mock service, which
serves the same opening fee menu as the policy plugin. Nothing in the
tests changes for the in-tree service; dropping it later only drops
its parameter.

With the mock, the JIT channel tests also check the oracles. The
non-approved zero-conf test makes its invoice itself, so the checks on
how the client makes invoices do not apply there.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: add the robustness oracle for the LSPS2 client testsby Peter Neuroth · 7125b76a · Oct 20, 2026 · 3 filesMessage 95 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: add the robustness oracle for the LSPS2 client tests

The last oracle for the LSPS2 client tests: the LSPS client plugin is
still running and never crashed, no HTLC is left pending in the
client's channels, and the client sent no more than 20 LSPS requests.
check_oracles first waits for the client's HTLCs to settle, so that a
check does not race a payment still in flight, unless the test waives
robustness.hanging.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Lower-prioritytests: add the params and deadlines oracle for the LSPS2 client testsby Peter Neuroth · 976b94bd · Oct 20, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: add the params and deadlines oracle for the LSPS2 client tests

Expired, contradictory or modified params must never lead to a
payment. Two checks:

- Every lsps2.buy the client sent uses params exactly as the LSP issued
them, before valid_until, with usable payment size limits, a payment
size the fee does not eat up, and a promise of at most 512 bytes of
printable ASCII without '"' or '\'.
- Every LSPS2 invoice follows the buy result the client was sent: the
lsp_cltv_expiry_delta in a route hint without fees, an expiry no
later than valid_until and the payment size as amount.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: add amount and identity oracles for the LSPS2 client testsby Peter Neuroth · 1c469d04 · Oct 20, 2026 · 4 filesMessage 95 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: add amount and identity oracles for the LSPS2 client tests

Every LSPS2 client test should end by checking the same invariants on
what the client did, whatever the mock service misbehaved in. Add
tests/lsps2_oracles.py with the first two:

- Amount: a paid invoice received at least its amount minus the
opening fee it owes (none for payments after the session), and the
client holds no more in channels its peers opened than its paid
invoices received.
- Identity: invoices route only through known channels or through
the LSP on a jit_channel_scid it issued to this client, and the only
channel used before its funding confirms is the session's.

The checks work on an Observation snapshot of plain data, gathered
from the client and the mock's state, so they are unit tested on hand-
written runs. For that the mock now timestamps its events, reports the
params it issued, remembers which payment opened each session and
records the incoming HTLC of each part it forwards, so that only the
parts the client settled count.

The honest JIT tests now run the oracles.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Security candidatetests: mock LSPS2 service charges the opening fee from its paramsby Peter Neuroth · d315f9f9 · Oct 20, 2026 · 2 filesMessage 95 · StrongInformational 15Details
Commit message · Peter Neuroth

tests: mock LSPS2 service charges the opening fee from its params

Until now the mock deducted a fixed `htlc.fee_msat` (default 0) and
did none of the fee checks bLIP-52 asks of an LSP. Compute the fee
instead:

- `lsps2.buy` with a `payment_size_msat` fails with 202 if the fee is
not below the payment size and with 203 if computing it overflows.
- In no-MPP+var-invoice mode the fee comes from the first HTLC, which
is failed with unknown_next_peer if it is outside the payment size
limits, if the fee overflows or if nothing would be left to forward.
- The honest deduction is the computed fee; `htlc.fee_msat` still
overrides it.

Failed HTLCs now record why they were failed.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
memory safety
AI analysis · Informational 15/100

This commit only changes test code. It updates a mock Lightning Service Provider (LSP) used in Core Lightning's test suite so that its simulated 'opening fee' follows the real bLIP-52 formula instead of being a hardcoded test value. No production wallet, node, or protocol code is touched, so it cannot directly affect real users or funds.

Lower-prioritytests: add the LSPS2 opening fee for the mock serviceby Peter Neuroth · b36ef93e · Oct 20, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: add the LSPS2 opening fee for the mock service

The mock LSPS2 service needs the opening fee to check `lsps2.buy`
requests and to deduct it when forwarding. Write it from the bLIP-52
text, with every operation checked against the unsigned 64-bit range as
the spec requires, instead of reusing the client's code: a bug shared by
client and mock would go unnoticed by the tests.

The spec's pseudocode divides by 10000000 and its prose mentions
`+ 9999999`; both contradict the definition of `proportional` in parts
per million and the spec's own C and Rust versions, which this follows.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityaskrene: mcf: introduce cost dialsby Lagrang3 · 3d772aa3 · Oct 20, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: mcf: introduce cost dials

Use cost dials normalized to 1 to combine the cost of different
features. This is a generalization of the mu factor combination with
medians ratio applied to more than 2 features: fees and delays.

Just like that fee constraining got slightly better.
Before mu (the corresponding fee dial) started at 1% and increased
linearly in chunks of 10%. Now every dial is increased by a factor of 2
per iteration and it approximates 1 asymptotically as the dials are
renormalized at each iteration. We have a cut-off at 1 - 1e-6, that
means 27 iterations until mu reaches the cut-off.

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityaskrene: mcf: all feature costs are doubleby Lagrang3 · d49750e6 · Oct 20, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: mcf: all feature costs are double

Treat all cost features as the same type of variable.

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityaskrene: getroutes: add maxhops optionby Lagrang3 · 6b845c44 · Oct 20, 2026 · 16 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: getroutes: add maxhops option

Changelog-Added: askrene: getroutes: maxhops, a parameter to limit the length of the paths in the solutions.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritytests: let the mock LSPS2 service open the JIT channel and forwardby Peter Neuroth · 5ce2a9ba · Oct 19, 2026 · 2 filesMessage 95 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: let the mock LSPS2 service open the JIT channel and forward

The mock now intercepts the HTLCs sent to a jit_channel_scid. It holds
them until the payment is complete (the first part without
payment_size_msat, otherwise parts summing to at least
payment_size_msat), opens a zero-conf channel to the client and
forwards the parts once channel_state_changed reports CHANNELD_NORMAL,
without polling.

The opening fee is deducted as in the bLIP-52 example algorithm, never
leaving a part below htlc_minimum_msat or 1 msat, with an extra_fee TLV
on every part that paid a share and on no other. After the session the
jit_channel_scid is forwarded like any alias of the channel.

The fee to deduct is an explicit config value (htlc.fee_msat) for now.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Security candidatetests: add configurable misbehavior to the mock LSPS2 serviceby Peter Neuroth · b323f375 · Oct 19, 2026 · 2 filesMessage 100 · StrongInformational 15Details
Commit message · Peter Neuroth

tests: add configurable misbehavior to the mock LSPS2 service

Each phase of the mock gets a table of named behaviors, each with its
own parameters, so that every attack in the security matrices is one
config entry:

- transport: drop, wrong_id, duplicate (optionally with a changed
second result), replace (send a raw payload), add_fields and error,
optionally limited to some methods.
- buy: the jit_channel_scid is a fixture too, next to
lsp_cltv_expiry_delta and client_trusts_lsp.
- open: never, or twice.
- htlc: deduct (per-part deduction and extra_fee, or no TLV),
forward_subset (fail the other parts) and deduct_again (charge the fee
again after the session).

lsps2-mock-send sends a message outside of any request and
lsps2-mock-open opens a zero-conf channel outside of any session.
Unknown behaviors and parameters, and missing required ones, are
rejected when the config is set.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
explicit security language
AI analysis · Informational 15/100

This commit only adds new testing capabilities to a mock LSPS2 service used in Core Lightning's test suite. It lets developers simulate misbehaving LSPs (e.g., dropping messages, sending wrong IDs, opening channels twice, deducting fees incorrectly) so they can verify that the real client handles those cases safely. The change does not alter production code, wallets, or node behavior, and it does not fix or introduce any real vulnerability.

Lower-prioritytests: add a mock LSPS2 service pluginby Peter Neuroth · fe3a9cfb · Oct 19, 2026 · 2 filesMessage 78 · AdequateTriage 0Details
Commit message · Peter Neuroth

tests: add a mock LSPS2 service plugin

The LSPS2 client needs a test counterpart that does not depend on the
in-tree service, which is going to leave the repository. The mock runs
on the LSP node and implements the service side of bLIP-50 and bLIP-52
from the spec text. This first step answers lsps0.list_protocols,
lsps2.get_info and lsps2.buy, including the JSON-RPC error cases.

Promises are plain fixture strings: buy accepts opening_fee_params only
if they equal, field by field, an entry the mock sent.

Behavior is configured per phase (transport, list_protocols, get_info,
buy) through the lsps2-mock-config option or the lsps2-mock-configure
RPC; only the honest behavior exists for now. lsps2-mock-state returns
everything the mock received, sent and decided.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityCI: move the memory monitor into a script, and add an ASAN constantby daywalker90 · 217aba5f · Oct 16, 2026 · 4 filesMessage 95 · StrongTriage 8Details
Commit message · daywalker90

CI: move the memory monitor into a script, and add an ASAN constant

The memory logging loop was duplicated in the valgrind and sanitizer
jobs. Move it to .github/scripts/mem-monitor.sh so each job starts it
with one line.

Add ASAN to pyln.testing.utils next to VALGRIND, and use it in
test_connection.py in place of reading the variable directly.

Changelog-None
Signed-off-by: daywalker90 <daywalker990@gmx.de>

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validation
Lower-prioritycontrib: fail missing-grpc on uncovered or stale RPC commandsby daywalker90 · ace0af4d · Oct 16, 2026 · 4 filesMessage 83 · StrongTriage 0Details
Commit message · daywalker90

contrib: fail missing-grpc on uncovered or stale RPC commands

missing-grpc printed commands without gRPC coverage but always exited 0,
so nothing enforced the mapping. Add an explicit grpc_method_blacklist
with a reason per command, and fail when a command is neither mapped nor
blacklisted, or when a blacklist entry is stale. Run it from
check-source.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritychanneld: reject start_batch with batch_size above 20by Andezion · a81866d2 · Oct 15, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Andezion

channeld: reject start_batch with batch_size above 20

Changelog-Fixed: Protocol: channeld now rejects a 'start_batch' with 'batch_size' above 20, as the spec requires, so a peer can no longer stall the channel or use up memory

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityplugins/recover: fix missing comma in nodes_for_gossip arrayby bhuvan-somisetty · 28a17e2c · Oct 15, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · bhuvan-somisetty

plugins/recover: fix missing comma in nodes_for_gossip array

A missing comma at the end of the line for the nicehash-ln1 entry
caused C string literal concatenation to merge the nicehash-ln1 and
BLUEIRON addresses into a single invalid address string:
"037659...195024b9a1...".

This reduced the array count to 9 and broke connection attempts to both
nodes during emergency recovery when entering recovery mode without
active peers.

Define nodes_for_gossip as an array of structs so missing commas cause a
compile-time syntax error rather than accidental string concatenation,
and clean up comment encoding for the Kraken entry.

Changelog-Fixed: plugins/recover: fix missing comma in nodes_for_gossip array.
Fixes: #9630
Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Security candidatetests: fix races in test_channel_lease_unilat_closesby daywalker90 · d3e6bebe · Oct 14, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · daywalker90

tests: fix races in test_channel_lease_unilat_closes

CI flaked with:

> assert l3blocks == 4032 - 6 - 2 - 1
E assert 4025 == (((4032 - 6) - 2) - 1)

l3's commitment used a blockheight 2 blocks behind the chain, because
l2 was stopped before l3 had saved a commitment with the new height.
A second run flaked with:

E pyln.client.lightning.RpcError: RPC call failed: method: fundchannel
... error: {'code': 301, 'message': 'Could not afford 506268sat using
all 0 available UTXOs: 506696sat short'}

l2 broadcast the l1 funding tx, but did not record its change output
until after the l2->l3 fundchannel with minconf=0 had already failed.

Wait for l3 to log the commitsig carrying the new blockheight before
stopping l2, and wait for l2 to see the funding change before the
minconf=0 fundchannel.

Changelog-None

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit fixes timing problems in a single automated test. It adds waits so the test nodes are fully synchronized before the test proceeds. There is no change to production code, no security bug, and no real-world attack possibility.

Security candidatedoc: fix references to manpages that don't existby mikeua · 33fda2d0 · Oct 13, 2026 · 11 filesMessage 68 · AdequateInformational 15Details
Commit message · mikeua

doc: fix references to manpages that don't exist

Several schema descriptions and see_also lists name manpages that are
never generated, so the links in the rendered docs are dead:

- lightningd-fetchinvoice(7) / lightningd-invoicerequest(7) ->
lightning-fetchinvoice(7) / lightning-invoicerequest(7)
- lightning-listsentpays(7) -> lightning-listsendpays(7)
- lightning-currencyrates(7) -> lightning-currencyrate(7)
- lightning-invoicerequests(7) -> lightning-invoicerequest(7)
- lightning-listbalances(7) and lightning-bkpr-listfunds(7) ->
lightning-bkpr-listbalances(7)

contrib/msggen/msggen/schema.json is updated to match.

Changelog-None

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
authentication path
AI analysis · Informational 15/100

This commit only fixes broken documentation links. It corrects the names of referenced manual pages in JSON schema files so that generated documentation points to pages that actually exist. There are no code, configuration, or behavior changes, and no security implications.

Lower-priorityplugins: check erring_node before keysend compares itby daywalker90 · 679f00ce · Oct 13, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

plugins: check erring_node before keysend compares it

keysend compares the failing node with the destination before it reads
the failcode. The plugin only fills erring_node from the route when the
daemon reports an erring_index inside the route, so the field can be
NULL. Check for NULL before the comparison.

This is defensive: the current code paths I checked always set
erring_node for keysend, so no test covers this. It prevents a NULL
dereference if that invariant changes.

Changelog-None
Signed-off-by: daywalker90 <daywalker990@gmx.de>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritydocs: correct the routing failure fields of pay, keysend, sendpay and waitsendpayby daywalker90 · beadbd91 · Oct 13, 2026 · 6 filesMessage 85 · StrongTriage 0Details
Commit message · daywalker90

docs: correct the routing failure fields of pay, keysend, sendpay and waitsendpay

The routing failure objects described fields the code does not send, and
called other fields always present when they are not:

- erring_node: waitsendpay on a payment sent with sendonion does not
record the node. pay and keysend infer it from their route, so it may
be absent in rare cases.
- erring_channel: the daemon omits it when the channel is not known. The
"or 0:0:0" text described a value that is never sent.
- erring_direction: only sent together with erring_channel. Documented
for all four commands and the sendpay_failure notification.
- channel_update: not sent in the routing failure object. The field that
carries the remote message is raw_message, which is now documented. It
is not present for failures that did not come from a node, such as a
local routing failure or the pay "ran out of routes" failure.
- failcodename: documented for pay, keysend and sendpay, where it is
omitted for unknown failcodes.

sendpay always has the route it was given, so its erring_node text is
unchanged. The sendpay_failure notification already marked erring_node
and erring_channel as "if known".

contrib/msggen/msggen/schema.json is regenerated from the schemas by
make gen.

Changelog-None
Signed-off-by: daywalker90 <daywalker990@gmx.de>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritylightningd: report the remote failure for sendonion payments after the factby daywalker90 · 22b7964e · Oct 13, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

lightningd: report the remote failure for sendonion payments after the fact

A sendonion payment has no route nodes, so remote_routing_failure() sets
no erring node, and payment_failed() stores failonion as NULL. The
failure is still stored with its failcode and raw failmsg. wait_payment()
only looked at failonionreply and failnode, so a waitsendpay() that ran
after the failure was recorded reported:

RpcError: ... error: {'code': 209, 'message': 'Payment failure reason unknown'}

A waitsendpay() that ran before the failure got the failure from the live
waiter and was correct, so the error only showed up when the call lost the
race. wait_payment() now uses the stored failmsg as the remote failure
when there is no erring node, the same way the live path does. The
"reason unknown" error is kept for databases with no failure information.

Changelog-Fixed: waitsendpay reports the remote failure for sendonion payments that failed before the call, instead of "Payment failure reason unknown"
Signed-off-by: daywalker90 <daywalker990@gmx.de>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritytests: waitsendpay after a sendonion failure is recordedby daywalker90 · 0d8b1dfc · Oct 13, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: waitsendpay after a sendonion failure is recorded

A sendonion payment whose remote failure is recorded before waitsendpay
is called reports "Payment failure reason unknown" (code 209) instead of
the failure. The CI ASan/UBSan shard failed test_reject_invalid_payload
this way:

RpcError: RPC call failed: method: waitsendpay, ... error: {'code': 209,
'message': 'Payment failure reason unknown'}

test_reject_invalid_payload now takes a wait_for_failure parameter. When
it is set, the test waits for the sender to log "htlc failed from 0th
node" before calling waitsendpay, so the call reads the failure from the
database rather than from a live waiter. The unset case is the original
test and passes either way. The set case is marked xfail(strict=True)
until the fix lands in the next commit.

Changelog-None
Signed-off-by: daywalker90 <daywalker990@gmx.de>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylightningd: replay accepted HTLCs after shutdownby Sangbida Chaudhuri · db63c1ca · Oct 13, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

lightningd: replay accepted HTLCs after shutdown

An HTLC being replayed was committed before the channel entered
shutdown. Do not treat it as a new HTLC added after shutdown; replay
the htlc_accepted hook so the plugin can return its verdict.

Changelog-Fixed: lightningd: replay htlc_accepted for HTLCs committed before shutdown or on-chain instead of failing them on restart without calling the hook.
Co-authored-by: Cursor <cursoragent@cursor.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context