EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 55 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedlightningd: remove deprecations due in v26.12by daywalker90 · d2a278b4 · Oct 23, 2026 · 20 filesMessage 78 · AdequateLow 29Details
Commit message · daywalker90

lightningd: remove deprecations due in v26.12

These were deprecated in v25.05 or v25.09 and last supported in v26.06
or v26.09:

- `coin_movement` notification: `tags`, `txid`, `utxo_txid` and `vout`.
- `channel_state_changed` notification: `short_channel_id` was `null`
when unconfirmed. It is now omitted.
- Plugin notifications: the legacy `payload` object and flat unwrapped fields.
- `pay_notifications.raw_fields`: `channel_hint_update`, `pay_failure`
and `pay_success` already wrap their members in an object of the same
name.
- `wait.details`: the subsystem-specific object is used instead.

The shared coin movement serializer no longer takes the legacy flags.
The Python plugin client no longer recreates `payload` for old plugins.
The Rust plugin client sends custom notifications in the modern shape
only, without the deprecated flat copy of the fields.

The test harness still skips `channel_state_changed` when `message` is
`null`: it is deprecated since v25.12 and still supported until v26.12,
unlike the removed `short_channel_id` null.

Changelog-Removed: Plugins: `coin_movement` notification `tags`, `txid`, `utxo_txid` and `vout` fields (use `primary_tag`, `extra_tags`, `spending_txid` and `utxo`).
Changelog-Removed: Plugins: `channel_state_changed` notification omits `short_channel_id` when the channel is unconfirmed, instead of `null`.
Changelog-Removed: Plugins: notifications no longer include the legacy `payload` object or flat unwrapped fields; use the object named after the method instead.
Changelog-Removed: JSON-RPC: `wait` no longer returns the `details` object for `invoices`, `forwards` and `sendpays`; use the subsystem-specific object instead.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: unusually broad change
AI analysis · Low 29/100

This commit removes old, previously-announced deprecated API fields and shapes from Core Lightning. It is a planned cleanup, not a security fix. Plugins or clients that still relied on the old fields will break or need to be updated, but there is no new vulnerability introduced.

AI review queueddocs: relabel v26.09 feature markers as v26.12by daywalker90 · b55aca37 · Oct 23, 2026 · 11 filesMessage 80 · StrongInformational 15Details
Commit message · daywalker90

docs: relabel v26.09 feature markers as v26.12

Features added in the v26.09 cycle are now marked for v26.12, the next
release. The 26.09 release was skipped, so the version-based `added`
markers move to v26.12. Deprecation end markers keep their time-based
values.

Changelog-None

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a documentation and metadata relabeling change. It updates version markers from 'v26.09' to 'v26.12' because the v26.09 release was skipped. No code logic, security behavior, or runtime functionality was changed.

Lower-priorityrelease: bump to v26.06.9 and next version to v26.12by daywalker90 · 3db689df · Oct 23, 2026 · 10 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

release: bump to v26.06.9 and next version to v26.12

Point release version bump for v26.06.9, and the next release is now
v26.12. v26.09 is skipped, so deprecations due at v26.12 are removed
in the previous commits.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanneld: return temporary_channel_failure when max_htlc_value_in_flight is exceededby Andezion · b07511c6 · Oct 23, 2026 · 4 filesMessage 73 · AdequateTriage 0Details
Commit message · Andezion

channeld: return temporary_channel_failure when max_htlc_value_in_flight is exceeded

Changelog-Fixed: Protocol: forwarding an HTLC that would exceed the outgoing channel's 'max_htlc_value_in_flight_msat' now fails with 'temporary_channel_failure' instead of 'required_node_feature_missing'

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Security candidatedoc: refresh the release verification examples from v26.06.9by Níckolas Goline · 1112b47b · Oct 22, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Níckolas Goline

doc: refresh the release verification examples from v26.06.9

The gpg example showed 2020 signatures from keys that no longer sign
releases, and the sha256sum example listed v24.11 files. Replace both
with the output for v26.06.9, covering all three release manifests
(amd64 and source, arm64, armv7) and every file they list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarydefensive validationdocumentation-only discount
AI analysis · Informational 15/100

This commit only updates the user documentation that shows how to verify Core Lightning release files. It replaces outdated example filenames, GPG signatures, and SHA256 checksums with current ones for version v26.06.9. No program code was changed, and there is no security vulnerability in the commit itself.

Lower-priorityxpay: better error message when create_onion failsby Lagrang3 · f03fe4a9 · Oct 22, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Lagrang3

xpay: better error message when create_onion fails

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Security candidatecontrib: refresh nGoline's signing keyby Níckolas Goline · 7a2375e9 · Oct 22, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Níckolas Goline

contrib: refresh nGoline's signing key

The signing subkey in the repo copy expired on 2026-06-30, so the
v26.06.9 signature could not be verified from it. Re-export the key
with the subkey extended to 2027-06-30.

Changelog-None
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydocumentation-only discount
AI analysis · Informational 15/100

This commit simply refreshes an expired PGP signing key stored in the repository so that future release signatures can be verified. It is a routine key update with no code or security vulnerability fix.

Lower-priorityaskrene: add constant probability cost per hopby Lagrang3 · b55631c8 · Oct 22, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: add constant probability cost per hop

Added an homogeneous and constant cost to every hop in the MCF solver.

test_real_data shows a slight decrease of paths lengths by looking at
the path length histograms

SLOW_MACHINE=0
histogram before {2: 1, 3: 8, 4: 34, 5: 77, 6: 45, 7: 23, 8: 4}
histogram after {2: 2, 3: 59, 4: 110, 5: 5, 6: 5}

SLOW_MACHINE=1
histograms before {2: 1, 3: 3, 4: 11, 5: 15, 6: 6, 7: 6, 8: 3}
histogram after {2: 2, 3: 16, 4: 18, 5: 1, 6: 5}

the most frequent path length moves from 5 to 4 and there aren't more
than 6 hops in any given path.

Another consequence of the additional per hop cost is a slight reduction
in the number paths (or payment parts) per route query. Even though our linear
approximation gives equal cost to 3 paths of length 1 than to 1 path of
length 3.

in test_real_data this is shown by the expected_first_success (the
number of success computations in the first loop) and
expected_total_paths (the total number of parts for those successes,
also the sum of values in the histogram).

For SLOW_MACHINE=0 we get a mean parts per payment of
expected_total_paths / expected_first_success = 192 / 95 = 2.02
that becomes
expected_total_paths / expected_first_success = 181 / 95 = 1.90

For SLOW_MACHINE=1 we get a mean parts per payment of
expected_total_paths / expected_first_success = 45 / 24 = 1.87
that becomes
expected_total_paths / expected_first_success = 42 / 24 = 1.75

Changelog-Changed: askrene-getroutes: penalizes every extra hop in every route with an homogeneous and constant probability of failure of 1%, as a consequence askrene will slightly prefer smaller routes and fewer payment parts.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityaskrene: getroutes: measure path lengths in test_real_databy Lagrang3 · 699fc5c0 · Oct 22, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: getroutes: measure path lengths in test_real_data

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityaskrene: getroutes: avoid dial racesby Lagrang3 · 6d5282ea · Oct 22, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: getroutes: avoid dial races

Fail early if we see detect a suggestion that a pair of cost dials are
racing each other. We are not likely to find a solution and we would
just waste cycles. This usually means that our method is not able to
find a solution that satisfies all given constraints.

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritytests: wait for the channel_ready retransmission on the node that disconnectedby Ken Sedgwick · ea94edd8 · Oct 21, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Ken Sedgwick

tests: wait for the channel_ready retransmission on the node that disconnected

test_reconnect_no_update waited for l1 to log "Retransmitting
channel_ready" after l2's scripted disconnect on sending channel_ready.
channeld, and dualopend in the dual-funding variant, retransmit only
when the node had sent channel_ready before the disconnect, which
lightningd derives from the channel's scid being known. When l2
reaches the funding depth and disconnects before l1 has seen the
block, l1 sends its channel_ready for the first time after the
reconnect, nothing is retransmitted on l1, and the wait times out.

Wait on l2 instead: it has sent channel_ready by the time it
reconnects, whichever node saw the block first. With dual funding
the retransmission comes from l2's dualopend, or from channeld when
l1's channel_ready arrived before l2 reached the depth and dualopend
had already handed the channel over, so the wait does not name the
daemon.

The second wait on l2, after the close, was only ever satisfied by
that same first retransmission: the fee update after lock-in advances
the commitment numbers, after which channel_ready is not retransmitted.
Wait for the reconnect in the closing state instead, which is what
that part of the test covers. l2 is in CHANNELD_SHUTTING_DOWN or
already in CLOSINGD_SIGEXCHANGE then, depending on whether its
channeld reported both shutdowns before the disconnect took it down,
so accept either.

Fixes: #9644
Changelog-None

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritytests: reserve the port in test_announce_and_connect_via_dnsby Ken Sedgwick · 3319180d · Oct 21, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Ken Sedgwick

tests: reserve the port in test_announce_and_connect_via_dns

The test bound its first node to port 12345. Other tests' nodes draw
their ports from reserve_unused_port(), whose pool is the range below
the ephemeral floor, 1024 to 32767 on Linux, and whose lock files only
cover the ports it handed out itself. A node of a test on another
worker can be given 12345, and this test then fails at startup with
"Failed to bind socket for 127.0.0.1:12345: Address already in use".

Reserve the port from the same pool instead, and release it at the end.

Fixes: #9642
Changelog-None

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritytests: wait for the htlc_sigs promotion in test_splice_rbf_htlc_sigsby Ken Sedgwick · a429104b · Oct 21, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Ken Sedgwick

tests: wait for the htlc_sigs promotion in test_splice_rbf_htlc_sigs

The final check read htlc_sigs as soon as the state change was logged.
lightningd logs that change from handle_peer_splice_locked(), inside
the database transaction that wraps the whole channeld message, and
the htlc_sigs promotion commits with it when the handler returns. A
read in that window sees the three rows from before the lock-in and
the test fails with "assert 3 == 1".

Wait for the single row instead, as the three-row check already does.

Fixes: #9640
Changelog-None

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Security candidateconnectd: never block the io loop on DNS resolutionby cdecker · 71572cae · Oct 21, 2026 · 7 filesMessage 73 · AdequateHigh 71Details
Commit message · cdecker

connectd: never block the io loop on DNS resolution

Resolving a DNS address announced in a node_announcement used to call
getaddrinfo() directly, on connectd's single io thread. A slow or
unresponsive nameserver held up every peer on the machine for the
duration of the lookup: ~10s per query with glibc defaults, enough to
trip the 60s ping-liveness check and disconnect all peers.

getaddrinfo() now runs in a forked child which writes the results
back over a pipe; connectd reads the pipe from its io loop and
resumes the connect attempt from a loop callback, so the io thread
never waits on resolution. Keeping libc for the actual lookup
preserves /etc/hosts, search domains, systemd-resolved and
AI_ADDRCONFIG ordering exactly, and keeps DNS packet parsing out of
connectd itself.

A 30-second cap covers each lookup end to end (a wedged child is
killed), and at most ten resolvers run at once: a gossip-driven
reconnect storm queues the excess FIFO rather than forking without
bound. Before resolving, the child closes every fd it inherited: a
wedged child must not keep peer connections alive, nor pin EOF on
another lookup's pipe with its copy of that write end.

The connect RPC resolved a host name the same way, with a blocking
getaddrinfo() in lightningd's main loop, and ignored --disable-dns.
It now hands the unresolved name to connectd as a DNS address, which
goes through the same asynchronous resolver and honours
--disable-dns (unless a proxy resolves names for us).

Reported-by: Vincenzo Palazzo
Changelog-Fixed: connectd: a stalling DNS name in a peer's announced address no longer freezes all peer traffic; resolution is now done asynchronously.
Changelog-Changed: `connect` with a host name now resolves it asynchronously in connectd, and fails with `--disable-dns`.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
access control
AI analysis · High 71/100

This commit fixes a denial-of-service weakness in Core Lightning's connection daemon. Previously, when the node needed to look up a peer's internet address from a domain name, it did that lookup directly in its main networking thread. A slow or malicious DNS server could freeze all peer traffic for about 10 seconds per lookup, potentially disconnecting every peer. The fix moves DNS lookups into separate child processes and reads the results back without blocking the main loop. It also makes the `connect` RPC command use the same non-blocking path and respect the `--disable-dns` setting.

Lower-prioritytests: mock LSPS2 service fails held parts at valid_untilby Peter Neuroth · 6559ea99 · Oct 21, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: mock LSPS2 service fails held parts at valid_until

Held parts were failed only when another part arrived after valid_until.
bLIP-52 asks for a separate timeout at valid_until for all pending
parts, so arm a timer when a session starts holding parts. Moving the
mock's clock past valid_until fails them as well, so tests do not wait
in real time.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: fail JIT payments with the error bLIP-52 asks for in the mockby Peter Neuroth · 1ebc4943 · Oct 21, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: fail JIT payments with the error bLIP-52 asks for in the mock

Every failure was unknown_next_peer. If the client disconnects before
funding_signed, bLIP-52 asks for temporary_channel_failure instead, so
that the payer may retry once the client is back; a client that rejects
the open with an `error` stays connected and still gets
unknown_next_peer. An internal error in the mock fails the parts with
temporary_node_failure.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: fail held HTLCs on unexpected errors in the mock LSPS2 serviceby Peter Neuroth · 0f931e6d · Oct 21, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: fail held HTLCs on unexpected errors in the mock LSPS2 service

An exception in the custommsg hook makes lightningd fail fatally, and
one while opening or forwarding leaves the held HTLCs unanswered until
the payment times out. Catch them where they enter the mock: answer a
request with an internal error, fail the HTLCs still held, and record
an `error` event. The error is also logged as BROKEN, so the test still
fails, at teardown.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: test a failed channel open in the mock LSPS2 serviceby Peter Neuroth · 9b3d2942 · Oct 21, 2026 · 1 fileMessage 75 · AdequateTriage 0Details
Commit message · Peter Neuroth

tests: test a failed channel open in the mock LSPS2 service

If fundchannel fails, the mock fails the held parts.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Lower-prioritytests: reject non-list values in the mock LSPS2 service's configby Peter Neuroth · 4cadca95 · Oct 21, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: reject non-list values in the mock LSPS2 service's config

A string for `methods` would match substrings of the method name, and
other non-list values would fail only when the mock uses them, while
holding HTLCs.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityxpay: use onion budget to detect early failuresby Lagrang3 · 3349204a · Oct 21, 2026 · 3 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

xpay: use onion budget to detect early failures

Changelog-Changed: xpay: computes a budget for the number of hops in the payment depending on the final payload and blinded paths, it can fail early if the onion packet doesn't fit

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityoffers: add dev-invoice-blinded-paddingby Lagrang3 · 84477b5e · Oct 21, 2026 · 5 filesMessage 90 · StrongTriage 0Details
Commit message · Lagrang3

offers: add dev-invoice-blinded-padding

Added dev-invoice-blinded-padding option to offers plugin so that we can
tweak the size of the final onion. This will be useful for testing the
onion budget in xpay.

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Lower-priorityxpay: call askrene with maxhopsby Lagrang3 · 4ca450ab · Oct 21, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

xpay: call askrene with maxhops

Changelog-Fixed: xpay: Clamp the length of the payment routes using askrene's maxhops option aiming at producing routes that fit the data limits in the onion packet.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedci: replace broken katyo/publish-crates with a native cargo publish stepby daywalker90 · 2646184f · Oct 20, 2026 · 1 fileMessage 85 · StrongInformational 20Details
Commit message · daywalker90

ci: replace broken katyo/publish-crates with a native cargo publish step

The katyo/publish-crates action no longer publishes anything: the
Release Rust workflow ran on the push that bumped lsps-types to 0.7.0
and did not publish it.

The new step publishes each crate only when its Cargo.toml version is
newer than the highest version on crates.io, in dependency order
(cln-rpc, cln-grpc, cln-plugin, lsps-types).

Cap the job at 30 minutes and give the crates.io index request a 30
second timeout so a hung network call cannot stall the release.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discountsecond-pass: broader security terminology
AI analysis · Informational 20/100

This commit updates the project's automated release workflow for publishing Rust crates to crates.io. It replaces a third-party GitHub Action that had stopped working with a custom shell script that checks whether each crate's local version is newer than what is already published before running the official cargo publish command. The change also adds a 30-minute job timeout and a 30-second network timeout for checking crates.io. There is no direct security vulnerability in the diff, but any change to a release pipeline that handles a secret publishing token deserves a routine security review.

Lower-prioritytests: mock LSPS2 service fails JIT payments after valid_untilby Peter Neuroth · 6f09ed30 · Oct 20, 2026 · 2 filesMessage 83 · StrongTriage 0Details
Commit message · Peter Neuroth

tests: mock LSPS2 service fails JIT payments after valid_until

bLIP-52 lets the LSP open the JIT channel only while the current time
is before the params' valid_until. The mock checked valid_until at
lsps2.buy only, so it still opened channels for expired params. Fail
parts that arrive once the params expired with unknown_next_peer.

htlc.clock_offset_seconds moves the clock of that check, so a test can
expire a session without waiting.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: check extra_fee in the LSPS2 amount oracleby Peter Neuroth · 0de02013 · Oct 20, 2026 · 2 filesMessage 78 · AdequateTriage 0Details
Commit message · Peter Neuroth

tests: check extra_fee in the LSPS2 amount oracle

A client that accepts a part whose extra_fee does not match what was
deducted from it breaks bLIP-52 even when the total deducted happens
to be the right fee, and the amount oracle did not see that. Check
that each part of a paid invoice arrived short by exactly its
extra_fee and that the extra_fees add up to at most what the payment
owes.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification