EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 34 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritylightningd: treat disconnected peer as offline in routehintsby daywalker90 · 5237a0d4 · Sep 24, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

lightningd: treat disconnected peer as offline in routehints

Peer disconnect is recorded before channeld exits, so routehint_candidates
could still count a channel as available while the peer was gone, skipping
warning_offline. Check peer connection state as well as channel->owner.

Changelog-Fixed: invoice could omit warning_offline if created right after a peer disconnect

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritytests: deterministically cover dataloss error resend on reconnectby daywalker90 · 9bf73975 · Sep 24, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: deterministically cover dataloss error resend on reconnect

test_dataloss_protection only exercises the reconnect rescue when the
first ERROR loses the race with l1's channeld exiting, so the resend
path itself is almost never tested. Drop l2's first WIRE_ERROR with
dev-disconnect (as test_dataloss_protection_no_broadcast does), then
reconnect: l2 must resend channel->error for l1 to drop to chain.

xfail(strict) for now: l2 currently replies with a stale
channel_reestablish before the canned error, l1's channeld exits on
the stale reply (peer-in-the-past warning) without reading the error,
and l1 never goes onchain.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritypyln-testing: ignore truncated plugin-io files in checkPluginJSONby daywalker90 · dd09c72f · Sep 24, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

pyln-testing: ignore truncated plugin-io files in checkPluginJSON

checkPluginJSON ran json.loads() unguarded over every file in
plugin-io. dev_save_plugin_io creates the file with open() and only
then write_all()s the payload, so a kill landing in between (the
mid-HTLC l1.daemon.kill() in test_payment_success_persistence, or the
SIGTERM at teardown - lightningd only installs a handler when PID 1)
leaves an empty or partial file behind. The resulting JSONDecodeError
escaped map_node_error and failed teardown even though the test body
passed: the test_payment_success_persistence CI flake.

Skip files that do not parse; real schema violations still return 1
from the validation path below.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: fix race in test_payment_duplicate_uncommittedby daywalker90 · 5acb017d · Sep 24, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: fix race in test_payment_duplicate_uncommitted

xpay only checks for a payment in progress when it finally calls
injectpaymentonion, after the async getroutes and askrene-reserve
round trips. The test reenabled the commit right after submitting the
second xpay, so the first payment could complete before the second
one's check ran. Then check_progress() found the completed payment
instead of the pending one, and the test failed with:

expected: Payment with groupid=N still in progress, cannot retry before
that completes.
actual: RPC call failed: method: xpay, ... error: {'code': 219,
'message': 'Already paid this invoice successfully'}

Both errors correctly deny the second payment, so this is a race in the
test, not a code bug. Wait for the second xpay to be rejected before
reenabling the commit: the first payment then cannot complete first,
and check_progress() deterministically sees it as pending.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityconnectd: free individual listeners on shutdownby daywalker90 · 862c46bb · Sep 23, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · daywalker90

connectd: free individual listeners on shutdown

In start_shutdown(), freeing daemon->listeners only freed the tal
array of pointers, but not the struct io_listener objects themselves
since they are parented to daemon. This left the listening sockets open
and caused them to be flagged as memory leaks during leak detection:

**BROKEN** connectd: MEMLEAK: 0x55b7288579f8
**BROKEN** connectd: label=ccan/ccan/io/io.c:25:struct io_listener
**BROKEN** connectd: alloc:
**BROKEN** connectd: ccan/ccan/io/io.c:25 (io_new_listener_)
**BROKEN** connectd: connectd/connectd.c:1818 (connect_activate)
**BROKEN** connectd: connectd/connectd.c:2357 (recv_req)
**BROKEN** connectd: parents:
**BROKEN** connectd: connectd/connectd.c:2519:struct daemon

Explicitly tal_free each listener in daemon->listeners before freeing the
array.

Changelog-None

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritypyln: test that an unstarted bitcoind tears down cleanlyby Kyle 🐆 · ec9175b4 · Sep 22, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Kyle 🐆

pyln: test that an unstarted bitcoind tears down cleanly

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Lower-prioritypyln: don't reap a bitcoind that was never startedby Kyle 🐆 · 1331ff86 · Sep 22, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Kyle 🐆

pyln: don't reap a bitcoind that was never started

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritybitcoin: hash a block's bytes only once pull has checked themby Kyle 🐆 · f323458a · Sep 22, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Kyle 🐆

bitcoin: hash a block's bytes only once pull has checked them

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritychanneld: fix splice accepter never recording negotiated feerateby Andezion · 4c1c86d2 · Sep 22, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Andezion

channeld: fix splice accepter never recording negotiated feerate

Changelog-Fixed: channeld: when accepting a splice, we now enforce the negotiated feerate on the splice transaction, so a peer can no longer get us to sign a splice paying (almost) no fees

(cherry picked from commit f4d9b36c00bf67ccb4c4c0e929c3f63390001120)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritydocs: hook payload types follow the emitted valuesby daywalker90 · 1cde7532 · Sep 22, 2026 · 8 filesMessage 100 · StrongTriage 8Details
Commit message · daywalker90

docs: hook payload types follow the emitted values

Hook schemas declared several fields with the wrong type or missed
fields that plugins can see:

htlc_accepted cltv_expiry_relative
lightningd/peer_htlcs.c:1327 emits it with json_add_s32: the
difference to the current blockheight can be negative. Type it
as a signed integer.

openchannel to_self_delay and max_accepted_htlcs
lightningd/opening_control.c:702 emits it from a u16 field.
Type both as u16.

openchannel2 response lease rates
plugins/funder.c:504 appends the lease rates when the funder
contributes funds and the peer requested a lease. Accept the
lease fields in the response.

rbf_channel response lease fields
funder.c sends the same lease fields in its rbf_channel response,
but the schema rejected them because additionalProperties is
false. Add the same fields openchannel2 already documents.

rpc_command return.result
lightningd/jsonrpc.c:971 copies the plugin's return.result
token without imposing a type, so it can be an object or an
array. Document both.

The hook schemas are also validated by pyln-testing (see below), so
these type fixes are checked by the tests.

Changelog-Changed: cln-rpc: hook types follow the corrected schemas: htlc_accepted cltv_expiry_relative is signed, openchannel to_self_delay and max_accepted_htlcs are u16, openchannel2 and rbf_channel responses accept channel lease fields, and rpc_command return.result is an object or an array.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
defensive validation
Lower-prioritydocs: fix listcurrencyrates rpc nameby daywalker90 · 8dba4654 · Sep 22, 2026 · 2 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

docs: fix listcurrencyrates rpc name

The plugin registers the method as `listcurrencyrates`:

plugins/currencyrate-plugin/src/main.rs:77
RpcMethodBuilder::new("listcurrencyrates", listcurrencyrates)

but the schema declared `"rpc": "currencyrates"`, so the
generated synopsis was `**currencyrates** *currency*`.

Changelog-None

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritydocs: fix listconfigs example and SCB canonicalization targetby daywalker90 · e759b3cd · Sep 22, 2026 · 2 filesMessage 93 · StrongTriage 0Details
Commit message · daywalker90

docs: fix listconfigs example and SCB canonicalization target

The listconfigs canonicalisation was a copy-paste of the
recoverchannel one and injected a bogus `scb` request parameter
into listconfigs#1; point it at recoverchannel.

Regenerate the stored examples so check-doc-examples passes.

Changelog-None

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Lower-prioritydocs: remove fields and log types that are never emittedby daywalker90 · 24f66107 · Sep 22, 2026 · 12 filesMessage 85 · StrongTriage 0Details
Commit message · daywalker90

docs: remove fields and log types that are never emitted

Several fields and enum values in the schemas are never produced:

getlog and listpeers SKIPPED log type, num_skipped
log_to_json() (lightningd/log.c:1185) only emits BROKEN,
UNUSUAL, INFO, DEBUG, TRACE, IO_IN and IO_OUT. num_skipped does
not exist in the tree. Mark SKIPPED deprecated and reserve the
num_skipped field number.
listpeers BROKEN log level
log_to_json() does emit BROKEN, so add it.
splicein and spliceout tx
plugins/spender/splice.c:123 emits tx only on the dev-only
wetrun path, which spliceout disables. Reserve the field.
listpeerchannels next_fee_step
json_add_channel() never emits it
(lightningd/peer_control.c:1128). Reserve it.

Changelog-Changed: cln-rpc and cln-grpc: getlog and listpeers no longer return the SKIPPED log type or num_skipped, listpeers adds the BROKEN log level, splicein and spliceout no longer return tx, and listpeerchannels next_fee_step is removed.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritymsggen: preserve enum wire values when variants are removedby daywalker90 · e9ed82a5 · Sep 22, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

msggen: preserve enum wire values when variants are removed

When a variant is removed from a JSON schema enum, msggen must
not reassign its proto3 integer value to another variant — that
is a breaking wire change for gRPC clients.

Teach enumerate_enum() to scan grpc-enum-map for entries that
were previously assigned a number but are no longer present in
the schema. Emit those entries with [deprecated = true] in the
generated proto3 definition, which satisfies three constraints:

1. Existing wire values are never reused.
2. proto3's requirement that the first enum value is 0 is met
even when the variant that held 0 is removed.
3. New code never produces the removed variant; old clients
that send it hit the TryFrom<i32> error arm in the Rust
model.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritydocs: fix getemergencyrecoverdata example shapeby daywalker90 · 1c5bc495 · Sep 22, 2026 · 3 filesMessage 90 · StrongTriage 0Details
Commit message · daywalker90

docs: fix getemergencyrecoverdata example shape

getemergencyrecoverdata returns an object with filedata,
can_create_penalty and backed_up_channel_ids
(plugins/chanbackup.c:1034-1043), but the generator locked a bare
string:

tests/autogenerate-rpc-examples.py:1509
response='emergencyrecoverdata' + ('01' * 827)

Replace it with a correctly-shaped canned response and
regenerate the stored examples so check-doc-examples passes.

Changelog-None

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Security candidatedocs: lease fields are u16by daywalker90 · ca3ec513 · Sep 22, 2026 · 10 filesMessage 80 · StrongInformational 19Details
Commit message · daywalker90

docs: lease fields are u16

The lease rate fields are u16 on the wire (wire/peer_wire.csv:215-217)
and in the structs they are serialized from (common/json_stream.c:
671). The funder plugin range-checks its request values into u16
(plugins/funder.c:1354-1355).

Type these as u16 in funderupdate (lease_fee_basis, funding_weight,
channel_fee_max_proportional_thousandths), in listnodes
option_will_fund, and in listpeerchannels, where to_self_delay and
max_accepted_htlcs are u16 as well (lightningd/peer_control.c emits
them from u16 members).

Changelog-Changed: cln-rpc: funderupdate and listnodes lease fields, and listpeerchannels max_accepted_htlcs, our_to_self_delay and their_to_self_delay are u16.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
boot or update path
AI analysis · Informational 19/100

This commit is a cleanup of data-type documentation and API definitions. It changes several numeric fields from being labeled as 32-bit unsigned integers to 16-bit unsigned integers, matching what the underlying code already used on the wire and in memory. It also removes an unused field called 'next_step' from the public API. There is no direct security vulnerability here, but it reduces the chance that future developers or API consumers will be confused about valid value ranges.

Lower-prioritydocs: fix dev-splice titleby daywalker90 · 2bcb923c · Sep 22, 2026 · 2 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

docs: fix dev-splice title

The title was copy-pasted from fundchannel; dev-splice moves funds
into or out of a channel (plugins/spender/splice.c).

Changelog-None

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritydocs: fix remaining field typesby daywalker90 · d5e8f649 · Sep 22, 2026 · 7 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

docs: fix remaining field types

cancelrecurringinvoice recurrence_start and recurrence_counter
are u32, not f64 and u64. The command was added in v25.12, not
v25.09, so the .msggen.json annotation is updated too.
listclosedchannels last_commitment_txid
lightningd/closed_channel.c:76 serializes it with json_add_txid(), so it is
a txid string, not a generic hash.
listnetworkevents id
wallet/walletrpc.c:1401 parses it with param_node_id, and the
response peer_id is already typed as a pubkey. Type id as one too.

Changelog-Changed: cln-rpc: cancelrecurringinvoice recurrence_start and recurrence_counter are u32, listclosedchannels last_commitment_txid is a txid string, and listnetworkevents id is a pubkey.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritydocs: payment timestamps are u32by daywalker90 · 4827fd78 · Sep 22, 2026 · 13 filesMessage 92 · StrongTriage 0Details
Commit message · daywalker90

docs: payment timestamps are u32

Every payment RPC and notification that reports created_at or
completed_at emits them with json_add_u32(), because struct
wallet_payment keeps both as u32:

lightningd/pay.c:158,160
json_add_u32(response, "created_at", t->timestamp);
json_add_u32(response, "completed_at", *t->completed_at);
wallet/wallet.h:363-364
u32 timestamp; u32 *completed_at;

The schemas declared these as u64 or number. Type them as u32 for
sendpay, sendonion, waitsendpay, listpays, listsendpays, delpay,
injectpaymentonion, sendpay_success and sendpay_failure. The xpay
listpays helper (plugins/xpay/listpays.c:168) uses the same u32
timestamp.

Changelog-Changed: cln-rpc: payment timestamps are u32 in sendpay, sendonion, waitsendpay, listpays, listsendpays, delpay, injectpaymentonion, sendpay_success and sendpay_failure.

92/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-prioritydocs: document fields that are emittedby daywalker90 · a1e768b2 · Sep 22, 2026 · 10 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

docs: document fields that are emitted

Two responses emit fields the schemas did not list:

forward_event
lightningd/notification.c:392 shares json_add_forwarding_fields()
(lightningd/forwards.c:89) with
listforwards, which emits created_index, updated_index,
in_htlc_id and preimage. Add them to the notification schema.
listfunds
wallet/walletrpc.c:408,411 emits csv_lock and spendable_at for
outputs from our own unilateral close. Add both.

Changelog-Changed: cln-rpc and cln-grpc: forward_event adds created_index, in_htlc_id, preimage and updated_index, and listfunds adds csv_lock and spendable_at.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI review queueddocs: drop dead example_hooks key from openchannel2_signby daywalker90 · e4ce6835 · Sep 22, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · daywalker90

docs: drop dead example_hooks key from openchannel2_sign

`example_hooks` is not part of the rpc meta-schema and is not
consumed by tools/fromschema.py (its FOOTER_KEY_SEQUENCE only
knows `examples` and `example_notifications`), so it was never
rendered. The same file already carries an `examples` block.

Changelog-None

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes an unused documentation key called example_hooks from two JSON schema files. The key was never read by any tool and had no effect on the software's behavior. It is purely a cleanup of dead documentation content.

Lower-prioritydocs: accept hook schemas in the rpc meta-schemaby daywalker90 · af028f74 · Sep 22, 2026 · 1 fileMessage 90 · StrongTriage 0Details
Commit message · daywalker90

docs: accept hook schemas in the rpc meta-schema

The meta-schema only accepted schemas carrying an `rpc` or
`notification` key, and `schemaResponse` did not allow
response-level `if`/`then`/`else`. As a result every
doc/schemas/hook/*.json failed the pre-commit
`check-jsonschema` hook, and the four hook responses which
encode conditional requiredness (htlc_accepted.json,
invoice_payment.json, openchannel.json and openchannel2.json)
were rejected outright.

Add the `hook` key with a matching top-level `oneOf` branch,
and allow `if`/`then`/`else` in `schemaResponse`.

Also list string_map, json_object_or_array, json_scalar and
proof_field, which msggen and the pyln-testing schema validator
already understand (contrib/msggen/msggen/model.py:425-461,
contrib/pyln-testing/pyln/testing/fixtures.py:482-511).

Changelog-None

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
documentation-only discount
Security candidatecontrib: add jaonoctus's signing keyby jaonoctus · 41278b4e · Sep 21, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · jaonoctus

contrib: add jaonoctus's signing key

Add jaonoctus's PGP fingerprint to the "Signatures For Releases" table
in both SECURITY.md and the security-policy doc, which are kept in sync.

Changelog-None

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydocumentation-only discount
AI analysis · Informational 15/100

This commit simply adds a new person's PGP public-key fingerprint to the list of trusted release signers in two documentation files. It does not change any code, fix any bug, or alter any security behavior of the software itself.

Lower-prioritybitcoin: a pull that has overrun must stay overrunby Kyle 🐆 · 5b2dff74 · Sep 20, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Kyle 🐆

bitcoin: a pull that has overrun must stay overrun

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritylightningd: adopt a confirmed splice candidate whose output is spent before splice_lockedby Níckolas Goline · 207c5735 · Sep 18, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Níckolas Goline

lightningd: adopt a confirmed splice candidate whose output is spent before splice_locked

splice_locked needs both sides. A peer that never sends it and closes
on the confirmed splice output left us in CHANNELD_AWAITING_SPLICE with
channel->funding still the outpoint the splice spent; the candidate
watch fired funding_spent(), which handed onchaind a commitment for
that old funding ("Funding transaction spent" on the wrong outpoint,
nothing resolved). The same happened on our own side after a force
close with an inflight, once the candidate's commitment confirmed:
onchaind took our own commitment for the peer's and died with "Could
not find resolution for output 1".

Whenever the spent outpoint is a candidate's and not the channel's
funding, adopt that candidate first, the way handle_peer_splice_locked()
(or opening_depth_cb for a dual-funding candidate) would have, then go
to onchaind on it.

Changelog-Fixed: splicing: a close on a confirmed splice output before splice_locked completed is now handled by onchaind on that output, on both sides.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 58911276927fc9476bd42936849d47e05f966f10)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context