AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

docs: lease fields are u16

Public commit record

What the developer wrote

Authored by daywalker90

80/100 · Strong
docs: lease fields are u16

The lease rate fields are u16 on the wire (wire/peer_wire.csv:215-217)
and in the structs they are serialized from (common/json_stream.c:
671). The funder plugin range-checks its request values into u16
(plugins/funder.c:1354-1355).

Type these as u16 in funderupdate (lease_fee_basis, funding_weight,
channel_fee_max_proportional_thousandths), in listnodes
option_will_fund, and in listpeerchannels, where to_self_delay and
max_accepted_htlcs are u16 as well (lightningd/peer_control.c emits
them from u16 members).

Changelog-Changed: cln-rpc: funderupdate and listnodes lease fields, and listpeerchannels max_accepted_htlcs, our_to_self_delay and their_to_self_delay are u16.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit is a cleanup of data-type documentation and API definitions. It changes several numeric fields from being labeled as 32-bit unsigned integers to 16-bit unsigned integers, matching what the underlying code already used on the wire and in memory. It also removes an unused field called 'next_step' from the public API. There is no direct security vulnerability here, but it reduces the chance that future developers or API consumers will be confused about valid value ranges.

Recommended action

No immediate action required. Treat as a normal API consistency/documentation update. If you maintain API clients, verify they handle uint16 ranges for the affected fields and remove any dependency on the removed 'next_step' field.

Security signals we found

01

Type narrowing to match wire format reduces risk of API consumers sending out-of-range values

02

Removal of unused 'next_step' field simplifies the API surface

03

No change to runtime validation logic or cryptographic operations

04

No memory-safety, authentication, or authorization changes

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.