BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
171commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 10 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedrpc: introduce HelpElision variant and ElideGroup helperby Renato Britto · 44fc3a29 · Jun 4, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · Renato Britto

rpc: introduce HelpElision variant and ElideGroup helper

Switch RPCResultOptions::print_elision to a variant
<HelpElisionNone, HelpElisionSkip, std::string> and add a constructor
that copies a result with replacement options.

Use the new ElideGroup() in TxDoc() to apply elision to field groups
instead of setting print_elision per field. Type::ELISION stays as a
deprecated alias.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a clean-up change to how Bitcoin Core formats its RPC help text. It replaces a slightly awkward way of hiding or summarising groups of help fields with a clearer helper function. There is no change to transaction handling, networking, wallet logic, or any code that processes untrusted data. It only affects the text users see when they call help commands.

AI review queuedtest_framework: BIP 434 supportby Anthony Towns · 01b8a117 · Jun 4, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · Anthony Towns

test_framework: BIP 434 support

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates Bitcoin Core's internal Python test framework to recognize a new P2P protocol version (70017) and a new 'FEATURE' message type as part of BIP 434 support. It does not change the actual Bitcoin node software, network rules, or consensus behavior. There is no security issue here.

AI review queuedtest: remove two unnecessary nodes from the testby rkrux · 5b65e312 · Jun 4, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · rkrux

test: remove two unnecessary nodes from the test

The test needs multiple wallets that can be created on a single node, multiple
nodes are not required.

As there is a cost associated with setting-up and tearing-down nodes, this patch
helps in reducing the test time as well.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple test cleanup. It changes one functional test so that it creates multiple wallets on a single Bitcoin Core node instead of spinning up three separate nodes. There is no change to the actual Bitcoin Core software that users run, and no security issue is introduced or fixed.

AI review queuedserialize: add LimitedVectorFormatterby Anthony Towns · 94ed4542 · Jun 4, 2026 · 2 filesMessage 35 · OpaqueInformational 12Details
Commit message · Anthony Towns

serialize: add LimitedVectorFormatter

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 12/100

This commit adds a new helper called LimitedVectorFormatter that lets Bitcoin Core reject serialized data containing vectors (lists of values) that are larger than an allowed maximum. It is a defensive building block, not a fix for an active bug. The commit itself does not change any existing network or file parsing code, so it cannot by itself prevent or cause any vulnerability.

AI review queuedqa: Avoid cleanup when exception is raisedby Hodlinator · 659671ac · Jun 4, 2026 · 6 filesMessage 68 · AdequateInformational 15Details
Commit message · Hodlinator

qa: Avoid cleanup when exception is raised

If an exception is raised before we get to cleanup, do not swallow it and attempt to reset the state. Doing so could trigger knock-on exceptions and extra tracebacks.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit changes how several Bitcoin Core test scripts clean up after themselves. Previously, cleanup code ran even when a test failed, which could hide the real failure behind extra error messages. Now cleanup is skipped if the test raises an exception, so the original failure is reported clearly. This only affects the project's internal test suite, not the live Bitcoin network or end users.

AI review queuedrefactor(test): Make CAmount arg explicit for BuildCreditingTransaction()by Hodlinator · 43ca54ca · Jun 3, 2026 · 2 filesMessage 72 · AdequateInformational 15Details
Commit message · Hodlinator

refactor(test): Make CAmount arg explicit for BuildCreditingTransaction()

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a tiny internal test-only code cleanup. It changes one function parameter in test helper code from the generic 'int' type to the project's specific 'CAmount' type, which is used for money values. It does not change any production code, network behavior, or wallet logic, and there is no security issue here.

AI review queuedwallet: Remove CoinsResult::Clear()by Hodlinator · b5e91e94 · Jun 3, 2026 · 3 filesMessage 66 · AdequateLow 29Details
Commit message · Hodlinator

wallet: Remove CoinsResult::Clear()

Instead we fully reset CoinsResult-instances without forgetting any fields.

Fixes: https://github.com/bitcoin/bitcoin/issues/35449

Variant resetting the other fields in Clear():
₿ hyperfine --warmup 2 "./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test"
Benchmark 1: ./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test
Time (mean ± σ): 4.289 s ± 0.008 s [User: 4.252 s, System: 0.027 s]
Range (min … max): 4.279 s … 4.301 s 10 runs

This variant:
₿ hyperfine --warmup 2 "./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test"
Benchmark 1: ./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test
Time (mean ± σ): 4.279 s ± 0.005 s [User: 4.244 s, System: 0.026 s]
Range (min … max): 4.271 s … 4.287 s 10 runs

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100

This Bitcoin Core commit removes a custom `Clear()` method from a wallet coin-selection helper struct and replaces its uses with a full default reset (`available_coins = {}`). The stated reason is to avoid accidentally leaving fields partially reset in the future. The change is defensive code cleanup; there is no direct evidence in the commit or supplied references that it fixes an active security vulnerability or exploitable bug.

AI review queueddepends: Build `qt` and `qrencode` packages for OpenBSD hostsby Hennadii Stepanov · a54ec373 · Jun 2, 2026 · 9 filesMessage 50 · ThinInformational 19Details
Commit message · Hennadii Stepanov

depends: Build `qt` and `qrencode` packages for OpenBSD hosts

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds build-system support so that Bitcoin Core's graphical user interface (GUI) and QR-code library can be compiled on OpenBSD. It does not change how Bitcoin validates transactions or handles wallets; it only fixes compilation and packaging issues for a new operating-system target. There is no indication this introduces a security vulnerability.

AI review queuedwallet, test: fix sendall anti-fee-sniping when locktime is not specifiedby rkrux · 9c1fcaca · May 29, 2026 · 1 fileMessage 95 · StrongInformational 12Details
Commit message · rkrux

wallet, test: fix sendall anti-fee-sniping when locktime is not specified

This particular test case only needs to ensure that locktime is not
specified in the RPC request, it doesn't need to rely on the wallet optin
RBF default that causes the test to pass coincidentally.

Co-authored-by: maflcko <6399679+maflcko@users.noreply.github.com>

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only changes a test file. It makes a wallet functional test more explicit by passing replaceable=False so the test reliably checks anti-fee-sniping locktime behavior, instead of relying on a coincidental wallet default. There is no change to production wallet or node code, so it does not fix a live security vulnerability.

AI review queuedkernel: assert invalid buffer preconditions in `btck_*_create` functionsby stringintech · 570a6276 · May 29, 2026 · 3 filesMessage 73 · AdequateLow 28Details
Commit message · stringintech

kernel: assert invalid buffer preconditions in `btck_*_create` functions

Switch buffer `ptr == nullptr && len > 0` checks from `nullptr` returns to assertions. These checks represent invalid caller preconditions, not failures encountered while deserializing or constructing the requested object. `btck_block_header_create` additionally asserts the pre-existing documented length contract (must be 80 bytes).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Low 28/100

This commit changes several Bitcoin Core kernel library functions so they crash the program (via assertions) instead of returning a null pointer when callers pass a null buffer with a non-zero length. It also tightens one function to require exactly 80-byte block headers. The change treats these as programmer errors rather than runtime failures, which can help catch misuse early but may cause denial-of-service crashes if an attacker can trigger those calls with bad inputs.

AI review queuedwallet: unfriend LegacyDataSPKM and DescriptorScriptPubKeyMan classesby rkrux · 6c525c2e · May 29, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · rkrux

wallet: unfriend LegacyDataSPKM and DescriptorScriptPubKeyMan classes

After PR 28333, `LegacyDataSPKM` doesn't need to use the private or
protected members of `DescriptorScriptPubKeyMan` class such as
`AddDescriptorKeyWithDB` and `TopUpWithDB`. Moreover, these two SPKMs
are siblings that inherit from the common `ScriptPubKeyMan`.

It seems reasonable to me that they are unfriended so that private
members of one are not exposed to another unnecessarily.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes a single 'friend' relationship between two wallet classes in Bitcoin Core. It is a code-cleanup change that reduces unnecessary access to private members; it does not fix a bug or vulnerability and has no direct security impact.

AI review queuedwallet: allow anti-fee-sniping in sendall RPC while not relying on RBF defaultby rkrux · 8877eec7 · May 29, 2026 · 1 fileMessage 85 · StrongLow 31Details
Commit message · rkrux

wallet: allow anti-fee-sniping in sendall RPC while not relying on RBF default

In case locktime (and replaceable) not being specified in this RPC request,
the wallet sets the transaction replaceable due to the default value of opt-in
RBF set in the wallet.

This allowed the anti-fee-sniping flow to be executed but in case of
replaceable being set false in the request, anti-fee-sniping flow would be
missed.

This patch fixes it.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100

This is a small fix in Bitcoin Core's 'sendall' wallet RPC command. The bug meant that when a user explicitly set a transaction as non-replaceable, the wallet skipped its normal anti-fee-sniping protection. Anti-fee-sniping is a privacy/defense mechanism that uses the current block height as a transaction 'locktime' to make transactions look more similar and slightly harder to target. The fix changes the input sequence number used in that case so the protection still runs even when RBF is disabled.

AI review queuedci, iwyu: Fix warnings in src/scripts and treat them as errorby Brandon Odiwuor · 61839425 · May 29, 2026 · 31 filesMessage 50 · ThinInformational 15Details
Commit message · Brandon Odiwuor

ci, iwyu: Fix warnings in src/scripts and treat them as error

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code-quality cleanup: it adjusts which C++ header files are included in many source files under src/script and related areas, and tells the continuous-integration (CI) tool to treat 'include-what-you-use' (IWYU) warnings as errors for those files. There is no functional change to how Bitcoin validates transactions, scripts, or signatures, and no security fix or vulnerability is described.

AI review queueddoc: Compress doc/build-unix.md dependency package names into tableby MarcoFalke · fa787043 · May 28, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · MarcoFalke

doc: Compress doc/build-unix.md dependency package names into table

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only reformats the Unix build instructions documentation. It compresses long lists of Linux package installation commands into a single table and removes an Arch Linux example. No program code, build scripts, or dependencies were changed, so it has no security relevance.

AI review queuedtest: add coverage for migrating ancient walletsby furszy · b86c1c44 · May 28, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · furszy

test: add coverage for migrating ancient wallets

Pre-#152 wallets have no best block stored. Test we
can migrate them.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a new automated test to Bitcoin Core that checks whether very old-style wallets (those created before a 2012-era change) can still be successfully migrated to the modern wallet format. It does not change any production wallet code; it only adds a test that deliberately corrupts a test wallet file to simulate an ancient wallet and then verifies migration still works.

AI review queuedwallet: fix ancient wallets migrationby furszy · fd44d48b · May 28, 2026 · 1 fileMessage 68 · AdequateInformational 22Details
Commit message · furszy

wallet: fix ancient wallets migration

The best block locator was introduced in #152, previously created
wallets do not have these record.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100

This patch fixes a bug where migrating very old Bitcoin wallets would fail entirely. The problem was that the migration code required a 'best block locator' record that did not exist in wallets created before that feature was added. The fix makes that record optional: if it is missing, migration continues and writes an empty locator to the new wallet files, which simply causes them to rescan the blockchain on next load. There is no attacker-controlled path here; it is a robustness fix for a user-initiated wallet migration.

AI review queuedguix, refactor: Add `BASE` argument to `*_for_host` functionsby Hennadii Stepanov · 62cf7bc5 · May 28, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

guix, refactor: Add `BASE` argument to `*_for_host` functions

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a straightforward internal cleanup of the Bitcoin Core Guix build scripts. It changes how directory paths are computed by adding an optional BASE argument to helper functions, replacing a temporary environment-variable trick. There is no change to how Bitcoin validates transactions, handles network data, or stores wallets, and nothing in the commit suggests a security fix or vulnerability.

AI review queuedguix, refactor: Move `distsrc_for_host()` to `prelude.bash`by Hennadii Stepanov · 5d46429e · May 28, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

guix, refactor: Move `distsrc_for_host()` to `prelude.bash`

The `distsrc_for_host()` function now accepts a second optional
argument, `SUFFIX`, making it consistent with other similar functions.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple code cleanup in Bitcoin Core's Guix build scripts. It moves a helper function that builds directory paths from two separate scripts into a shared library file, and adds an optional suffix parameter so both scripts can use the same function. There is no change to how Bitcoin works, no security fix, and no vulnerability.

AI review queuedguix, refactor: Move duplicated `profiledir_for_host()` to `prelude.bash`by Hennadii Stepanov · cab65ea9 · May 28, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

guix, refactor: Move duplicated `profiledir_for_host()` to `prelude.bash`

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple code cleanup in Bitcoin Core's Guix build scripts. It removes two identical copies of a helper function and places a single shared copy in a common file. The function itself only builds a directory path string and does not change behavior. There is no security issue here.

AI review queuedguix, refactor: Move duplicated `outdir_for_host()` to `prelude.bash`by Hennadii Stepanov · faa9d434 · May 28, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

guix, refactor: Move duplicated `outdir_for_host()` to `prelude.bash`

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple cleanup: it removes two identical copies of a small helper function from two build scripts and places a single shared copy in a common file that both scripts already use. The function itself just builds an output directory path string. There is no security-relevant change here.

AI review queuedtest: Wait for node exit after crash in verify_utxo_hashby MarcoFalke · fad585b6 · May 28, 2026 · 1 fileMessage 72 · AdequateInformational 18Details
Commit message · MarcoFalke

test: Wait for node exit after crash in verify_utxo_hash

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100

This is a small fix to a Bitcoin Core test script. The test deliberately crashes nodes to check that the database recovers correctly. The change adds a short wait after detecting a crash before restarting the node, preventing the test from trying to restart a node that has not fully shut down yet. It does not change the actual Bitcoin network software that users run, so it has no direct security impact on real Bitcoin nodes.

AI review queuedtest: Fix feature_dbcrash.py --usecli intermittent errorby MarcoFalke · fac27d70 · May 28, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · MarcoFalke

test: Fix feature_dbcrash.py --usecli intermittent error

Catch any Exception in verify_utxo_hash and let restart_node verify the
crash via wait_for_node_exit.

(Also, use named args in restart_node, while touching this test)

Catching any Exception covers possible subprocess.CalledProcessError
that may happen in a --usecli run. E.g.

TestFramework (INFO): Verifying utxo hash matches for all nodes
TestFramework.bitcoincli (DEBUG): Running bitcoin-cli ['-datadir=/tmp/bitcoin_func_test_gzufs0ht/node0', '-rpcclienttimeout=240', '-rpcconnect=127.0.0.1', '-rpcport=20963', 'gettxoutsetinfo']
TestFramework.bitcoincli (DEBUG): Running bitcoin-cli ['-datadir=/tmp/bitcoin_func_test_gzufs0ht/node1', '-rpcclienttimeout=240', '-rpcconnect=127.0.0.1', '-rpcport=20964', 'gettxoutsetinfo']
TestFramework (ERROR): Called Process failed with stdout='error: timeout on transient error: Could not connect to the server 127.0.0.1:20964 (error code 1 - "EOF reached")

Make sure the bitcoind server is running and that you are connecting to the correct RPC port.
Use "bitcoin-cli -help" for more info.
'; stderr='None';
Traceback (most recent call last):
File "./test/functional/test_framework/test_framework.py", line 143, in main
self.run_test()
~~~~~~~~~~~~~^^
File "./test/functional/feature_dbcrash.py", line 273, in run_test
self.verify_utxo_hash()
~~~~~~~~~~~~~~~~~~~~~^^
File "./test/functional/feature_dbcrash.py", line 182, in verify_utxo_hash
nodei_utxo_hash = self.nodes[i].gettxoutsetinfo()['hash_serialized_3']
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "./test/functional/test_framework/test_node.py", line 963, in __call__
return self.cli.send_cli(self.command, *args, **kwargs)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "./test/functional/test_framework/test_node.py", line 1043, in send_cli
raise subprocess.CalledProcessError(returncode, p_args, output=cli_stderr)

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This is a fix for an unreliable test script, not a security fix in Bitcoin Core itself. The test intentionally crashes Bitcoin nodes to verify database crash recovery. When run with the --usecli option, the test sometimes failed because it only caught one type of error (OSError) but bitcoin-cli can raise a different error (CalledProcessError) when the node is temporarily unreachable. The change broadens the exception handling so the test can continue and verify the crash as intended. It does not change production code or introduce a vulnerability.

AI review queuedtest: [refactor] Simplify submit_block_catch_errorby MarcoFalke · fa09de8b · May 28, 2026 · 1 fileMessage 97 · StrongInformational 15Details
Commit message · MarcoFalke

test: [refactor] Simplify submit_block_catch_error

Make it catch any Exception and let the caller verify it.

This refactor does not change any behavior, but the code is simpler,
more flexible and still correct, because wait_for_node_exit enforces the
crash to happen.

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This is a test-only code cleanup. It changes how a Bitcoin Core functional test catches errors when submitting blocks to a test node that is intentionally being crashed. The test now catches any generic exception instead of a specific list of network/process errors, and relies on a separate helper to confirm the node actually crashed. It does not touch the live Bitcoin network code, consensus rules, or wallet handling.

AI review queuedwallet, test: add wallet_deprecated_rbf.py for walletrbf deprecated keys & optionsby rkrux · 7bc39e3d · May 28, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: add wallet_deprecated_rbf.py for walletrbf deprecated keys & options

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new automated test file and registers it in the test runner. It checks that two old wallet/RBF-related command-line options still behave as documented while they are being phased out. There is no change to the actual Bitcoin Core software that users run, so it cannot introduce a security vulnerability or fix one.

AI review queuedwallet, test: remove -deprecatedrpc=bip125 from wallet_basic.pyby rkrux · 3ec550d1 · May 28, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: remove -deprecatedrpc=bip125 from wallet_basic.py

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a minor test-only cleanup. It removes a deprecated command-line flag and an obsolete field name from a single automated test script. There is no change to Bitcoin Core's actual wallet or network code, and no security relevance.