What the developer wrote
Authored by Sjors Provoost
wallet: drop stale TODOs
What changed, and why it matters
This commit simply removes two outdated code comments (TODOs) from a Bitcoin Core wallet file related to external signers. No actual code behavior was changed, so it does not fix or introduce any security issue on its own.
No security action needed; this is a non-functional comment cleanup. If the TODOs described real remaining limitations, they should be tracked elsewhere if not already resolved.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes two TODO comments in src/wallet/external_signer_scriptpubkeyman.cpp: one noting that multisig completeness checks should consider only the wallet’s own inputs, and another noting that FinalizePSBT won’t work in a multisig setup. The executable code is unchanged; only comments were removed.
Changed components
src/wallet/external_signer_scriptpubkeyman.cppInspect captured patch +1 / −2
diff --git a/src/wallet/external_signer_scriptpubkeyman.cpp b/src/wallet/external_signer_scriptpubkeyman.cpp
index f6668625..274da09e 100644
--- a/src/wallet/external_signer_scriptpubkeyman.cpp
+++ b/src/wallet/external_signer_scriptpubkeyman.cpp
@@ -88,7 +88,6 @@ std::optional<PSBTError> ExternalSignerScriptPubKeyMan::FillPSBT(PartiallySigned
// Already complete if every input is now signed
bool complete = true;
for (const auto& input : psbt.inputs) {
- // TODO: for multisig wallets, we should only care if all _our_ inputs are signed
complete &= PSBTInputSigned(input);
}
if (complete) return {};
@@ -104,7 +103,7 @@ std::optional<PSBTError> ExternalSignerScriptPubKeyMan::FillPSBT(PartiallySigned
LogWarning("Failed to sign: %s\n", failure_reason);
return PSBTError::EXTERNAL_SIGNER_FAILED;
}
- if (finalize) FinalizePSBT(psbt); // This won't work in a multisig setup
+ if (finalize) FinalizePSBT(psbt);
return {};
}
} // namespace wallet
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.