BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

2924 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

258security candidates613second-pass queue2891AI analyses
191commits · 30 days
470commits · 60 days
1488commits · 180 days
2865commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

70/100 average clarity
960Strong · 80–100
1188Adequate · 60–79
688Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Antoine Poinsot22422170
Ava Chow16351161065
MarcoFalke41021406074
Lőrinc17721177081
fanquake22819226057
Hennadii Stepanov21214208063
rkrux57957074
Sjors Provoost89889074
merge-script37718088
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 50 minutes ago

Low 28 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35959: Update secp256k1 subtree to latest master

This commit updates Bitcoin Core's embedded copy of the secp256k1 cryptographic library to a newer version. The update adds a new Silent Payments module, lets advanced users swap in a custom SHA256 compression function, removes some old de…

Dependency update of a core cryptographic library (libsecp256k1)New runtime SHA256 compression callback with self-test/smoke test to catch mis-implementations earlyBehavior change in ellswift_xdh to reject secret keys >= curve order (vendor states not a security issue)
625f951bby Ava Chow+297−11626 files
No security note in commit
Informational 23 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35605: wallet: rpc: Deprecate `removeprunedfunds` RPC

This commit deprecates a Bitcoin Core wallet RPC command called removeprunedfunds. The command lets users delete transactions from their own wallet, which can alter displayed balances. The change does not fix a software bug; it is a cleanu…

RPC allows deletion of arbitrary wallet transactions, affecting balancesDeprecation framed by authors as removing a dangerous and maintenance-burden featureNo authentication bypass, memory corruption, or consensus change present in diff
e9ed5e83by Ava Chow+64−695 files
No security note in commit
Informational 18 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35930: wallet: post-#35501 cleanups in CWalletTx

This is a follow-up cleanup and hardening patch for the Bitcoin Core wallet's handling of transactions that have multiple possible witness versions (same transaction ID but different witness data). It renames a variable, simplifies a helpe…

Added input-validation during wallet transaction deserializationNew unit test specifically exercises rejection of mismatched variant txidFollow-up to PR #35501 which introduced witness-variant tracking in the wallet
512dc9afby Ava Chow+68−315 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35729: refactor: test: Unroll `&&` conditions in macros

This commit only changes Bitcoin Core's internal test code. It splits combined conditions inside test-check macros (like BOOST_CHECK(a && b)) into separate checks so that when a test fails, the test output points to the exact failing condi…

aa0e0f79by merge-script+196−9519 files
No security note in commit
Low 26 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35493: wallet, descriptor: Fix MuSig private key completeness checks on `importdescriptors`

This commit fixes a bug in Bitcoin Core's wallet import logic for a new type of multi-signature setup called MuSig. Previously, when a user imported a MuSig descriptor that already contained all needed private keys, the wallet incorrectly …

False-positive warning in wallet import for fully-private MuSig descriptorsIncorrect private-key completeness check on synthetic aggregate public keyDescriptor logic now delegates completeness to `Descriptor::HavePrivateKeys()`
2c01832fby merge-script+76−374 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35943: doc: fix dead link in txrequest.h

This commit only fixes a broken web link in a code comment. It replaces an outdated URL to a research paper with a working URL to the same paper. There is no change to program logic, no security fix, and no vulnerability.

5d051c05by merge-script+1−11 file
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#33186: wallet, test: Ancient Wallet Migration from v0.14.3 (no-HD and Single Chain)

This commit only adds new automated tests for migrating very old Bitcoin Core wallets (version 0.14.3 from 2017) to the modern descriptor wallet format. It does not change any wallet production code, consensus rules, or network behavior. T…

757aa573by merge-script+246−124 files
No security note in commit
Low 28 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35925: wallet, rpc: Exclude non-owned addresses from listreceivedby*

This update fixes a wallet reporting bug. When a user asked their Bitcoin wallet to list every address that had received money, including empty ones, the result incorrectly included foreign addresses that the wallet merely knew about (for …

Information disclosure: wallet RPCs leaked existence/labels of foreign addressesIncorrect access-control boundary: non-owned addresses exposed in 'received' reportFix uses IsMine() rather than address purpose metadata, avoiding inconsistent purpose handling
e8cc21c5by Ava Chow+19−32 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35937: test: Append print_suppressions=0 to LSAN_OPTIONS, and suppress bitcoin-qt

This commit only changes test configuration. It tells the LeakSanitizer tool used during automated testing to stop printing long lists of suppressed memory leaks, and it narrows the list of ignored leaks to the bitcoin-qt GUI test binary. …

5973e075by merge-script+3−42 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35928: doc: mention -DWITH_ZMQ=ON in macOS build guide

This is a one-line documentation update to the macOS build guide. It adds a note telling users to pass a specific CMake option if they want ZeroMQ notification support. There is no code change and no security impact.

8397e09eby merge-script+1−11 file
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35482: fuzz: exercise the transaction-handling path in process_message(s)

This commit only changes Bitcoin Core's internal fuzz testing code. It makes the fuzz tests exercise more of the transaction-handling code path by toggling Initial Block Download mode and resetting the mempool between test runs. There is n…

No production code modifiedNo consensus, validation, net_processing, or wallet logic changedOnly fuzz test harnesses and test utilities affected
f11dc617by merge-script+105−798 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35914: test, fuzz: Remove unused variables

This commit removes unused variables from Bitcoin Core's test and fuzzing code. It is a cleanup/refactoring change with no effect on the live network software or user funds. It does not fix or introduce any security vulnerability.

d36bf709by merge-script+1−138 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35896: refactor: Default uint256::operator==, add operator<=>

This commit is a routine code cleanup in Bitcoin Core. It switches the uint256 equality and comparison operators to use standard C++20 defaults, removes an old custom Compare() helper, and marks an internal assertion-failure function as ne…

ed2c59abby merge-script+99−245 files
No security note in commit
Moderate 62 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35872: rpc: avoid descriptor range counter overflow

This update fixes a counting bug in several Bitcoin Core RPC commands that scan descriptors. When a user requested a descriptor range ending at the maximum allowed value (2,147,483,647), the internal counter used a smaller integer type and…

Signed integer overflow in descriptor expansion loopCrash/undefined behavior on maximum-range descriptor scansAuthenticated RPC surface affected (scantxoutset, scanblocks, getdescriptoractivity, utxoupdatepsbt, descriptorprocesspsbt)
b388674aby Ava Chow+3−12 files
Vendor flagged security relevance
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35842: rpc: Properly make RPCResult::Type::ANY non-test-only

This is a small cleanup and documentation fix for Bitcoin Core's RPC help system. It removes a comment that incorrectly said a certain output type was 'for testing only' and makes the help text properly display those outputs. There is no d…

No memory safety, cryptography, consensus, or authorization changes observedChange is confined to RPC help/schema metadata generationComment-only/type-label change from 'for testing only' to general use
c36ffd87by merge-script+42−364 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35895: refactor: Enable clang-tidy rule to reject anon namespace in header

This is a code cleanup change that turns on a static-analysis rule to prevent a specific C++ coding pattern (anonymous namespaces in header files) and updates two headers to comply. It does not change how Bitcoin Core behaves at runtime an…

No security-relevant code changeNo memory safety, cryptography, consensus, or network changesTooling-only refactor (clang-tidy configuration)
c4fbd3c7by merge-script+9−123 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35630: test: Add importdescriptors rpc error test coverage

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production wallet, node, or RPC code. The tests verify that the importdescriptors RPC reports errors in the right order, rejects bad times…

465196d0by merge-script+77−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35180: coins: group private cache helpers

This change is purely a code cleanup: it moves two internal helper functions of a Bitcoin Core cache class into the private section of the class and removes a duplicate 'private:' label. There is no change to what the code does, no bug fix…

c940fd75by merge-script+13−141 file
No security note in commit
Low 29 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35582: rpc: reject null for optional parameters

This Bitcoin Core change tightens how three RPC commands (scantxoutset, scanblocks, deriveaddresses) handle the value null when it is passed for optional parameters. Previously, explicitly passing null could be treated differently from sim…

RPC parameter validation changeNull value handling changeAddition of explicit error checks for missing required contextual parameters
3db96eb5by merge-script+18−75 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityLimit mempool size based on chunk feerateby Suhas Daftuar · 1ad4590f · Nov 18, 2025 · 2 filesMessage 80 · StrongLow 38Details
Commit message · Suhas Daftuar

Limit mempool size based on chunk feerate

Rather than evicting the transactions with the lowest descendant feerate,
instead evict transactions that have the lowest chunk feerate.

Once mining is implemented based on choosing transactions with highest chunk
feerate (see next commit), mining and eviction will be opposites, so that we
will evict the transactions that would be mined last.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 38/100

This Bitcoin Core commit changes how the mempool (the waiting area for unconfirmed transactions) decides which transactions to kick out when it gets too full. Previously it used 'descendant feerate'; now it uses 'chunk feerate' so that the transactions a miner would pick last are the same ones the mempool evicts first. This is a consistency improvement in transaction selection policy, not a fix for a clear exploit. The change could affect transaction propagation, fee estimation, and mempool behavior under load, but the commit itself does not describe any security vulnerability.

Lower-prioritySelect transactions for blocks based on chunk feerateby Suhas Daftuar · 47ab32fd · Nov 18, 2025 · 3 filesMessage 65 · AdequateLow 32Details
Commit message · Suhas Daftuar

Select transactions for blocks based on chunk feerate

Co-Authored-By: Gregory Sanders <gsanders87@gmail.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 32/100

This commit refactors how Bitcoin Core selects transactions for new blocks. It replaces an older, more complex ancestor-feerate algorithm with a new 'chunk feerate' approach driven by a new mempool graph builder. The change is a significant rewrite of mining transaction selection logic, but the commit itself does not describe any security bug or fix. Because it is a large behavioral change in consensus-adjacent code, it carries ordinary implementation risks, but there is no direct evidence in the commit of a vulnerability.

Lower-priority[test] rework/delete feature_rbf tests requiring large clustersby glozow · edb3e7cd · Nov 18, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · glozow

[test] rework/delete feature_rbf tests requiring large clusters

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's functional test suite. It reworks and deletes some Replace-By-Fee (RBF) tests that previously needed very large transaction clusters. The production mempool rules are not modified, and no security vulnerability is present in the commit.

Lower-prioritytest: update feature_rbf.py replacement testby Suhas Daftuar · 435fd567 · Nov 18, 2025 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · Suhas Daftuar

test: update feature_rbf.py replacement test

Preparatory commit to the rbf functional test, before changes are made to the
rbf rules as part of cluster mempool.

82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a minor test-only change in Bitcoin Core's functional test suite. It adds a constant and changes one test variable from 100 to 64 in preparation for future mempool work. It does not modify any production code, consensus rules, or network behavior, and presents no security issue.

Lower-priorityAdd new (unused) limits for cluster size/countby Suhas Daftuar · 34e32985 · Nov 18, 2025 · 4 filesMessage 45 · ThinInformational 15Details
Commit message · Suhas Daftuar

Add new (unused) limits for cluster size/count

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds two new command-line options, -limitclustercount and -limitclustersize, and corresponding data fields for mempool limits. However, the commit title and code make clear these new limits are currently unused: no enforcement logic consumes them. It is purely preparatory infrastructure for future mempool policy changes. There is no immediate security impact.

Lower-priorityfuzz: remove comparison between mini_miner block construction and minerby Suhas Daftuar · dec138d1 · Nov 18, 2025 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Suhas Daftuar

fuzz: remove comparison between mini_miner block construction and miner

After cluster mempool, the mini_miner will no longer match the miner's block
construction. Eventually mini_miner should be reworked to directly use
linearizations done in the mempool.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit removes a fuzz test that compared two internal Bitcoin components (MiniMiner and BlockAssembler) to ensure they built the same block. The test is being deleted because an upcoming code change ('cluster mempool') will make their outputs intentionally differ. This is a test-only cleanup, not a fix for a security bug.

Security candidateDo not allow mempool clusters to exceed configured limitsby Suhas Daftuar · 95762e67 · Nov 18, 2025 · 6 filesMessage 95 · StrongLow 47Details
Commit message · Suhas Daftuar

Do not allow mempool clusters to exceed configured limits

Include an adjustment to mempool_tests.cpp due to the additional memory used by
txgraph.

Includes a temporary change to the mempool_ephemeral_dust.py functional test,
due to validation checks being reordered. This change will revert once the RBF
rules are changed in a later commit.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
boot or update path
AI analysis · Low 47/100

This Bitcoin Core commit enforces a new mempool policy: groups of related unconfirmed transactions ('clusters') are now capped by configured size and count limits. Previously these limits existed as settings but were not fully enforced by the new in-memory transaction graph. The patch wires the limits into the graph, rejects submissions that would exceed them, and removes transactions from the mempool when a newly accepted block creates oversized clusters. It also reorders some validation checks so cluster-size rejection happens before certain standardness checks, which is why one functional test was temporarily adjusted.

Lower-prioritydoc: CI - Describe qemu-user-static usageby Hodlinator · 552eb900 · Nov 18, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Hodlinator

doc: CI - Describe qemu-user-static usage

Should help in cases such as: https://github.com/bitcoin/bitcoin/pull/31144#issuecomment-2450578651

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds documentation to the CI README explaining how to set up QEMU user-mode emulation for running tests on foreign CPU architectures. It is a pure documentation change with no code modifications, no security fixes, and no functional changes to Bitcoin Core.

Lower-prioritydoc: CI - Clarify how important `env -i` is and whyby Hodlinator · 2afbbdde · Nov 18, 2025 · 1 fileMessage 93 · StrongInformational 15Details
Commit message · Hodlinator

doc: CI - Clarify how important `env -i` is and why

Would hopefully have helped me in this case: https://github.com/bitcoin/bitcoin/pull/31176#issuecomment-2526410039
Since then however, fd813bf863b1ffa91429de6342285b35bab2bfa4 also made sure a minimal environment is used.

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates a documentation file (ci/README.md) to explain more clearly why the CI system should be run inside a clean environment using the `env -i` command. It does not change any code, build scripts, or configuration that could affect Bitcoin Core's runtime security. There is no vulnerability or security fix here.

Lower-priorityclang-format: Set InsertNewlineAtEOF: trueby MarcoFalke · fa1bf681 · Nov 18, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · MarcoFalke

clang-format: Set InsertNewlineAtEOF: true

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single formatting setting in Bitcoin Core's code style configuration file. It tells the clang-format tool to automatically add a blank newline at the end of source files when it runs. This has no effect on how the software runs, what data it processes, or its security. It only affects whitespace in source code files.

Security candidateMerge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flowsby Ava Chow · a90f3922 · Nov 17, 2025 · 2865 filesMessage 81 · StrongInformational 15Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows

d31158d3646f3c7e4832b9ca50f6ffe02800ff4c psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows (rkrux)

Pull request description:

The unserialization flows of the PSBT types work based on few underlying assumptions of functions from `serialize.h` & `stream.h` that takes some to understand when read the first time.

Add few comments that highlight these assumptions hopefully making it easier to grasp. Also, mention key/value format types as per BIP 174.

ACKs for top commit:
achow101:
ACK d31158d3646f3c7e4832b9ca50f6ffe02800ff4c
theStack:
ACK d31158d3646f3c7e4832b9ca50f6ffe02800ff4c

Tree-SHA512: 45111ef7f0258ebbc41d058b3ef2a72472774ab2878caf2d71d7b57b27549c46a51ccbeda5fe164bcf4f7ec10627bbae6e7763aa80b1e66912703a2088682817

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarycryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a documentation-only change for Bitcoin Core. It adds comments explaining how PSBT (Partially Signed Bitcoin Transaction) data is read from serialized bytes, with no changes to actual code behavior. The surrounding merge commit also includes a very large number of unrelated file additions (build files, templates, docs, etc.), but the titled change itself is purely explanatory comments.

Lower-prioritynet: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()`by WakeTrainDev · 4d893c0f · Nov 17, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · WakeTrainDev

net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()`

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply removes an unused local variable from a single function in Bitcoin Core's networking code. There is no functional change, no bug fix, and no security relevance.

Lower-priorityci: Move lint exec snippet to stand-alone py fileby MarcoFalke · fa1dacae · Nov 17, 2025 · 2 filesMessage 80 · StrongInformational 15Details
Commit message · MarcoFalke

ci: Move lint exec snippet to stand-alone py file

Moving the python code out of the yaml string makes it easier to lint,
format, and edit.

This can be reviewed with the git options:

--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply moves a chunk of Python code from inside a GitHub Actions workflow file into its own separate Python file. The code that runs is unchanged; only its location changed. There is no security issue here.

Lower-prioritytest: Remove tests violating hardened std::spanby MarcoFalke · fadb4f63 · Nov 17, 2025 · 1 fileMessage 67 · AdequateInformational 14Details
Commit message · MarcoFalke

test: Remove tests violating hardened std::span

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
defensive validation
AI analysis · Informational 14/100

This is a test-only change. It removes unit tests that created a std::span from a null pointer with a non-zero length, which is undefined behavior and now trapped by hardened std::span implementations. The production code is not changed, and no vulnerability in live Bitcoin Core is introduced or fixed here.

Lower-prioritydoc: Update NetBSD Build Guideby Hennadii Stepanov · c29eaeea · Nov 15, 2025 · 1 fileMessage 76 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

doc: Update NetBSD Build Guide

The `py310-zmq` binary package is not available by default on
NetBSD 10.1. It has been updated to `py313-zmq`, and the `python310`
package is updated accordingly.

See: https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/index-all.html.

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates a documentation file for building Bitcoin Core on NetBSD. It changes the recommended Python package from version 3.10 to version 3.13 because the older package is no longer available by default in NetBSD 10.1. There is no code change and no security issue.

Lower-prioritytests: Add witness commitment if we have a witness transaction in FullBlockTest.update_block()by Chris Stewart · a7c96f87 · Nov 15, 2025 · 2 filesMessage 60 · AdequateInformational 16Details
Commit message · Chris Stewart

tests: Add witness commitment if we have a witness transaction in FullBlockTest.update_block()

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 16/100

This commit only changes Bitcoin Core's own test code. It makes the test framework correctly add a witness commitment to test blocks when they contain a segwit transaction, and adds a new test case for transactions that have unnecessary witness data. There is no change to the actual Bitcoin network code that users run, so this does not create a security vulnerability in Bitcoin Core itself.

Lower-priorityqa: Account for errno not always being set for ConnectionResetErrorby Hodlinator · 76e0e608 · Nov 14, 2025 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · Hodlinator

qa: Account for errno not always being set for ConnectionResetError

Logging issue can be triggered by:

```diff
--- a/src/httpserver.cpp
+++ b/src/httpserver.cpp
@@ -263,6 +263,7 @@ std::string RequestMethodString(HTTPRequest::RequestMethod m)
/** HTTP request callback */
static void http_request_cb(struct evhttp_request* req, void* arg)
{
+ throw std::runtime_error{"Hello"};
evhttp_connection* conn{evhttp_request_get_connection(req)};
// Track active requests
{
```

http.client.RemoteDisconnected not specifying errno to ConnectionResetError-ctor:
https://github.com/python/cpython/blob/ce4b0ede16aea62ee7b1e02df7e1538102a356da/Lib/http/client.py#L1556C9-L1556C29

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 19/100

This is a small fix to Bitcoin Core's internal Python test framework. When a test talks to a running node and the connection is reset unexpectedly, Python's error object sometimes doesn't include a standard error number. The patch makes the test code treat that as a connection reset, so it can log and retry correctly instead of crashing the test run. It does not change the Bitcoin node itself, user wallets, consensus rules, or network behavior.

Lower-prioritytest: Add better coverage for Autofile size()by Fabian Jahr · 7f318e1d · Nov 14, 2025 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · Fabian Jahr

test: Add better coverage for Autofile size()

The new test explicitly checks that the function does not change the current position.

82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new test to Bitcoin Core. It checks that calling size() on an AutoFile object reports the file size without moving the file's internal read/write position. There is no change to production code and no security fix or vulnerability is present in the diff.

AI review queuedrefactor: Add AutoFile::sizeby Fabian Jahr · b7af960e · Nov 13, 2025 · 5 filesMessage 47 · ThinInformational 15Details
Commit message · Fabian Jahr

refactor: Add AutoFile::size

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a new helper method called size() to the AutoFile class, which reports how large a file is. It also updates two existing places in the code to use this new helper instead of manually seeking to the end of the file and asking for the current position. The change is purely a code cleanup (refactor) and does not fix any security bug.

Lower-priorityrefactor: Modernize logging in util/asmap.cppby Fabian Jahr · ec0f7586 · Nov 13, 2025 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · Fabian Jahr

refactor: Modernize logging in util/asmap.cpp

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a minor code cleanup: it changes two logging calls in the asmap file handling from a general log function to a warning-level log function. There is no security-relevant behavior change, no bug fix, and no new vulnerability introduced.

Lower-prioritytests: add unit test vectors for asmap interpreterby Pieter Wuille · 606a251e · Nov 13, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Pieter Wuille

tests: add unit test vectors for asmap interpreter

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit only adds new test cases to Bitcoin Core. It does not change any production code, so it cannot introduce a security vulnerability or fix one. The tests verify that a piece of networking code (the ASMap interpreter, used to map IP addresses to autonomous system numbers) produces expected results for a set of known inputs.

Lower-prioritykernel: allow null data_directoryby stickies-v · 6657bcbd · Nov 13, 2025 · 4 filesMessage 58 · ThinLow 26Details
Commit message · stickies-v

kernel: allow null data_directory

An empty path may be represented with a nullptr. For example,
std::string_view::data() may return nullptr.

Removes the BITCOINKERNEL_ARG_NONNULL attribute for data_directory,
and instead handles such null arguments in the implementation.

Also documents how BITCOINKERNEL_ARG_NONNULL should be used.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Low 26/100

This commit tightens input handling in Bitcoin Core's kernel library. Previously, the library's C interface promised that callers must not pass a null or empty directory path, but it did not actually check. Now it explicitly rejects null or empty data and blocks directories and returns an error instead of potentially misbehaving. It also updates the internal C++ wrapper to accept string views, which can legitimately have null data pointers when empty. This is a defensive hardening change, not a fix for an active exploit.

Lower-priorityinit: completely remove `-maxorphantx` optionby Sebastian Falbesoner · 0aebdac9 · Nov 13, 2025 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Sebastian Falbesoner

init: completely remove `-maxorphantx` option

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit removes an already-unused command-line option called `-maxorphantx`. The option had no effect since version 30.0 and only produced a warning if someone still had it in their configuration. Now it is fully removed, and a release note explains the change. There is no security issue here.

Lower-priorityrefactor: add missing LIFETIMEBOUND annotation for parameterby Andrew Toth · f743e6c5 · Nov 13, 2025 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · Andrew Toth

refactor: add missing LIFETIMEBOUND annotation for parameter

The BlockManager::GetFirstBlock lower_block parameter can have its lifetime
extended by the return parameter. In the case where lower_block is returned,
its lifetime will be bound to the return value. A LIFETIMEBOUND annotation is
appropriate here.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a code-quality annotation change only. It tells the compiler that a function parameter's lifetime is tied to the returned value, which helps catch misuse during development. It does not change program behavior or fix a runtime security bug.

Lower-priorityrefactor: return reference instead of pointerby Andrew Toth · 99d012ec · Nov 13, 2025 · 4 filesMessage 80 · StrongInformational 15Details
Commit message · Andrew Toth

refactor: return reference instead of pointer

The return value of BlockManager::GetFirstBlock must always be non-null. This
can be inferred by the implementation, which has an assertion that the return
value is not null. A raw pointer should only be returned if the result may be
null. In this case a reference is more appropriate.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a small internal code cleanup in Bitcoin Core. A helper function that finds the earliest block matching certain criteria used to return a raw pointer; now it returns a reference. The change is purely stylistic/safety-related because the function was already guaranteed to return a non-null result (it contains an assertion). No behavior changes, no bug fixes, and no security issue is present.