move-only: MAX_BLOCK_TIME_GAP to src/qt
What the developer wrote
Authored by MarcoFalke
move-only: MAX_BLOCK_TIME_GAP to src/qt
Can be reviewed via the git option:
--color-moved=dimmed-zebra
What changed, and why it matters
This commit simply moves a constant named MAX_BLOCK_TIME_GAP from one source file (src/chain.h) to another (src/qt/bitcoingui.cpp). The value and its meaning stay exactly the same. It is a code-cleanup change with no functional or security effect.
No security action needed. This is a benign refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is a move-only relocation of the static constexpr int64_t MAX_BLOCK_TIME_GAP = 90 * 60 definition out of src/chain.h and into src/qt/bitcoingui.cpp, which is the only place it is used. The diff stats are +8/-8 and the commit message explicitly says ‘move-only’. No logic, value, or visibility changes.
Changed components
src/chain.hsrc/qt/bitcoingui.cppInspect captured patch +8 / −8
diff --git a/src/chain.h b/src/chain.h
index 64c86357..de22b9c9 100644
--- a/src/chain.h
+++ b/src/chain.h
@@ -39,14 +39,6 @@ static constexpr int64_t TIMESTAMP_WINDOW = MAX_FUTURE_BLOCK_TIME;
static constexpr int32_t SEQ_ID_BEST_CHAIN_FROM_DISK = 0;
static constexpr int32_t SEQ_ID_INIT_FROM_DISK = 1;
-/**
- * Maximum gap between node time and block time used
- * for the "Catching up..." mode in GUI.
- *
- * Ref: https://github.com/bitcoin/bitcoin/pull/1026
- */
-static constexpr int64_t MAX_BLOCK_TIME_GAP = 90 * 60;
-
enum BlockStatus : uint32_t {
//! Unused.
BLOCK_VALID_UNKNOWN = 0,
diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp
index 6aa8bae0..4a408c87 100644
--- a/src/qt/bitcoingui.cpp
+++ b/src/qt/bitcoingui.cpp
@@ -72,6 +72,14 @@
#include <QWindow>
+/**
+ * Maximum gap between node time and block time used
+ * for the "Catching up..." mode in GUI.
+ *
+ * Ref: https://github.com/bitcoin/bitcoin/pull/1026
+ */
+static constexpr int64_t MAX_BLOCK_TIME_GAP = 90 * 60;
+
const std::string BitcoinGUI::DEFAULT_UIPLATFORM =
#if defined(Q_OS_MACOS)
"macosx"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.