Bitcoin Core

This is a minor test-only cleanup. It removes a deprecated command-line flag and an obsolete field name from a single automated test script. There is no change to Bitcoin Core's actual wallet or network code, and no security relevance.

This is a routine test-only cleanup. A Bitcoin Core functional test was still starting one node with a deprecated RPC compatibility flag (-deprecatedrpc=bip125). The patch removes that flag and adjusts the test assertions to ignore the now-removed 'bip125-replaceable' field when comparing transaction lists. No production code, no wallet logic, and no network behavior changed.

This commit only changes a single test file. It removes the redundant '-walletrbf=1' startup flag from several test nodes because those older Bitcoin Core versions already default to that setting. There is no change to the actual Bitcoin Core wallet or network code, and no security issue is present.

This is a routine test-only cleanup. It removes an obsolete command-line option (-walletrbf) and its associated deprecation warning from a backwards-compatibility test script. There is no change to the Bitcoin Core wallet or network code that end users run, and no security issue is present.

This commit only changes a single test file. It removes the use of a deprecated RPC option and deletes test assertions that checked a now-removed 'bip125-replaceable' field in wallet transaction output. There is no change to the actual Bitcoin Core wallet or node code that users run, so this cannot affect live wallets, funds, or network security.

This commit only removes a test case from Bitcoin Core's automated test suite. It deletes the part of a test that exercised the deprecated '-walletrbf' startup option and related opt-in RBF transaction behavior. There is no change to the actual Bitcoin Core wallet, node, or network code, and no security vulnerability is present in the diff.

This commit only changes a single test file. It removes the use of the deprecated '-walletrbf' startup option and its associated deprecation warning from the wallet_bumpfee.py functional test. There is no change to production wallet code, no bug fix, and no security issue.

This commit only changes Bitcoin Core's own test code. It removes the obsolete -walletrbf startup option from two functional tests and adds a missing PSBT v2 field (fallback locktime) to a test helper that creates blank PSBTs. There is no change to production wallet or node code, so it does not affect real users' funds, transactions, or network security.

This commit is a build-system housekeeping change for Bitcoin Core's Guix reproducible-build tooling. It takes one large package list file (manifest.scm) and splits it into two smaller files: one used when compiling the software (manifest_build.scm) and one used when applying release signatures (manifest_codesign.scm). The scripts that invoke Guix are updated to point at the correct new file. There is no change to the Bitcoin Core node software, wallet logic, or network behavior, and nothing in the commit suggests a security vulnerability or fix.

This is a tiny code cleanup in Bitcoin Core's wallet setup. It changes how the deprecated '-walletrbf' setting is read so the value is fetched once and reused, rather than checked for existence and then fetched separately. There is no security issue here.

This commit only changes Bitcoin Core's internal test scripts. It removes five lines that previously told the test framework these particular tests cannot be run with the command-line bitcoin-cli tool. There is no change to the actual Bitcoin node software, no security fix, and no vulnerability.

This change tightens two low-level math helper functions so they only accept whole-number (integer) types. Previously, a non-integer type could slip through and silently produce wrong min/max values because the generic fallback for numeric limits returns 0. The patch prevents that misuse at compile time rather than relying on an internal check.

This is a minor code cleanup in Bitcoin Core's test framework. It removes a lazy (deferred) import and replaces it with a normal import at the top of the file. There is no security issue here—it's purely a refactoring change to simplify the code after an earlier dependency cleanup.

This is a harmless internal code cleanup in Bitcoin Core's test suite. It moves a Python exception class named JSONRPCException from one test helper file (authproxy.py) to another (util.py) and updates the files that import it. There is no change to how Bitcoin nodes behave, no fix for a security bug, and no change that affects real users or live networks.

This commit is a one-word documentation update. It removes the phrase 'RPC only' from the help text of the -walletrbf command-line option because the feature is now also available through the graphical user interface. There is no code behavior change and no security impact.

This commit is a routine infrastructure change for Bitcoin Core's continuous integration (CI) system. It switches the CI cache provider from Cirrus to GitHub's own cache service because Cirrus is being phased out and GitHub now offers more cache storage. The changes only affect how build artifacts and dependencies are stored between automated test runs; they do not modify the Bitcoin Core software that users run, nor do they introduce any known security vulnerability.

This commit refactors how Bitcoin Core's block builder (the miner) handles the maximum block weight setting. It replaces an older signed-size field with a new optional unsigned field and fixes a parsing quirk: a negative command-line value for -blockmaxweight is now treated as 0 before validation rejects it, instead of silently wrapping around to a huge positive number. The change is mostly a cleanup, but it removes a small overflow/underflow footgun in argument parsing.

This is a code cleanup in Bitcoin Core's internal testing tools. It changes when and how the test framework creates a command-line interface (CLI) helper for test nodes, and removes some redundant settings. There is no indication this fixes a security bug or affects live Bitcoin software.

This is a minor code cleanup in a test file. It replaces a manual way of creating a connection to the Bitcoin node with a helper method that does the same thing. There is no security issue here.

This commit only changes Bitcoin Core's internal functional test code. It replaces hardcoded {'rules': ['segwit']} parameters with a shared constant NORMAL_GBT_REQUEST_PARAMS when calling getblocktemplate in tests. There is no change to production node code, no change to consensus rules, and no security fix or vulnerability introduced.

This commit simply marks an old wallet startup option called -walletrbf as deprecated. Since a recent release already makes all transactions replaceable by default, the option is now redundant. The change adds a warning when the option is used and updates tests to expect that warning. There is no security vulnerability here.

This is a routine Bitcoin Core change that hides an old transaction status field called 'bip125-replaceable' from wallet RPC responses by default, marking it as deprecated. Users can still get it back by starting the node with -deprecatedrpc=bip125. It is not a security fix and does not introduce a vulnerability; it is a user-interface/API cleanup following earlier changes that made transactions replaceable by default.

This commit fixes a bug in how Bitcoin Core lists external hardware wallets (signers). Previously, if the list contained duplicate signers, the code would stop processing entirely after the first duplicate, potentially hiding valid non-duplicate signers from the user. The fix changes the behavior so duplicates are skipped while the rest of the list is still processed. This is a correctness and usability fix rather than a direct theft-of-funds vulnerability, but it could mislead a user about which hardware wallets are available.

This is a straightforward internal code cleanup in Bitcoin Core's wallet migration feature. It changes how wallet names are passed around so that the code stores names directly in a result structure rather than fetching names from live wallet objects. There is no security-relevant change visible in the diff, and the commit message explicitly calls it a refactor.

This is a tiny test-only change that adds a missing assertion in a unit test. It does not change any production code, network rules, or wallet behavior. There is no security issue here.