Bitcoin Core

This is a routine code cleanup commit. It adjusts which C++ header files are included in the `src/common` part of Bitcoin Core so that an automated tool called Include What You Use (IWYU) reports no warnings. It also tells the continuous integration system to treat any future IWYU warnings in this area as errors. There is no change to program behavior, no bug fix, and no security-relevant change.

This commit only adds a one-line comment to a requirements file used by the continuous integration (CI) linting system, noting that the pinned lief version should match the version used in Guix. It does not change any code, dependency version, or configuration that affects the Bitcoin Core software users run.

This commit is a routine linting fix. It re-adds some Guix build helper scripts to the Python type-checker (mypy) configuration and adds two comment-only annotations to suppress false-positive type warnings. There is no change to Bitcoin Core's runtime behavior, consensus rules, wallet handling, or network code.

This commit only adds a release note documenting a prior change: the `fundrawtransaction` RPC command no longer silently accepts a boolean value in its second argument and will now report an error instead. It is a documentation-only change with no code modifications, so it does not by itself introduce or fix a security vulnerability. The prior behavior it describes was a silent no-op fallback, which could be considered a minor API usability issue but not a direct security flaw.

This commit only restructures a single test file by wrapping each test case in its own code block (scope). It does not change any production code, network rules, or test behavior. There is no security impact.

This is a one-line fix inside a Bitcoin Core unit test. The test was checking the P2SH signature-operation count for the wrong transaction object: it used a transaction that still had its scriptSig, instead of the version where the scriptSig was intentionally removed. The assertion value was also wrong (20 instead of 0). The change only affects test code, not production consensus or networking logic, so it cannot be exploited by users or attackers.

This commit rewrites an internal fuzz-testing harness for Bitcoin Core's RPC interface. It changes how fake RPC arguments are generated so the test can feed more realistic JSON data (numbers, booleans, nested arrays/objects, raw JSON) directly into RPC handlers instead of converting everything from strings first. There is no change to the live Bitcoin node or wallet code that users run; only the test code is modified.

This change makes Bitcoin Core disconnect any peer that sends a 'getblocktxn' message asking for zero transactions. Such a request is pointless because if no transactions are missing, the receiver already has everything it needs to reconstruct the block. The patch prevents the node from wastefully reading a block from disk and helps identify misbehaving or buggy peers. It is a hardening fix rather than a clear-cut exploit patch, and the commit message frames it as performance/robustness, not a security vulnerability.

This commit only adds new fuzz-test code for Bitcoin Core's mempool. It does not change any production networking, consensus, or wallet code, so it cannot directly affect live Bitcoin nodes or users' funds.

This change makes Bitcoin Core disconnect a peer earlier when it asks for a 'filtered block' from a node that does not advertise bloom-filter support. Previously, the node would read the block from disk first and only then ignore the request. Now it rejects the request before doing any disk read. This is mainly a small performance/hardening improvement rather than a serious security fix.

This commit is a simple code cleanup in a test file. It takes an existing test and moves it into a separate helper method, then calls that method from the main test runner. There is no change to Bitcoin Core's actual network code, no bug fix, and no security-related behavior change.

This commit re-enables a GUI test on macOS by changing the visual style used during automated testing. It is a quality-assurance/testing change, not a security fix. There is no indication it addresses a vulnerability or changes how real users run Bitcoin Core.

This commit removes an old backward-compatibility feature in Bitcoin Core's wallet RPC command `fundrawtransaction`. Previously, callers could pass a plain `true` or `false` as the second argument, which was silently ignored. Now, passing a boolean triggers a clear JSON type error, and callers must use the normal options object. This is a cleanup change, not a security fix, but it makes the API stricter and easier to reason about.

This commit is a housekeeping change to Bitcoin Core's Guix build scripts. It only reorders and consolidates CMake configuration flags, and adds a couple of disabled test/build options. There is no change to the actual Bitcoin software code, no bug fix, and no security-related behavior change.

This commit changes Bitcoin Core's build scripts so that linker warnings are treated as fatal errors during Linux and Windows release builds. It is a hardening of the build process, not a fix for a user-facing security bug. The change makes the build fail if the linker emits warnings, which helps catch build-time problems early. It is not something an attacker can directly exploit.

This commit is a straightforward cleanup of Bitcoin Core's Windows build scripts. It moves duplicated toolchain setup code into a shared helper function, with no functional changes visible in the diff. There is no indication this affects runtime security, user funds, or network behavior.

This commit is a routine cleanup of the Bitcoin Core build scripts used for Guix (a reproducible build system). It moves duplicated GCC toolchain setup code from two separate files into a single shared function in setup.sh, with no functional changes visible in the diff. There is no indication this affects the security of Bitcoin Core itself or introduces a vulnerability.

This commit is a straightforward cleanup of Bitcoin Core's macOS build scripts. It moves repeated LLVM/clang toolchain setup code from two separate scripts into a single shared function, with no change to the actual commands or build behavior. There is no security issue visible in the diff.

This commit adds a new menu item in the Bitcoin Core desktop wallet that lets users export a 'watch-only' copy of their wallet. A watch-only wallet can see transactions and balances but cannot spend funds. The change only wires up an existing export function to the graphical user interface; it does not appear to fix a bug or introduce a security vulnerability.

This commit only adds a release note describing a new graphical menu option in the Bitcoin Core wallet. It documents a feature that lets users create a watch-only wallet file from an existing descriptor wallet, matching an existing RPC command. There is no code change and no security issue.

This commit only adds a short release note describing a new wallet-migration user-interface option. There is no code change, no bug fix, and no security-related content in the diff.

This commit adds a user-facing checkbox in the Bitcoin Core desktop wallet that lets someone choose whether to automatically load a wallet after migrating it from an older format. Previously the wallet was always loaded. The change is a usability improvement, not a security fix, and does not introduce any obvious vulnerability.

This commit is a small internal code cleanup in Bitcoin Core. It removes the ability of a utility called LineReader to accept raw byte buffers, and updates two network components (Tor control connection and HTTP server) to use ordinary std::string buffers instead. There is no indication in the commit that this fixes a security vulnerability; it appears to be a refactoring to simplify the code and make buffer handling more consistent.

This is a small internal code cleanup in Bitcoin Core. It rewrites a helper class called LineReader so it works directly with string data instead of converting bytes to strings back and forth. There is no user-facing change, no bug fix, and no security-relevant behavior change visible in the diff.

This is a small code cleanup in Bitcoin Core's line-reading utility. It changes how the reader strips newline characters from input lines. The old code tried to remove both '\n' and '\r' from the end of a line after the fact; the new code builds the line without the '\n' in the first place and only strips a trailing '\r' if present. The commit message frames this as a correctness improvement for single-character '\r' line endings. There is no direct evidence in the commit or supplied references that this fixes an active security vulnerability.