Bitcoin Core

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production wallet, node, or RPC code. The tests verify that the importdescriptors RPC reports errors in the right order, rejects bad timestamps, and handles locked wallets correctly. There is no security fix or vulnerability being introduced.

This change is purely a code cleanup: it moves two internal helper functions of a Bitcoin Core cache class into the private section of the class and removes a duplicate 'private:' label. There is no change to what the code does, no bug fix, and no security impact.

This Bitcoin Core change tightens how three RPC commands (scantxoutset, scanblocks, deriveaddresses) handle the value null when it is passed for optional parameters. Previously, explicitly passing null could be treated differently from simply omitting the parameter, which could lead to unexpected behavior or errors. The patch makes null equivalent to 'not provided' for these specific cases and adds tests to confirm the new behavior. There is no direct evidence in the commit of a security vulnerability being exploited, but the change removes a potential source of confusion and misuse.

This commit is a code cleanup: it turns on a clang-tidy style check called 'misc-definitions-in-headers' and suppresses that check around a large inline implementation block in a benchmark header. There is no change to Bitcoin's runtime behavior, consensus rules, wallet handling, or network code. It only affects static analysis and the internal benchmark tool.

This commit only changes a linting configuration file for the project's code style checker. It enables a rule that prevents anonymous namespaces from being used in header files, which is a code-quality and build-hygiene practice. There is no change to Bitcoin Core's runtime behavior, network protocol, wallet handling, consensus logic, or any user-facing feature, so it has no direct security impact.

This commit is a straightforward code cleanup: it replaces a small custom helper named IntIdentity with the standard C++20 std::identity from the <functional> header. The behavior of the ConvertBits function is unchanged; only the implementation is simplified. There is no security-relevant change.

This commit only adds a new automated test to Bitcoin Core. It checks that when a user asks the wallet to import multiple descriptors at once, the list of results comes back in the same order as the original request, including any error messages. There is no change to production wallet code, so this cannot directly affect live users or funds.

This commit only adds new automated tests for the Bitcoin Core wallet's importdescriptors RPC. It checks that the command correctly rejects requests with a missing or invalid timestamp. No production wallet code is changed, so this cannot introduce a security vulnerability or fix one in running software.

This is a minor code cleanup that removes one unused header file include and swaps another for a more specific one. It does not change any program behavior or fix any security issue.

This commit is a routine code cleanup: it adjusts which C++ header files are included in several consensus-related source files and turns on a stricter compiler hygiene check (Include What You Use, or IWYU) for the src/consensus directory. There is no functional change to Bitcoin's rules, no bug fix, and no security-relevant behavior change.

This is a small fix to a Bitcoin Core fuzz test (an automated internal testing harness), not to the live network code. The fuzzer was sometimes creating fake P2P messages larger than the real protocol allows and passing them into a test helper. The change simply skips those oversized fake messages during fuzzing. It does not change how Bitcoin Core handles messages from actual peers on the network.

This commit simply removes one failing test configuration (RISC-V 32-bit bare metal) from the project's GitHub Actions CI matrix because it was failing. It is a routine CI maintenance change with no security implications.

This change adds checksum verification to the build system's downloads of Apple, FreeBSD, NetBSD, and OpenBSD software development kits (SDKs). Before this patch, those SDK archives were downloaded at build time and extracted without confirming they were the expected files. A network attacker or compromised download mirror could have supplied a tampered SDK, potentially altering the compiled Bitcoin Core binaries. The patch also fixes a small timing issue in OpenBSD setup so library symlinks are created only after both required archives are extracted.

This is a routine maintenance update to Bitcoin Core's continuous integration (CI) system. It changes the version number of the NetBSD operating system used for cross-compilation testing from a release candidate (11.0_RC6) to the final release (11.0), because the older release candidate files are no longer available for download. There is no change to the Bitcoin Core software that users run, and no security issue is present.

This commit only changes a test file and build configuration. It removes the option to skip a test when the system cannot detect total RAM, and instead requires the RAM detection to succeed. It does not change any production wallet, networking, consensus, or node code, so it has no direct security impact on running Bitcoin Core software.

This commit is a simple automated rename of a constant from MIN_DB_CACHE to MIN_DBCACHE_BYTES across five files. The value stays the same (4 MiB), and no behavior changes. It is a code-cleanup/refactoring change with no security relevance.

This commit adds a new public API knob to the Bitcoin Core 'libbitcoinkernel' library so that programs using the kernel can choose how much memory to use for the chainstate database cache. It also enforces minimum and maximum size limits. There is no obvious security bug in the change; it is a normal feature addition. The only security-relevant aspect is that the new setting is now properly validated and applied, whereas before the cache size was hard-coded.

This commit is a small code cleanup: it moves two constants that define the minimum and maximum size of the database cache (dbcache) into a shared kernel header so that both the node and kernel code use the same limits. There is no change to the actual values or behavior, and no security issue is present.

This is a small code cleanup change in Bitcoin Core. It removes a misleading alias named DEFAULT_DB_CACHE and replaces it with the underlying name DEFAULT_KERNEL_CACHE in a few places. The behavior of the program is unchanged; only the names used in the source code are clearer.

This is a small code-quality change in Bitcoin Core that changes how the program remembers how much RAM a computer has. It now stores the RAM amount as a 64-bit unsigned integer and caches the value once, instead of repeatedly detecting it and clamping it to a smaller 32-bit size. The change removes a potential source of inconsistent cache-size decisions on systems with more than about 4 GB of RAM, but it is not a fix for an active security vulnerability.

This commit simply renames a function from GetTotalRAM to TryGetTotalRam across the codebase. The behavior of the code does not change at all. The rename is meant to make it clearer to programmers that the function may fail to detect the system's RAM. There is no security fix or vulnerability here.

This commit is a tiny code cleanup in Bitcoin Core. It replaces old-style bit-shift math (>> 20) with a clearer named constant (1_MiB) when converting database cache sizes to megabytes. There is no security issue here—just improved readability.

This is a one-line compiler warning fix. A developer added a marker telling the compiler that a newly-added helper function may not be used yet, so Clang 23 stops complaining about it. There is no change to program behavior, no bug fix, and no security relevance.

This commit is a build-system housekeeping change. It moves the Python package dependency from the non-GUI build manifest to the GUI build manifest in Bitcoin Core's Guix reproducible-build setup. There is no indication this fixes or introduces a security vulnerability; it simply makes sure the right build environment includes Python only when needed for GUI packaging.

This commit removes a strict compiler/build flag (-Werror=dev) from Bitcoin Core's Guix build scripts. The flag previously turned CMake developer warnings into fatal errors. It was removed because an upcoming change (removing Python from non-GUI builds) would trigger a harmless warning. This is a build-system maintenance change, not a security fix.