BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 17 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge bitcoin/bitcoin#36262: test: cover orphan reconsideration interruptibilityby merge-script · 0036d5f1 · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36262: test: cover orphan reconsideration interruptibility

16bff77a5aaf7a9740b859f74b8898cee6de5588 test: cover orphan reconsideration interruptibility (ViniciusCestarii)

Pull request description:

Add test checking that ProcessOrphanTx reconsiders at most one orphan per ProcessMessages(). This test prevents regression of [CVE-2024-52914](https://bitcoincore.org/en/2024/07/03/disclose-orphan-dos/) which currently no existing test checks.

The test kills 2 mutants found with https://github.com/ViniciusCestarii/mutant-harness:

1. Remove `return true` after an orphan is accepted

```diff
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -3494,7 +3494,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)
if (result.m_result_type == MempoolAcceptResult::ResultType::VALID) {
LogDebug(BCLog::TXPACKAGES, " accepted orphan tx %s (wtxid=%s)\n", orphanHash.ToString(), orphan_wtxid.ToString());
ProcessValidTx(peer.m_id, porphanTx, result.m_replaced_transactions);
- return true;
} else if (state.GetResult() != TxValidationResult::TX_MISSING_INPUTS) {
```

2. Remove `return true` after an orphan is rejected for a reason other than `TX_MISSING_INPUTS`

```diff
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -3508,7 +3508,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)
state.GetResult() != TxValidationResult::TX_RESULT_UNSET)) {
ProcessInvalidTx(peer.m_id, porphanTx, state, /*first_time_failure=*/false);
}
- return true;
}
}
```

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/36262/commits/16bff77a5aaf7a9740b859f74b8898cee6de5588
fametrano:
tACK 16bff77a5aaf7a9740b859f74b8898cee6de5588

Tree-SHA512: 3d00bf7aa023c47d335b0f4c9d720c914611962272b895d91c8a542739f3b9c0d35c1dba5becdfd7167122c3f3f2be87b366d296732fa2765538467e6c0af6d7

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languageaccess controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds a new automated test to Bitcoin Core. It does not change any production code. The test verifies that a previously fixed denial-of-service bug (CVE-2024-52914) stays fixed by checking that orphan transactions are reconsidered one at a time per network message. It is a regression test, not a security patch.

AI review queuedMerge bitcoin/bitcoin#34907: wallet, test: make wallet_fast_rescan robustby merge-script · 36e9e52f · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#34907: wallet, test: make wallet_fast_rescan robust

f217da5c59f43b43abca96de66b95c24ae99eed7 wallet, test: wallet_fast_rescan follow-ups (rkrux)

Pull request description:

This patch addresses my own review comments from the review of #34667 and adds some more changes that I find helpful. It was observed in the review of the earlier PR that there is a tendency for the test code to cause the topups not being done that defeats the purpose of the test. Combine that with the earlier issue where the block filter was not being updated ever since this test was written, I think it's helpful that some robustness is added in the test.

Exact details are in the commit message.

ACKs for top commit:
Bicaru20:
lgtm ACK f217da5c59
polespinasa:
lgtm ACK f217da5c59f43b43abca96de66b95c24ae99eed7
sedited:
ACK f217da5c59f43b43abca96de66b95c24ae99eed7

Tree-SHA512: 781aeee4607a6750f370d4370b28da47f01428eb894ce59ac7de930396864a7c3708d1d1c05efb607fae8e5c2888a2503573140c37eed5c285c79d3e5155a3af

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a test-only change to a Bitcoin Core functional test file. It makes the wallet_fast_rescan test more robust by ensuring the test actually triggers wallet keypool top-ups and verifies block filter rescans find the expected transactions. There is no change to production wallet, node, or consensus code, and no security vulnerability is being fixed.

Security candidateMerge bitcoin/bitcoin#36151: makeseeds: fix off-by-one in field count checkby merge-script · 8c49a9ab · Oct 5, 2026 · 1 fileMessage 81 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36151: makeseeds: fix off-by-one in field count check

c786052865fd173fd8bc7396e1303f7840c5b0da makeseeds: fix off-by-one in field count check (aman21-droid)

Pull request description:

Fixes #36146.

`parseline()` checks that a line has at least 11 whitespace-separated fields:

```python
if len(sline) < 11:
# line too short to be valid, skip it.
return None
```

but it later reads `sline[11]` (the user agent), which needs 12. A line with exactly 11 fields got past the check and then raised `IndexError`, aborting the whole run instead of skipping that line. 11 is the highest index the function uses, so the check now requires 12 fields.

This isn't only theoretical: README.md builds seeds_main.txt by appending one crawler's output onto another's, so the file mixes two independently maintained formats, and a truncated download leaves a short last line too. Skipping the line is what the check was already trying to do.

ACKs for top commit:
maflcko:
lgtm ACK c786052865fd173fd8bc7396e1303f7840c5b0da
l0rinc:
ACK c786052865fd173fd8bc7396e1303f7840c5b0da

Tree-SHA512: 3c3aeb8876b7e0eccf8f03faafe0e0bb71d1b11924feaf22b2bb6bf1a36e25bedd622de257060de873c42f12fba8df42d96b2a831a2e8d395220fed70f4bba34

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathmerge-commit duplicate discount
AI analysis · Informational 20/100

This is a one-line fix in a Python helper script used to build the list of network seed nodes for Bitcoin Core. The script reads lines of data about internet nodes and was supposed to skip any line that didn't have enough fields. Due to an off-by-one error, a line with exactly 11 fields passed the 'too short' check but then crashed the program when it tried to read the 12th field. The fix simply changes the minimum required field count from 11 to 12. This only affects an offline developer/operations tool and cannot be used to attack the Bitcoin network or wallets directly.

Security candidateMerge bitcoin/bitcoin#32895: wallet: Prepare for future upgrades by recording versions of last client to open and decryptby merge-script · 6e419391 · Oct 5, 2026 · 6 filesMessage 81 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#32895: wallet: Prepare for future upgrades by recording versions of last client to open and decrypt

7b32155458cc87e50da1fa9f245cc84bc203f25a wallet: Set last opened and decrypted features during migration (Ava Chow)
f998a740fc9f56c813973155cef44c757f1955dd wallet: Record the supported features of the last client to decrypt a wallet (Ava Chow)
8453ad801b63ec92af1652cdcf801165c59f2ab2 wallet: Introduce LastClientFeatures flags and LAST_OPENED_FEATURES record (Ava Chow)
0f104733cc8e4b1736efa6a3bc92a8e3dba1a1b3 walletdb: Decouple last client record from CLIENT_VERSION (Ava Chow)

Pull request description:

When a wallet is automatically upgraded, we always do so in a way that allows the user to load their wallet in an older version. When the user loads their wallet into an upgraded version again, the wallet may not perform the automatic upgrade and end up with upgraded and non-upgraded material in the wallet.

If we write some information about the last client to open the wallet, we would be able to detect these upgrade-downgrade-upgrade situations and perform another upgrade if so. However, in order for this to work, we need to have implemented writing such information into versions prior to the ones which introduce new automatic upgrades.

We are already writing the CLIENT_VERSION into all wallets in a "version" record, although this record is not updated in the same way across all previous versions. Since v24.0, we are always updating the record when the client version differs, but prior to that, the record would only be updated when the client version is newer. Even so, we can use this record to store the last client version.

The first commit decouples the written client version from the node version. This aids in development of new features. The version is entirely decoupled from previous versions by requiring all versions to have bit 19 set, and the initial version being `0 | (1 << 19)`. The versions just need to be at least 299900, and forcing bit 19 to be set was an easy way to achieve this.

However, using version numbers is not as flexible as feature flags, so the second commit introduces the concept of Wallet Client Features. These flags are distinct from the existing Wallet Feature Flags since they are conceptually different. These are written in a separate record, and the wallet client version is incremented to `(1 << 19) + 1`.

Lastly, since some upgrades may need private keys and can only occur after the wallet is decrypted, the third commit also adds a last decrypted features flags record to record the features of the last client to decrypt the wallet.

The result is that we will now be able to detect a downgrade down to v24.0 and be able to implement in parallel multiple features that require automatic upgrades.

ACKs for top commit:
polespinasa:
ACK 7b32155458cc87e50da1fa9f245cc84bc203f25a
w0xlt:
reACK 7b32155458cc87e50da1fa9f245cc84bc203f25a

Tree-SHA512: 7d619e24e06a48162950bd153e12ae9fe05454ca8422e7f3d185b1b8ac2506ead6c1bc094da0b1182aceffe3cf198b948335b676f383ce88f4f9e0ae78beca61

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialupdate trustsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This change is a wallet infrastructure improvement, not a fix for an active security bug. It records which Bitcoin Core version and feature set last opened or decrypted a wallet so that future releases can detect 'upgrade-downgrade-upgrade' cycles and re-run automatic wallet upgrades safely. There is no direct exploit here, but any bug in this bookkeeping could in theory cause a wallet to skip needed upgrades or behave unexpectedly after being loaded in older software.

Security candidateMerge bitcoin/bitcoin#36080: p2p: Suspend ping timeout while downloading blocks from a peerby merge-script · c7835db1 · Oct 5, 2026 · 3 filesMessage 100 · StrongLow 34Details
Commit message · merge-script

Merge bitcoin/bitcoin#36080: p2p: Suspend ping timeout while downloading blocks from a peer

d83647e7c48a11dc54ad697342a4b7e3bce9061b p2p: Don't apply ping timeout while downloading blocks (Martin Zumsande)
2b43c62d8ef53edfadf8f097731f48a01b9570cd p2p: move ping timeout check into SendMessages (Martin Zumsande)
8b5bbfe1fca1f4100f858ebfd187dcf74d9d3c82 test: add functional test for pings during IBD (Martin Zumsande)

Pull request description:

While serving blocks, there is a system in place that prioritizes a peer's block requests before answering other p2p messages:
See
https://github.com/bitcoin/bitcoin/blob/11090c8bb359f894ef7d97b65aff52fe8191aec1/src/net_processing.cpp#L5436

As a result it can happen that if we do IBD with a low download bandwidth (that is distributed over 10 peers) a peer will not get around to answering our ping before the timeout of 20 minutes, in which case we would disconnect them, although they have done nothing wrong and are not even slow themselves (we are).
This situation has been described in #35761.

This PR fixes the issue by not enforcing the ping timeout from a peer while downloading blocks from them.
In order to do that, the ping timeout check is moved out of `MaybeSendPing()` (which was a slightly awkward place anyway, given the name of the function) and suspended until there are no longer blocks in flight with that peer (with a grace period, so that we don't disconnect immediately after the last block was received before the peer got a chance to send us the `pong`).

Note that during block download, there are still other timeouts:
- A dynamic timeout (`BLOCK_DOWNLOAD_TIMEOUT_BASE` / `BLOCK_DOWNLOAD_TIMEOUT_PER_PEER`) which will result in a timeout of `600s × (1 + 0.5×9) = 55 minutes` per block when downloading from 10 peers in parallel
- the stalling logic which hits if the peer is much slower in comparison to other peers
- the socket inactivity check disconnects a peer that hasn't sent us anything at all in the last 20 minutes.

So the ping timeout didn't add much value anyway in that situation.

Fixes #35761

ACKs for top commit:
maflcko:
review ACK d83647e7c48a11dc54ad697342a4b7e3bce9061b 🌎
fjahr:
reACK d83647e7c48a11dc54ad697342a4b7e3bce9061b
danielabrozzoni:
ACK d83647e7c48a11dc54ad697342a4b7e3bce9061b
sedited:
ACK d83647e7c48a11dc54ad697342a4b7e3bce9061b

Tree-SHA512: b6986349432117e70b34c7dd812e88cb22e986794f6644b021fee1a282f904d04a2a524415794ec3a22f2f592550a8e89f9416a2a00922184341b280fbc315b4

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
authentication pathmerge-commit duplicate discount
AI analysis · Low 34/100

This change fixes a bug where Bitcoin Core could wrongly disconnect a peer during Initial Block Download (IBD). The problem happened because the node demanded a ping reply within 20 minutes even while the peer was busy sending blocks. With slow bandwidth, the peer could be too busy serving blocks to reply to the ping in time, so the node would drop a perfectly good peer. The fix pauses the ping timeout while blocks are being downloaded from a peer, and adds a one-minute grace period after the last block before the timeout applies again. It is a reliability/availability fix, not a remote exploit.

Security candidateMerge bitcoin/bitcoin#36128: test: add script_tests cases covering more interpreter mutantsby merge-script · b3f9d8e1 · Oct 5, 2026 · 2 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36128: test: add script_tests cases covering more interpreter mutants

44a7083d43604b3d5c923ffc9011d8043a27d052 test: cover MAX_OPS_PER_SCRIPT in P2WSH witness scripts (ViniciusCestarii)
f1380123b6f8912e2ca599f30f2d89c0af9b9c5f test: cover P2WSH trailing byte mismatch (ViniciusCestarii)
4e7de2ac4cc6c08ff27620de01ccd9d66c568459 test: cover TAPSCRIPT_MINIMALIF for OP_IF and OP_NOTIF with 1-byte vector 0x00 (ViniciusCestarii)

Pull request description:

Kills some live mutants on interpreter.cpp that affect consensus found with https://github.com/ViniciusCestarii/mutant-harness. They are:

interpreter.cpp (killed by 4e7de2ac4cc6c08ff27620de01ccd9d66c568459): `OP_IF / OP_NOTIF` tapscript minimal-IF:
```diff
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
index 98b16ec..f9b08fe 100644
--- a/src/script/interpreter.cpp
+++ b/src/script/interpreter.cpp
@@ -624,7 +624,7 @@ bool EvalScript(std::vector<std::vector<unsigned char> >& stack, const CScript&
- if (vch.size() > 1 || (vch.size() == 1 && vch[0] != 1)) {
+ if (vch.size() > 1 || (vch.size() == 1 && vch[0] > 1)) {
```

interpreter.cpp (killed by f1380123b6f8912e2ca599f30f2d89c0af9b9c5f): P2WSH:

```diff
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
index 98b16ec..73a1bb5 100644
--- a/src/script/interpreter.cpp
+++ b/src/script/interpreter.cpp
@@ -1940,7 +1940,7 @@ static bool VerifyWitnessProgram(const CScriptWitness& witness, int witversion,
- if (memcmp(hash_exec_script.begin(), program.data(), 32)) {
+ if (memcmp(hash_exec_script.begin(), program.data(), 31)) {
```

interpreter.cpp (killed by 44a7083d43604b3d5c923ffc9011d8043a27d052): opcode limit:

```diff
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
index 98b16ec..b117045 100644
--- a/src/script/interpreter.cpp
+++ b/src/script/interpreter.cpp
@@ -457,7 +457,7 @@ bool EvalScript(std::vector<std::vector<unsigned char> >& stack, const CScript&
- if (sigversion == SigVersion::BASE || sigversion == SigVersion::WITNESS_V0) {
+ if (sigversion == SigVersion::BASE) {
```

Recommend reviewing per commit.

ACKs for top commit:
aaron-leeb:
tACK [44a7083](https://github.com/bitcoin/bitcoin/pull/36128/commits/44a7083d43604b3d5c923ffc9011d8043a27d052)
fametrano:
ACK 44a7083d43604b3d5c923ffc9011d8043a27d052
sedited:
ACK 44a7083d43604b3d5c923ffc9011d8043a27d052

Tree-SHA512: 62a41df06422e8981f0ab4be30563e513ce8a7b566f674662300f0466efa35b87ef658e8c8a01a2911c8bab9e5d6060fa7ff279a41669bf131766379e2f75027

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new test cases to Bitcoin Core's test suite. It does not change any production consensus code. The tests are designed to catch accidental code changes ('mutants') in the script interpreter that could break consensus rules, but the commit itself is a defensive testing improvement, not a vulnerability fix.

Security candidateMerge bitcoin/bitcoin#36327: test: speed up secp256k1 fixed-base multiplication and Schnorr signingby merge-script · b6a1b0ff · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36327: test: speed up secp256k1 fixed-base multiplication and Schnorr signing

b6fc3cf0046d3106e0dfb30f320d48514eff6fb2 test: speed up secp256k1 fixed-base multiplication (brunoerg)

Pull request description:

This PR speeds up the test framework’s fixed-base multiplication and Schnorr signing by:

- Changing FastGEMul to process scalars in 4-bit windows instead of individual bits. Precompute all 16 multiples for each window position, reducing multiplication from about 128 point additions on average to 64 table lookups and about 60 nonzero point additions. This trades a larger table and additional initialization work for cheaper repeated multiplications.

On my local machine (Macbook M2 Pro) the `feature_taproot.py`'s medium time decreased from 83.39s to 35.42s.

ACKs for top commit:
fametrano:
tACK b6fc3cf0046d3106e0dfb30f320d48514eff6fb2
theStack:
ACK b6fc3cf0046d3106e0dfb30f320d48514eff6fb2
ViniciusCestarii:
tACK b6fc3cf0046d3106e0dfb30f320d48514eff6fb2

Tree-SHA512: 983c1e971122e7a15458436943d5c14a936e86b157bc8c74ce1631aafcd0c7f35bbc476df625a57afb37d4e32bb620d1f1d5b3e2267867279bca736f170e83c9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarycryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a pure performance optimization for Bitcoin Core's internal test framework. It changes how the test code performs certain mathematical operations on the secp256k1 elliptic curve, making tests run faster. There is no change to live network code, wallet behavior, consensus rules, or cryptographic security. It does not fix a vulnerability or introduce a known security risk.

Security candidateMerge bitcoin/bitcoin#36415: rpc: clarify preciousblock help textby merge-script · 66776840 · Oct 3, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36415: rpc: clarify preciousblock help text

15d092639957242d443a680d380f8df1def2bd4e rpc: clarify preciousblock help text (ViniciusCestarii)

Pull request description:

The preciousblock help says only "Treats a block as if it were received before others with the same work". This isn't wrong but could be clearer and it also leaves out cases that confuse users, including me (see discussion in #35300):

- The call has no effect when the block has less work than the current tip, and that includes any ancestor of the tip. A successful return doesn't mean the tip changed. ([code](https://github.com/bitcoin/bitcoin/blob/69142eacd1374925cc9e4ea736c21fcec16307d0/src/validation.cpp#L3504-L3507))
- It only breaks ties between equal-work chains and doesn't pin the chain. If another chain gains more work, the node switches to it as usual. ([code](https://github.com/bitcoin/bitcoin/blob/69142eacd1374925cc9e4ea736c21fcec16307d0/src/node/blockstorage.cpp#L174-L182))

This adds both points to the help text and doesn't change any behavior.

ACKs for top commit:
instagibbs:
ACK https://github.com/bitcoin/bitcoin/pull/36415/commits/15d092639957242d443a680d380f8df1def2bd4e
maflcko:
lgtm ACK 15d092639957242d443a680d380f8df1def2bd4e

Tree-SHA512: cc2bc740bb0e9ebc442b35b31b59b6f5ec56da23a555352e1491d98684d1722617e18072e05807e95be23b8a14ddd20aed01d67fae42c45cb2c788b1f999dc8a

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This change only updates the help text shown by the preciousblock RPC command to explain more clearly when it has no effect and that it does not permanently lock the chain. No code behavior was changed.

AI review queuedMerge bitcoin/bitcoin#36299: cli: Improve empty-response and fix -rpcclienttimeout regressionby Ava Chow · dd809d2c · Oct 2, 2026 · 2 filesMessage 100 · StrongLow 38Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36299: cli: Improve empty-response and fix -rpcclienttimeout regression

1805716354b49ecb96e49b949a61e2c72ad2c1a3 cli: Apply -rpcclienttimeout per socket wait instead of per phase (Fabian Jahr)
b841ab694215699cba53c4de8a7cc08b9fce259a cli: Treat a response with Content-Length: 0 as complete (Fabian Jahr)

Pull request description:

Two follow-ups to #34342

First commit: An empty body was not treated as a complete response. We currently check if `Content-Length` is greater than zero instead of whether the header was sent, so a response with a `Content-Length` of 0 falls into the branch for responses that carry no length and confinues to read until the peer disconnects. Our server sends an empty body with several types of errors such as a wrong RPC password but it does close the connection as well, which mitigates this from causing any serious issue. However, it would still be good to handle this correctly on the client side that we don't have to rely on the server to save us from hanging.

b-l-u-e found this in post-merge review in https://github.com/bitcoin/bitcoin/pull/34342#discussion_r3358700705 but I didn't manage to look into it until now.

Second commit: `-rpcclienttimeout` no longer measures real idle time. Before the libevent removal, it used to mean give up if really nothing arrives for this long, and any newly incoming data did reset the counter. With the new code the countdown ignores progress, so a large/slow response could be cut off while data still arrives. Revert this to the old behavior.

The second commit does not have a test because I didn't manage to construct one that didn't turn out to be flaky. It may be possible but I couldn't come up with something within a scope of complexity that seems reasonable for this.

ACKs for top commit:
achow101:
ACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
0tuedon:
tACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
winterrdog:
tACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
hodlinator:
ACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3

Tree-SHA512: 6139328c84480af7c7ccd5beec3361a28bbd639459e36b3f033ffc5946840ac0e589d987d4ce2414e58110b73ce48e34b449f9dd5ca577d07e334589a280a136

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 38/100

This update fixes two bugs in bitcoin-cli, the command-line tool used to talk to a Bitcoin node. First, when a server replied with an empty body but said it was intentionally empty (Content-Length: 0), the client would keep waiting instead of accepting the reply. Second, the client timeout stopped measuring actual idle time, so a slow but ongoing download could be cut off. The patch makes the timeout reset whenever new data arrives and treats a declared empty body as complete. The hang-on-empty-body case is the more security-relevant one, because a malicious or misbehaving server that keeps the connection open could make bitcoin-cli hang until the user kills it.

Security candidateMerge bitcoin/bitcoin#36052: ci: Doc: Move all config comments right next to the option they explainby merge-script · 9f059527 · Oct 2, 2026 · 26 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36052: ci: Doc: Move all config comments right next to the option they explain

fa90a8a01318493d39bca924dbd51c72f0232e4c ci: [refactor] Use eval-based string-to-argv conversion for FUZZ_TESTS_ARGS (MarcoFalke)
fa18f9aeac8e22d1aeae78f9bceb4a9694ed1b2c ci: Doc: Move all config comments right next to the option they explain (MarcoFalke)
fa0e84ec53fcf9cc85af29e1a36983b0575e17d7 ci: refactor: Use printf %q quoting for BITCOIN_CONFIG (MarcoFalke)

Pull request description:

This is a CI doc-style-cleanup. `BITCOIN_CONFIG` is a single manually-formatted-and-quoted large string. This is fine, but shellcheck doesn't like when trailing comments are added: `SC2155 -- Declare and assign separately`.

Fix this style by using `printf` to format the single string. The second commit then moves the comments right into (or next to) the line that it concerns.

ACKs for top commit:
hebasto:
re-ACK fa90a8a01318493d39bca924dbd51c72f0232e4c.
willcl-ark:
ACK fa90a8a01318493d39bca924dbd51c72f0232e4c

Tree-SHA512: d683829b36469ab9c0c799a918a0d7b0be12389a01bc18f3bb43cff41049269d3ea398a478329bc5f7d2e1619642e2cf4aa991f5f5c299ab3acbfc64e27a6f8a

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathauthentication pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a documentation and code-style cleanup for Bitcoin Core's continuous integration (CI) scripts. It changes how build configuration strings are formatted in shell scripts so comments can sit next to the options they describe, and it switches one fuzz-test argument handling pattern to use an array. There is no change to the Bitcoin protocol, wallet logic, networking, or any code that runs in production. It is purely a CI maintenance refactor.

AI review queuedMerge bitcoin/bitcoin#35833: log: prevent user input from injecting fake log linesby Ava Chow · d4b0e1e4 · Sep 30, 2026 · 4 filesMessage 100 · StrongModerate 60Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35833: log: prevent user input from injecting fake log lines

d93d366e204e95e873ef0b89425f84a520f8fabd log: escape newlines in messages (Lőrinc)
960dcdb62529a6498d1397e1cf1077fe3cb19d9f test: characterize RPC and wallet input logs (Lőrinc)

Pull request description:

**Problem:** Restricted RPC users and callers of `createwallet` or `restorewallet` can inject newlines through rejected methods or wallet names, and [global log escaping preserves them](https://github.com/bitcoin/bitcoin/pull/17095), making forged lines look like node messages.

**Fix:** Escape embedded newlines in log messages.

<details>
<summary>Manual reproducer</summary>

```bash
DATADIR="$(mktemp -d /tmp/bitcoin-log-injection.XXXXXX)"
M="$(date -u +%Y-%m-%dT%H:%M:%SZ) ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent"
cmake -B build >/dev/null 2>&1 && cmake --build build -j >/dev/null 2>&1
build/bin/bitcoind -regtest -daemonwait -datadir="$DATADIR" -rpcwhitelist=__cookie__:getblock,stop >/dev/null 2>&1
build/bin/bitcoin-cli -regtest -datadir="$DATADIR" $'getblock\n'"$M" >/dev/null 2>&1; killall bitcoind >/dev/null
echo; grep -E 'ConnectTip|not allowed' "$DATADIR/regtest/debug.log"
```

> Before

```bash
2026-07-28T23:18:57Z [warning] RPC User __cookie__ not allowed to call method getblock
2026-07-28T23:18:55Z ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent
```

> After

```bash
2026-07-28T23:19:45Z [warning] RPC User __cookie__ not allowed to call method getblock\x0a2026-07-28T23:19:41Z ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent
```
</details>

ACKs for top commit:
achow101:
ACK d93d366e204e95e873ef0b89425f84a520f8fabd
ryanofsky:
Code review ACK d93d366e204e95e873ef0b89425f84a520f8fabd. Fix is minimal now and tests have been expanded to ensure that newlines can't sneak into log messages through `InitWarning` or `InitError` calls by testing the `load_on_startup` case w0xlt reported https://github.com/bitcoin/bitcoin/pull/35833#issuecomment-5849713749.
w0xlt:
ACK d93d366e204e95e873ef0b89425f84a520f8fabd

Tree-SHA512: 6a19f937a2d362fd4dd2960d1551d7e630dc61e4200bd1f61eb65fd02286b2500ac5eb4fee01c1f1aed5fb4899daa56c11e800ccb4572a3372b180f8ec44c6db

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 60/100

This update fixes a way that people with limited access to a Bitcoin node could make fake log entries appear real. Normally, the node cleans up special characters in log messages but was leaving newlines alone. A clever user could slip a newline into a wallet name or a blocked RPC command, causing the log file to show a forged line that looks like an official node error or warning. The fix now escapes newlines too, so the whole injected text stays on one line and is clearly not a real log entry. This is mainly a log-integrity and anti-confusion issue, not a direct theft or remote-control bug.

Security candidateMerge bitcoin/bitcoin#36391: test: fix typo in rpc_psbtby merge-script · 4b612c6b · Sep 30, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36391: test: fix typo in rpc_psbt

0a8ffe9051ab6c6192c8ec8716bac74e625747c4 test: fix typo in rpc_psbt (Bruno Garcia)

Pull request description:

s/walletcreatepsbt/walletcreatefundedpsbt

ACKs for top commit:
maflcko:
lgtm ACK 0a8ffe9051ab6c6192c8ec8716bac74e625747c4

Tree-SHA512: fa227c6ac09469130555ff3253dce865b84d7c7001a39c84dc7863e88a178703729193aced70dc9f48b2870ae0d206c9b3734ea6e55048220b461d81b3ffb206

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit fixes a one-word typo in a comment inside a test file. The comment incorrectly referred to 'walletcreatepsbt' when the surrounding test code actually calls 'walletcreatefundedpsbt'. No code behavior changes, and there is no security impact.

Security candidatetest: fix typo in rpc_psbtby Bruno Garcia · 0a8ffe90 · Sep 30, 2026 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · Bruno Garcia

test: fix typo in rpc_psbt

s/walletcreatepsbt/walletcreatefundedpsbt

82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit fixes a typo in a comment within a test file. The comment incorrectly referred to 'walletcreatepsbt' when the surrounding test code actually exercises 'walletcreatefundedpsbt'. No code behavior changes, and there is no security impact.

Security candidateMerge bitcoin/bitcoin#36377: doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.mdby merge-script · e0f16ef9 · Sep 30, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36377: doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.md

d57346d682f17e6cf09f8acc5e7893ee16eec193 doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.md (Sebastian Falbesoner)

Pull request description:

Note that the mailing list discussion on the [BIP](https://github.com/bitcoin/bips/blob/master/bip-0461.md) mentions Bitcoin Core and the linked pull request #13666 (released in v0.17.0) explicitly: https://groups.google.com/g/bitcoindev/c/boEZRlqczvw/m/F4Bvid36CwAJ

ACKs for top commit:
achow101:
ACK d57346d682f17e6cf09f8acc5e7893ee16eec193
davidgumberg:
ACK https://github.com/bitcoin/bitcoin/commit/d57346d682f17e6cf09f8acc5e7893ee16eec193

Tree-SHA512: 6cf0c91ae8518d06a779aa91ee963341bc51cb941ecff0823a9a0e6a9d0ffb9e618f29336f7a4d8c72889d15fe59429623fe0f029c0f1b0f6b353da58e778fa2

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a documentation-only update. It adds a single line to Bitcoin Core's list of implemented BIPs, noting that BIP 461 (a technique for making ECDSA signatures smaller and deterministic) has been implemented since version 0.17.0. No code was changed, and there is no security fix or vulnerability.

AI review queuedMerge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendallby Ava Chow · e7aef7e8 · Sep 29, 2026 · 2 filesMessage 81 · StrongLow 27Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendall

df2994b14a4ba26c4ccebd6df4c24d8aaf22d851 wallet: accept uppercase addresses without amount in sendall (FlashW)

Pull request description:

`sendall` keeps the recipients that were given without an amount as the strings the user passed (spend.cpp:1399). Later it finds their outputs by comparing against `EncodeDestination` of each output script (spend.cpp:1564), which for bech32 is the canonical lowercase form.

An address given in uppercase is valid bech32, and `validateaddress` and `sendtoaddress` accept it. In `sendall` it never matches, so its output keeps the placeholder amount of 0 and the call fails:

```
sendall '["BCRT1Q..."]'
error code: -8
Specified output amount to bcrt1q... is below dust threshold.
```

This stores the decoded destinations of those addresses instead and compares them with the destinations of the outputs, so the match doesn't depend on how the address was written. Invalid addresses are still rejected later when the transaction is constructed.

The new `sendall_uppercase_address` in `wallet_sendall.py` sweeps the wallet to the uppercase form of an address. It fails on master with the dust error above and passes with the fix. `wallet_send.py` still passes.

ACKs for top commit:
maflcko:
lgtm ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
achow101:
ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
polespinasa:
ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851

Tree-SHA512: 57fc356d52c69517aaef2ed67abad8c7c8350a984be914b4f6e1d79b871b269d6bb6d4bbc0b0a87cb55c560fe215b0fd310977f95856c3d54134a65fc92bf15c

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100

This patch fixes a bug in Bitcoin Core's `sendall` wallet command. If a user typed a bech32 address in uppercase letters, the command would fail with a confusing 'below dust threshold' error instead of sending the funds. The fix compares decoded address data rather than raw text, so uppercase and lowercase addresses are treated the same. It is a usability/functional bug, not a vulnerability that lets someone steal funds.

Security candidateMerge bitcoin/bitcoin#36381: test: avoid testing at the exact `-maxfeerate` boundaryby Ava Chow · ba8fdb97 · Sep 29, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36381: test: avoid testing at the exact `-maxfeerate` boundary

025768fb37cefdffcfc47376055bedb103699565 test: avoid testing at the exact `-maxfeerate` boundary (ismaelsadeeq)

Pull request description:

Fixes #36363

`test_maxfeerate` configured `-maxfeerate=0.00001009` and then created a
transaction requesting the exact same fee rate. This is fragile because the
wallet sizes the fee from the estimated (maximum) signed vsize, while the
`-maxfeerate` limit is checked against the actual signed vsize.

When the actual signature is smaller than the estimate, the actual vsize is smaller than
estimated resulting in a higher feerate and the transaction is rejected, causing
intermittent CI failures.

Request a fee rate slightly below `-maxfeerate` so the transaction is accepted
regardless of the signature size, while still exercising the limit.

Can be reproduced with

```diff
--- a/test/functional/wallet_send.py
+++ b/test/functional/wallet_send.py
@@ -221,8 +221,17 @@ class WalletSendTest(BitcoinTestFramework):
self.nodes[0].sendtoaddress, address=self.nodes[0].getnewaddress(), amount=1, fee_rate=11)
self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), amount=1, fee_rate=9)

- self.restart_node(0, extra_args=['-maxfeerate=0.00001009'])
- self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), amount=1, fee_rate=Decimal("1.009"))
+ self.restart_node(0, extra_args=['-maxfeerate=0.00001009', '-changetype=bech32m'])
+ w = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
+ tr_addr = w.getnewaddress(address_type="bech32m")
+ funding_txid = w.sendtoaddress(tr_addr, 5)
+ self.generate(self.nodes[0], 1)
+ vout = next(o["n"] for o in w.gettransaction(funding_txid, verbose=True)["decoded"]["vout"]
+ if o["scriptPubKey"]["address"] == tr_addr)
+ # Spend the taproot input at exactly maxfeerate. The tr() descriptor
+ # estimates a 65-byte sig but the key-path spend is 64 bytes, so the
+ # estimated vsize always exceeds the actual deterministic rejection.
+ w.send(outputs={w.getnewaddress(): 1}, fee_rate=Decimal("1.009"),
+ options={"inputs": [{"txid": funding_txid, "vout": vout}], "add_inputs": False})
```

The actual failure in #36363 is intermittent because legacy output signatures only sometimes result in a tx size smaller than estimated. It can be reproduced in master by running the test on the file from 100 to 200 times.

And running it again at the same time with this PR does not fail.

ACKs for top commit:
maflcko:
lgtm ACK 025768fb37cefdffcfc47376055bedb103699565
achow101:
ACK 025768fb37cefdffcfc47376055bedb103699565
furszy:
utACK 025768fb37cefdffcfc47376055bedb103699565

Tree-SHA512: 9e70b238f22e6d75108c1b10096008aad5f1bea7ddbb51a11fe722674adcd2dada3dabe577a6049b242fcf826ccd582c16a025b406742ad6b3195a0dae27b44f

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit fixes a flaky automated test in Bitcoin Core. The test was checking the maximum transaction fee rate by creating a transaction at the exact boundary, which sometimes failed because the real transaction size could be slightly smaller than estimated. The fix simply lowers the requested fee rate in the test so it no longer sits exactly on the boundary. There is no change to production code or to any real security behavior.

AI review queuedMerge bitcoin/bitcoin#36233: guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8`by merge-script · 619185d5 · Sep 29, 2026 · 3 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36233: guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8`

feb77d838eda70dfc27df78537da89f2b568f52c guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8` (Hennadii Stepanov)
f14a3ef8c5c6480f2e452d9668db71786cdb83fc guix: Skip some packages' tests in `python-lief` and `nsis-x86_64` (fanquake)

Pull request description:

On the master branch @ 17817818da3cb67c95320b7a5d4d69bd649c1fbf, building on a RISC-V system [fails](https://github.com/bitcoin/bitcoin/issues/36232):
```
guix shell: error: package python-lief@0.17.5 does not support riscv64-linux
```

Also see https://github.com/bitcoin/bitcoin/pull/34550#issuecomment-3921035276.

This is caused by the `python-msgspec` package, an indirect dependency of `python-lief`:

`python-lief` <-- `python-scikit-build-core` <-- `python-cattrs` <-- `python-msgspec`

Also see https://github.com/bitcoin/bitcoin/pull/34550#issuecomment-3926767282.

This [commit](https://codeberg.org/guix/guix/commit/b35905695afd2e24c56e6950433dd4f571581873) updates `python-msgspec` and removes `(supported-systems (list "x86_64-linux" "aarch64-linux"))` from its definition.

Package updates:
- `git-minimal`: 2.52.0 -> 2.54.0
- `linux-headers` 6.1.166 -> 6.1.172
- `python-lief`: 0.17.5 -> 0.17.6
- `python-minimal`: 3.11.14 -> 3.12.12

Additionally, `python-lief` and `nsis-x86_64` transitively pull in packages whose tests fail when building natively on `riscv64`:
- `python-lief`: `python-psutil`, `python-pytest-xprocess`, `python-sh`
- `nsis-x86_64`: `python-psutil`

Tests for the problematic packages are temporarily disabled.

Fixes https://github.com/bitcoin/bitcoin/issues/36232.

ACKs for top commit:
maflcko:
re-review ACK feb77d838eda70dfc27df78537da89f2b568f52c 🦏
willcl-ark:
ACK feb77d838eda70dfc27df78537da89f2b568f52c

Tree-SHA512: c89c57e0f3f8090c3eaa52cbc6b55c6564f297158afebf8306bcae692f4f5121156e64e5af3fb9e6dcb0091a9cd2d65e002854abb5befd7df6df31f1618ed280

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 20/100

This is a build-system maintenance update for Bitcoin Core's reproducible build environment (Guix). It updates the Guix time-machine commit and several dependency versions, and temporarily disables some test suites that fail when building on the RISC-V processor architecture. The change is not a security fix for Bitcoin's consensus or networking code; it is a portability fix so that builds work on RISC-V machines.

Security candidateMerge bitcoin/bitcoin#36364: tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-walletby merge-script · dc2a9987 · Sep 29, 2026 · 3 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36364: tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet

4048909a53422bf86b207a9b5c8650e8edd25737 tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet (Torkel Rogstad)

Pull request description:

Only kernel::Context users selected a hardware SHA256 implementation, so these tools fell back to the generic one. On an M2 Max, grind is ~5x faster and signing 2000 P2PKH inputs with bitcoin-tx ~2.3x.

ACKs for top commit:
maflcko:
lgtm ACK 4048909a53422bf86b207a9b5c8650e8edd25737
furszy:
utACK 4048909a53422bf86b207a9b5c8650e8edd25737

Tree-SHA512: 0edc6b78efbf0c84c22bbe98bd1ab295accc9530e24cee8f0faed9f63515fe8b677e8c33d3b46e0f1c0a44b422374cd7395ce163468d98772ea72a8faa9a1cfa

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This change makes three Bitcoin command-line tools (bitcoin-tx, bitcoin-util, and bitcoin-wallet) automatically pick the fastest SHA-256 hashing implementation available on the computer, such as hardware-accelerated versions on modern CPUs. Previously, only some parts of Bitcoin Core did this, so these tools used a slower generic implementation. The result is a significant speedup for operations that do a lot of hashing, but there is no security bug being fixed here.

Security candidateMerge bitcoin/bitcoin#36321: net: cast vector size to avoid overflow, truncation, sign changeby merge-script · ced4c6e6 · Sep 29, 2026 · 1 fileMessage 98 · StrongInformational 23Details
Commit message · merge-script

Merge bitcoin/bitcoin#36321: net: cast vector size to avoid overflow, truncation, sign change

308cd670195d908fbd50caf76a8a215386121bd0 net: cast vector size to avoid overflow, truncation, sign change (Eugene Siegel)

Pull request description:

When running with `-fsanitize=integer` compiled, the following can error [here](https://github.com/bitcoin/bitcoin/blob/b3f846ec3e5c21b08779ac6c13475f3ab37e7d9c/src/net_processing.cpp#L3662):

```
SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow /bitcoin/src/net_processing.cpp:3662:33
SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation-or-sign-change /bitcoin/src/net_processing.cpp:3662:18
```

When `stop_index->nHeight` is less than `CFCHECKPT_INTERVAL`, the `headers` vector will be empty. This will just set the loop counter to -1 and never enter the loop, so this is harmless anyways. Fix this by casting `headers.size()` to `int`.

ACKs for top commit:
maflcko:
lgtm ACK 308cd670195d908fbd50caf76a8a215386121bd0
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/308cd670195d908fbd50caf76a8a215386121bd0

Tree-SHA512: 1074667b644e42507b32043e98a0541fff6de9a3711003a43b9874b31956a8e10efe65af89ed2b23322a7aa3df7d6a8606db5c1ab342f070a625b9e9650ae1fa

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetydefensive validationmerge-commit duplicate discount
AI analysis · Informational 23/100

This is a one-line fix in Bitcoin Core's network code. It changes how the size of a list of block headers is converted to a signed integer inside a loop. Previously, if the list was empty, the conversion could trigger undefined-behavior warnings under special compiler sanitizers because subtracting 1 from an unsigned zero produced a very large positive number, which then got squeezed into a signed integer. The code already did not enter the loop in that case, so there was no practical exploit path. The patch simply makes the conversion explicit and clean.

AI review queuedMerge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactionsby Ava Chow · ed7dd7cf · Sep 25, 2026 · 3 filesMessage 91 · StrongLow 32Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

c2da52d3660f178a9c11210216d295515988e89d wallet: allow importprunedfunds for spending transactions (8144225309)

Pull request description:

`importprunedfunds` only allowed importing transactions that credit the wallet
(checked via `IsMine`), rejecting transactions that spend from it. This could
leave a pruned wallet showing an incorrect balance: if a spending transaction
was removed with `removeprunedfunds`, it couldn't be re-imported and would fail
with "No addresses in wallet correspond to included transaction".

This routes the import through `AddToWalletIfInvolvingMe()`, which already
checks both `IsMine()` and `IsFromMe()`, so spending transactions are accepted
and the involvement check is no longer duplicated in `importprunedfunds`. A
functional test imports a transaction that spends from the wallet but has no
outputs to it (entire UTXO sent externally).

Fixes #21647

ACKs for top commit:
achow101:
ACK c2da52d3660f178a9c11210216d295515988e89d
Bicaru20:
re-ACK c2da52d366

Tree-SHA512: 0ece38c75d3608948f1c29c5fca29b6420197b0a153e361decf232fd27edd5dd1f2e5d6f9625eee6f7691abd9992f95ef89c904d486ee927d03c88475e479b9c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 32/100

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing transactions can be re-imported, so a pruned wallet's balance and transaction history stay accurate.

AI review queuedMerge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup optionby Ava Chow · f80aaf4b · Sep 25, 2026 · 30 filesMessage 91 · StrongLow 28Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9 [doc]: add release notes (ismaelsadeeq)
40ab7aa90de5a6382fe6f8946cde735e05308a20 [wallet]: warn when `-maxtxfee` conflicts with `-minrelaytxfee` (ismaelsadeeq)
df1feeb487dc54dc44ac8eff96650319bb3a2584 [wallet]: enforce `-maxfeerate` on wallet transactions (ismaelsadeeq)
d2c832e9e79d0f8691e64f25bcfe198ae34805d5 [util]: add a new transaction error type (ismaelsadeeq)
633c08d3f7af95953a818c645a4ad4c90f0bbdb0 [node]: update `BroadcastTransaction` to check fee rate limit (ismaelsadeeq)
7bfce65801bf5a7ae45f5f75a627e6cd03d9c8c0 [wallet]: add `maxfeerate` wallet startup option (ismaelsadeeq)
607568f2b00260ac54fd4c2c904002be17edebfd [wallet]: update `max_fee` to `max_tx_fee` (ismaelsadeeq)
6b913b6224bdafac6b83328441a347a00d7d4d06 doc: add missing verb to make sentence readable (ismaelsadeeq)
a9c39696f4be2ffe02cd78d152f4e5960692c833 scripted-diff: rename `m_default_max_tx_fee` to `m_max_tx_fee` (ismaelsadeeq)

Pull request description:

This PR fixes #29220

- The PR adds a wallet `-maxfeerate` startup option, as the upper limit of wallet transactions fee rate.

- This fixes the ambiguity of using `maxtxfee` value to check the upper limit of transactions fee rate.

- Wallet will not create a transaction with fee rate above `maxfeerate` value.

- This PR adds a functional test that ensure the behavior is enforced.

ACKs for top commit:
achow101:
ACK f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9
polespinasa:
ACK f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9

Tree-SHA512: 595f451a2fd49ca887705e16ca82373c840c610d079de893bb67fba06e8b5c78646fb723255f226fdae7a6ad57a6f2b42e5d54b07d320c5c2b3a17c943add4ab

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wallet only had -maxtxfee, which limits the total absolute fee. The change also makes the error messages clearer so users can tell whether a transaction was rejected because of the total fee or the fee rate. It is a defensive feature, not a fix for an active vulnerability, and it helps prevent users from accidentally paying extremely high per-byte fees.

Security candidateMerge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding outputby Ava Chow · e19f83e9 · Sep 25, 2026 · 2 filesMessage 86 · StrongModerate 64Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

8df006f233839736b6d7b856bcf8673526c7acef wallet: skip signing SIGHASH_SINGLE inputs with no corresponding output (furszy)

Pull request description:

`SIGHASH_SINGLE` only commits to the output at the input's index. If the output at such
position doesn't exist, it commits to no output at all (legacy uses a fixed sighash of 1, segwit
v0 zeroes `hashOutputs`), which means the signature stays valid even when outputs are
swapped, which is a footgun that lets funds be redirected without the owner's consent.

`SignTransaction()` already skipped these inputs, but `SignPSBTInput()` did not, so
`walletprocesspsbt` signed them. This moves the check into the `CreateSig` so both
paths, and any future one, skip producing the detached signature.

Note: if there is a valid use for the segwit v0 case, I would rather re-allow it through
an explicit opt-in arg than by default, so it is always a deliberate choice.

Fixes #35977

ACKs for top commit:
thomasbuilds:
ACK 8df006f
achow101:
ACK 8df006f233839736b6d7b856bcf8673526c7acef

Tree-SHA512: ac1c9659910eae889475c65b8dde68e711c4d85d0d520af06411728591e573bf027b41a9ac6dd0f6e93de425841ac6c7d9e6c9f07936b9d8ae390941fbe6f1f1

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 64/100

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if someone later changed where the money goes, creating a risk of funds being redirected without the original owner's consent. The fix makes the signer refuse to create such signatures in the first place, closing the gap for both normal transaction signing and PSBT signing.

Security candidateMerge bitcoin/bitcoin#35696: i2p: update leaseset encryption typesby Ava Chow · 65e075f8 · Sep 25, 2026 · 1 fileMessage 86 · StrongLow 35Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

412540e18d877c4a34cf9c8fb43dfd34a603d5f5 i2p: update leaseset encryption types (jpk68)

Pull request description:

Updates the I2P SAM leaseset parameters to `6,4` (MLKEM-768/ECIES-X25519), as is [now recommended](https://i2p.net/en/docs/api/samv3/#signature-and-encryption-types) by the I2P project. ElGamal leasesets are now considered "legacy" and likely should not be used anymore.

ACKs for top commit:
kevkevinpal:
ACK [412540e](https://github.com/bitcoin/bitcoin/pull/35696/commits/412540e18d877c4a34cf9c8fb43dfd34a603d5f5)
davidgumberg:
ACK 412540e
achow101:
ACK 412540e18d877c4a34cf9c8fb43dfd34a603d5f5
jonatack:
ACK 412540e18d877c4a34cf9c8fb43dfd34a603d5f5
janb84:
ACK 412540e18d877c4a34cf9c8fb43dfd34a603d5f5

Tree-SHA512: 639f6c58700f0a6ec471652d31b62d36ee16226afc13267a2064c199fd7e6102d7ac1b146fecaaee611235f8463fb1572318d21aa774c0a7e06ea4be06062a8c

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Low 35/100

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal encryption, which the I2P project now labels 'legacy' and no longer recommends. This is a hardening improvement rather than a fix for a known active attack, but it reduces future cryptographic risk for users who route Bitcoin traffic over I2P.

Security candidateMerge bitcoin/bitcoin#35948: init: correct first-run disk space estimateby Ava Chow · d26f19c7 · Sep 25, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

42215b85811a4950265fa2d02b22e83046ed95d5 init: correct first-run disk space estimate (Lőrinc)

Pull request description:

**Problem:** The assumed blockchain size is maintained in GiB, but the first-run disk-space warning labels it as GB.
For pruned nodes, the warning also displays the full-chain estimate even though the check uses the lower of the prune target and that estimate.
The chainparams API comments likewise describe both assumed sizes as GB.

**Fix:** Label the warning as GiB, display the same rounded-up GiB estimate that the disk-space check uses, and document both assumed sizes as GiB.

This PR revives the first-run warning fixes from #29678.

ACKs for top commit:
jeanpablojp:
tACK 42215b85811a4950265fa2d02b22e83046ed95d5
achow101:
ACK 42215b85811a4950265fa2d02b22e83046ed95d5
murchandamus:
ACK 42215b85811a4950265fa2d02b22e83046ed95d5

Tree-SHA512: fa8a0e1eeefd674a4344772fa5e8f63fc3af9c106057c34fef47817d41cf162ad21f0e06412ad5bebc1504c57bb720e1c0ca5392e6f3d4052d3f8c7c360bac69

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-chain size instead of the smaller pruned size. The patch corrects the label to GiB and shows the same rounded-up value that the actual disk-space check uses. There is no security vulnerability here.

AI review queuedMerge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspendsby Ava Chow · e8e7e91a · Sep 24, 2026 · 4 filesMessage 91 · StrongLow 44Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

719324977a41ab5132699d9c81032f8b2687f599 test: Check that ineligible output groups are discarded only once (Fabian Jahr)
20307f0ac0e17c6e478e2e11318dc7a9b18fc5d1 wallet: don't double count discarded output groups with avoidpartialspends (Fabian Jahr)

Pull request description:

With `-avoidpartialspends` or `avoid_reuse`, `GroupOutputs` puts every positive-value output into both the mixed and the positive-only map and runs `push_output_groups` on each, so a group rejected by the eligibility filters lands in `discarded_groups` twice. `AutomaticCoinSelection` then subtracts it twice and could fail with an insufficient funds error even when there would be enough confirmed coins to cover the payment.

Not a problem in a default wallet but it can happen with `sendtoaddress` from an `avoid_reuse` wallet, or with `-avoidpartialspends=1`.

The simplest possible fix is to record discards only from the mixed map pass, which contains every output anyway. Also adds a test that reproduces the issue.

ACKs for top commit:
achow101:
ACK 719324977a41ab5132699d9c81032f8b2687f599
pablomartin4btc:
ACK 719324977a41ab5132699d9c81032f8b2687f599
vicjuma:
ACK 719324977a41ab5132699d9c81032f8b2687f599
polespinasa:
code reviewed ACK 719324977a41ab5132699d9c81032f8b2687f599

Tree-SHA512: 3028f8feeacecc601aacfce757fc885b7bd25cf6ea2ad9d9b65c56b5da71096aa48d0d70ce04d80fc2b147d67109c47d190e5dc925d06c67dfcf33cf8cc715d8

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That double-counting could make the wallet wrongly believe there are not enough spendable coins and fail to create a transaction, even though the user actually has enough confirmed funds. The fix makes sure each rejected group is recorded only once, and adds tests to prove it.