What the developer wrote
Authored by fanquake
guix: remove -Werror=dev
Otherwise the build will fail with warnings about missing Python (removed
in the next commit). However the non-gui build does not need Python.
Note that #25573 contains the same change, because the use of -static-pie
causes warnings when combined with our/CMakes own PIE handling.
What changed, and why it matters
This commit removes a strict compiler/build flag (-Werror=dev) from Bitcoin Core's Guix build scripts. The flag previously turned CMake developer warnings into fatal errors. It was removed because an upcoming change (removing Python from non-GUI builds) would trigger a harmless warning. This is a build-system maintenance change, not a security fix.
No security action required. Review as normal build-system maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes -Werror=dev from three Guix build scripts (build_linux.sh, build_macos.sh, build_win.sh). This CMake flag treats developer warnings as errors. The removal is motivated by anticipated benign warnings when Python is no longer required for non-GUI builds, and by similar issues with -static-pie PIE handling in PR #25573. There is no code change affecting consensus, networking, wallet, or runtime behavior.
Changed components
contrib/guix/libexec/build_linux.shcontrib/guix/libexec/build_macos.shcontrib/guix/libexec/build_win.shInspect captured patch +3 / −6
diff --git a/contrib/guix/libexec/build_linux.sh b/contrib/guix/libexec/build_linux.sh
index 212b86c2..b84fcdde 100755
--- a/contrib/guix/libexec/build_linux.sh
+++ b/contrib/guix/libexec/build_linux.sh
@@ -66,8 +66,7 @@ mkdir -p "$DISTSRC"
-DCMAKE_INSTALL_PREFIX="${INSTALLPATH}" \
-DCMAKE_SKIP_RPATH=TRUE \
-DREDUCE_EXPORTS=ON \
- -DWITH_CCACHE=OFF \
- -Werror=dev
+ -DWITH_CCACHE=OFF
# Build Bitcoin Core
cmake --build build -j "$JOBS"
diff --git a/contrib/guix/libexec/build_macos.sh b/contrib/guix/libexec/build_macos.sh
index 08298d35..a782d80e 100755
--- a/contrib/guix/libexec/build_macos.sh
+++ b/contrib/guix/libexec/build_macos.sh
@@ -44,8 +44,7 @@ mkdir -p "$DISTSRC"
-DCMAKE_INSTALL_PREFIX="${INSTALLPATH}" \
-DCMAKE_SKIP_RPATH=TRUE \
-DREDUCE_EXPORTS=ON \
- -DWITH_CCACHE=OFF \
- -Werror=dev
+ -DWITH_CCACHE=OFF
# Build Bitcoin Core
cmake --build build -j "$JOBS"
diff --git a/contrib/guix/libexec/build_win.sh b/contrib/guix/libexec/build_win.sh
index 3b4554e9..7dd6e9fc 100755
--- a/contrib/guix/libexec/build_win.sh
+++ b/contrib/guix/libexec/build_win.sh
@@ -49,8 +49,7 @@ mkdir -p "$DISTSRC"
-DBUILD_GUI_TESTS=OFF \
-DCMAKE_INSTALL_PREFIX="${INSTALLPATH}" \
-DREDUCE_EXPORTS=ON \
- -DWITH_CCACHE=OFF \
- -Werror=dev
+ -DWITH_CCACHE=OFF
# Build Bitcoin Core
cmake --build build -j "$JOBS"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.