Bitcoin Core

This commit only updates a documentation file for building Bitcoin Core on NetBSD. It changes the recommended Python package from version 3.10 to version 3.13 because the older package is no longer available by default in NetBSD 10.1. There is no code change and no security issue.

This commit only changes Bitcoin Core's own test code. It makes the test framework correctly add a witness commitment to test blocks when they contain a segwit transaction, and adds a new test case for transactions that have unnecessary witness data. There is no change to the actual Bitcoin network code that users run, so this does not create a security vulnerability in Bitcoin Core itself.

This is a small fix to Bitcoin Core's internal Python test framework. When a test talks to a running node and the connection is reset unexpectedly, Python's error object sometimes doesn't include a standard error number. The patch makes the test code treat that as a connection reset, so it can log and retry correctly instead of crashing the test run. It does not change the Bitcoin node itself, user wallets, consensus rules, or network behavior.

This commit only adds a new test to Bitcoin Core. It checks that calling size() on an AutoFile object reports the file size without moving the file's internal read/write position. There is no change to production code and no security fix or vulnerability is present in the diff.

This commit adds a new helper method called size() to the AutoFile class, which reports how large a file is. It also updates two existing places in the code to use this new helper instead of manually seeking to the end of the file and asking for the current position. The change is purely a code cleanup (refactor) and does not fix any security bug.

This commit is a minor code cleanup: it changes two logging calls in the asmap file handling from a general log function to a warning-level log function. There is no security-relevant behavior change, no bug fix, and no new vulnerability introduced.

This commit only adds new test cases to Bitcoin Core. It does not change any production code, so it cannot introduce a security vulnerability or fix one. The tests verify that a piece of networking code (the ASMap interpreter, used to map IP addresses to autonomous system numbers) produces expected results for a set of known inputs.

This commit tightens input handling in Bitcoin Core's kernel library. Previously, the library's C interface promised that callers must not pass a null or empty directory path, but it did not actually check. Now it explicitly rejects null or empty data and blocks directories and returns an error instead of potentially misbehaving. It also updates the internal C++ wrapper to accept string views, which can legitimately have null data pointers when empty. This is a defensive hardening change, not a fix for an active exploit.

This commit removes an already-unused command-line option called `-maxorphantx`. The option had no effect since version 30.0 and only produced a warning if someone still had it in their configuration. Now it is fully removed, and a release note explains the change. There is no security issue here.

This is a small internal code cleanup in Bitcoin Core. A helper function that finds the earliest block matching certain criteria used to return a raw pointer; now it returns a reference. The change is purely stylistic/safety-related because the function was already guaranteed to return a non-null result (it contains an assertion). No behavior changes, no bug fixes, and no security issue is present.

This is a code-quality annotation change only. It tells the compiler that a function parameter's lifetime is tied to the returned value, which helps catch misuse during development. It does not change program behavior or fix a runtime security bug.

This is a routine change to Bitcoin Core's automated testing setup. It switches the macOS CI jobs from running directly on a Git checkout to running on a snapshot of the source code created by 'git archive'. The commit message says the goal is simply to verify that compilation works this way. There is no security-relevant change here.

This commit removes two compiler-hint annotations (LIFETIMEBOUND) that were technically incorrect. The function only inspects the input objects during the call and does not keep pointers or references to them afterward. Removing the annotations prevents the compiler from enforcing lifetime rules that do not actually apply, but it does not change runtime behavior or fix any active security bug.

This commit is a routine improvement to Bitcoin Core's GitHub Actions CI workflow. It makes sure every CI job prints a machine-readable annotation containing the pull request number, because GitHub discards those annotations when individual checks are re-run. There is no security-relevant change here.

This change simply makes the automated CI (continuous integration) system retry building a lint Docker image one time if the first attempt fails, waiting 3 seconds between attempts. It is a reliability improvement for internal testing infrastructure and does not touch any Bitcoin Core code that handles transactions, wallets, networking, or consensus rules.

This commit changes how Bitcoin Core's graphical wallet (bitcoin-qt) links to a low-level Linux graphics library called libxcb. Previously, libxcb and several related extension libraries were allowed to be loaded dynamically from the operating system. Now they are built as static libraries and linked directly into the application. The main practical effect is to reduce the application's dependency on whatever versions of these libraries happen to be installed on the user's Linux distribution, which can make builds more reproducible and avoid crashes or compatibility problems caused by mismatched library versions. It is a build-system hardening change, not a fix for an active remote-attack vulnerability.

This commit removes an unused Qt tool called qdbusviewer from Bitcoin Core's dependency build. It is a build-system cleanup with no apparent security relevance.

This commit adds a patch to Bitcoin Core's build system so that when Qt is built statically for Linux, it correctly links several helper libraries from the XCB (X11 client communication) family. The patch itself comes from upstream Qt bug reports and fixes missing dependency declarations that could cause build failures or incomplete linking. It is a build-system correctness fix rather than a runtime code change, and there is no direct evidence it fixes an exploitable vulnerability.

This commit changes how Bitcoin Core's build system handles a low-level graphics helper library called libxcb-util-image. Previously it was built as a shared library that had to be present on the user's system; now it is built as a static library that is copied directly into the Bitcoin Core executable. This is a build/packaging change, not a fix for a known vulnerability in the library itself. It mainly reduces the chance that a missing or incompatible system library prevents Bitcoin Core from running, and slightly changes the attack surface around dynamic library loading.

This commit changes how Bitcoin Core's graphical wallet (bitcoin-qt) links a keyboard-handling library called libxkbcommon. Previously it was linked dynamically (the program loads the library from the user's system at runtime). Now it is linked statically (the library code is built into the program binary). This is a build-system hardening change that reduces the chance of runtime failures or supply-chain issues caused by incompatible system versions of that library, but it is not a fix for a known exploitable bug in Bitcoin Core itself.

This commit changes how a low-level graphics helper library (libxcb-render-util) is bundled when building Bitcoin Core. It switches the build from producing a shared library to a static library, and removes that shared library from the list of files allowed in release binaries. This is a build-hardening change that reduces external runtime dependencies; it does not by itself fix a known exploitable bug in Bitcoin Core.

This commit changes how a low-level Linux graphics helper library (libxcb-util-wm) is bundled with Bitcoin Core. It switches the build from producing a shared library to a static library, and removes one shared library name from the list of allowed runtime dependencies. The change is a build-hardening improvement, not a fix for an active security bug. It reduces the chance that a malicious or incompatible version of that library on the user's system could affect Bitcoin Core, but it does not patch any vulnerability in Bitcoin Core itself.

This commit changes how a low-level graphical keyboard library (libxcb-keysyms) is bundled with Bitcoin Core's build system. Previously it was allowed as a shared library that had to be present on the user's system; now it is compiled directly into the Bitcoin Core binary. This is a build-hardening change that reduces external runtime dependencies and makes the release binary more self-contained, but it is not a fix for an active security vulnerability in Bitcoin Core itself.

This is a minor code cleanup in Bitcoin Core. It changes a copyright year range to 'present', adds a blank line between include statements, and reformats a comment about how git fills in commit IDs in archived source code. There is no security-relevant change.

This commit is a build-system cleanup, not a fix for an active security flaw. It removes old CMake settings that forced build-time library paths to be stripped from binaries, because the release build script now runs its security checks after installing the software rather than before. It also removes two unused developer maintenance targets and makes the security checks cover one extra directory (libexec). The change is hygiene work that slightly hardens the build pipeline, but it does not by itself create or close a user-exploitable vulnerability.